Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(423)

Issue 171763003: Apply Issue shim for disabling checkout when bot update ran. (Closed)

Created:
6 years, 10 months ago by Ryan Tseng
Modified:
6 years, 10 months ago
Reviewers:
agable, iannucci, hinoka
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Visibility:
Public.

Description

Apply Issue changes for disabling checkout when bot update ran. This add --force to ignore the flag file. This also passes --base_ref so we can specify which ref we're basing off of so that it does not incorrectly assert that it is basing off origin/master BUG=339171 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=252464

Patch Set 1 #

Patch Set 2 : Add --force flag and --git_ref flag #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -4 lines) Patch
M apply_issue.py View 1 2 chunks +12 lines, -1 line 0 comments Download
M checkout.py View 1 2 chunks +8 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
Ryan Tseng
Apply issue is out of the normal gclient master step.
6 years, 10 months ago (2014-02-19 00:52:12 UTC) #1
agable
Looks right, but make sure the message is the same as in the other steps. ...
6 years, 10 months ago (2014-02-19 02:44:00 UTC) #2
hinoka
Ptal again. Added a bypass flag along with a --base_ref flag which would be needed ...
6 years, 10 months ago (2014-02-19 22:05:04 UTC) #3
agable
re-lgtm
6 years, 10 months ago (2014-02-20 00:08:28 UTC) #4
Ryan Tseng
The CQ bit was checked by hinoka@google.com
6 years, 10 months ago (2014-02-20 00:09:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hinoka@google.com/171763003/50001
6 years, 10 months ago (2014-02-20 00:09:09 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-20 00:10:48 UTC) #7
commit-bot: I haz the power
Presubmit check for 171763003-50001 failed and returned exit status 1. Running presubmit commit checks ...
6 years, 10 months ago (2014-02-20 00:10:49 UTC) #8
Ryan Tseng
Robbie can you review and stamp?
6 years, 10 months ago (2014-02-20 00:12:45 UTC) #9
Ryan Tseng
ping bump
6 years, 10 months ago (2014-02-21 00:30:46 UTC) #10
iannucci
lgtm
6 years, 10 months ago (2014-02-21 02:20:59 UTC) #11
Ryan Tseng
The CQ bit was checked by hinoka@google.com
6 years, 10 months ago (2014-02-21 02:21:29 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hinoka@google.com/171763003/50001
6 years, 10 months ago (2014-02-21 02:21:35 UTC) #13
commit-bot: I haz the power
6 years, 10 months ago (2014-02-21 02:23:15 UTC) #14
Message was sent while issue was closed.
Change committed as 252464

Powered by Google App Engine
This is Rietveld 408576698