Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(685)

Issue 1717583003: Mojom compiler: Move RuntimeTypeInfo from mojom_files.mojom to mojom_types.mojom. (Closed)

Created:
4 years, 10 months ago by rudominer
Modified:
4 years, 10 months ago
Reviewers:
azani
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, yzshen+mojopublicwatch_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Mojom compiler: Move RuntimeTypeInfo from mojom_files.mojom to mojom_types.mojom. Previously it was awkward/impossible for mojom_types.mojom.go to include the functions that implement runtime type discovery because the structs were defined in mojom_files.mojom.go which is in a different package that depends on mojom_types.mojom.go. This was an unfortunate situation because it meant that any other mojom that depended on mojom_types.mojom also could not fully implement runtime type discovery. BUG=#448 R=azani@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/114885d95b658a7ef6d3225aaccd1be2b748b03c

Patch Set 1 #

Patch Set 2 : New sha1s #

Unified diffs Side-by-side diffs Delta from patch set Stats (+822 lines, -815 lines) Patch
M mojo/dart/packages/mojo/lib/mojo/bindings/types/mojom_files.mojom.dart View 1 chunk +0 lines, -300 lines 0 comments Download
M mojo/dart/packages/mojo/lib/mojo/bindings/types/mojom_types.mojom.dart View 1 chunk +300 lines, -0 lines 0 comments Download
M mojo/public/interfaces/bindings/mojom_files.mojom View 1 chunk +1 line, -53 lines 0 comments Download
M mojo/public/interfaces/bindings/mojom_types.mojom View 1 chunk +55 lines, -0 lines 0 comments Download
M mojo/public/tools/bindings/mojom_parser/bin/linux64/mojom_parser.sha1 View 1 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/tools/bindings/mojom_parser/bin/mac64/mojom_parser.sha1 View 1 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/tools/bindings/pylib/mojom/generate/generated/mojom_files_mojom.py View 1 chunk +0 lines, -18 lines 0 comments Download
M mojo/public/tools/bindings/pylib/mojom/generate/generated/mojom_types_mojom.py View 1 chunk +18 lines, -0 lines 0 comments Download
M mojom/mojom_parser/generated/mojom_files/mojom_files.mojom.go View 1 chunk +0 lines, -426 lines 0 comments Download
M mojom/mojom_parser/generated/mojom_types/mojom_types.mojom.go View 1 chunk +430 lines, -0 lines 0 comments Download
M mojom/mojom_parser/serialization/serialization.go View 2 chunks +4 lines, -4 lines 0 comments Download
M mojom/mojom_parser/serialization/serialization_test.go View 6 chunks +12 lines, -12 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
rudominer
Hi Alex, ptal
4 years, 10 months ago (2016-02-19 20:00:52 UTC) #4
azani
lgtm
4 years, 10 months ago (2016-02-19 20:16:06 UTC) #5
rudominer
4 years, 10 months ago (2016-02-19 20:45:27 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
114885d95b658a7ef6d3225aaccd1be2b748b03c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698