Issue 17175020: Fix compile error on x86-generic (32-bit) PFQ bots.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 17175020: Fix compile error on x86-generic (32-bit) PFQ bots. (Closed)

Created:
7 years, 6 months ago by hshi1

Modified:
7 years, 6 months ago

Reviewers:
Harry McCleave, satorux1

CC:
chromium-reviews, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix compile error on x86-generic (32-bit) PFQ bots. For some reason the integer literal "1ULL" is still treated as 32-bit and we encounter the error "left shift count >= width of type". See x86-generic nightly chromium PFQ build #2727 for details. BUG=none TEST=trybot R=satorux@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=207976

Patch Set 1 #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	chrome/browser/chromeos/audio/audio_devices_pref_handler_impl.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

hshi1

The failing log is available at http://chromegw/i/chromeos/builders/x86-generic%20nightly%20chromium%20PFQ/builds/2727/steps/BuildPackages/logs/stdio This is really weird though. I thought "1ULL" ...

7 years, 6 months ago (2013-06-21 20:21:35 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hshi@chromium.org/17175020/1

7 years, 6 months ago (2013-06-21 20:46:59 UTC) #4

hshi1

7 years, 6 months ago (2013-06-22 00:38:01 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 manually as r207976 (presubmit successful).

Expand Messages | Collapse Messages