Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Unified Diff: ui/views/window/dialog_client_view.h

Issue 1717453003: Introduce BubbleDialogDelegateView, which extends DialogDelegateView (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: msw review Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/views/window/dialog_client_view.h
diff --git a/ui/views/window/dialog_client_view.h b/ui/views/window/dialog_client_view.h
index eab82df461b3311f681eae96f5c7456b9dec447d..b31f0a285ba77e5fa5a2e9bc59713074731718ad 100644
--- a/ui/views/window/dialog_client_view.h
+++ b/ui/views/window/dialog_client_view.h
@@ -19,14 +19,13 @@ class Widget;
// DialogClientView provides adornments for a dialog's content view, including
// custom-labeled [OK] and [Cancel] buttons with [Enter] and [Esc] accelerators.
-// The view also displays the delegate's extra view alongside the buttons and
-// the delegate's footnote view below the buttons. The view appears like below.
-// NOTE: The contents view is not inset on the top or side client view edges.
+// The view also displays the delegate's extra view alongside the buttons. The
+// view appears like below. NOTE: The contents view is not inset on the top or
+// side client view edges.
// +------------------------------+
// | Contents View |
// +------------------------------+
// | [Extra View] [OK] [Cancel] |
-// | [ Footnote View ] |
// +------------------------------+
class VIEWS_EXPORT DialogClientView : public ClientView,
public ButtonListener {
@@ -61,6 +60,10 @@ class VIEWS_EXPORT DialogClientView : public ClientView,
// ButtonListener implementation:
void ButtonPressed(Button* sender, const ui::Event& event) override;
+ void set_button_row_insets(const gfx::Insets& insets) {
+ button_row_insets_ = insets;
+ }
+
protected:
// For testing.
explicit DialogClientView(View* contents_view);
@@ -71,9 +74,6 @@ class VIEWS_EXPORT DialogClientView : public ClientView,
// Create and add the extra view, if supplied by the delegate.
void CreateExtraView();
- // Creates and adds the footnote view, if supplied by the delegate.
- void CreateFootnoteView();
-
// View implementation.
void ChildPreferredSizeChanged(View* child) override;
void ChildVisibilityChanged(View* child) override;
@@ -93,6 +93,9 @@ class VIEWS_EXPORT DialogClientView : public ClientView,
// Returns the insets for the buttons and extra view.
gfx::Insets GetButtonRowInsets() const;
+ // How much to inset the button row.
+ gfx::Insets button_row_insets_;
+
// The dialog buttons.
LabelButton* ok_button_;
LabelButton* cancel_button_;
@@ -100,9 +103,6 @@ class VIEWS_EXPORT DialogClientView : public ClientView,
// The extra view shown in the row of buttons; may be NULL.
View* extra_view_;
- // The footnote view shown below the buttons; may be NULL.
- View* footnote_view_;
-
// True if we've notified the delegate the window is closing and the delegate
// allowed the close. In some situations it's possible to get two closes (see
// http://crbug.com/71940). This is used to avoid notifying the delegate

Powered by Google App Engine
This is Rietveld 408576698