chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc - Issue 1717453003: Introduce BubbleDialogDelegateView, which extends DialogDelegateView

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc

Issue 1717453003: Introduce BubbleDialogDelegateView, which extends DialogDelegateView (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: relative ps Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/bookmarks/bookmark_bubble_view.h ('k') | chrome/browser/ui/views/extensions/extension_installed_bubble_view.h » ('j') | ui/views/window/dialog_delegate.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc

diff --git a/chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc b/chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc

index 6b8de33bfcec46a20fd7ec7f31422b2fbfeb4544..81a488b7a3a753fd7410b2d468af7d5eab5564b4 100644

--- a/chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc

+++ b/chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc

@@ -238,16 +238,15 @@ views::View* BookmarkBubbleView::GetInitiallyFocusedView() {

return title_tf_;

}

-scoped_ptr<views::View> BookmarkBubbleView::CreateFootnoteView() {

+views::View* BookmarkBubbleView::CreateFootnoteView() {

if (!SyncPromoUI::ShouldShowSyncPromo(profile_))

return nullptr;

content::RecordAction(

base::UserMetricsAction("Signin_Impression_FromBookmarkBubble"));

- return scoped_ptr<views::View>(

- new BubbleSyncPromoView(delegate_.get(), IDS_BOOKMARK_SYNC_PROMO_LINK,

- IDS_BOOKMARK_SYNC_PROMO_MESSAGE));

+ return new BubbleSyncPromoView(delegate_.get(), IDS_BOOKMARK_SYNC_PROMO_LINK,

+ IDS_BOOKMARK_SYNC_PROMO_MESSAGE);

}

BookmarkBubbleView::BookmarkBubbleView(