Add "sample locations" feature to GrProcessor

src/gpu/gl/GrGLGpu.cpp

 /*
  * Copyright 2011 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #include "GrGLGpu.h"
 #include "GrGLGLSL.h"
 #include "GrGLStencilAttachment.h"
@@ skipping 3765 matching lines @@
                             dstGLRect.fBottom,
                             dstGLRect.fLeft + dstGLRect.fWidth,
                             dstGLRect.fBottom + dstGLRect.fHeight,
                             GR_GL_COLOR_BUFFER_BIT, GR_GL_NEAREST));
     this->unbindTextureFBOForCopy(GR_GL_DRAW_FRAMEBUFFER, dst);
     this->unbindTextureFBOForCopy(GR_GL_READ_FRAMEBUFFER, src);
     this->didWriteToSurface(dst, &dstRect);
     return true;
 }
 
+void GrGLGpu::onGetMultisampleSpecs(GrRenderTarget* rt,
+                                    const GrStencilSettings& stencil,
+                                    int* effectiveSampleCnt,
+                                    SamplePattern* pattern) {
+    SkASSERT(!rt->hasMixedSamples() || rt->renderTargetPriv().getStencilAttachment() ||
+             stencil.isDisabled());
+
+    this->flushStencil(stencil);
+    this->flushHWAAState(rt, true, !stencil.isDisabled());
+    this->flushRenderTarget(static_cast<GrGLRenderTarget*>(rt), &SkIRect::EmptyIRect());
+
+    if (0 != this->caps()->maxRasterSamples()) {
+        GR_GL_GetIntegerv(this->glInterface(), GR_GL_EFFECTIVE_RASTER_SAMPLES, effectiveSampleCnt);
+    } else {
+        GR_GL_GetIntegerv(this->glInterface(), GR_GL_SAMPLES, effectiveSampleCnt);
+    }
+    if (this->caps()->sampleLocationsSupport()) {
+        pattern->reset(*effectiveSampleCnt);
+        for (int i = 0; i < *effectiveSampleCnt; ++i) {
+            GrGLfloat pos[2];
+            GL_CALL(GetMultisamplefv(GR_GL_SAMPLE_POSITION, i, pos));
+            // OpenGL pixel space and Skia device space have inverted y directions.
+            (*pattern)[i].set(pos[0] - 0.5f, 0.5f - pos[1]);

[Mark Kilgard, 2016/02/22 18:41:04]

so do samples in Skia are in a [-0.5, 0.5) range where OpenGL uses [0,1] so
(0.5,0.5) is at the pixel center?

This is a bit surprising

The comment probably should note not just the inverted y direction but also the
2D shift by half-pixel for OpenGL pixel space vs. Skia device space

or is this to make interpolation in shaders easier by having pixel center at
(0,0)?

[Chris Dalton, 2016/02/22 19:10:43]

The 0.5, 0.5 offset was added by me just because it makes sense for
interpolation in shaders.

You bring up a good point. As far as the skia API is concerned, maybe it would
make more sense for 0,0 to be the top left corner? Brian? Josh? Thoughts? The
builders can easily account for this elsewhere if needed.

[bsalomon, 2016/02/22 20:28:26]

Skia's device coordinates have integers at the borders between pixels, so I
think it makes sense for 0.5, 0.5 in sample coordinates to be at the pixel
center.

[Chris Dalton, 2016/02/22 21:19:11]

Agreed. Now that I think about it I also prefer 0.5, 0.5 for the center.

[Chris Dalton, 2016/02/22 22:17:55]

Done.

+        }
+    }
+}
+
 void GrGLGpu::xferBarrier(GrRenderTarget* rt, GrXferBarrierType type) {
     SkASSERT(type);
     switch (type) {
         case kTexture_GrXferBarrierType: {
             GrGLRenderTarget* glrt = static_cast<GrGLRenderTarget*>(rt);
             if (glrt->textureFBOID() != glrt->renderFBOID()) {
                 // The render target uses separate storage so no need for glTextureBarrier.
                 // FIXME: The render target will resolve automatically when its texture is bound,
                 // but we could resolve only the bounds that will be read if we do it here instead.
                 return;
@@ skipping 156 matching lines @@
         if (GR_GL_TEXTURE_EXTERNAL == glTexture->target() ||
             GR_GL_TEXTURE_RECTANGLE == glTexture->target()) {
             copyParams->fFilter = GrTextureParams::kNone_FilterMode;
             copyParams->fWidth = texture->width();
             copyParams->fHeight = texture->height();
             return true;
         }
     }
     return false;
 }