Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(849)

Issue 1717333003: X87: [interpreter, debugger] support debug breaks via bytecode array copy. (Closed)

Created:
4 years, 10 months ago by zhengxing.li
Modified:
4 years, 10 months ago
Reviewers:
Weiliang, chunyang.dai, Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [interpreter, debugger] support debug breaks via bytecode array copy. port e032a98d3d1c532716892d2aad0e9d4467acae61 (r34190) original commit message: BUG= Committed: https://crrev.com/360c761decee70ae88bde00ccfadac18929622c6 Cr-Commit-Position: refs/heads/master@{#34205}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -0 lines) Patch
M src/x87/builtins-x87.cc View 2 chunks +14 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
PTAL, thanks!
4 years, 10 months ago (2016-02-23 02:41:13 UTC) #2
Weiliang
lgtm
4 years, 10 months ago (2016-02-23 03:08:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1717333003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1717333003/1
4 years, 10 months ago (2016-02-23 06:02:58 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-23 06:17:35 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-23 06:18:58 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/360c761decee70ae88bde00ccfadac18929622c6
Cr-Commit-Position: refs/heads/master@{#34205}

Powered by Google App Engine
This is Rietveld 408576698