third_party/WebKit/Source/core/dom/StyleSheetCandidate.cpp - Issue 1717303002: Ignore title attribute for style elements in shadow trees.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/StyleSheetCandidate.cpp

Issue 1717303002: Ignore title attribute for style elements in shadow trees. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/dom/StyleSheetCandidate.cpp

diff --git a/third_party/WebKit/Source/core/dom/StyleSheetCandidate.cpp b/third_party/WebKit/Source/core/dom/StyleSheetCandidate.cpp

index 3dc0e62a4dd77e6f736a51f031f6e74255e18372..12890f0f88db81058544eacca3abb0ede692adfd 100644

--- a/third_party/WebKit/Source/core/dom/StyleSheetCandidate.cpp

+++ b/third_party/WebKit/Source/core/dom/StyleSheetCandidate.cpp

@@ -93,6 +93,10 @@ bool StyleSheetCandidate::canBeActivated(const String& currentPreferrableName) c

StyleSheet* sheet = this->sheet();

if (!sheet || sheet->disabled() || !sheet->isCSSStyleSheet())

return false;

+ if (sheet->ownerNode() && sheet->ownerNode()->treeScope().rootNode().isShadowRoot())

dglazkov 2016/02/22 16:44:45 would ownerNode()->isInShadowTree() not work?

rune 2016/02/22 17:38:16 Done.

+ return true;

const AtomicString& title = this->title();

if (!isEnabledViaScript() && !title.isEmpty() && title != currentPreferrableName)

return false;

« no previous file with comments | « third_party/WebKit/Source/core/dom/ShadowTreeStyleSheetCollection.cpp ('k') | no next file » | no next file with comments »