Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(441)

Unified Diff: test/cctest/interpreter/test-bytecode-generator.cc

Issue 1717293002: [Interpreter] Refactor bytecode generator test suite. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Move golden files to subdir, update golden format. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: test/cctest/interpreter/test-bytecode-generator.cc
diff --git a/test/cctest/interpreter/test-bytecode-generator.cc b/test/cctest/interpreter/test-bytecode-generator.cc
index 73767eb3c6100ee923bbb96d331b657e03d997d7..89fa8af8ad28ab60edc03ffe497887409551fad9 100644
--- a/test/cctest/interpreter/test-bytecode-generator.cc
+++ b/test/cctest/interpreter/test-bytecode-generator.cc
@@ -2,6 +2,8 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
+#include <fstream>
+
#include "src/v8.h"
#include "src/compiler.h"
@@ -9,113 +11,15 @@
#include "src/interpreter/bytecode-generator.h"
#include "src/interpreter/interpreter.h"
#include "test/cctest/cctest.h"
+#include "test/cctest/interpreter/bytecode-expectations-printer.h"
#include "test/cctest/test-feedback-vector.h"
namespace v8 {
namespace internal {
namespace interpreter {
oth 2016/02/24 13:43:55 I'd be inclined to have some doc comments here tha
Stefano Sanfilippo 2016/02/24 14:55:01 Agreed. I am working on it.
-static const InstanceType kInstanceTypeDontCare = static_cast<InstanceType>(-1);
-
-class BytecodeGeneratorHelper {
- public:
- const char* kFunctionName = "f";
-
- static const int kLastParamIndex =
- -InterpreterFrameConstants::kLastParamFromRegisterPointer / kPointerSize;
-
- BytecodeGeneratorHelper() {
- i::FLAG_ignition = true;
- i::FLAG_ignition_filter = StrDup(kFunctionName);
- i::FLAG_always_opt = false;
- i::FLAG_allow_natives_syntax = true;
- CcTest::i_isolate()->interpreter()->Initialize();
- }
-
- Isolate* isolate() { return CcTest::i_isolate(); }
- Factory* factory() { return CcTest::i_isolate()->factory(); }
-
- Handle<BytecodeArray> MakeTopLevelBytecode(const char* source) {
- const char* old_ignition_filter = i::FLAG_ignition_filter;
- i::FLAG_ignition_filter = "*";
- Local<v8::Script> script = v8_compile(source);
- i::FLAG_ignition_filter = old_ignition_filter;
- i::Handle<i::JSFunction> js_function = v8::Utils::OpenHandle(*script);
- return handle(js_function->shared()->bytecode_array(), CcTest::i_isolate());
- }
-
- Handle<BytecodeArray> MakeBytecode(const char* script,
- const char* function_name) {
- CompileRun(script);
- v8::Local<v8::Context> context =
- v8::Isolate::GetCurrent()->GetCurrentContext();
- Local<Function> function = Local<Function>::Cast(
- CcTest::global()->Get(context, v8_str(function_name)).ToLocalChecked());
- i::Handle<i::JSFunction> js_function =
- i::Handle<i::JSFunction>::cast(v8::Utils::OpenHandle(*function));
- return handle(js_function->shared()->bytecode_array(), CcTest::i_isolate());
- }
-
- Handle<BytecodeArray> MakeBytecode(const char* script, const char* filter,
- const char* function_name) {
- const char* old_ignition_filter = i::FLAG_ignition_filter;
- i::FLAG_ignition_filter = filter;
- Handle<BytecodeArray> return_val = MakeBytecode(script, function_name);
- i::FLAG_ignition_filter = old_ignition_filter;
- return return_val;
- }
-
- Handle<BytecodeArray> MakeBytecodeForFunctionBody(const char* body) {
- static const char kFormat[] = "function %s() { %s }\n%s();";
- static const int kFormatLength = arraysize(kFormat);
- int length = kFormatLength + 2 * StrLength(kFunctionName) + StrLength(body);
- ScopedVector<char> program(length);
- length = SNPrintF(program, kFormat, kFunctionName, body, kFunctionName);
- CHECK_GT(length, 0);
- return MakeBytecode(program.start(), kFunctionName);
- }
-
- Handle<BytecodeArray> MakeBytecodeForFunction(const char* function) {
- ScopedVector<char> program(3072);
- SNPrintF(program, "%s\n%s();", function, kFunctionName);
- return MakeBytecode(program.start(), kFunctionName);
- }
-
- Handle<BytecodeArray> MakeBytecodeForFunctionNoFilter(const char* function) {
- ScopedVector<char> program(3072);
- SNPrintF(program, "%s\n%s();", function, kFunctionName);
- return MakeBytecode(program.start(), "*", kFunctionName);
- }
-};
-
-
-// Helper macros for handcrafting bytecode sequences.
-#define B(x) static_cast<uint8_t>(Bytecode::k##x)
-#define U8(x) static_cast<uint8_t>((x) & 0xff)
-#define R(x) static_cast<uint8_t>(-(x) & 0xff)
-#define R16(x) U16(-(x))
-#define A(x, n) R(helper.kLastParamIndex - (n) + 1 + (x))
-#define THIS(n) A(0, n)
-#if defined(V8_TARGET_LITTLE_ENDIAN)
-#define U16(x) static_cast<uint8_t>((x) & 0xff), \
- static_cast<uint8_t>(((x) >> kBitsPerByte) & 0xff)
-#define U16I(x) static_cast<uint8_t>((x) & 0xff), \
- static_cast<uint8_t>(((x++) >> kBitsPerByte) & 0xff)
-#elif defined(V8_TARGET_BIG_ENDIAN)
-#define U16(x) static_cast<uint8_t>(((x) >> kBitsPerByte) & 0xff), \
- static_cast<uint8_t>((x) & 0xff)
-#define U16I(x) static_cast<uint8_t>(((x) >> kBitsPerByte) & 0xff), \
- static_cast<uint8_t>((x++) & 0xff)
-#else
-#error Unknown byte ordering
-#endif
-
-#define XSTR(A) #A
-#define STR(A) XSTR(A)
-
#define COMMA() ,
#define SPACE()
-#define UNIQUE_VAR() "var a" STR(__COUNTER__) " = 0;\n"
#define REPEAT_2(SEP, ...) \
__VA_ARGS__ SEP() __VA_ARGS__
@@ -145,7800 +49,1616 @@ class BytecodeGeneratorHelper {
REPEAT_32(SEP, __VA_ARGS__) SEP() REPEAT_16(SEP, __VA_ARGS__) SEP() \
REPEAT_8(SEP, __VA_ARGS__) SEP() REPEAT_2(SEP, __VA_ARGS__)
-#define REPEAT_249_UNIQUE_VARS() \
-UNIQUE_VAR() REPEAT_127(UNIQUE_VAR) UNIQUE_VAR() REPEAT_64(UNIQUE_VAR) \
-UNIQUE_VAR() REPEAT_32(UNIQUE_VAR) UNIQUE_VAR() REPEAT_16(UNIQUE_VAR) \
-UNIQUE_VAR() REPEAT_8(UNIQUE_VAR) UNIQUE_VAR() REPEAT_2(UNIQUE_VAR)
-
-// Structure for containing expected bytecode snippets.
-template<typename T, int C = 6>
-struct ExpectedSnippet {
- const char* code_snippet;
- int frame_size;
- int parameter_count;
- int bytecode_length;
- const uint8_t bytecode[2048];
- int constant_count;
- T constants[C];
- int handler_count;
- struct {
- int start;
- int end;
- int handler;
- } handlers[C];
-};
+static const char* kGoldenFileDirectory =
+ "test/cctest/interpreter/bytecode_expectations/";
+class InitializedIgnitionHandleScope : public InitializedHandleScope {
+ public:
+ InitializedIgnitionHandleScope() {
+ i::FLAG_ignition = true;
+ i::FLAG_always_opt = false;
+ i::FLAG_allow_natives_syntax = true;
+ CcTest::i_isolate()->interpreter()->Initialize();
+ }
+};
-static void CheckConstant(int expected, Object* actual) {
- CHECK_EQ(expected, Smi::cast(actual)->value());
+void SkipGoldenFileHeader(std::istream& stream) { // NOLINT
+ std::string line;
+ int separators_seen = 0;
+ while (std::getline(stream, line)) {
+ if (line == "---") separators_seen += 1;
+ if (separators_seen == 2) return;
+ }
}
+std::string LoadGolden(const std::string& golden_filename) {
+ std::ifstream expected_file((kGoldenFileDirectory + golden_filename).c_str());
+ std::cerr << golden_filename << '\n';
rmcilroy 2016/02/24 08:55:35 Is this for debugging? Please remove it, we don't
Stefano Sanfilippo 2016/02/24 14:55:01 Done.
+ CHECK(expected_file.is_open());
+ SkipGoldenFileHeader(expected_file);
+ std::ostringstream expected_stream;
+ expected_stream << "---\n" << expected_file.rdbuf();
rmcilroy 2016/02/24 08:55:35 Please add a comment on why this is necessary.
Stefano Sanfilippo 2016/02/24 14:55:01 Done.
+ return expected_stream.str();
+}
-static void CheckConstant(double expected, Object* actual) {
- CHECK_EQ(expected, HeapNumber::cast(actual)->value());
+template <size_t N>
+std::string BuildActual(const BytecodeExpectationsPrinter& printer,
+ const char* (&snippet_list)[N],
+ const char* prologue = nullptr,
+ const char* epilogue = nullptr) {
+ std::ostringstream actual_stream;
+ for (const char* snippet : snippet_list) {
+ std::string source_code;
+ if (prologue) source_code += prologue;
+ source_code += snippet;
+ if (epilogue) source_code += epilogue;
+ printer.PrintExpectation(actual_stream, source_code);
+ }
+ return actual_stream.str();
}
+typedef BytecodeExpectationsPrinter::ConstantPoolType ConstantPoolType;
rmcilroy 2016/02/24 08:55:35 can you do this with a "using" instead of a typede
Stefano Sanfilippo 2016/02/24 14:55:01 Done.
-static void CheckConstant(const char* expected, Object* actual) {
- Handle<String> expected_string =
- CcTest::i_isolate()->factory()->NewStringFromAsciiChecked(expected);
- CHECK(String::cast(actual)->Equals(*expected_string));
+TEST(PrimitiveReturnStatements) {
+ InitializedIgnitionHandleScope scope;
+ BytecodeExpectationsPrinter printer(CcTest::isolate(),
+ ConstantPoolType::kNumber);
+ const char* snippets[] = {
+ "",
+ "return;",
+ "return null;",
+ "return true;",
+ "return false;",
+ "return 0;",
+ "return +1;",
+ "return -1;",
+ "return +127;",
+ "return -128;",
+ };
+
+ CHECK_EQ(BuildActual(printer, snippets),
+ LoadGolden("PrimitiveReturnStatements.golden"));
}
-
-static void CheckConstant(Handle<Object> expected, Object* actual) {
- CHECK(actual == *expected || expected->StrictEquals(actual));
+TEST(PrimitiveExpressions) {
+ InitializedIgnitionHandleScope scope;
+ BytecodeExpectationsPrinter printer(CcTest::isolate(),
+ ConstantPoolType::kNumber);
+ const char* snippets[] = {
+ "var x = 0; return x;",
+ "var x = 0; return x + 3;",
+ "var x = 0; return x - 3;",
+ "var x = 4; return x * 3;",
+ "var x = 4; return x / 3;",
+ "var x = 4; return x % 3;",
+ "var x = 1; return x | 2;",
+ "var x = 1; return x ^ 2;",
+ "var x = 1; return x & 2;",
+ "var x = 10; return x << 3;",
+ "var x = 10; return x >> 3;",
+ "var x = 10; return x >>> 3;",
+ "var x = 0; return (x, 3);",
+ };
+
+ CHECK_EQ(BuildActual(printer, snippets),
+ LoadGolden("PrimitiveExpressions.golden"));
}
+TEST(LogicalExpressions) {
+ InitializedIgnitionHandleScope scope;
+ BytecodeExpectationsPrinter printer(CcTest::isolate(),
+ ConstantPoolType::kNumber);
+ const char* snippets[] = {
+ "var x = 0; return x || 3;",
-static void CheckConstant(InstanceType expected, Object* actual) {
- if (expected != kInstanceTypeDontCare) {
- CHECK_EQ(expected, HeapObject::cast(actual)->map()->instance_type());
- }
-}
+ "var x = 0; return (x == 1) || 3;",
+ "var x = 0; return x && 3;",
-template <typename T, int C>
-static void CheckBytecodeArrayEqual(const ExpectedSnippet<T, C>& expected,
- Handle<BytecodeArray> actual) {
- CHECK_EQ(expected.frame_size, actual->frame_size());
- CHECK_EQ(expected.parameter_count, actual->parameter_count());
- CHECK_EQ(expected.bytecode_length, actual->length());
- if (expected.constant_count == 0) {
- CHECK_EQ(CcTest::heap()->empty_fixed_array(), actual->constant_pool());
- } else {
- CHECK_EQ(expected.constant_count, actual->constant_pool()->length());
- for (int i = 0; i < expected.constant_count; i++) {
- CheckConstant(expected.constants[i], actual->constant_pool()->get(i));
- }
- }
- if (expected.handler_count == 0) {
- CHECK_EQ(CcTest::heap()->empty_fixed_array(), actual->handler_table());
- } else {
- HandlerTable* table = HandlerTable::cast(actual->handler_table());
- CHECK_EQ(expected.handler_count, table->NumberOfRangeEntries());
- for (int i = 0; i < expected.handler_count; i++) {
- CHECK_EQ(expected.handlers[i].start, table->GetRangeStart(i));
- CHECK_EQ(expected.handlers[i].end, table->GetRangeEnd(i));
- CHECK_EQ(expected.handlers[i].handler, table->GetRangeHandler(i));
- }
- }
+ "var x = 0; return (x == 0) && 3;",
- BytecodeArrayIterator iterator(actual);
- int i = 0;
- while (!iterator.done()) {
- int bytecode_index = i++;
- Bytecode bytecode = iterator.current_bytecode();
- if (Bytecodes::ToByte(bytecode) != expected.bytecode[bytecode_index]) {
- std::ostringstream stream;
- stream << "Check failed: expected bytecode [" << bytecode_index
- << "] to be " << Bytecodes::ToString(static_cast<Bytecode>(
- expected.bytecode[bytecode_index]))
- << " but got " << Bytecodes::ToString(bytecode);
- FATAL(stream.str().c_str());
- }
- for (int j = 0; j < Bytecodes::NumberOfOperands(bytecode); ++j) {
- OperandType operand_type = Bytecodes::GetOperandType(bytecode, j);
- int operand_index = i;
- i += static_cast<int>(Bytecodes::SizeOfOperand(operand_type));
- uint32_t raw_operand = iterator.GetRawOperand(j, operand_type);
- uint32_t expected_operand;
- switch (Bytecodes::SizeOfOperand(operand_type)) {
- case OperandSize::kNone:
- UNREACHABLE();
- return;
- case OperandSize::kByte:
- expected_operand =
- static_cast<uint32_t>(expected.bytecode[operand_index]);
- break;
- case OperandSize::kShort:
- expected_operand =
- ReadUnalignedUInt16(&expected.bytecode[operand_index]);
- break;
- default:
- UNREACHABLE();
- return;
- }
- if (raw_operand != expected_operand) {
- std::ostringstream stream;
- stream << "Check failed: expected operand [" << j << "] for bytecode ["
- << bytecode_index << "] to be "
- << static_cast<unsigned int>(expected_operand) << " but got "
- << static_cast<unsigned int>(raw_operand);
- FATAL(stream.str().c_str());
- }
- }
- iterator.Advance();
- }
-}
+ "var x = 0; return x || (1, 2, 3);",
+ "var a = 2, b = 3, c = 4; return a || (a, b, a, b, c = 5, 3);",
-TEST(PrimitiveReturnStatements) {
- InitializedHandleScope handle_scope;
- BytecodeGeneratorHelper helper;
-
- // clang-format off
- ExpectedSnippet<int> snippets[] = {
- {"",
- 0,
- 1,
- 3,
- {
- B(StackCheck), //
- B(LdaUndefined), //
- B(Return) //
- },
- 0},
- {"return;",
- 0,
- 1,
- 3,
- {
- B(StackCheck), //
- B(LdaUndefined), //
- B(Return) //
- },
- 0},
- {"return null;",
- 0,
- 1,
- 3,
- {
- B(StackCheck), //
- B(LdaNull), //
- B(Return) //
- },
- 0},
- {"return true;",
- 0,
- 1,
- 3,
- {
- B(StackCheck), //
- B(LdaTrue), //
- B(Return) //
- },
- 0},
- {"return false;",
- 0,
- 1,
- 3,
- {
- B(StackCheck), //
- B(LdaFalse), //
- B(Return) //
- },
- 0},
- {"return 0;",
- 0,
- 1,
- 3,
- {
- B(StackCheck), //
- B(LdaZero), //
- B(Return) //
- },
- 0},
- {"return +1;",
- 0,
- 1,
- 4,
- {
- B(StackCheck), //
- B(LdaSmi8), U8(1), //
- B(Return) //
- },
- 0},
- {"return -1;",
- 0,
- 1,
- 4,
- {
- B(StackCheck), //
- B(LdaSmi8), U8(-1), //
- B(Return) //
- },
- 0},
- {"return +127;",
- 0,
- 1,
- 4,
- {
- B(StackCheck), //
- B(LdaSmi8), U8(127), //
- B(Return) //
- },
- 0},
- {"return -128;",
- 0,
- 1,
- 4,
- {
- B(StackCheck), //
- B(LdaSmi8), U8(-128), //
- B(Return) //
- },
- 0},
- };
- // clang-format on
+ "var x = 1; var a = 2, b = 3; return x || ("
+ REPEAT_32(SPACE, "\na = 1, b = 2, ") "3);",
- for (size_t i = 0; i < arraysize(snippets); i++) {
- Handle<BytecodeArray> bytecode_array =
- helper.MakeBytecodeForFunctionBody(snippets[i].code_snippet);
- CheckBytecodeArrayEqual(snippets[i], bytecode_array);
- }
-}
+ "var x = 0; var a = 2, b = 3; return x && ("
+ REPEAT_32(SPACE, "\na = 1, b = 2, ") "3);",
+ "var x = 1; var a = 2, b = 3; return (x > 3) || ("
+ REPEAT_32(SPACE, "\na = 1, b = 2, ") "3);",
-TEST(PrimitiveExpressions) {
- InitializedHandleScope handle_scope;
- BytecodeGeneratorHelper helper;
-
- // clang-format off
- ExpectedSnippet<int> snippets[] = {
- {"var x = 0; return x;",
- kPointerSize,
- 1,
- 5,
- {B(StackCheck), //
- B(LdaZero), //
- B(Star), R(0), //
- B(Return)},
- 0},
- {"var x = 0; return x + 3;",
- 2 * kPointerSize,
- 1,
- 11,
- {B(StackCheck), //
- B(LdaZero), //
- B(Star), R(0), //
- B(Star), R(1), //
- B(LdaSmi8), U8(3), //
- B(Add), R(1), //
- B(Return)},
- 0},
- {"var x = 0; return x - 3;",
- 2 * kPointerSize,
- 1,
- 11,
- {B(StackCheck), //
- B(LdaZero), //
- B(Star), R(0), //
- B(Star), R(1), //
- B(LdaSmi8), U8(3), //
- B(Sub), R(1), //
- B(Return)},
- 0},
- {"var x = 4; return x * 3;",
- 2 * kPointerSize,
- 1,
- 12,
- {B(StackCheck), //
- B(LdaSmi8), U8(4), //
- B(Star), R(0), //
- B(Star), R(1), //
- B(LdaSmi8), U8(3), //
- B(Mul), R(1), //
- B(Return)},
- 0},
- {"var x = 4; return x / 3;",
- 2 * kPointerSize,
- 1,
- 12,
- {B(StackCheck), //
- B(LdaSmi8), U8(4), //
- B(Star), R(0), //
- B(Star), R(1), //
- B(LdaSmi8), U8(3), //
- B(Div), R(1), //
- B(Return)},
- 0},
- {"var x = 4; return x % 3;",
- 2 * kPointerSize,
- 1,
- 12,
- {B(StackCheck), //
- B(LdaSmi8), U8(4), //
- B(Star), R(0), //
- B(Star), R(1), //
- B(LdaSmi8), U8(3), //
- B(Mod), R(1), //
- B(Return)},
- 0},
- {"var x = 1; return x | 2;",
- 2 * kPointerSize,
- 1,
- 12,
- {B(StackCheck), //
- B(LdaSmi8), U8(1), //
- B(Star), R(0), //
- B(Star), R(1), //
- B(LdaSmi8), U8(2), //
- B(BitwiseOr), R(1), //
- B(Return)},
- 0},
- {"var x = 1; return x ^ 2;",
- 2 * kPointerSize,
- 1,
- 12,
- {B(StackCheck), //
- B(LdaSmi8), U8(1), //
- B(Star), R(0), //
- B(Star), R(1), //
- B(LdaSmi8), U8(2), //
- B(BitwiseXor), R(1), //
- B(Return)},
- 0},
- {"var x = 1; return x & 2;",
- 2 * kPointerSize,
- 1,
- 12,
- {B(StackCheck), //
- B(LdaSmi8), U8(1), //
- B(Star), R(0), //
- B(Star), R(1), //
- B(LdaSmi8), U8(2), //
- B(BitwiseAnd), R(1), //
- B(Return)},
- 0},
- {"var x = 10; return x << 3;",
- 2 * kPointerSize,
- 1,
- 12,
- {B(StackCheck), //
- B(LdaSmi8), U8(10), //
- B(Star), R(0), //
- B(Star), R(1), //
- B(LdaSmi8), U8(3), //
- B(ShiftLeft), R(1), //
- B(Return)},
- 0},
- {"var x = 10; return x >> 3;",
- 2 * kPointerSize,
- 1,
- 12,
- {B(StackCheck), //
- B(LdaSmi8), U8(10), //
- B(Star), R(0), //
- B(Star), R(1), //
- B(LdaSmi8), U8(3), //
- B(ShiftRight), R(1), //
- B(Return)},
- 0},
- {"var x = 10; return x >>> 3;",
- 2 * kPointerSize,
- 1,
- 12,
- {B(StackCheck), //
- B(LdaSmi8), U8(10), //
- B(Star), R(0), //
- B(Star), R(1), //
- B(LdaSmi8), U8(3), //
- B(ShiftRightLogical), R(1), //
- B(Return)},
- 0},
- {"var x = 0; return (x, 3);",
- 1 * kPointerSize,
- 1,
- 7,
- {B(StackCheck), //
- B(LdaZero), //
- B(Star), R(0), //
- B(LdaSmi8), U8(3), //
- B(Return)},
- 0},
- };
- // clang-format on
+ "var x = 0; var a = 2, b = 3; return (x < 5) && ("
+ REPEAT_32(SPACE, "\na = 1, b = 2, ") "3);",
- for (size_t i = 0; i < arraysize(snippets); i++) {
- Handle<BytecodeArray> bytecode_array =
- helper.MakeBytecodeForFunctionBody(snippets[i].code_snippet);
- CheckBytecodeArrayEqual(snippets[i], bytecode_array);
- }
-}
+ "return 0 && 3;",
+ "return 1 || 3;",
-TEST(LogicalExpressions) {
- InitializedHandleScope handle_scope;
- BytecodeGeneratorHelper helper;
-
- // clang-format off
- ExpectedSnippet<int> snippets[] = {
- {"var x = 0; return x || 3;",
- 1 * kPointerSize,
- 1,
- 9,
- {B(StackCheck), //
- B(LdaZero), //
- B(Star), R(0), //
- B(JumpIfToBooleanTrue), U8(4), //
- B(LdaSmi8), U8(3), //
- B(Return)},
- 0},
- {"var x = 0; return (x == 1) || 3;",
- 2 * kPointerSize,
- 1,
- 15,
- {B(StackCheck), //
- B(LdaZero), //
- B(Star), R(0), //
- B(Star), R(1), //
- B(LdaSmi8), U8(1), //
- B(TestEqual), R(1), //
- B(JumpIfTrue), U8(4), //
- B(LdaSmi8), U8(3), //
- B(Return)},
- 0},
- {"var x = 0; return x && 3;",
- 1 * kPointerSize,
- 1,
- 9,
- {B(StackCheck), //
- B(LdaZero), //
- B(Star), R(0), //
- B(JumpIfToBooleanFalse), U8(4), //
- B(LdaSmi8), U8(3), //
- B(Return)},
- 0},
- {"var x = 0; return (x == 0) && 3;",
- 2 * kPointerSize,
- 1,
- 14,
- {B(StackCheck), //
- B(LdaZero), //
- B(Star), R(0), //
- B(Star), R(1), //
- B(LdaZero), //
- B(TestEqual), R(1), //
- B(JumpIfFalse), U8(4), //
- B(LdaSmi8), U8(3), //
- B(Return)},
- 0},
- {"var x = 0; return x || (1, 2, 3);",
- 1 * kPointerSize,
- 1,
- 9,
- {B(StackCheck), //
- B(LdaZero), //
- B(Star), R(0), //
- B(JumpIfToBooleanTrue), U8(4), //
- B(LdaSmi8), U8(3), //
- B(Return)},
- 0},
- {"var a = 2, b = 3, c = 4; return a || (a, b, a, b, c = 5, 3);",
- 3 * kPointerSize,
- 1,
- 32,
- {B(StackCheck), //
- B(LdaSmi8), U8(2), //
- B(Star), R(0), //
- B(LdaSmi8), U8(3), //
- B(Star), R(1), //
- B(LdaSmi8), U8(4), //
- B(Star), R(2), //
- B(Ldar), R(0), //
- B(JumpIfToBooleanTrue), U8(16), //
- B(Ldar), R(0), //
- B(Ldar), R(1), //
- B(Ldar), R(0), //
- B(Ldar), R(1), //
- B(LdaSmi8), U8(5), //
- B(Star), R(2), //
- B(LdaSmi8), U8(3), //
- B(Return)},
- 0},
- {"var x = 1; var a = 2, b = 3; return x || ("
- REPEAT_32(SPACE, "a = 1, b = 2, ")
- "3);",
- 3 * kPointerSize,
- 1,
- 276,
- {B(StackCheck), //
- B(LdaSmi8), U8(1), //
- B(Star), R(0), //
- B(LdaSmi8), U8(2), //
- B(Star), R(1), //
- B(LdaSmi8), U8(3), //
- B(Star), R(2), //
- B(Ldar), R(0), //
- B(JumpIfToBooleanTrueConstant), U8(0), //
- REPEAT_32(COMMA, //
- B(LdaSmi8), U8(1), //
- B(Star), R(1), //
- B(LdaSmi8), U8(2), //
- B(Star), R(2)), //
- B(LdaSmi8), U8(3), //
- B(Return)},
- 1,
- {260, 0, 0, 0}},
- {"var x = 0; var a = 2, b = 3; return x && ("
- REPEAT_32(SPACE, "a = 1, b = 2, ")
- "3);",
- 3 * kPointerSize,
- 1,
- 275,
- {B(StackCheck), //
- B(LdaZero), //
- B(Star), R(0), //
- B(LdaSmi8), U8(2), //
- B(Star), R(1), //
- B(LdaSmi8), U8(3), //
- B(Star), R(2), //
- B(Ldar), R(0), //
- B(JumpIfToBooleanFalseConstant), U8(0), //
- REPEAT_32(COMMA, //
- B(LdaSmi8), U8(1), //
- B(Star), R(1), //
- B(LdaSmi8), U8(2), //
- B(Star), R(2)), //
- B(LdaSmi8), U8(3), //
- B(Return)}, //
- 1,
- {260, 0, 0, 0}},
- {"var x = 1; var a = 2, b = 3; return (x > 3) || ("
- REPEAT_32(SPACE, "a = 1, b = 2, ")
- "3);",
- 4 * kPointerSize,
- 1,
- 282,
- {B(StackCheck), //
- B(LdaSmi8), U8(1), //
- B(Star), R(0), //
- B(LdaSmi8), U8(2), //
- B(Star), R(1), //
- B(LdaSmi8), U8(3), //
- B(Star), R(2), //
- B(Ldar), R(0), //
- B(Star), R(3), //
- B(LdaSmi8), U8(3), //
- B(TestGreaterThan), R(3), //
- B(JumpIfTrueConstant), U8(0), //
- REPEAT_32(COMMA, //
- B(LdaSmi8), U8(1), //
- B(Star), R(1), //
- B(LdaSmi8), U8(2), //
- B(Star), R(2)), //
- B(LdaSmi8), U8(3), //
- B(Return)},
- 1,
- {260, 0, 0, 0}},
- {"var x = 0; var a = 2, b = 3; return (x < 5) && ("
- REPEAT_32(SPACE, "a = 1, b = 2, ")
- "3);",
- 4 * kPointerSize,
- 1,
- 281,
- {B(StackCheck), //
- B(LdaZero), //
- B(Star), R(0), //
- B(LdaSmi8), U8(2), //
- B(Star), R(1), //
- B(LdaSmi8), U8(3), //
- B(Star), R(2), //
- B(Ldar), R(0), //
- B(Star), R(3), //
- B(LdaSmi8), U8(5), //
- B(TestLessThan), R(3), //
- B(JumpIfFalseConstant), U8(0), //
- REPEAT_32(COMMA, //
- B(LdaSmi8), U8(1), //
- B(Star), R(1), //
- B(LdaSmi8), U8(2), //
- B(Star), R(2)), //
- B(LdaSmi8), U8(3), //
- B(Return)},
- 1,
- {260, 0, 0, 0}},
- {"return 0 && 3;",
- 0 * kPointerSize,
- 1,
- 3,
- {B(StackCheck), //
- B(LdaZero), //
- B(Return)},
- 0},
- {"return 1 || 3;",
- 0 * kPointerSize,
- 1,
- 4,
- {B(StackCheck), //
- B(LdaSmi8), U8(1), //
- B(Return)},
- 0},
- {"var x = 1; return x && 3 || 0, 1;",
- 1 * kPointerSize,
- 1,
- 15,
- {B(StackCheck), //
- B(LdaSmi8), U8(1), //
- B(Star), R(0), //
- B(JumpIfToBooleanFalse), U8(4), //
- B(LdaSmi8), U8(3), //
- B(JumpIfToBooleanTrue), U8(3), //
- B(LdaZero), //
- B(LdaSmi8), U8(1), //
- B(Return)},
- 0}
+ "var x = 1; return x && 3 || 0, 1;",
};
- // clang-format on
- for (size_t i = 0; i < arraysize(snippets); i++) {
- Handle<BytecodeArray> bytecode_array =
- helper.MakeBytecodeForFunctionBody(snippets[i].code_snippet);
- CheckBytecodeArrayEqual(snippets[i], bytecode_array);
- }
+ CHECK_EQ(BuildActual(printer, snippets),
+ LoadGolden("LogicalExpressions.golden"));
}
-
TEST(Parameters) {
- InitializedHandleScope handle_scope;
- BytecodeGeneratorHelper helper;
-
- // clang-format off
- ExpectedSnippet<int> snippets[] = {
- {"function f() { return this; }",
- 0,
- 1,
- 4,
- {B(StackCheck), //
- B(Ldar), THIS(1), //
- B(Return)},
- 0},
- {"function f(arg1) { return arg1; }",
- 0,
- 2,
- 4,
- {B(StackCheck), //
- B(Ldar), A(1, 2), //
- B(Return)},
- 0},
- {"function f(arg1) { return this; }",
- 0,
- 2,
- 4,
- {B(StackCheck), //
- B(Ldar), THIS(2), //
- B(Return)},
- 0},
- {"function f(arg1, arg2, arg3, arg4, arg5, arg6, arg7) { return arg4; }",
- 0,
- 8,
- 4,
- {B(StackCheck), //
- B(Ldar), A(4, 8), //
- B(Return)},
- 0},
- {"function f(arg1, arg2, arg3, arg4, arg5, arg6, arg7) { return this; }",
- 0,
- 8,
- 4,
- {B(StackCheck), //
- B(Ldar), THIS(8), //
- B(Return)},
- 0},
- {"function f(arg1) { arg1 = 1; }",
- 0,
- 2,
- 7,
- {B(StackCheck), //
- B(LdaSmi8), U8(1), //
- B(Star), A(1, 2), //
- B(LdaUndefined), //
- B(Return)},
- 0},
- {"function f(arg1, arg2, arg3, arg4) { arg2 = 1; }",
- 0,
- 5,
- 7,
- {B(StackCheck), //
- B(LdaSmi8), U8(1), //
- B(Star), A(2, 5), //
- B(LdaUndefined), //
- B(Return)},
- 0},
+ InitializedIgnitionHandleScope scope;
+ BytecodeExpectationsPrinter printer(CcTest::isolate(),
+ ConstantPoolType::kNumber);
+ printer.set_wrap(false);
+ printer.set_test_function_name("f");
+
+ const char* snippets[] = {
+ "function f() { return this; }",
+ "function f(arg1) { return arg1; }",
+ "function f(arg1) { return this; }",
+ "function f(arg1, arg2, arg3, arg4, arg5, arg6, arg7) { return arg4; }",
+ "function f(arg1, arg2, arg3, arg4, arg5, arg6, arg7) { return this; }",
+ "function f(arg1) { arg1 = 1; }",
+ "function f(arg1, arg2, arg3, arg4) { arg2 = 1; }",
};
- // clang-format on
- for (size_t i = 0; i < arraysize(snippets); i++) {
- Handle<BytecodeArray> bytecode_array =
- helper.MakeBytecodeForFunction(snippets[i].code_snippet);
- CheckBytecodeArrayEqual(snippets[i], bytecode_array);
- }
+ CHECK_EQ(BuildActual(printer, snippets, "", "\nf();"),
+ LoadGolden("Parameters.golden"));
}
-
TEST(IntegerConstants) {
- InitializedHandleScope handle_scope;
- BytecodeGeneratorHelper helper;
-
- // clang-format off
- ExpectedSnippet<int> snippets[] = {
- {"return 12345678;",
- 0,
- 1,
- 4,
- {
- B(StackCheck), //
- B(LdaConstant), U8(0), //
- B(Return) //
- },
- 1,
- {12345678}},
- {"var a = 1234; return 5678;",
- 1 * kPointerSize,
- 1,
- 8,
- {
- B(StackCheck), //
- B(LdaConstant), U8(0), //
- B(Star), R(0), //
- B(LdaConstant), U8(1), //
- B(Return) //
- },
- 2,
- {1234, 5678}},
- {"var a = 1234; return 1234;",
- 1 * kPointerSize,
- 1,
- 8,
- {
- B(StackCheck), //
- B(LdaConstant), U8(0), //
- B(Star), R(0), //
- B(LdaConstant), U8(0), //
- B(Return) //
- },
- 1,
- {1234}}
+ InitializedIgnitionHandleScope scope;
+ BytecodeExpectationsPrinter printer(CcTest::isolate(),
+ ConstantPoolType::kNumber);
+ const char* snippets[] = {
+ "return 12345678;",
+ "var a = 1234; return 5678;",
+ "var a = 1234; return 1234;",
};
- // clang-format on
- for (size_t i = 0; i < arraysize(snippets); i++) {
- Handle<BytecodeArray> bytecode_array =
- helper.MakeBytecodeForFunctionBody(snippets[i].code_snippet);
- CheckBytecodeArrayEqual(snippets[i], bytecode_array);
- }
+ CHECK_EQ(BuildActual(printer, snippets),
+ LoadGolden("IntegerConstants.golden"));
}
-
TEST(HeapNumberConstants) {
- InitializedHandleScope handle_scope;
- BytecodeGeneratorHelper helper;
-
- int wide_idx = 0;
-
- // clang-format off
- ExpectedSnippet<double, 257> snippets[] = {
- {"return 1.2;",
- 0,
- 1,
- 4,
- {
- B(StackCheck), //
- B(LdaConstant), U8(0), //
- B(Return) //
- },
- 1,
- {1.2}},
- {"var a = 1.2; return 2.6;",
- 1 * kPointerSize,
- 1,
- 8,
- {
- B(StackCheck), //
- B(LdaConstant), U8(0), //
- B(Star), R(0), //
- B(LdaConstant), U8(1), //
- B(Return) //
- },
- 2,
- {1.2, 2.6}},
- {"var a = 3.14; return 3.14;",
- 1 * kPointerSize,
- 1,
- 8,
- {
- B(StackCheck), //
- B(LdaConstant), U8(0), //
- B(Star), R(0), //
- B(LdaConstant), U8(1), //
- B(Return) //
- },
- 2,
- {3.14, 3.14}},
- {"var a;"
- REPEAT_256(SPACE, " a = 1.414;")
- " a = 3.14;",
- 1 * kPointerSize,
- 1,
- 1032,
- {
- B(StackCheck), //
- REPEAT_256(COMMA, //
- B(LdaConstant), U8(wide_idx++), //
- B(Star), R(0)), //
- B(LdaConstantWide), U16(wide_idx), //
- B(Star), R(0), //
- B(LdaUndefined), //
- B(Return), //
- },
- 257,
- {REPEAT_256(COMMA, 1.414),
- 3.14}}
+ InitializedIgnitionHandleScope scope;
+ BytecodeExpectationsPrinter printer(CcTest::isolate(),
+ ConstantPoolType::kNumber);
+ const char* snippets[] = {
+ "return 1.2;",
+ "var a = 1.2; return 2.6;",
+ "var a = 3.14; return 3.14;",
+ "var a;" REPEAT_256(SPACE, "\na = 1.414;") " a = 3.14;",
};
- // clang-format on
- for (size_t i = 0; i < arraysize(snippets); i++) {
- Handle<BytecodeArray> bytecode_array =
- helper.MakeBytecodeForFunctionBody(snippets[i].code_snippet);
- CheckBytecodeArrayEqual(snippets[i], bytecode_array);
- }
+ CHECK_EQ(BuildActual(printer, snippets),
+ LoadGolden("HeapNumberConstants.golden"));
}
-
TEST(StringConstants) {
- InitializedHandleScope handle_scope;
- BytecodeGeneratorHelper helper;
-
- // clang-format off
- ExpectedSnippet<const char*> snippets[] = {
- {"return \"This is a string\";",
- 0,
- 1,
- 4,
- {
- B(StackCheck), //
- B(LdaConstant), U8(0), //
- B(Return) //
- },
- 1,
- {"This is a string"}},
- {"var a = \"First string\"; return \"Second string\";",
- 1 * kPointerSize,
- 1,
- 8,
- {
- B(StackCheck), //
- B(LdaConstant), U8(0), //
- B(Star), R(0), //
- B(LdaConstant), U8(1), //
- B(Return) //
- },
- 2,
- {"First string", "Second string"}},
- {"var a = \"Same string\"; return \"Same string\";",
- 1 * kPointerSize,
- 1,
- 8,
- {
- B(StackCheck), //
- B(LdaConstant), U8(0), //
- B(Star), R(0), //
- B(LdaConstant), U8(0), //
- B(Return) //
- },
- 1,
- {"Same string"}}
+ InitializedIgnitionHandleScope scope;
+ BytecodeExpectationsPrinter printer(CcTest::isolate(),
+ ConstantPoolType::kString);
+ const char* snippets[] = {
+ "return \"This is a string\";",
+ "var a = \"First string\"; return \"Second string\";",
+ "var a = \"Same string\"; return \"Same string\";",
};
- // clang-format on
- for (size_t i = 0; i < arraysize(snippets); i++) {
- Handle<BytecodeArray> bytecode_array =
- helper.MakeBytecodeForFunctionBody(snippets[i].code_snippet);
- CheckBytecodeArrayEqual(snippets[i], bytecode_array);
- }
+ CHECK_EQ(BuildActual(printer, snippets),
+ LoadGolden("StringConstants.golden"));
}
-
TEST(PropertyLoads) {
- InitializedHandleScope handle_scope;
- BytecodeGeneratorHelper helper;
- Zone zone;
-
- FeedbackVectorSpec feedback_spec(&zone);
- FeedbackVectorSlot slot1 = feedback_spec.AddLoadICSlot();
- FeedbackVectorSlot slot2 = feedback_spec.AddLoadICSlot();
-
- Handle<i::TypeFeedbackVector> vector =
- i::NewTypeFeedbackVector(helper.isolate(), &feedback_spec);
-
- // These are a hack used by the LoadICXXXWide tests below.
- int wide_idx_1 = vector->GetIndex(slot1) - 2;
- int wide_idx_2 = vector->GetIndex(slot1) - 2;
-
- // clang-format off
- ExpectedSnippet<const char*> snippets[] = {
- {"function f(a) { return a.name; }\nf({name : \"test\"})",
- 1 * kPointerSize,
- 2,
- 10,
- {
- B(StackCheck), //
- B(Ldar), A(1, 2), //
- B(Star), R(0), //
- B(LoadIC), R(0), U8(0), U8(vector->GetIndex(slot1)), //
- B(Return), //
- },
- 1,
- {"name"}},
- {"function f(a) { return a[\"key\"]; }\nf({key : \"test\"})",
- 1 * kPointerSize,
- 2,
- 10,
- {
- B(StackCheck), //
- B(Ldar), A(1, 2), //
- B(Star), R(0), //
- B(LoadIC), R(0), U8(0), U8(vector->GetIndex(slot1)), //
- B(Return) //
- },
- 1,
- {"key"}},
- {"function f(a) { return a[100]; }\nf({100 : \"test\"})",
- 1 * kPointerSize,
- 2,
- 11,
- {
- B(StackCheck), //
- B(Ldar), A(1, 2), //
- B(Star), R(0), //
- B(LdaSmi8), U8(100), //
- B(KeyedLoadIC), R(0), U8(vector->GetIndex(slot1)), //
- B(Return) //
- },
- 0},
- {"function f(a, b) { return a[b]; }\nf({arg : \"test\"}, \"arg\")",
- 1 * kPointerSize,
- 3,
- 11,
- {
- B(StackCheck), //
- B(Ldar), A(1, 3), //
- B(Star), R(0), //
- B(Ldar), A(1, 2), //
- B(KeyedLoadIC), R(0), U8(vector->GetIndex(slot1)), //
- B(Return) //
- },
- 0},
- {"function f(a) { var b = a.name; return a[-124]; }\n"
- "f({\"-124\" : \"test\", name : 123 })",
- 2 * kPointerSize,
- 2,
- 21,
- {
- B(StackCheck), //
- B(Ldar), A(1, 2), //
- B(Star), R(1), //
- B(LoadIC), R(1), U8(0), U8(vector->GetIndex(slot1)), //
- B(Star), R(0), //
- B(Ldar), A(1, 2), //
- B(Star), R(1), //
- B(LdaSmi8), U8(-124), //
- B(KeyedLoadIC), R(1), U8(vector->GetIndex(slot2)), //
- B(Return), //
- },
- 1,
- {"name"}},
- {"function f(a) {\n"
- " var b;\n"
- "b = a.name;"
- REPEAT_127(SPACE, " b = a.name; ")
- " return a.name; }\n"
- "f({name : \"test\"})\n",
- 2 * kPointerSize,
- 2,
- 1292,
- {
- B(StackCheck), //
- B(Ldar), A(1, 2), //
- B(Star), R(1), //
- B(LoadIC), R(1), U8(0), U8(wide_idx_1 += 2), //
- B(Star), R(0), //
- REPEAT_127(COMMA, //
- B(Ldar), A(1, 2), //
- B(Star), R(1), //
- B(LoadIC), R(1), U8(0), //
- U8((wide_idx_1 += 2)), //
- B(Star), R(0)), //
- B(Ldar), A(1, 2), //
- B(Star), R(1), //
- B(LoadICWide), R(1), U16(0), U16(wide_idx_1 + 2), //
- B(Return), //
- },
- 1,
- {"name"}},
- {"function f(a, b) {\n"
- " var c;\n"
- " c = a[b];"
- REPEAT_127(SPACE, " c = a[b]; ")
- " return a[b]; }\n"
- "f({name : \"test\"}, \"name\")\n",
- 2 * kPointerSize,
- 3,
- 1420,
- {
- B(StackCheck), //
- B(Ldar), A(1, 3), //
- B(Star), R(1), //
- B(Ldar), A(2, 3), //
- B(KeyedLoadIC), R(1), U8((wide_idx_2 += 2)), //
- B(Star), R(0), //
- REPEAT_127(COMMA, //
- B(Ldar), A(1, 3), //
- B(Star), R(1), //
- B(Ldar), A(2, 3), //
- B(KeyedLoadIC), R(1), U8((wide_idx_2 += 2)), //
- B(Star), R(0)), //
- B(Ldar), A(1, 3), //
- B(Star), R(1), //
- B(Ldar), A(2, 3), //
- B(KeyedLoadICWide), R(1), U16(wide_idx_2 + 2), //
- B(Return), //
- }},
- };
- // clang-format on
-
- for (size_t i = 0; i < arraysize(snippets); i++) {
- Handle<BytecodeArray> bytecode_array =
- helper.MakeBytecode(snippets[i].code_snippet, helper.kFunctionName);
- CheckBytecodeArrayEqual(snippets[i], bytecode_array);
- }
+ InitializedIgnitionHandleScope scope;
+ BytecodeExpectationsPrinter printer(CcTest::isolate(),
+ ConstantPoolType::kString);
+ printer.set_wrap(false);
+ printer.set_test_function_name("f");
+
+ const char* snippets[] = {
+ "function f(a) { return a.name; }\nf({name : \"test\"})",
+ "function f(a) { return a[\"key\"]; }\nf({key : \"test\"})",
+ "function f(a) { return a[100]; }\nf({100 : \"test\"})",
+ "function f(a, b) { return a[b]; }\nf({arg : \"test\"}, \"arg\")",
+ "function f(a) { var b = a.name; return a[-124]; }\n"
+
+ "function f(a) {\n"
+ " var b;\n"
rmcilroy 2016/02/24 08:55:35 What's happened with the indentation (here and in
Stefano Sanfilippo 2016/02/24 14:55:01 No it was me. Fixed.
+ "b = a.name;\n"
+ REPEAT_127(SPACE, "b = a.name;\n")
+ " return a.name; }\n"
+ "f({name : \"test\"})\n",
+
+ "function f(a, b) {\n"
+ " var c;\n"
+ " c = a[b];\n"
+ REPEAT_127(SPACE, "c = a[b];\n")
+ " return a[b]; }\n"
+ "f({name : \"test\"}, \"name\")\n",
+ };
+
+ CHECK_EQ(BuildActual(printer, snippets),
+ LoadGolden("PropertyLoads.golden"));
}
-
TEST(PropertyStores) {
- InitializedHandleScope handle_scope;
- BytecodeGeneratorHelper helper;
- Zone zone;
-
- FeedbackVectorSpec feedback_spec(&zone);
- FeedbackVectorSlot slot1 = feedback_spec.AddStoreICSlot();
- FeedbackVectorSlot slot2 = feedback_spec.AddStoreICSlot();
-
- Handle<i::TypeFeedbackVector> vector =
- i::NewTypeFeedbackVector(helper.isolate(), &feedback_spec);
-
- // These are a hack used by the StoreICXXXWide tests below.
- int wide_idx_1 = vector->GetIndex(slot1) - 2;
- int wide_idx_2 = vector->GetIndex(slot1) - 2;
- int wide_idx_3 = vector->GetIndex(slot1) - 2;
- int wide_idx_4 = vector->GetIndex(slot1) - 2;
-
- // clang-format off
- ExpectedSnippet<const char*> snippets[] = {
- {"function f(a) { a.name = \"val\"; }\nf({name : \"test\"})",
- kPointerSize,
- 2,
- 13,
- {
- B(StackCheck), //
- B(Ldar), A(1, 2), //
- B(Star), R(0), //
- B(LdaConstant), U8(0), //
- B(StoreICSloppy), R(0), U8(1), U8(vector->GetIndex(slot1)), //
- B(LdaUndefined), //
- B(Return), //
- },
- 2,
- {"val", "name"}},
- {"function f(a) { a[\"key\"] = \"val\"; }\nf({key : \"test\"})",
- kPointerSize,
- 2,
- 13,
- {
- B(StackCheck), //
- B(Ldar), A(1, 2), //
- B(Star), R(0), //
- B(LdaConstant), U8(0), //
- B(StoreICSloppy), R(0), U8(1), U8(vector->GetIndex(slot1)), //
- B(LdaUndefined), //
- B(Return), //
- },
- 2,
- {"val", "key"}},
- {"function f(a) { a[100] = \"val\"; }\nf({100 : \"test\"})",
- 2 * kPointerSize,
- 2,
- 17,
- {
- B(StackCheck), //
- B(Ldar), A(1, 2), //
- B(Star), R(0), //
- B(LdaSmi8), U8(100), //
- B(Star), R(1), //
- B(LdaConstant), U8(0), //
- B(KeyedStoreICSloppy), R(0), R(1), //
- U8(vector->GetIndex(slot1)), //
- B(LdaUndefined), //
- B(Return), //
- },
- 1,
- {"val"}},
- {"function f(a, b) { a[b] = \"val\"; }\nf({arg : \"test\"}, \"arg\")",
- 2 * kPointerSize,
- 3,
- 17,
- {
- B(StackCheck), //
- B(Ldar), A(1, 3), //
- B(Star), R(0), //
- B(Ldar), A(2, 3), //
- B(Star), R(1), //
- B(LdaConstant), U8(0), //
- B(KeyedStoreICSloppy), R(0), R(1), //
- U8(vector->GetIndex(slot1)), //
- B(LdaUndefined), //
- B(Return), //
- },
- 1,
- {"val"}},
- {"function f(a) { a.name = a[-124]; }\n"
- "f({\"-124\" : \"test\", name : 123 })",
- 2 * kPointerSize,
- 2,
- 20,
- {
- B(StackCheck), //
- B(Ldar), A(1, 2), //
- B(Star), R(0), //
- B(Ldar), A(1, 2), //
- B(Star), R(1), //
- B(LdaSmi8), U8(-124), //
- B(KeyedLoadIC), R(1), U8(vector->GetIndex(slot1)), //
- B(StoreICSloppy), R(0), U8(0), U8(vector->GetIndex(slot2)), //
- B(LdaUndefined), //
- B(Return), //
- },
- 1,
- {"name"}},
- {"function f(a) { \"use strict\"; a.name = \"val\"; }\n"
- "f({name : \"test\"})",
- kPointerSize,
- 2,
- 13,
- {
- B(StackCheck), //
- B(Ldar), A(1, 2), //
- B(Star), R(0), //
- B(LdaConstant), U8(0), //
- B(StoreICStrict), R(0), U8(1), U8(vector->GetIndex(slot1)), //
- B(LdaUndefined), //
- B(Return), //
- },
- 2,
- {"val", "name"}},
- {"function f(a, b) { \"use strict\"; a[b] = \"val\"; }\n"
- "f({arg : \"test\"}, \"arg\")",
- 2 * kPointerSize,
- 3,
- 17,
- {
- B(StackCheck), //
- B(Ldar), A(1, 3), //
- B(Star), R(0), //
- B(Ldar), A(2, 3), //
- B(Star), R(1), //
- B(LdaConstant), U8(0), //
- B(KeyedStoreICStrict), R(0), R(1), U8(vector->GetIndex(slot1)), //
- B(LdaUndefined), //
- B(Return), //
- },
- 1,
- {"val"}},
- {"function f(a) {\n"
- "a.name = 1;"
- REPEAT_127(SPACE, " a.name = 1; ")
- " a.name = 2; }\n"
- "f({name : \"test\"})\n",
- kPointerSize,
- 2,
- 1295,
- {
- B(StackCheck), //
- B(Ldar), A(1, 2), //
- B(Star), R(0), //
- B(LdaSmi8), U8(1), //
- B(StoreICSloppy), R(0), U8(0), U8((wide_idx_1 += 2)), //
- REPEAT_127(COMMA, //
- B(Ldar), A(1, 2), //
- B(Star), R(0), //
- B(LdaSmi8), U8(1), //
- B(StoreICSloppy), R(0), U8(0), //
- U8((wide_idx_1 += 2))), //
- B(Ldar), A(1, 2), //
- B(Star), R(0), //
- B(LdaSmi8), U8(2), //
- B(StoreICSloppyWide), R(0), U16(0), U16(wide_idx_1 + 2), //
- B(LdaUndefined), //
- B(Return), //
- },
- 1,
- {"name"}},
- {"function f(a) {\n"
- " 'use strict';\n"
- " a.name = 1;"
- REPEAT_127(SPACE, " a.name = 1; ")
- " a.name = 2; }\n"
- "f({name : \"test\"})\n",
- kPointerSize,
- 2,
- 1295,
- {
- B(StackCheck), //
- B(Ldar), A(1, 2), //
- B(Star), R(0), //
- B(LdaSmi8), U8(1), //
- B(StoreICStrict), R(0), U8(0), U8(wide_idx_2 += 2), //
- REPEAT_127(COMMA, //
- B(Ldar), A(1, 2), //
- B(Star), R(0), //
- B(LdaSmi8), U8(1), //
- B(StoreICStrict), R(0), U8(0), //
- U8((wide_idx_2 += 2))), //
- B(Ldar), A(1, 2), //
- B(Star), R(0), //
- B(LdaSmi8), U8(2), //
- B(StoreICStrictWide), R(0), U16(0), U16(wide_idx_2 + 2), //
- B(LdaUndefined), //
- B(Return), //
- },
- 1,
- {"name"}},
- {"function f(a, b) {\n"
- " a[b] = 1;"
- REPEAT_127(SPACE, " a[b] = 1; ")
- " a[b] = 2; }\n"
- "f({name : \"test\"})\n",
- 2 * kPointerSize,
- 3,
- 1810,
- {
- B(StackCheck), //
- B(Ldar), A(1, 3), //
- B(Star), R(0), //
- B(Ldar), A(2, 3), //
- B(Star), R(1), //
- B(LdaSmi8), U8(1), //
- B(KeyedStoreICSloppy), R(0), R(1), U8(wide_idx_3 += 2), //
- REPEAT_127(COMMA, //
- B(Ldar), A(1, 3), //
- B(Star), R(0), //
- B(Ldar), A(2, 3), //
- B(Star), R(1), //
- B(LdaSmi8), U8(1), //
- B(KeyedStoreICSloppy), R(0), R(1), //
- U8((wide_idx_3 += 2))), //
- B(Ldar), A(1, 3), //
- B(Star), R(0), //
- B(Ldar), A(2, 3), //
- B(Star), R(1), //
- B(LdaSmi8), U8(2), //
- B(KeyedStoreICSloppyWide), R(0), R(1), U16(wide_idx_3 + 2), //
- B(LdaUndefined), //
- B(Return), //
- }},
- {"function f(a, b) {\n"
- " 'use strict';\n"
- " a[b] = 1;"
- REPEAT_127(SPACE, " a[b] = 1; ")
- " a[b] = 2; }\n"
- "f({name : \"test\"})\n",
- 2 * kPointerSize,
- 3,
- 1810,
- {
- B(StackCheck), //
- B(Ldar), A(1, 3), //
- B(Star), R(0), //
- B(Ldar), A(2, 3), //
- B(Star), R(1), //
- B(LdaSmi8), U8(1), //
- B(KeyedStoreICStrict), R(0), R(1), U8(wide_idx_4 += 2), //
- REPEAT_127(COMMA, //
- B(Ldar), A(1, 3), //
- B(Star), R(0), //
- B(Ldar), A(2, 3), //
- B(Star), R(1), //
- B(LdaSmi8), U8(1), //
- B(KeyedStoreICStrict), R(0), R(1), //
- U8((wide_idx_4 += 2))), //
- B(Ldar), A(1, 3), //
- B(Star), R(0), //
- B(Ldar), A(2, 3), //
- B(Star), R(1), //
- B(LdaSmi8), U8(2), //
- B(KeyedStoreICStrictWide), R(0), R(1), U16(wide_idx_4 + 2), //
- B(LdaUndefined), //
- B(Return), //
- }}
- };
- // clang-format on
-
- for (size_t i = 0; i < arraysize(snippets); i++) {
- Handle<BytecodeArray> bytecode_array =
- helper.MakeBytecode(snippets[i].code_snippet, helper.kFunctionName);
- CheckBytecodeArrayEqual(snippets[i], bytecode_array);
- }
+ InitializedIgnitionHandleScope scope;
+ BytecodeExpectationsPrinter printer(CcTest::isolate(),
+ ConstantPoolType::kString);
+ printer.set_wrap(false);
+ printer.set_test_function_name("f");
+
+ const char* snippets[] = {
+ "function f(a) { a.name = \"val\"; }\nf({name : \"test\"})",
+ "function f(a) { a[\"key\"] = \"val\"; }\nf({key : \"test\"})",
+ "function f(a) { a[100] = \"val\"; }\nf({100 : \"test\"})",
+ "function f(a, b) { a[b] = \"val\"; }\nf({arg : \"test\"}, \"arg\")",
+
+ "function f(a) { a.name = a[-124]; }\n"
+ "f({\"-124\" : \"test\", name : 123 })",
+
+ "function f(a) { \"use strict\"; a.name = \"val\"; }\n"
+ "f({name : \"test\"})",
+
+ "function f(a, b) { \"use strict\"; a[b] = \"val\"; }\n"
+ "f({arg : \"test\"}, \"arg\")",
+
+ "function f(a) {\n"
+ "a.name = 1;\n"
+ REPEAT_127(SPACE, "a.name = 1;\n")
+ " a.name = 2; }\n"
+ "f({name : \"test\"})\n",
+
+ "function f(a) {\n"
+ " 'use strict';\n"
+ " a.name = 1;\n"
+ REPEAT_127(SPACE, "a.name = 1;\n")
+ " a.name = 2; }\n"
+ "f({name : \"test\"})\n",
+
+ "function f(a, b) {\n"
+ " a[b] = 1;"
+ REPEAT_127(SPACE, " a[b] = 1;\n")
+ " a[b] = 2; }\n"
+ "f({name : \"test\"})\n",
+
+ "function f(a, b) {\n"
+ " 'use strict';\n"
+ " a[b] = 1;"
+ REPEAT_127(SPACE, " a[b] = 1;\n")
+ " a[b] = 2; }\n"
+ "f({name : \"test\"})\n",
+ };
+
+ CHECK_EQ(BuildActual(printer, snippets),
+ LoadGolden("PropertyStores.golden"));
}
-
#define FUNC_ARG "new (function Obj() { this.func = function() { return; }})()"
-
TEST(PropertyCall) {
- InitializedHandleScope handle_scope;
- BytecodeGeneratorHelper helper;
- Zone zone;
-
- FeedbackVectorSpec feedback_spec(&zone);
- FeedbackVectorSlot slot1 = feedback_spec.AddCallICSlot();
- FeedbackVectorSlot slot2 = feedback_spec.AddLoadICSlot();
-
- Handle<i::TypeFeedbackVector> vector =
- i::NewTypeFeedbackVector(helper.isolate(), &feedback_spec);
-
- // These are a hack used by the CallWide test below.
- int wide_idx = vector->GetIndex(slot1) - 2;
-
- // clang-format off
- ExpectedSnippet<const char*> snippets[] = {
- {"function f(a) { return a.func(); }\nf(" FUNC_ARG ")",
- 2 * kPointerSize,
- 2,
- 17,
- {
- B(StackCheck), //
- B(Ldar), A(1, 2), //
- B(Star), R(1), //
- B(LoadIC), R(1), U8(0), U8(vector->GetIndex(slot2)), //
- B(Star), R(0), //
- B(Call), R(0), R(1), U8(1), U8(vector->GetIndex(slot1)), //
- B(Return), //
- },
- 1,
- {"func"}},
- {"function f(a, b, c) { return a.func(b, c); }\nf(" FUNC_ARG ", 1, 2)",
- 4 * kPointerSize,
- 4,
- 25,
- {
- B(StackCheck), //
- B(Ldar), A(1, 4), //
- B(Star), R(1), //
- B(LoadIC), R(1), U8(0), U8(vector->GetIndex(slot2)), //
- B(Star), R(0), //
- B(Ldar), A(2, 4), //
- B(Star), R(2), //
- B(Ldar), A(3, 4), //
- B(Star), R(3), //
- B(Call), R(0), R(1), U8(3), U8(vector->GetIndex(slot1)), //
- B(Return) //
- },
- 1,
- {"func"}},
- {"function f(a, b) { return a.func(b + b, b); }\nf(" FUNC_ARG ", 1)",
- 4 * kPointerSize,
- 3,
- 31,
- {
- B(StackCheck), //
- B(Ldar), A(1, 3), //
- B(Star), R(1), //
- B(LoadIC), R(1), U8(0), U8(vector->GetIndex(slot2)), //
- B(Star), R(0), //
- B(Ldar), A(2, 3), //
- B(Star), R(3), //
- B(Ldar), A(2, 3), //
- B(Add), R(3), //
- B(Star), R(2), //
- B(Ldar), A(2, 3), //
- B(Star), R(3), //
- B(Call), R(0), R(1), U8(3), U8(vector->GetIndex(slot1)), //
- B(Return), //
- },
- 1,
- {"func"}},
- {"function f(a) {\n"
- " a.func;\n" REPEAT_127(
- SPACE, " a.func;\n") " return a.func(); }\nf(" FUNC_ARG ")",
- 2 * kPointerSize,
- 2,
- 1047,
- {
- B(StackCheck), //
- B(Ldar), A(1, 2), //
- B(Star), R(0), //
- B(LoadIC), R(0), U8(0), U8(wide_idx += 2), //
- REPEAT_127(COMMA, //
- B(Ldar), A(1, 2), //
- B(Star), R(0), //
- B(LoadIC), R(0), U8(0), U8((wide_idx += 2))), //
- B(Ldar), A(1, 2), //
- B(Star), R(1), //
- B(LoadICWide), R(1), U16(0), U16(wide_idx + 4), //
- B(Star), R(0), //
- B(CallWide), R16(0), R16(1), U16(1), U16(wide_idx + 2), //
- B(Return), //
- },
- 1,
- {"func"}},
- };
- // clang-format on
-
- for (size_t i = 0; i < arraysize(snippets); i++) {
- Handle<BytecodeArray> bytecode_array =
- helper.MakeBytecode(snippets[i].code_snippet, helper.kFunctionName);
- CheckBytecodeArrayEqual(snippets[i], bytecode_array);
- }
-}
+ InitializedIgnitionHandleScope scope;
+ BytecodeExpectationsPrinter printer(CcTest::isolate(),
+ ConstantPoolType::kString);
+ printer.set_wrap(false);
+ printer.set_test_function_name("f");
+ const char* snippets[] = {
+ "function f(a) { return a.func(); }\nf(" FUNC_ARG ")",
+ "function f(a, b, c) { return a.func(b, c); }\nf(" FUNC_ARG ", 1, 2)",
+ "function f(a, b) { return a.func(b + b, b); }\nf(" FUNC_ARG ", 1)",
-TEST(LoadGlobal) {
- InitializedHandleScope handle_scope;
- BytecodeGeneratorHelper helper;
- Zone zone;
-
- FeedbackVectorSpec feedback_spec(&zone);
- FeedbackVectorSlot slot = feedback_spec.AddLoadICSlot();
-
- Handle<i::TypeFeedbackVector> vector =
- i::NewTypeFeedbackVector(helper.isolate(), &feedback_spec);
-
- // These are a hack used by the LdaGlobalXXXWide tests below.
- int wide_idx_1 = vector->GetIndex(slot) - 2;
-
- // clang-format off
- ExpectedSnippet<const char*> snippets[] = {
- {"var a = 1;\nfunction f() { return a; }\nf()",
- 0,
- 1,
- 5,
- {
- B(StackCheck), //
- B(LdaGlobal), U8(0), U8(vector->GetIndex(slot)), //
- B(Return) //
- },
- 1,
- {"a"}},
- {"function t() { }\nfunction f() { return t; }\nf()",
- 0,
- 1,
- 5,
- {
- B(StackCheck), //
- B(LdaGlobal), U8(0), U8(vector->GetIndex(slot)), //
- B(Return) //
- },
- 1,
- {"t"}},
- {"a = 1;\nfunction f() { return a; }\nf()",
- 0,
- 1,
- 5,
- {
- B(StackCheck), //
- B(LdaGlobal), U8(0), U8(vector->GetIndex(slot)), //
- B(Return) //
- },
- 1,
- {"a"}},
- {"a = 1;"
- "function f(b) {\n"
- " b.name;\n"
- REPEAT_127(SPACE, "b.name; ")
- " return a;"
- "}\nf({name: 1});",
- kPointerSize,
- 2,
- 1031,
- {
- B(StackCheck), //
- B(Ldar), A(1, 2), //
- B(Star), R(0), //
- B(LoadIC), R(0), U8(0), U8(wide_idx_1 += 2), //
- REPEAT_127(COMMA, //
- B(Ldar), A(1, 2), //
- B(Star), R(0), //
- B(LoadIC), R(0), U8(0), U8(wide_idx_1 += 2)), //
- B(LdaGlobalWide), U16(1), U16(wide_idx_1 + 2), //
- B(Return), //
- },
- 2,
- {"name", "a"}},
+ "function f(a) {\n"
+ " a.func;\n" REPEAT_127(SPACE, " a.func;\n")
+ " return a.func(); }\nf(" FUNC_ARG ")",
};
- // clang-format on
- for (size_t i = 0; i < arraysize(snippets); i++) {
- Handle<BytecodeArray> bytecode_array =
- helper.MakeBytecode(snippets[i].code_snippet, "f");
- CheckBytecodeArrayEqual(snippets[i], bytecode_array);
- }
+ CHECK_EQ(BuildActual(printer, snippets),
+ LoadGolden("PropertyCall.golden"));
}
+TEST(LoadGlobal) {
+ InitializedIgnitionHandleScope scope;
+ BytecodeExpectationsPrinter printer(CcTest::isolate(),
+ ConstantPoolType::kString);
+ printer.set_wrap(false);
+ printer.set_test_function_name("f");
-TEST(StoreGlobal) {
- InitializedHandleScope handle_scope;
- BytecodeGeneratorHelper helper;
- Zone zone;
-
- FeedbackVectorSpec feedback_spec(&zone);
- FeedbackVectorSlot slot = feedback_spec.AddStoreICSlot();
-
- Handle<i::TypeFeedbackVector> vector =
- i::NewTypeFeedbackVector(helper.isolate(), &feedback_spec);
-
- // These are a hack used by the StaGlobalXXXWide tests below.
- int wide_idx_1 = vector->GetIndex(slot) - 2;
- int wide_idx_2 = vector->GetIndex(slot) - 2;
-
- // clang-format off
- ExpectedSnippet<const char*> snippets[] = {
- {"var a = 1;\nfunction f() { a = 2; }\nf()",
- 0,
- 1,
- 8,
- {
- B(StackCheck), //
- B(LdaSmi8), U8(2), //
- B(StaGlobalSloppy), U8(0), U8(vector->GetIndex(slot)), //
- B(LdaUndefined), //
- B(Return) //
- },
- 1,
- {"a"}},
- {"var a = \"test\"; function f(b) { a = b; }\nf(\"global\")",
- 0,
- 2,
- 8,
- {
- B(StackCheck), //
- B(Ldar), R(helper.kLastParamIndex), //
- B(StaGlobalSloppy), U8(0), U8(vector->GetIndex(slot)), //
- B(LdaUndefined), //
- B(Return) //
- },
- 1,
- {"a"}},
- {"'use strict'; var a = 1;\nfunction f() { a = 2; }\nf()",
- 0,
- 1,
- 8,
- {
- B(StackCheck), //
- B(LdaSmi8), U8(2), //
- B(StaGlobalStrict), U8(0), U8(vector->GetIndex(slot)), //
- B(LdaUndefined), //
- B(Return) //
- },
- 1,
- {"a"}},
- {"a = 1;\nfunction f() { a = 2; }\nf()",
- 0,
- 1,
- 8,
- {
- B(StackCheck), //
- B(LdaSmi8), U8(2), //
- B(StaGlobalSloppy), U8(0), U8(vector->GetIndex(slot)), //
- B(LdaUndefined), //
- B(Return) //
- },
- 1,
- {"a"}},
- {"a = 1;"
- "function f(b) {"
- " b.name;\n"
- REPEAT_127(SPACE, "b.name; ")
- " a = 2; }\n"
- "f({name: 1});",
- kPointerSize,
- 2,
- 1034,
- {
- B(StackCheck), //
- B(Ldar), A(1, 2), //
- B(Star), R(0), //
- B(LoadIC), R(0), U8(0), U8(wide_idx_1 += 2), //
- REPEAT_127(COMMA, //
- B(Ldar), A(1, 2), //
- B(Star), R(0), //
- B(LoadIC), R(0), U8(0), U8(wide_idx_1 += 2)), //
- B(LdaSmi8), U8(2), //
- B(StaGlobalSloppyWide), U16(1), U16(wide_idx_1 + 2), //
- B(LdaUndefined), //
- B(Return), //
- },
- 2,
- {"name", "a"}},
- {"a = 1;"
- "function f(b) {\n"
- " 'use strict';\n"
- " b.name;\n"
- REPEAT_127(SPACE, "b.name; ")
- " a = 2; }\n"
- "f({name: 1});",
- kPointerSize,
- 2,
- 1034,
- {
- B(StackCheck), //
- B(Ldar), A(1, 2), //
- B(Star), R(0), //
- B(LoadIC), R(0), U8(0), U8(wide_idx_2 += 2), //
- REPEAT_127(COMMA, //
- B(Ldar), A(1, 2), //
- B(Star), R(0), //
- B(LoadIC), R(0), U8(0), U8(wide_idx_2 += 2)), //
- B(LdaSmi8), U8(2), //
- B(StaGlobalStrictWide), U16(1), U16(wide_idx_2 + 2), //
- B(LdaUndefined), //
- B(Return), //
- },
- 2,
- {"name", "a"}},
+ const char* snippets[] = {
+ "var a = 1;\nfunction f() { return a; }\nf()",
+ "function t() { }\nfunction f() { return t; }\nf()",
+ "a = 1;\nfunction f() { return a; }\nf()",
+ "a = 1;\n"
+ "function f(b) {\n"
+ " b.name;\n"
+ REPEAT_127(SPACE, "b.name;\n")
+ " return a;\n"
+ "}\nf({name: 1});",
};
- // clang-format on
- for (size_t i = 0; i < arraysize(snippets); i++) {
- Handle<BytecodeArray> bytecode_array =
- helper.MakeBytecode(snippets[i].code_snippet, "f");
- CheckBytecodeArrayEqual(snippets[i], bytecode_array);
- }
+ CHECK_EQ(BuildActual(printer, snippets),
+ LoadGolden("LoadGlobal.golden"));
}
+TEST(StoreGlobal) {
+ InitializedIgnitionHandleScope scope;
+ BytecodeExpectationsPrinter printer(CcTest::isolate(),
+ ConstantPoolType::kString);
+ printer.set_wrap(false);
+ printer.set_test_function_name("f");
+
+ const char* snippets[] = {
+ "var a = 1;\nfunction f() { a = 2; }\nf()",
+ "var a = \"test\"; function f(b) { a = b; }\nf(\"global\")",
+ "'use strict'; var a = 1;\nfunction f() { a = 2; }\nf()",
+ "a = 1;\nfunction f() { a = 2; }\nf()",
+
+ "a = 1;"
+ "function f(b) {\n"
+ " b.name;\n"
+ REPEAT_127(SPACE, "b.name;\n")
+ " a = 2; }\n"
+ "f({name: 1});",
+
+ "a = 1;"
+ "function f(b) {\n"
+ " 'use strict';\n"
+ " b.name;\n"
+ REPEAT_127(SPACE, "b.name;\n")
+ " a = 2; }\n"
+ "f({name: 1});",
+ };
+
+ CHECK_EQ(BuildActual(printer, snippets),
+ LoadGolden("StoreGlobal.golden"));
+}
TEST(CallGlobal) {
- InitializedHandleScope handle_scope;
- BytecodeGeneratorHelper helper;
- Zone zone;
-
- FeedbackVectorSpec feedback_spec(&zone);
- FeedbackVectorSlot slot1 = feedback_spec.AddCallICSlot();
- FeedbackVectorSlot slot2 = feedback_spec.AddLoadICSlot();
-
- Handle<i::TypeFeedbackVector> vector =
- i::NewTypeFeedbackVector(helper.isolate(), &feedback_spec);
-
- // clang-format off
- ExpectedSnippet<const char*> snippets[] = {
- {"function t() { }\nfunction f() { return t(); }\nf()",
- 2 * kPointerSize,
- 1,
- 15,
- {
- B(StackCheck), //
- B(LdaUndefined), //
- B(Star), R(1), //
- B(LdaGlobal), U8(0), U8(vector->GetIndex(slot2)), //
- B(Star), R(0), //
- B(Call), R(0), R(1), U8(1), U8(vector->GetIndex(slot1)), //
- B(Return) //
- },
- 1,
- {"t"}},
- {"function t(a, b, c) { }\nfunction f() { return t(1, 2, 3); }\nf()",
- 5 * kPointerSize,
- 1,
- 27,
- {
- B(StackCheck), //
- B(LdaUndefined), //
- B(Star), R(1), //
- B(LdaGlobal), U8(0), U8(vector->GetIndex(slot2)), //
- B(Star), R(0), //
- B(LdaSmi8), U8(1), //
- B(Star), R(2), //
- B(LdaSmi8), U8(2), //
- B(Star), R(3), //
- B(LdaSmi8), U8(3), //
- B(Star), R(4), //
- B(Call), R(0), R(1), U8(4), U8(vector->GetIndex(slot1)), //
- B(Return) //
- },
- 1,
- {"t"}},
+ InitializedIgnitionHandleScope scope;
+ BytecodeExpectationsPrinter printer(CcTest::isolate(),
+ ConstantPoolType::kString);
+ printer.set_wrap(false);
+ printer.set_test_function_name("f");
+
+ const char* snippets[] = {
+ "function t() { }\nfunction f() { return t(); }\nf()",
+ "function t(a, b, c) { }\nfunction f() { return t(1, 2, 3); }\nf()",
};
- // clang-format on
- size_t num_snippets = sizeof(snippets) / sizeof(snippets[0]);
- for (size_t i = 0; i < num_snippets; i++) {
- Handle<BytecodeArray> bytecode_array =
- helper.MakeBytecode(snippets[i].code_snippet, "f");
- CheckBytecodeArrayEqual(snippets[i], bytecode_array);
- }
+ CHECK_EQ(BuildActual(printer, snippets),
+ LoadGolden("CallGlobal.golden"));
}
-
TEST(CallRuntime) {
- InitializedHandleScope handle_scope;
- BytecodeGeneratorHelper helper;
-
- // clang-format off
- ExpectedSnippet<InstanceType> snippets[] = {
- {
- "function f() { %TheHole() }\nf()",
- 0,
- 1,
- 8,
- {
- B(StackCheck), //
- B(CallRuntime), U16(Runtime::kTheHole), R(0), U8(0), //
- B(LdaUndefined), //
- B(Return) //
- },
- },
- {
- "function f(a) { return %IsArray(a) }\nf(undefined)",
- 1 * kPointerSize,
- 2,
- 11,
- {
- B(StackCheck), //
- B(Ldar), A(1, 2), //
- B(Star), R(0), //
- B(CallRuntime), U16(Runtime::kIsArray), R(0), U8(1), //
- B(Return) //
- },
- },
- {
- "function f() { return %Add(1, 2) }\nf()",
- 2 * kPointerSize,
- 1,
- 15,
- {
- B(StackCheck), //
- B(LdaSmi8), U8(1), //
- B(Star), R(0), //
- B(LdaSmi8), U8(2), //
- B(Star), R(1), //
- B(CallRuntime), U16(Runtime::kAdd), R(0), U8(2), //
- B(Return) //
- },
- },
- {
- "function f() { return %spread_iterable([1]) }\nf()",
- 2 * kPointerSize,
- 1,
- 16,
- {
- B(StackCheck), //
- B(LdaUndefined), //
- B(Star), R(0), //
- B(CreateArrayLiteral), U8(0), U8(0), U8(3), //
- B(Star), R(1), //
- B(CallJSRuntime), U16(Context::SPREAD_ITERABLE_INDEX), R(0), //
- /* */ U8(2), //
- B(Return), //
- },
- 1,
- {InstanceType::FIXED_ARRAY_TYPE},
- },
+ InitializedIgnitionHandleScope scope;
+ BytecodeExpectationsPrinter printer(CcTest::isolate(),
+ ConstantPoolType::kMixed);
+ printer.set_wrap(false);
+ printer.set_test_function_name("f");
+
+ const char* snippets[] = {
+ "function f() { %TheHole() }\nf()",
+ "function f(a) { return %IsArray(a) }\nf(undefined)",
+ "function f() { return %Add(1, 2) }\nf()",
+ "function f() { return %spread_iterable([1]) }\nf()",
};
- // clang-format on
- for (size_t i = 0; i < arraysize(snippets); i++) {
- Handle<BytecodeArray> bytecode_array =
- helper.MakeBytecode(snippets[i].code_snippet, "f");
- CheckBytecodeArrayEqual(snippets[i], bytecode_array);
- }
+ CHECK_EQ(BuildActual(printer, snippets),
+ LoadGolden("CallRuntime.golden"));
}
-
TEST(IfConditions) {
- InitializedHandleScope handle_scope;
- BytecodeGeneratorHelper helper;
-
- Handle<Object> unused = helper.factory()->undefined_value();
-
- // clang-format off
- ExpectedSnippet<Handle<Object>> snippets[] = {
- {"function f() { if (0) { return 1; } else { return -1; } } f()",
- 0,
- 1,
- 4,
- {
- B(StackCheck), //
- B(LdaSmi8), U8(-1), //
- B(Return), //
- },
- 0,
- {unused, unused, unused, unused, unused, unused}},
- {"function f() { if ('lucky') { return 1; } else { return -1; } } f();",
- 0,
- 1,
- 4,
- {
- B(StackCheck), //
- B(LdaSmi8), U8(1), //
- B(Return), //
- },
- 0,
- {unused, unused, unused, unused, unused, unused}},
- {"function f() { if (false) { return 1; } else { return -1; } } f();",
- 0,
- 1,
- 4,
- {
- B(StackCheck), //
- B(LdaSmi8), U8(-1), //
- B(Return), //
- },
- 0,
- {unused, unused, unused, unused, unused, unused}},
- {"function f() { if (false) { return 1; } } f();",
- 0,
- 1,
- 3,
- {
- B(StackCheck), //
- B(LdaUndefined), //
- B(Return), //
- },
- 0,
- {unused, unused, unused, unused, unused, unused}},
- {"function f() { var a = 1; if (a) { a += 1; } else { return 2; } } f();",
- 2 * kPointerSize,
- 1,
- 24,
- {
- B(StackCheck), //
- B(LdaSmi8), U8(1), //
- B(Star), R(0), //
- B(JumpIfToBooleanFalse), U8(14), //
- B(Ldar), R(0), //
- B(Star), R(1), //
- B(LdaSmi8), U8(1), //
- B(Add), R(1), //
- B(Star), R(0), //
- B(Jump), U8(5), //
- B(LdaSmi8), U8(2), //
- B(Return), //
- B(LdaUndefined), //
- B(Return), //
- },
- 0,
- {unused, unused, unused, unused, unused, unused}},
- {"function f(a) { if (a <= 0) { return 200; } else { return -200; } }"
- "f(99);",
- kPointerSize,
- 2,
- 18,
- {
- B(StackCheck), //
- B(Ldar), A(1, 2), //
- B(Star), R(0), //
- B(LdaZero), //
- B(TestLessThanOrEqual), R(0), //
- B(JumpIfFalse), U8(5), //
- B(LdaConstant), U8(0), //
- B(Return), //
- B(LdaConstant), U8(1), //
- B(Return), //
- B(LdaUndefined), //
- B(Return), //
- },
- 2,
- {helper.factory()->NewNumberFromInt(200),
- helper.factory()->NewNumberFromInt(-200), unused, unused, unused,
- unused}},
- {"function f(a, b) { if (a in b) { return 200; } }"
- "f('prop', { prop: 'yes'});",
- kPointerSize,
- 3,
- 16,
- {
- B(StackCheck), //
- B(Ldar), A(1, 3), //
- B(Star), R(0), //
- B(Ldar), A(2, 3), //
- B(TestIn), R(0), //
- B(JumpIfFalse), U8(5), //
- B(LdaConstant), U8(0), //
- B(Return), //
- B(LdaUndefined), //
- B(Return), //
- },
- 1,
- {helper.factory()->NewNumberFromInt(200), unused, unused, unused, unused,
- unused}},
- {"function f(z) { var a = 0; var b = 0; if (a === 0.01) { "
- REPEAT_64(SPACE, "b = a; a = b; ")
- " return 200; } else { return -200; } } f(0.001)",
- 3 * kPointerSize,
- 2,
- 283,
- {
- B(StackCheck), //
- B(LdaZero), //
- B(Star), R(0), //
- B(LdaZero), //
- B(Star), R(1), //
- B(Ldar), R(0), //
- B(Star), R(2), //
- B(LdaConstant), U8(0), //
- B(TestEqualStrict), R(2), //
- B(JumpIfFalseConstant), U8(2), //
- B(Ldar), R(0), //
- REPEAT_64(COMMA, //
- B(Star), R(1), //
- B(Star), R(0)), //
- B(LdaConstant), U8(1), //
- B(Return), //
- B(LdaConstant), U8(3), //
- B(Return), //
- B(LdaUndefined), //
- B(Return)}, //
- 4,
- {helper.factory()->NewHeapNumber(0.01),
- helper.factory()->NewNumberFromInt(200),
- helper.factory()->NewNumberFromInt(263),
- helper.factory()->NewNumberFromInt(-200), unused, unused}},
- {"function f() { var a = 0; var b = 0; if (a) { "
- REPEAT_64(SPACE, "b = a; a = b; ")
- " return 200; } else { return -200; } } f()",
- 2 * kPointerSize,
- 1,
- 277,
- {
- B(StackCheck), //
- B(LdaZero), //
- B(Star), R(0), //
- B(LdaZero), //
- B(Star), R(1), //
- B(Ldar), R(0), //
- B(JumpIfToBooleanFalseConstant), U8(1), //
- B(Ldar), R(0), //
- REPEAT_64(COMMA, //
- B(Star), R(1), //
- B(Star), R(0)), //
- B(LdaConstant), U8(0), //
- B(Return), //
- B(LdaConstant), U8(2), //
- B(Return), //
- B(LdaUndefined), //
- B(Return)}, //
- 3,
- {helper.factory()->NewNumberFromInt(200),
- helper.factory()->NewNumberFromInt(263),
- helper.factory()->NewNumberFromInt(-200), unused, unused, unused}},
-
- {"function f(a, b) {\n"
- " if (a == b) { return 1; }\n"
- " if (a === b) { return 1; }\n"
- " if (a < b) { return 1; }\n"
- " if (a > b) { return 1; }\n"
- " if (a <= b) { return 1; }\n"
- " if (a >= b) { return 1; }\n"
- " if (a in b) { return 1; }\n"
- " if (a instanceof b) { return 1; }\n"
- " return 0;\n"
- "} f(1, 1);",
- kPointerSize,
- 3,
- 107,
- {
-#define IF_CONDITION_RETURN(condition) \
- B(Ldar), A(1, 3), \
- B(Star), R(0), \
- B(Ldar), A(2, 3), \
- B(condition), R(0), \
- B(JumpIfFalse), U8(5), \
- B(LdaSmi8), U8(1), \
- B(Return),
- B(StackCheck), //
- IF_CONDITION_RETURN(TestEqual) //
- IF_CONDITION_RETURN(TestEqualStrict) //
- IF_CONDITION_RETURN(TestLessThan) //
- IF_CONDITION_RETURN(TestGreaterThan) //
- IF_CONDITION_RETURN(TestLessThanOrEqual) //
- IF_CONDITION_RETURN(TestGreaterThanOrEqual) //
- IF_CONDITION_RETURN(TestIn) //
- IF_CONDITION_RETURN(TestInstanceOf) //
- B(LdaZero), //
- B(Return)}, //
-#undef IF_CONDITION_RETURN
- 0,
- {unused, unused, unused, unused, unused, unused}},
- {"function f() {"
- " var a = 0;"
- " if (a) {"
- " return 20;"
- "} else {"
- " return -20;}"
- "};"
- "f();",
- 1 * kPointerSize,
- 1,
- 14,
- {
- B(StackCheck), //
- B(LdaZero), //
- B(Star), R(0), //
- B(JumpIfToBooleanFalse), U8(5), //
- B(LdaSmi8), U8(20), //
- B(Return), //
- B(LdaSmi8), U8(-20), //
- B(Return), //
- B(LdaUndefined), //
- B(Return)
- },
- 0,
- {unused, unused, unused, unused, unused, unused}}
- };
- // clang-format on
-
- for (size_t i = 0; i < arraysize(snippets); i++) {
- Handle<BytecodeArray> bytecode_array =
- helper.MakeBytecode(snippets[i].code_snippet, helper.kFunctionName);
- CheckBytecodeArrayEqual(snippets[i], bytecode_array);
- }
+ InitializedIgnitionHandleScope scope;
+ BytecodeExpectationsPrinter printer(CcTest::isolate(),
+ ConstantPoolType::kNumber);
+ printer.set_wrap(false);
+ printer.set_test_function_name("f");
+
+ const char* snippets[] = {
+ "function f() { if (0) { return 1; } else { return -1; } } f()",
+ "function f() { if ('lucky') { return 1; } else { return -1; } } f();",
+ "function f() { if (false) { return 1; } else { return -1; } } f();",
+ "function f() { if (false) { return 1; } } f();",
+ "function f() { var a = 1; if (a) { a += 1; } else { return 2; } } f();",
+ "function f(a) { if (a <= 0) { return 200; } else { return -200; } }"
+ "f(99);",
+
+ "function f(a, b) { if (a in b) { return 200; } }"
+ "f('prop', { prop: 'yes'});",
+ "function f(z) { var a = 0; var b = 0; if (a === 0.01) {\n"
+ REPEAT_64(SPACE, "b = a; a = b;\n")
+ " return 200; } else { return -200; } } f(0.001)",
+
+ "function f() { var a = 0; var b = 0; if (a) { "
+ REPEAT_64(SPACE, "b = a; a = b;\n")
+ " return 200; } else { return -200; } } f()",
+
+ "function f(a, b) {\n"
+ " if (a == b) { return 1; }\n"
+ " if (a === b) { return 1; }\n"
+ " if (a < b) { return 1; }\n"
+ " if (a > b) { return 1; }\n"
+ " if (a <= b) { return 1; }\n"
+ " if (a >= b) { return 1; }\n"
+ " if (a in b) { return 1; }\n"
+ " if (a instanceof b) { return 1; }\n"
+ " return 0;\n"
+ "} f(1, 1);",
+
+ "function f() {\n"
+ " var a = 0;\n"
+ " if (a) {\n"
+ " return 20;\n"
+ "} else {\n"
+ " return -20;}\n"
+ "};\n"
+ "f();",
+ };
+
+ CHECK_EQ(BuildActual(printer, snippets),
+ LoadGolden("IfConditions.golden"));
}
-
TEST(DeclareGlobals) {
- InitializedHandleScope handle_scope;
- BytecodeGeneratorHelper helper;
- Zone zone;
-
- // Create different feedback vector specs to be precise on slot numbering.
- FeedbackVectorSpec feedback_spec_stores(&zone);
- FeedbackVectorSlot store_slot_1 = feedback_spec_stores.AddStoreICSlot();
- FeedbackVectorSlot store_slot_2 = feedback_spec_stores.AddStoreICSlot();
- USE(store_slot_1);
-
- Handle<i::TypeFeedbackVector> store_vector =
- i::NewTypeFeedbackVector(helper.isolate(), &feedback_spec_stores);
-
- FeedbackVectorSpec feedback_spec_loads(&zone);
- FeedbackVectorSlot load_slot_1 = feedback_spec_loads.AddLoadICSlot();
- FeedbackVectorSlot call_slot_1 = feedback_spec_loads.AddCallICSlot();
-
- Handle<i::TypeFeedbackVector> load_vector =
- i::NewTypeFeedbackVector(helper.isolate(), &feedback_spec_loads);
-
- // clang-format off
- ExpectedSnippet<InstanceType> snippets[] = {
- {"var a = 1;",
- 4 * kPointerSize,
- 1,
- 31,
- {
- B(LdaConstant), U8(0), //
- B(Star), R(1), //
- B(LdaZero), //
- B(Star), R(2), //
- B(CallRuntime), U16(Runtime::kDeclareGlobals), R(1), U8(2), //
- B(StackCheck), //
- B(LdaConstant), U8(1), //
- B(Star), R(1), //
- B(LdaZero), //
- B(Star), R(2), //
- B(LdaSmi8), U8(1), //
- B(Star), R(3), //
- B(CallRuntime), U16(Runtime::kInitializeVarGlobal), R(1), U8(3), //
- B(LdaUndefined), //
- B(Return) //
- },
- 2,
- {InstanceType::FIXED_ARRAY_TYPE,
- InstanceType::ONE_BYTE_INTERNALIZED_STRING_TYPE}},
- {"function f() {}",
- 2 * kPointerSize,
- 1,
- 15,
- {
- B(LdaConstant), U8(0), //
- B(Star), R(0), //
- B(LdaZero), //
- B(Star), R(1), //
- B(CallRuntime), U16(Runtime::kDeclareGlobals), R(0), U8(2), //
- B(StackCheck), //
- B(LdaUndefined), //
- B(Return) //
- },
- 1,
- {InstanceType::FIXED_ARRAY_TYPE}},
- {"var a = 1;\na=2;",
- 4 * kPointerSize,
- 1,
- 37,
- {
- B(LdaConstant), U8(0), //
- B(Star), R(1), //
- B(LdaZero), //
- B(Star), R(2), //
- B(CallRuntime), U16(Runtime::kDeclareGlobals), R(1), U8(2), //
- B(StackCheck), //
- B(LdaConstant), U8(1), //
- B(Star), R(1), //
- B(LdaZero), //
- B(Star), R(2), //
- B(LdaSmi8), U8(1), //
- B(Star), R(3), //
- B(CallRuntime), U16(Runtime::kInitializeVarGlobal), R(1), U8(3), //
- B(LdaSmi8), U8(2), //
- B(StaGlobalSloppy), U8(1), //
- /* */ U8(store_vector->GetIndex(store_slot_2)), //
- B(Star), R(0), //
- B(Return) //
- },
- 2,
- {InstanceType::FIXED_ARRAY_TYPE,
- InstanceType::ONE_BYTE_INTERNALIZED_STRING_TYPE}},
- {"function f() {}\nf();",
- 3 * kPointerSize,
- 1,
- 29,
- {
- B(LdaConstant), U8(0), //
- B(Star), R(1), //
- B(LdaZero), //
- B(Star), R(2), //
- B(CallRuntime), U16(Runtime::kDeclareGlobals), R(1), U8(2), //
- B(StackCheck), //
- B(LdaUndefined), //
- B(Star), R(2), //
- B(LdaGlobal), U8(1), U8(load_vector->GetIndex(load_slot_1)), //
- B(Star), R(1), //
- B(Call), R(1), R(2), U8(1), //
- /* */ U8(load_vector->GetIndex(call_slot_1)), //
- B(Star), R(0), //
- B(Return) //
- },
- 2,
- {InstanceType::FIXED_ARRAY_TYPE,
- InstanceType::ONE_BYTE_INTERNALIZED_STRING_TYPE}},
+ InitializedIgnitionHandleScope scope;
+ BytecodeExpectationsPrinter printer(CcTest::isolate(),
+ ConstantPoolType::kMixed);
+ printer.set_wrap(false);
+ printer.set_test_function_name("f");
+ printer.set_execute(false);
+ printer.set_top_level(true);
+
+ const char* snippets[] = {
+ "var a = 1;",
+ "function f() {}",
+ "var a = 1;\na=2;",
+ "function f() {}\nf();",
};
- // clang-format on
- for (size_t i = 0; i < arraysize(snippets); i++) {
- Handle<BytecodeArray> bytecode_array =
- helper.MakeTopLevelBytecode(snippets[i].code_snippet);
- CheckBytecodeArrayEqual(snippets[i], bytecode_array);
- }
+ CHECK_EQ(BuildActual(printer, snippets),
+ LoadGolden("DeclareGlobals.golden"));
}
-
TEST(BreakableBlocks) {
- InitializedHandleScope handle_scope;
- BytecodeGeneratorHelper helper;
-
- int closure = Register::function_closure().index();
- int context = Register::current_context().index();
-
- // clang-format off
- ExpectedSnippet<InstanceType> snippets[] = {
- {"var x = 0;\n"
- "label: {\n"
- " x = x + 1;\n"
- " break label;\n"
- " x = x + 1;\n"
- "}\n"
- "return x;",
- 2 * kPointerSize,
- 1,
- 17,
- {
- B(StackCheck), //
- B(LdaZero), //
- B(Star), R(0), //
- B(Star), R(1), //
- B(LdaSmi8), U8(1), //
- B(Add), R(1), //
- B(Star), R(0), //
- B(Jump), U8(2), //
- B(Ldar), R(0), //
- B(Return) //
- }},
- {"var sum = 0;\n"
- "outer: {\n"
- " for (var x = 0; x < 10; ++x) {\n"
- " for (var y = 0; y < 3; ++y) {\n"
- " ++sum;\n"
- " if (x + y == 12) { break outer; }\n"
- " }\n"
- " }\n"
- "}\n"
- "return sum;",
- 5 * kPointerSize,
- 1,
- 75,
- {
- B(StackCheck), //
- B(LdaZero), //
- B(Star), R(0), //
- B(LdaZero), //
- B(Star), R(1), //
- B(Ldar), R(1), //
- B(Star), R(3), //
- B(LdaSmi8), U8(10), //
- B(TestLessThan), R(3), //
- B(JumpIfFalse), U8(57), //
- B(StackCheck), //
- B(LdaZero), //
- B(Star), R(2), //
- B(Ldar), R(2), //
- B(Star), R(3), //
- B(LdaSmi8), U8(3), //
- B(TestLessThan), R(3), //
- B(JumpIfFalse), U8(35), //
- B(StackCheck), //
- B(Ldar), R(0), //
- B(ToNumber), //
- B(Inc), //
- B(Star), R(0), //
- B(Ldar), R(1), //
- B(Star), R(3), //
- B(Ldar), R(2), //
- B(Add), R(3), //
- B(Star), R(4), //
- B(LdaSmi8), U8(12), //
- B(TestEqual), R(4), //
- B(JumpIfFalse), U8(4), //
- B(Jump), U8(18), //
- B(Ldar), R(2), //
- B(ToNumber), //
- B(Inc), //
- B(Star), R(2), //
- B(Jump), U8(-41), //
- B(Ldar), R(1), //
- B(ToNumber), //
- B(Inc), //
- B(Star), R(1), //
- B(Jump), U8(-63), //
- B(Ldar), R(0), //
- B(Return), //
- }},
- {"outer: {\n"
- " let y = 10;"
- " function f() { return y; }\n"
- " break outer;\n"
- "}\n",
- 5 * kPointerSize,
- 1,
- 51,
- {
- B(StackCheck), //
- B(LdaConstant), U8(0), //
- B(Star), R(3), //
- B(Ldar), R(closure), //
- B(Star), R(4), //
- B(CallRuntime), U16(Runtime::kPushBlockContext), R(3), U8(2), //
- B(PushContext), R(2), //
- B(LdaTheHole), //
- B(StaContextSlot), R(context), U8(4), //
- B(CreateClosure), U8(1), U8(0), //
- B(Star), R(0), //
- B(LdaSmi8), U8(10), //
- B(StaContextSlot), R(context), U8(4), //
- B(Ldar), R(0), //
- B(JumpIfNotHole), U8(11), //
- B(LdaConstant), U8(2), //
- B(Star), R(3), //
- B(CallRuntime), U16(Runtime::kThrowReferenceError), R(3), U8(1), //
- B(Star), R(1), //
- B(Jump), U8(2), //
- B(PopContext), R(2), //
- B(LdaUndefined), //
- B(Return), //
- },
- 3,
- {InstanceType::FIXED_ARRAY_TYPE, InstanceType::SHARED_FUNCTION_INFO_TYPE,
- InstanceType::ONE_BYTE_INTERNALIZED_STRING_TYPE}},
- {"let x = 1;\n"
- "outer: {\n"
- " inner: {\n"
- " let y = 2;\n"
- " function f() { return x + y; }\n"
- " if (y) break outer;\n"
- " y = 3;\n"
- " }\n"
- "}\n"
- "x = 4;",
- 6 * kPointerSize,
- 1,
- 131,
- {
- B(CallRuntime), U16(Runtime::kNewFunctionContext), R(closure), //
- U8(1), //
- B(PushContext), R(2), //
- B(LdaTheHole), //
- B(StaContextSlot), R(context), U8(4), //
- B(StackCheck), //
- B(LdaSmi8), U8(1), //
- B(StaContextSlot), R(context), U8(4), //
- B(LdaConstant), U8(0), //
- B(Star), R(4), //
- B(Ldar), R(closure), //
- B(Star), R(5), //
- B(CallRuntime), U16(Runtime::kPushBlockContext), R(4), U8(2), //
- B(PushContext), R(3), //
- B(LdaTheHole), //
- B(StaContextSlot), R(context), U8(4), //
- B(CreateClosure), U8(1), U8(0), //
- B(Star), R(0), //
- B(LdaSmi8), U8(2), //
- B(StaContextSlot), R(context), U8(4), //
- B(Ldar), R(0), //
- B(JumpIfNotHole), U8(11), //
- B(LdaConstant), U8(2), //
- B(Star), R(4), //
- B(CallRuntime), U16(Runtime::kThrowReferenceError), R(4), U8(1), //
- B(Star), R(1), //
- B(LdaContextSlot), R(context), U8(4), //
- B(JumpIfNotHole), U8(11), //
- B(LdaConstant), U8(3), //
- B(Star), R(4), //
- B(CallRuntime), U16(Runtime::kThrowReferenceError), R(4), U8(1), //
- B(JumpIfToBooleanFalse), U8(6), //
- B(PopContext), R(3), //
- B(Jump), U8(27), //
- B(LdaSmi8), U8(3), //
- B(Star), R(4), //
- B(LdaContextSlot), R(context), U8(4), //
- B(JumpIfNotHole), U8(11), //
- B(LdaConstant), U8(3), //
- B(Star), R(5), //
- B(CallRuntime), U16(Runtime::kThrowReferenceError), R(5), U8(1), //
- B(Ldar), R(4), //
- B(StaContextSlot), R(context), U8(4), //
- B(PopContext), R(3), //
- B(LdaSmi8), U8(4), //
- B(Star), R(4), //
- B(LdaContextSlot), R(context), U8(4), //
- B(JumpIfNotHole), U8(11), //
- B(LdaConstant), U8(4), //
- B(Star), R(5), //
- B(CallRuntime), U16(Runtime::kThrowReferenceError), R(5), U8(1), //
- B(Ldar), R(4), //
- B(StaContextSlot), R(context), U8(4), //
- B(LdaUndefined), //
- B(Return), //
- },
- 5,
- {InstanceType::FIXED_ARRAY_TYPE, InstanceType::SHARED_FUNCTION_INFO_TYPE,
- InstanceType::ONE_BYTE_INTERNALIZED_STRING_TYPE,
- InstanceType::ONE_BYTE_INTERNALIZED_STRING_TYPE,
- InstanceType::ONE_BYTE_INTERNALIZED_STRING_TYPE}},
- };
- // clang-format on
-
- for (size_t i = 0; i < arraysize(snippets); i++) {
- Handle<BytecodeArray> bytecode_array =
- helper.MakeBytecodeForFunctionBody(snippets[i].code_snippet);
- CheckBytecodeArrayEqual(snippets[i], bytecode_array);
- }
+ InitializedIgnitionHandleScope scope;
+ BytecodeExpectationsPrinter printer(CcTest::isolate(),
+ ConstantPoolType::kMixed);
+
+ const char* snippets[] = {
+ "var x = 0;\n"
+ "label: {\n"
+ " x = x + 1;\n"
+ " break label;\n"
+ " x = x + 1;\n"
+ "}\n"
+ "return x;",
+
+ "var sum = 0;\n"
+ "outer: {\n"
+ " for (var x = 0; x < 10; ++x) {\n"
+ " for (var y = 0; y < 3; ++y) {\n"
+ " ++sum;\n"
+ " if (x + y == 12) { break outer; }\n"
+ " }\n"
+ " }\n"
+ "}\n"
+ "return sum;",
+
+ "outer: {\n"
+ " let y = 10;\n"
+ " function f() { return y; }\n"
+ " break outer;\n"
+ "}\n",
+
+ "let x = 1;\n"
+ "outer: {\n"
+ " inner: {\n"
+ " let y = 2;\n"
+ " function f() { return x + y; }\n"
+ " if (y) break outer;\n"
+ " y = 3;\n"
+ " }\n"
+ "}\n"
+ "x = 4;",
+ };
+
+ CHECK_EQ(BuildActual(printer, snippets),
+ LoadGolden("BreakableBlocks.golden"));
}
-
TEST(BasicLoops) {
- InitializedHandleScope handle_scope;
- BytecodeGeneratorHelper helper;
-
- int closure = Register::function_closure().index();
- int context = Register::current_context().index();
-
- // clang-format off
- ExpectedSnippet<InstanceType> snippets[] = {
- {"var x = 0;\n"
- "while (false) { x = 99; break; continue; }\n"
- "return x;",
- 1 * kPointerSize,
- 1,
- 5,
- {
- B(StackCheck), //
- B(LdaZero), //
- B(Star), R(0), //
- B(Return) //
- }},
- {"var x = 0;"
- "while (false) {"
- " x = x + 1;"
- "};"
- "return x;",
- 1 * kPointerSize,
- 1,
- 5,
- {
- B(StackCheck), //
- B(LdaZero), //
- B(Star), R(0), //
- B(Return), //
- },
- 0},
- {"var x = 0;"
- "var y = 1;"
- "while (x < 10) {"
- " y = y * 12;"
- " x = x + 1;"
- " if (x == 3) continue;"
- " if (x == 4) break;"
- "}"
- "return y;",
- 3 * kPointerSize,
- 1,
- 66,
- {
- B(StackCheck), //
- B(LdaZero), //
- B(Star), R(0), //
- B(LdaSmi8), U8(1), //
- B(Star), R(1), //
- B(Ldar), R(0), //
- B(Star), R(2), //
- B(LdaSmi8), U8(10), //
- B(TestLessThan), R(2), //
- B(JumpIfFalse), U8(47), //
- B(StackCheck), //
- B(Ldar), R(1), //
- B(Star), R(2), //
- B(LdaSmi8), U8(12), //
- B(Mul), R(2), //
- B(Star), R(1), //
- B(Ldar), R(0), //
- B(Star), R(2), //
- B(LdaSmi8), U8(1), //
- B(Add), R(2), //
- B(Star), R(0), //
- B(Star), R(2), //
- B(LdaSmi8), U8(3), //
- B(TestEqual), R(2), //
- B(JumpIfFalse), U8(4), //
- B(Jump), U8(-39), //
- B(Ldar), R(0), //
- B(Star), R(2), //
- B(LdaSmi8), U8(4), //
- B(TestEqual), R(2), //
- B(JumpIfFalse), U8(4), //
- B(Jump), U8(4), //
- B(Jump), U8(-53), //
- B(Ldar), R(1), //
- B(Return), //
- },
- 0},
- {"var i = 0;"
- "while (true) {"
- " if (i < 0) continue;"
- " if (i == 3) break;"
- " if (i == 4) break;"
- " if (i == 10) continue;"
- " if (i == 5) break;"
- " i = i + 1;"
- "}"
- "return i;",
- 2 * kPointerSize,
- 1,
- 79,
- {
- B(StackCheck), //
- B(LdaZero), //
- B(Star), R(0), //
- B(StackCheck), //
- B(Ldar), R(0), //
- B(Star), R(1), //
- B(LdaZero), //
- B(TestLessThan), R(1), //
- B(JumpIfFalse), U8(4), //
- B(Jump), U8(-10), //
- B(Ldar), R(0), //
- B(Star), R(1), //
- B(LdaSmi8), U8(3), //
- B(TestEqual), R(1), //
- B(JumpIfFalse), U8(4), //
- B(Jump), U8(50), //
- B(Ldar), R(0), //
- B(Star), R(1), //
- B(LdaSmi8), U8(4), //
- B(TestEqual), R(1), //
- B(JumpIfFalse), U8(4), //
- B(Jump), U8(38), //
- B(Ldar), R(0), //
- B(Star), R(1), //
- B(LdaSmi8), U8(10), //
- B(TestEqual), R(1), //
- B(JumpIfFalse), U8(4), //
- B(Jump), U8(-46), //
- B(Ldar), R(0), //
- B(Star), R(1), //
- B(LdaSmi8), U8(5), //
- B(TestEqual), R(1), //
- B(JumpIfFalse), U8(4), //
- B(Jump), U8(14), //
- B(Ldar), R(0), //
- B(Star), R(1), //
- B(LdaSmi8), U8(1), //
- B(Add), R(1), //
- B(Star), R(0), //
- B(Jump), U8(-70), //
- B(Ldar), R(0), //
- B(Return), //
- },
- 0},
- {"var i = 0;"
- "while (true) {"
- " while (i < 3) {"
- " if (i == 2) break;"
- " i = i + 1;"
- " }"
- " i = i + 1;"
- " break;"
- "}"
- "return i;",
- 2 * kPointerSize,
- 1,
- 57,
- {
- B(StackCheck), //
- B(LdaZero), //
- B(Star), R(0), //
- B(StackCheck), //
- B(Ldar), R(0), //
- B(Star), R(1), //
- B(LdaSmi8), U8(3), //
- B(TestLessThan), R(1), //
- B(JumpIfFalse), U8(27), //
- B(StackCheck), //
- B(Ldar), R(0), //
- B(Star), R(1), //
- B(LdaSmi8), U8(2), //
- B(TestEqual), R(1), //
- B(JumpIfFalse), U8(4), //
- B(Jump), U8(14), //
- B(Ldar), R(0), //
- B(Star), R(1), //
- B(LdaSmi8), U8(1), //
- B(Add), R(1), //
- B(Star), R(0), //
- B(Jump), U8(-33), //
- B(Ldar), R(0), //
- B(Star), R(1), //
- B(LdaSmi8), U8(1), //
- B(Add), R(1), //
- B(Star), R(0), //
- B(Jump), U8(4), //
- B(Jump), U8(-48), //
- B(Ldar), R(0), //
- B(Return), //
- },
- 0},
- {"var x = 10;"
- "var y = 1;"
- "while (x) {"
- " y = y * 12;"
- " x = x - 1;"
- "}"
- "return y;",
- 3 * kPointerSize,
- 1,
- 39,
- {
- B(StackCheck), //
- B(LdaSmi8), U8(10), //
- B(Star), R(0), //
- B(LdaSmi8), U8(1), //
- B(Star), R(1), //
- B(Ldar), R(0), //
- B(JumpIfToBooleanFalse), U8(25), //
- B(StackCheck), //
- B(Ldar), R(1), //
- B(Star), R(2), //
- B(LdaSmi8), U8(12), //
- B(Mul), R(2), //
- B(Star), R(1), //
- B(Ldar), R(0), //
- B(Star), R(2), //
- B(LdaSmi8), U8(1), //
- B(Sub), R(2), //
- B(Star), R(0), //
- B(Jump), U8(-25), //
- B(Ldar), R(1), //
- B(Return), //
- },
- 0},
- {"var x = 0; var y = 1;"
- "do {"
- " y = y * 10;"
- " if (x == 5) break;"
- " if (x == 6) continue;"
- " x = x + 1;"
- "} while (x < 10);"
- "return y;",
- 3 * kPointerSize,
- 1,
- 66,
- {
- B(StackCheck), //
- B(LdaZero), //
- B(Star), R(0), //
- B(LdaSmi8), U8(1), //
- B(Star), R(1), //
- B(StackCheck), //
- B(Ldar), R(1), //
- B(Star), R(2), //
- B(LdaSmi8), U8(10), //
- B(Mul), R(2), //
- B(Star), R(1), //
- B(Ldar), R(0), //
- B(Star), R(2), //
- B(LdaSmi8), U8(5), //
- B(TestEqual), R(2), //
- B(JumpIfFalse), U8(4), //
- B(Jump), U8(34), //
- B(Ldar), R(0), //
- B(Star), R(2), //
- B(LdaSmi8), U8(6), //
- B(TestEqual), R(2), //
- B(JumpIfFalse), U8(4), //
- B(Jump), U8(12), //
- B(Ldar), R(0), //
- B(Star), R(2), //
- B(LdaSmi8), U8(1), //
- B(Add), R(2), //
- B(Star), R(0), //
- B(Ldar), R(0), //
- B(Star), R(2), //
- B(LdaSmi8), U8(10), //
- B(TestLessThan), R(2), //
- B(JumpIfTrue), U8(-53), //
- B(Ldar), R(1), //
- B(Return), //
- },
- 0},
- {"var x = 10;"
- "var y = 1;"
- "do {"
- " y = y * 12;"
- " x = x - 1;"
- "} while (x);"
- "return y;",
- 3 * kPointerSize,
- 1,
- 37,
- {
- B(StackCheck), //
- B(LdaSmi8), U8(10), //
- B(Star), R(0), //
- B(LdaSmi8), U8(1), //
- B(Star), R(1), //
- B(StackCheck), //
- B(Ldar), R(1), //
- B(Star), R(2), //
- B(LdaSmi8), U8(12), //
- B(Mul), R(2), //
- B(Star), R(1), //
- B(Ldar), R(0), //
- B(Star), R(2), //
- B(LdaSmi8), U8(1), //
- B(Sub), R(2), //
- B(Star), R(0), //
- B(Ldar), R(0), //
- B(JumpIfToBooleanTrue), U8(-23), //
- B(Ldar), R(1), //
- B(Return), //
- },
- 0},
- {"var x = 0; var y = 1;"
- "do {"
- " y = y * 10;"
- " if (x == 5) break;"
- " x = x + 1;"
- " if (x == 6) continue;"
- "} while (false);"
- "return y;",
- 3 * kPointerSize,
- 1,
- 54,
- {
- B(StackCheck), //
- B(LdaZero), //
- B(Star), R(0), //
- B(LdaSmi8), U8(1), //
- B(Star), R(1), //
- B(StackCheck), //
- B(Ldar), R(1), //
- B(Star), R(2), //
- B(LdaSmi8), U8(10), //
- B(Mul), R(2), //
- B(Star), R(1), //
- B(Ldar), R(0), //
- B(Star), R(2), //
- B(LdaSmi8), U8(5), //
- B(TestEqual), R(2), //
- B(JumpIfFalse), U8(4), //
- B(Jump), U8(22), //
- B(Ldar), R(0), //
- B(Star), R(2), //
- B(LdaSmi8), U8(1), //
- B(Add), R(2), //
- B(Star), R(0), //
- B(Star), R(2), //
- B(LdaSmi8), U8(6), //
- B(TestEqual), R(2), //
- B(JumpIfFalse), U8(4), //
- B(Jump), U8(2), //
- B(Ldar), R(1), //
- B(Return), //
- },
- 0},
- {"var x = 0; var y = 1;"
- "do {"
- " y = y * 10;"
- " if (x == 5) break;"
- " x = x + 1;"
- " if (x == 6) continue;"
- "} while (true);"
- "return y;",
- 3 * kPointerSize,
- 1,
- 56,
- {
- B(StackCheck), //
- B(LdaZero), //
- B(Star), R(0), //
- B(LdaSmi8), U8(1), //
- B(Star), R(1), //
- B(StackCheck), //
- B(Ldar), R(1), //
- B(Star), R(2), //
- B(LdaSmi8), U8(10), //
- B(Mul), R(2), //
- B(Star), R(1), //
- B(Ldar), R(0), //
- B(Star), R(2), //
- B(LdaSmi8), U8(5), //
- B(TestEqual), R(2), //
- B(JumpIfFalse), U8(4), //
- B(Jump), U8(24), //
- B(Ldar), R(0), //
- B(Star), R(2), //
- B(LdaSmi8), U8(1), //
- B(Add), R(2), //
- B(Star), R(0), //
- B(Star), R(2), //
- B(LdaSmi8), U8(6), //
- B(TestEqual), R(2), //
- B(JumpIfFalse), U8(4), //
- B(Jump), U8(-41), //
- B(Jump), U8(-43), //
- B(Ldar), R(1), //
- B(Return), //
- },
- 0},
- {"var x = 0; "
- "for (;;) {"
- " if (x == 1) break;"
- " if (x == 2) continue;"
- " x = x + 1;"
- "}",
- 2 * kPointerSize,
- 1,
- 43,
- {
- B(StackCheck), //
- B(LdaZero), //
- B(Star), R(0), //
- B(StackCheck), //
- B(Ldar), R(0), //
- B(Star), R(1), //
- B(LdaSmi8), U8(1), //
- B(TestEqual), R(1), //
- B(JumpIfFalse), U8(4), //
- B(Jump), U8(26), //
- B(Ldar), R(0), //
- B(Star), R(1), //
- B(LdaSmi8), U8(2), //
- B(TestEqual), R(1), //
- B(JumpIfFalse), U8(4), //
- B(Jump), U8(-23), //
- B(Ldar), R(0), //
- B(Star), R(1), //
- B(LdaSmi8), U8(1), //
- B(Add), R(1), //
- B(Star), R(0), //
- B(Jump), U8(-35), //
- B(LdaUndefined), //
- B(Return), //
- },
- 0},
- {"for (var x = 0;;) {"
- " if (x == 1) break;"
- " if (x == 2) continue;"
- " x = x + 1;"
- "}",
- 2 * kPointerSize,
- 1,
- 43,
- {
- B(StackCheck), //
- B(LdaZero), //
- B(Star), R(0), //
- B(StackCheck), //
- B(Ldar), R(0), //
- B(Star), R(1), //
- B(LdaSmi8), U8(1), //
- B(TestEqual), R(1), //
- B(JumpIfFalse), U8(4), //
- B(Jump), U8(26), //
- B(Ldar), R(0), //
- B(Star), R(1), //
- B(LdaSmi8), U8(2), //
- B(TestEqual), R(1), //
- B(JumpIfFalse), U8(4), //
- B(Jump), U8(-23), //
- B(Ldar), R(0), //
- B(Star), R(1), //
- B(LdaSmi8), U8(1), //
- B(Add), R(1), //
- B(Star), R(0), //
- B(Jump), U8(-35), //
- B(LdaUndefined), //
- B(Return), //
- },
- 0},
- {"var x = 0; "
- "for (;; x = x + 1) {"
- " if (x == 1) break;"
- " if (x == 2) continue;"
- "}",
- 2 * kPointerSize,
- 1,
- 43,
- {
- B(StackCheck), //
- B(LdaZero), //
- B(Star), R(0), //
- B(StackCheck), //
- B(Ldar), R(0), //
- B(Star), R(1), //
- B(LdaSmi8), U8(1), //
- B(TestEqual), R(1), //
- B(JumpIfFalse), U8(4), //
- B(Jump), U8(26), //
- B(Ldar), R(0), //
- B(Star), R(1), //
- B(LdaSmi8), U8(2), //
- B(TestEqual), R(1), //
- B(JumpIfFalse), U8(4), //
- B(Jump), U8(2), //
- B(Ldar), R(0), //
- B(Star), R(1), //
- B(LdaSmi8), U8(1), //
- B(Add), R(1), //
- B(Star), R(0), //
- B(Jump), U8(-35), //
- B(LdaUndefined), //
- B(Return), //
- },
- 0},
- {"for (var x = 0;; x = x + 1) {"
- " if (x == 1) break;"
- " if (x == 2) continue;"
- "}",
- 2 * kPointerSize,
- 1,
- 43,
- {
- B(StackCheck), //
- B(LdaZero), //
- B(Star), R(0), //
- B(StackCheck), //
- B(Ldar), R(0), //
- B(Star), R(1), //
- B(LdaSmi8), U8(1), //
- B(TestEqual), R(1), //
- B(JumpIfFalse), U8(4), //
- B(Jump), U8(26), //
- B(Ldar), R(0), //
- B(Star), R(1), //
- B(LdaSmi8), U8(2), //
- B(TestEqual), R(1), //
- B(JumpIfFalse), U8(4), //
- B(Jump), U8(2), //
- B(Ldar), R(0), //
- B(Star), R(1), //
- B(LdaSmi8), U8(1), //
- B(Add), R(1), //
- B(Star), R(0), //
- B(Jump), U8(-35), //
- B(LdaUndefined), //
- B(Return), //
- },
- 0},
- {"var u = 0;"
- "for (var i = 0; i < 100; i = i + 1) {"
- " u = u + 1;"
- " continue;"
- "}",
- 3 * kPointerSize,
- 1,
- 44,
- {
- B(StackCheck), //
- B(LdaZero), //
- B(Star), R(0), //
- B(LdaZero), //
- B(Star), R(1), //
- B(Ldar), R(1), //
- B(Star), R(2), //
- B(LdaSmi8), U8(100), //
- B(TestLessThan), R(2), //
- B(JumpIfFalse), U8(27), //
- B(StackCheck), //
- B(Ldar), R(0), //
- B(Star), R(2), //
- B(LdaSmi8), U8(1), //
- B(Add), R(2), //
- B(Star), R(0), //
- B(Jump), U8(2), //
- B(Ldar), R(1), //
- B(Star), R(2), //
- B(LdaSmi8), U8(1), //
- B(Add), R(2), //
- B(Star), R(1), //
- B(Jump), U8(-33), //
- B(LdaUndefined), //
- B(Return), //
- },
- 0},
- {"var y = 1;"
- "for (var x = 10; x; --x) {"
- " y = y * 12;"
- "}"
- "return y;",
- 3 * kPointerSize,
- 1,
- 35,
- {
- B(StackCheck), //
- B(LdaSmi8), U8(1), //
- B(Star), R(0), //
- B(LdaSmi8), U8(10), //
- B(Star), R(1), //
- B(Ldar), R(1), //
- B(JumpIfToBooleanFalse), U8(21), //
- B(StackCheck), //
- B(Ldar), R(0), //
- B(Star), R(2), //
- B(LdaSmi8), U8(12), //
- B(Mul), R(2), //
- B(Star), R(0), //
- B(Ldar), R(1), //
- B(ToNumber), //
- B(Dec), //
- B(Star), R(1), //
- B(Jump), U8(-21), //
- B(Ldar), R(0), //
- B(Return), //
- },
- 0},
- {"var x = 0;"
- "for (var i = 0; false; i++) {"
- " x = x + 1;"
- "};"
- "return x;",
- 2 * kPointerSize,
- 1,
- 10,
- {
- B(StackCheck), //
- B(LdaZero), //
- B(Star), R(0), //
- B(LdaZero), //
- B(Star), R(1), //
- B(Ldar), R(0), //
- B(Return), //
- },
- 0},
- {"var x = 0;"
- "for (var i = 0; true; ++i) {"
- " x = x + 1;"
- " if (x == 20) break;"
- "};"
- "return x;",
- 3 * kPointerSize,
- 1,
- 39,
- {
- B(StackCheck), //
- B(LdaZero), //
- B(Star), R(0), //
- B(LdaZero), //
- B(Star), R(1), //
- B(StackCheck), //
- B(Ldar), R(0), //
- B(Star), R(2), //
- B(LdaSmi8), U8(1), //
- B(Add), R(2), //
- B(Star), R(0), //
- B(Star), R(2), //
- B(LdaSmi8), U8(20), //
- B(TestEqual), R(2), //
- B(JumpIfFalse), U8(4), //
- B(Jump), U8(10), //
- B(Ldar), R(1), //
- B(ToNumber), //
- B(Inc), //
- B(Star), R(1), //
- B(Jump), U8(-27), //
- B(Ldar), R(0), //
- B(Return), //
- },
- 0},
- {"var a = 0;\n"
- "while (a) {\n"
- " { \n"
- " let z = 1;\n"
- " function f() { z = 2; }\n"
- " if (z) continue;\n"
- " z++;\n"
- " }\n"
- "}\n",
- 7 * kPointerSize,
- 1,
- 118,
- {
- B(StackCheck), //
- B(LdaZero), //
- B(Star), R(1), //
- B(Ldar), R(1), //
- B(JumpIfToBooleanFalse), U8(110), //
- B(StackCheck), //
- B(LdaConstant), U8(0), //
- B(Star), R(4), //
- B(Ldar), R(closure), //
- B(Star), R(5), //
- B(CallRuntime), U16(Runtime::kPushBlockContext), R(4), U8(2), //
- B(PushContext), R(3), //
- B(LdaTheHole), //
- B(StaContextSlot), R(context), U8(4), //
- B(CreateClosure), U8(1), U8(0), //
- B(Star), R(0), //
- B(LdaSmi8), U8(1), //
- B(StaContextSlot), R(context), U8(4), //
- B(Ldar), R(0), //
- B(JumpIfNotHole), U8(11), //
- B(LdaConstant), U8(2), //
- B(Star), R(4), //
- B(CallRuntime), U16(Runtime::kThrowReferenceError), R(4), U8(1), //
- B(Star), R(2), //
- B(LdaContextSlot), R(context), U8(4), //
- B(JumpIfNotHole), U8(11), //
- B(LdaConstant), U8(3), //
- B(Star), R(4), //
- B(CallRuntime), U16(Runtime::kThrowReferenceError), R(4), U8(1), //
- B(JumpIfToBooleanFalse), U8(6), //
- B(PopContext), R(3), //
- B(Jump), U8(-67), //
- B(LdaContextSlot), R(context), U8(4), //
- B(JumpIfNotHole), U8(11), //
- B(LdaConstant), U8(3), //
- B(Star), R(4), //
- B(CallRuntime), U16(Runtime::kThrowReferenceError), R(4), U8(1), //
- B(ToNumber), //
- B(Star), R(4), //
- B(Inc), //
- B(Star), R(5), //
- B(LdaContextSlot), R(context), U8(4), //
- B(JumpIfNotHole), U8(11), //
- B(LdaConstant), U8(3), //
- B(Star), R(6), //
- B(CallRuntime), U16(Runtime::kThrowReferenceError), R(6), U8(1), //
- B(Ldar), R(5), //
- B(StaContextSlot), R(context), U8(4), //
- B(PopContext), R(3), //
- B(Jump), U8(-110), //
- B(LdaUndefined), //
- B(Return), //
- },
- 4,
- {InstanceType::FIXED_ARRAY_TYPE, InstanceType::SHARED_FUNCTION_INFO_TYPE,
- InstanceType::ONE_BYTE_INTERNALIZED_STRING_TYPE,
- InstanceType::ONE_BYTE_INTERNALIZED_STRING_TYPE}},
- };
- // clang-format on
-
- for (size_t i = 0; i < arraysize(snippets); i++) {
- Handle<BytecodeArray> bytecode_array =
- helper.MakeBytecodeForFunctionBody(snippets[i].code_snippet);
- CheckBytecodeArrayEqual(snippets[i], bytecode_array);
- }
+ InitializedIgnitionHandleScope scope;
+ BytecodeExpectationsPrinter printer(CcTest::isolate(),
+ ConstantPoolType::kMixed);
+ const char* snippets[] = {
+ "var x = 0;\n"
oth 2016/02/24 13:43:55 clang-format off
Stefano Sanfilippo 2016/02/24 14:55:01 I was discussing with rmcilroy the best way to tel
Stefano Sanfilippo 2016/02/24 16:32:15 Actually, I made the cc file go through cl format
+ "while (false) { x = 99; break; continue; }\n"
+ "return x;",
+
+ "var x = 0;\n"
+ "while (false) {\n"
+ " x = x + 1;\n"
+ "};\n"
+ "return x;",
+
+ "var x = 0;\n"
+ "var y = 1;\n"
+ "while (x < 10) {\n"
+ " y = y * 12;\n"
+ " x = x + 1;\n"
+ " if (x == 3) continue;\n"
+ " if (x == 4) break;\n"
+ "}\n"
+ "return y;",
+
+ "var i = 0;\n"
+ "while (true) {\n"
+ " if (i < 0) continue;\n"
+ " if (i == 3) break;\n"
+ " if (i == 4) break;\n"
+ " if (i == 10) continue;\n"
+ " if (i == 5) break;\n"
+ " i = i + 1;\n"
+ "}\n"
+ "return i;",
+
+ "var i = 0;\n"
+ "while (true) {\n"
+ " while (i < 3) {\n"
+ " if (i == 2) break;\n"
+ " i = i + 1;\n"
+ " }\n"
+ " i = i + 1;\n"
+ " break;\n"
+ "}\n"
+ "return i;\n",
+
+ "var x = 10;\n"
+ "var y = 1;\n"
+ "while (x) {\n"
+ " y = y * 12;\n"
+ " x = x - 1;\n"
+ "}\n"
+ "return y;",
+
+ "var x = 0; var y = 1;\n"
+ "do {\n"
+ " y = y * 10;\n"
+ " if (x == 5) break;\n"
+ " if (x == 6) continue;\n"
+ " x = x + 1;\n"
+ "} while (x < 10);\n"
+ "return y;",
+
+ "var x = 10;\n"
+ "var y = 1;\n"
+ "do {\n"
+ " y = y * 12;\n"
+ " x = x - 1;\n"
+ "} while (x);\n"
+ "return y;",
+
+ "var x = 0; var y = 1;\n"
+ "do {\n"
+ " y = y * 10;\n"
+ " if (x == 5) break;\n"
+ " x = x + 1;\n"
+ " if (x == 6) continue;\n"
+ "} while (false);\n"
+ "return y;",
+
+ "var x = 0; var y = 1;\n"
+ "do {\n"
+ " y = y * 10;\n"
+ " if (x == 5) break;\n"
+ " x = x + 1;\n"
+ " if (x == 6) continue;\n"
+ "} while (true);\n"
+ "return y;",
+
+ "var x = 0;\n"
+ "for (;;) {\n"
+ " if (x == 1) break;\n"
+ " if (x == 2) continue;\n"
+ " x = x + 1;\n"
+ "}",
+
+ "for (var x = 0;;) {\n"
+ " if (x == 1) break;\n"
+ " if (x == 2) continue;\n"
+ " x = x + 1;\n"
+ "}",
+
+ "var x = 0;\n"
+ "for (;; x = x + 1) {\n"
+ " if (x == 1) break;\n"
+ " if (x == 2) continue;\n"
+ "}",
+
+ "for (var x = 0;; x = x + 1) {\n"
+ " if (x == 1) break;\n"
+ " if (x == 2) continue;\n"
+ "}",
+
+ "var u = 0;\n"
+ "for (var i = 0; i < 100; i = i + 1) {\n"
+ " u = u + 1;\n"
+ " continue;\n"
+ "}",
+
+ "var y = 1;\n"
+ "for (var x = 10; x; --x) {\n"
+ " y = y * 12;\n"
+ "}\n"
+ "return y;",
+
+ "var x = 0;\n"
+ "for (var i = 0; false; i++) {\n"
+ " x = x + 1;\n"
+ "};\n"
+ "return x;",
+
+ "var x = 0;\n"
+ "for (var i = 0; true; ++i) {\n"
+ " x = x + 1;\n"
+ " if (x == 20) break;\n"
+ "};\n"
+ "return x;",
+
+ "var a = 0;\n"
+ "while (a) {\n"
+ " { \n"
+ " let z = 1;\n"
+ " function f() { z = 2; }\n"
+ " if (z) continue;\n"
+ " z++;\n"
+ " }\n"
+ "}\n",
oth 2016/02/24 13:43:55 clang-format on
+ };
+
+ CHECK_EQ(BuildActual(printer, snippets),
+ LoadGolden("BasicLoops.golden"));
}
-
TEST(JumpsRequiringConstantWideOperands) {
- InitializedHandleScope handle_scope;
- BytecodeGeneratorHelper helper;
-
- int constant_count = 0;
- // clang-format off
- ExpectedSnippet<Handle<Object>, 316> snippets[] = {
- {
- REPEAT_256(SPACE, "var x = 0.1;")
- REPEAT_32(SPACE, "var x = 0.2;")
- REPEAT_16(SPACE, "var x = 0.3;")
- REPEAT_8(SPACE, "var x = 0.4;")
- "for (var i = 0; i < 3; i++) {\n"
- " if (i == 1) continue;\n"
- " if (i == 2) break;\n"
- "}\n"
- "return 3;",
- kPointerSize * 3,
- 1,
- 1361,
- {
- B(StackCheck), //
-#define L(c) B(LdaConstant), U8(c), B(Star), R(0)
- REPEAT_256(COMMA, L(constant_count++)),
-#undef L
-#define LW(c) B(LdaConstantWide), U16I(c), B(Star), R(0)
- REPEAT_32(COMMA, LW(constant_count)),
- REPEAT_16(COMMA, LW(constant_count)),
- REPEAT_8(COMMA, LW(constant_count)),
-#undef LW
- B(LdaZero), //
- B(Star), R(1), //
- B(Ldar), R(1), //
- B(Star), R(2), //
- B(LdaSmi8), U8(3), //
- B(TestLessThan), R(2), //
- B(JumpIfFalseConstantWide), U16(313), //
- B(StackCheck), //
- B(Ldar), R(1), //
- B(Star), R(2), //
- B(LdaSmi8), U8(1), //
- B(TestEqual), R(2), //
- B(JumpIfFalseConstantWide), U16(312), //
- B(JumpConstantWide), U16(315), //
- B(Ldar), R(1), //
- B(Star), R(2), //
- B(LdaSmi8), U8(2), //
- B(TestEqual), R(2), //
- B(JumpIfFalseConstantWide), U16(312), //
- B(JumpConstantWide), U16(314), //
- B(Ldar), R(1), //
- B(ToNumber), //
- B(Star), R(2), //
- B(Inc), //
- B(Star), R(1), //
- B(Jump), U8(-48), //
- B(LdaSmi8), U8(3), //
- B(Return) //
- },
- 316,
- {
-#define S(x) CcTest::i_isolate()->factory()->NewNumber(x)
- REPEAT_256(COMMA, S(0.1)),
- REPEAT_32(COMMA, S(0.2)),
- REPEAT_16(COMMA, S(0.3)),
- REPEAT_8(COMMA, S(0.4)),
-#undef S
-#define N(x) CcTest::i_isolate()->factory()->NewNumberFromInt(x)
- N(6), N(42), N(13), N(17)
-#undef N
- }}
+ InitializedIgnitionHandleScope scope;
+ BytecodeExpectationsPrinter printer(CcTest::isolate(),
+ ConstantPoolType::kNumber);
+ const char* snippets[] = {
+ REPEAT_256(SPACE, "var x = 0.1;\n")
+ REPEAT_32(SPACE, "var x = 0.2;\n")
+ REPEAT_16(SPACE, "var x = 0.3;\n")
+ REPEAT_8(SPACE, "var x = 0.4;\n")
+ "for (var i = 0; i < 3; i++) {\n"
+ " if (i == 1) continue;\n"
+ " if (i == 2) break;\n"
+ "}\n"
+ "return 3;",
};
- // clang-format on
- for (size_t i = 0; i < arraysize(snippets); i++) {
- Handle<BytecodeArray> bytecode_array =
- helper.MakeBytecodeForFunctionBody(snippets[i].code_snippet);
- CheckBytecodeArrayEqual(snippets[i], bytecode_array);
- }
+ CHECK_EQ(BuildActual(printer, snippets),
+ LoadGolden("JumpsRequiringConstantWideOperands.golden"));
}
-
TEST(UnaryOperators) {
- InitializedHandleScope handle_scope;
- BytecodeGeneratorHelper helper;
-
- // clang-format off
- ExpectedSnippet<int> snippets[] = {
- {"var x = 0;"
- "while (x != 10) {"
- " x = x + 10;"
- "}"
- "return x;",
- 2 * kPointerSize,
- 1,
- 31,
- {
- B(StackCheck), //
- B(LdaZero), //
- B(Star), R(0), //
- B(Ldar), R(0), //
- B(Star), R(1), //
- B(LdaSmi8), U8(10), //
- B(TestEqual), R(1), //
- B(LogicalNot), //
- B(JumpIfFalse), U8(15), //
- B(StackCheck), //
- B(Ldar), R(0), //
- B(Star), R(1), //
- B(LdaSmi8), U8(10), //
- B(Add), R(1), //
- B(Star), R(0), //
- B(Jump), U8(-22), //
- B(Ldar), R(0), //
- B(Return), //
- },
- 0},
- {"var x = false;"
- "do {"
- " x = !x;"
- "} while(x == false);"
- "return x;",
- 2 * kPointerSize,
- 1,
- 22,
- {
- B(StackCheck), //
- B(LdaFalse), //
- B(Star), R(0), //
- B(StackCheck), //
- B(Ldar), R(0), //
- B(LogicalNot), //
- B(Star), R(0), //
- B(Ldar), R(0), //
- B(Star), R(1), //
- B(LdaFalse), //
- B(TestEqual), R(1), //
- B(JumpIfTrue), U8(-13), //
- B(Ldar), R(0), //
- B(Return), //
- },
- 0},
- {"var x = 101;"
- "return void(x * 3);",
- 2 * kPointerSize,
- 1,
- 13,
- {
- B(StackCheck), //
- B(LdaSmi8), U8(101), //
- B(Star), R(0), //
- B(Star), R(1), //
- B(LdaSmi8), U8(3), //
- B(Mul), R(1), //
- B(LdaUndefined), //
- B(Return), //
- },
- 0},
- {"var x = 1234;"
- "var y = void (x * x - 1);"
- "return y;",
- 4 * kPointerSize,
- 1,
- 21,
- {
- B(StackCheck), //
- B(LdaConstant), U8(0), //
- B(Star), R(0), //
- B(Star), R(2), //
- B(Ldar), R(0), //
- B(Mul), R(2), //
- B(Star), R(3), //
- B(LdaSmi8), U8(1), //
- B(Sub), R(3), //
- B(LdaUndefined), //
- B(Star), R(1), //
- B(Return), //
- },
- 1,
- {1234}},
- {"var x = 13;"
- "return ~x;",
- 2 * kPointerSize,
- 1,
- 12,
- {
- B(StackCheck), //
- B(LdaSmi8), U8(13), //
- B(Star), R(0), //
- B(Star), R(1), //
- B(LdaSmi8), U8(-1), //
- B(BitwiseXor), R(1), //
- B(Return), //
- },
- 0},
- {"var x = 13;"
- "return +x;",
- 2 * kPointerSize,
- 1,
- 12,
- {
- B(StackCheck), //
- B(LdaSmi8), U8(13), //
- B(Star), R(0), //
- B(Star), R(1), //
- B(LdaSmi8), U8(1), //
- B(Mul), R(1), //
- B(Return), //
- },
- 0},
- {"var x = 13;"
- "return -x;",
- 2 * kPointerSize,
- 1,
- 12,
- {
- B(StackCheck), //
- B(LdaSmi8), U8(13), //
- B(Star), R(0), //
- B(Star), R(1), //
- B(LdaSmi8), U8(-1), //
- B(Mul), R(1), //
- B(Return), //
- },
- 0}
- };
- // clang-format on
+ InitializedIgnitionHandleScope scope;
+ BytecodeExpectationsPrinter printer(CcTest::isolate(),
+ ConstantPoolType::kNumber);
+ const char* snippets[] = {
+ "var x = 0;\n"
+ "while (x != 10) {\n"
+ " x = x + 10;\n"
+ "}\n"
+ "return x;",
- for (size_t i = 0; i < arraysize(snippets); i++) {
- Handle<BytecodeArray> bytecode_array =
- helper.MakeBytecodeForFunctionBody(snippets[i].code_snippet);
- CheckBytecodeArrayEqual(snippets[i], bytecode_array);
- }
-}
+ "var x = false;\n"
+ "do {\n"
+ " x = !x;\n"
+ "} while(x == false);\n"
+ "return x;",
+ "var x = 101;\n"
+ "return void(x * 3);",
-TEST(Typeof) {
- InitializedHandleScope handle_scope;
- BytecodeGeneratorHelper helper;
- Zone zone;
-
- FeedbackVectorSpec feedback_spec(&zone);
- FeedbackVectorSlot slot = feedback_spec.AddLoadICSlot();
-
- Handle<i::TypeFeedbackVector> vector =
- i::NewTypeFeedbackVector(helper.isolate(), &feedback_spec);
-
- // clang-format off
- ExpectedSnippet<const char*> snippets[] = {
- {"function f() {\n"
- " var x = 13;\n"
- " return typeof(x);\n"
- "}; f();",
- kPointerSize,
- 1,
- 7,
- {
- B(StackCheck), //
- B(LdaSmi8), U8(13), //
- B(Star), R(0), //
- B(TypeOf), //
- B(Return), //
- }},
- {"var x = 13;\n"
- "function f() {\n"
- " return typeof(x);\n"
- "}; f();",
- 0,
- 1,
- 6,
- {
- B(StackCheck), //
- B(LdaGlobalInsideTypeof), U8(0), U8(vector->GetIndex(slot)), //
- B(TypeOf), //
- B(Return), //
- },
- 1,
- {"x"}},
- };
- // clang-format on
+ "var x = 1234;\n"
+ "var y = void (x * x - 1);\n"
+ "return y;",
- for (size_t i = 0; i < arraysize(snippets); i++) {
- Handle<BytecodeArray> bytecode_array =
- helper.MakeBytecodeForFunction(snippets[i].code_snippet);
- CheckBytecodeArrayEqual(snippets[i], bytecode_array);
- }
-}
+ "var x = 13;\n"
+ "return ~x;",
+ "var x = 13;\n"
+ "return +x;",
-TEST(Delete) {
- InitializedHandleScope handle_scope;
- BytecodeGeneratorHelper helper;
-
- int deep_elements_flags =
- ObjectLiteral::kFastElements | ObjectLiteral::kDisableMementos;
- int closure = Register::function_closure().index();
- int context = Register::current_context().index();
- int first_context_slot = Context::MIN_CONTEXT_SLOTS;
-
- // clang-format off
- ExpectedSnippet<InstanceType> snippets[] = {
- {"var a = {x:13, y:14}; return delete a.x;",
- 2 * kPointerSize,
- 1,
- 16,
- {
- B(StackCheck), //
- B(CreateObjectLiteral), U8(0), U8(0), U8(deep_elements_flags), //
- B(Star), R(1), //
- B(Star), R(0), //
- B(Star), R(1), //
- B(LdaConstant), U8(1), //
- B(DeletePropertySloppy), R(1), //
- B(Return)},
- 2,
- {InstanceType::FIXED_ARRAY_TYPE,
- InstanceType::ONE_BYTE_INTERNALIZED_STRING_TYPE}},
- {"'use strict'; var a = {x:13, y:14}; return delete a.x;",
- 2 * kPointerSize,
- 1,
- 16,
- {B(StackCheck), //
- B(CreateObjectLiteral), U8(0), U8(0), U8(deep_elements_flags), //
- B(Star), R(1), //
- B(Star), R(0), //
- B(Star), R(1), //
- B(LdaConstant), U8(1), //
- B(DeletePropertyStrict), R(1), //
- B(Return)},
- 2,
- {InstanceType::FIXED_ARRAY_TYPE,
- InstanceType::ONE_BYTE_INTERNALIZED_STRING_TYPE}},
- {"var a = {1:13, 2:14}; return delete a[2];",
- 2 * kPointerSize,
- 1,
- 16,
- {B(StackCheck), //
- B(CreateObjectLiteral), U8(0), U8(0), U8(deep_elements_flags), //
- B(Star), R(1), //
- B(Star), R(0), //
- B(Star), R(1), //
- B(LdaSmi8), U8(2), //
- B(DeletePropertySloppy), R(1), //
- B(Return)},
- 1,
- {InstanceType::FIXED_ARRAY_TYPE}},
- {"var a = 10; return delete a;",
- 1 * kPointerSize,
- 1,
- 7,
- {B(StackCheck), //
- B(LdaSmi8), U8(10), //
- B(Star), R(0), //
- B(LdaFalse), //
- B(Return)},
- 0},
- {"'use strict';"
- "var a = {1:10};"
- "(function f1() {return a;});"
- "return delete a[1];",
- 2 * kPointerSize,
- 1,
- 30,
- {B(CallRuntime), U16(Runtime::kNewFunctionContext), //
- /* */ R(closure), U8(1), //
- B(PushContext), R(0), //
- B(StackCheck), //
- B(CreateObjectLiteral), U8(0), U8(0), U8(deep_elements_flags), //
- B(Star), R(1), //
- B(StaContextSlot), R(context), U8(first_context_slot), //
- B(CreateClosure), U8(1), U8(0), //
- B(LdaContextSlot), R(context), U8(first_context_slot), //
- B(Star), R(1), //
- B(LdaSmi8), U8(1), //
- B(DeletePropertyStrict), R(1), //
- B(Return)},
- 2,
- {InstanceType::FIXED_ARRAY_TYPE,
- InstanceType::SHARED_FUNCTION_INFO_TYPE}},
- {"return delete 'test';",
- 0 * kPointerSize,
- 1,
- 3,
- {B(StackCheck), //
- B(LdaTrue), //
- B(Return)},
- 0},
+ "var x = 13;\n"
+ "return -x;",
};
- // clang-format on
- for (size_t i = 0; i < arraysize(snippets); i++) {
- Handle<BytecodeArray> bytecode_array =
- helper.MakeBytecodeForFunctionBody(snippets[i].code_snippet);
- CheckBytecodeArrayEqual(snippets[i], bytecode_array);
- }
+ CHECK_EQ(BuildActual(printer, snippets),
+ LoadGolden("UnaryOperators.golden"));
}
+TEST(Typeof) {
+ InitializedIgnitionHandleScope scope;
+ BytecodeExpectationsPrinter printer(CcTest::isolate(),
+ ConstantPoolType::kString);
+ printer.set_wrap(false);
+ printer.set_test_function_name("f");
-TEST(GlobalDelete) {
- InitializedHandleScope handle_scope;
- BytecodeGeneratorHelper helper;
- Zone zone;
-
- int context = Register::current_context().index();
- int native_context_index = Context::NATIVE_CONTEXT_INDEX;
- int global_context_index = Context::EXTENSION_INDEX;
- FeedbackVectorSpec feedback_spec(&zone);
- FeedbackVectorSlot slot = feedback_spec.AddLoadICSlot();
-
- Handle<i::TypeFeedbackVector> vector =
- i::NewTypeFeedbackVector(helper.isolate(), &feedback_spec);
-
- // clang-format off
- ExpectedSnippet<InstanceType> snippets[] = {
- {"var a = {x:13, y:14};\n function f() { return delete a.x; };\n f();",
- 1 * kPointerSize,
- 1,
- 11,
- {B(StackCheck), //
- B(LdaGlobal), U8(0), U8(vector->GetIndex(slot)), //
- B(Star), R(0), //
- B(LdaConstant), U8(1), //
- B(DeletePropertySloppy), R(0), //
- B(Return)},
- 2,
- {InstanceType::ONE_BYTE_INTERNALIZED_STRING_TYPE,
- InstanceType::ONE_BYTE_INTERNALIZED_STRING_TYPE}},
- {"a = {1:13, 2:14};\n"
- "function f() {'use strict'; return delete a[1];};\n f();",
- 1 * kPointerSize,
- 1,
- 11,
- {B(StackCheck), //
- B(LdaGlobal), U8(0), U8(vector->GetIndex(slot)), //
- B(Star), R(0), //
- B(LdaSmi8), U8(1), //
- B(DeletePropertyStrict), R(0), //
- B(Return)},
- 1,
- {InstanceType::ONE_BYTE_INTERNALIZED_STRING_TYPE}},
- {"var a = {x:13, y:14};\n function f() { return delete a; };\n f();",
- 2 * kPointerSize,
- 1,
- 16,
- {B(StackCheck), //
- B(LdaContextSlot), R(context), U8(native_context_index), //
- B(Star), R(0), //
- B(LdaContextSlot), R(0), U8(global_context_index), //
- B(Star), R(1), //
- B(LdaConstant), U8(0), //
- B(DeletePropertySloppy), R(1), //
- B(Return)},
- 1,
- {InstanceType::ONE_BYTE_INTERNALIZED_STRING_TYPE}},
- {"b = 30;\n function f() { return delete b; };\n f();",
- 2 * kPointerSize,
- 1,
- 16,
- {B(StackCheck), //
- B(LdaContextSlot), R(context), U8(native_context_index), //
- B(Star), R(0), //
- B(LdaContextSlot), R(0), U8(global_context_index), //
- B(Star), R(1), //
- B(LdaConstant), U8(0), //
- B(DeletePropertySloppy), R(1), //
- B(Return)},
- 1,
- {InstanceType::ONE_BYTE_INTERNALIZED_STRING_TYPE}}
+ const char* snippets[] = {
+ "function f() {\n"
+ " var x = 13;\n"
+ " return typeof(x);\n"
+ "}; f();",
+
+ "var x = 13;\n"
+ "function f() {\n"
+ " return typeof(x);\n"
+ "}; f();",
};
- // clang-format on
- for (size_t i = 0; i < arraysize(snippets); i++) {
- Handle<BytecodeArray> bytecode_array =
- helper.MakeBytecode(snippets[i].code_snippet, "f");
- CheckBytecodeArrayEqual(snippets[i], bytecode_array);
- }
+ CHECK_EQ(BuildActual(printer, snippets, "", "\nf();"),
+ LoadGolden("Typeof.golden"));
}
+TEST(Delete) {
+ InitializedIgnitionHandleScope scope;
+ BytecodeExpectationsPrinter printer(CcTest::isolate(),
+ ConstantPoolType::kMixed);
-TEST(FunctionLiterals) {
- InitializedHandleScope handle_scope;
- BytecodeGeneratorHelper helper;
- Zone zone;
-
- FeedbackVectorSpec feedback_spec(&zone);
- FeedbackVectorSlot slot = feedback_spec.AddCallICSlot();
-
- Handle<i::TypeFeedbackVector> vector =
- i::NewTypeFeedbackVector(helper.isolate(), &feedback_spec);
-
- // clang-format off
- ExpectedSnippet<InstanceType> snippets[] = {
- {"return function(){ }",
- 0,
- 1,
- 5,
- {
- B(StackCheck), //
- B(CreateClosure), U8(0), U8(0), //
- B(Return) //
- },
- 1,
- {InstanceType::SHARED_FUNCTION_INFO_TYPE}},
- {"return (function(){ })()",
- 2 * kPointerSize,
- 1,
- 15,
- {
- B(StackCheck), //
- B(LdaUndefined), //
- B(Star), R(1), //
- B(CreateClosure), U8(0), U8(0), //
- B(Star), R(0), //
- B(Call), R(0), R(1), U8(1), U8(vector->GetIndex(slot)), //
- B(Return) //
- },
- 1,
- {InstanceType::SHARED_FUNCTION_INFO_TYPE}},
- {"return (function(x){ return x; })(1)",
- 3 * kPointerSize,
- 1,
- 19,
- {
- B(StackCheck), //
- B(LdaUndefined), //
- B(Star), R(1), //
- B(CreateClosure), U8(0), U8(0), //
- B(Star), R(0), //
- B(LdaSmi8), U8(1), //
- B(Star), R(2), //
- B(Call), R(0), R(1), U8(2), U8(vector->GetIndex(slot)), //
- B(Return) //
- },
- 1,
- {InstanceType::SHARED_FUNCTION_INFO_TYPE}},
+ const char* snippets[] = {
+ "var a = {x:13, y:14}; return delete a.x;",
+
+ "'use strict'; var a = {x:13, y:14}; return delete a.x;",
+
+ "var a = {1:13, 2:14}; return delete a[2];",
+
+ "var a = 10; return delete a;",
+
+ "'use strict';\n"
+ "var a = {1:10};\n"
+ "(function f1() {return a;});\n"
+ "return delete a[1];",
+
+ "return delete 'test';",
};
- // clang-format on
- for (size_t i = 0; i < arraysize(snippets); i++) {
- Handle<BytecodeArray> bytecode_array =
- helper.MakeBytecodeForFunctionBody(snippets[i].code_snippet);
- CheckBytecodeArrayEqual(snippets[i], bytecode_array);
- }
+ CHECK_EQ(BuildActual(printer, snippets),
+ LoadGolden("Delete.golden"));
}
+TEST(GlobalDelete) {
+ InitializedIgnitionHandleScope scope;
+ BytecodeExpectationsPrinter printer(CcTest::isolate(),
+ ConstantPoolType::kMixed);
+ printer.set_wrap(false);
+ printer.set_test_function_name("f");
+
+ const char* snippets[] = {
+ "var a = {x:13, y:14};\n"
+ "function f() {\n"
+ "return delete a.x;\n"
+ "};\n"
+ "f();",
+
+ "a = {1:13, 2:14};\n"
+ "function f() {\n"
+ "'use strict';\n"
+ "return delete a[1];\n"
+ "};\n"
+ "f();",
+
+ "var a = {x:13, y:14};\n"
+ "function f() {\n"
+ "return delete a;\n"
+ "};\n"
+ "f();",
+
+ "b = 30;\n"
+ "function f() {\n"
+ "return delete b;\n"
+ "};\n"
+ "f();",
+ };
+
+ CHECK_EQ(BuildActual(printer, snippets),
+ LoadGolden("GlobalDelete.golden"));
+}
-TEST(RegExpLiterals) {
- InitializedHandleScope handle_scope;
- BytecodeGeneratorHelper helper;
- Zone zone;
-
- FeedbackVectorSpec feedback_spec(&zone);
- FeedbackVectorSlot slot1 = feedback_spec.AddCallICSlot();
- FeedbackVectorSlot slot2 = feedback_spec.AddLoadICSlot();
- uint8_t i_flags = JSRegExp::kIgnoreCase;
-
- Handle<i::TypeFeedbackVector> vector =
- i::NewTypeFeedbackVector(helper.isolate(), &feedback_spec);
-
- // clang-format off
- ExpectedSnippet<const char*> snippets[] = {
- {"return /ab+d/;",
- 0 * kPointerSize,
- 1,
- 6,
- {
- B(StackCheck), //
- B(CreateRegExpLiteral), U8(0), U8(0), U8(0), //
- B(Return), //
- },
- 1,
- {"ab+d"}},
- {"return /(\\w+)\\s(\\w+)/i;",
- 0 * kPointerSize,
- 1,
- 6,
- {
- B(StackCheck), //
- B(CreateRegExpLiteral), U8(0), U8(0), U8(i_flags), //
- B(Return), //
- },
- 1,
- {"(\\w+)\\s(\\w+)"}},
- {"return /ab+d/.exec('abdd');",
- 3 * kPointerSize,
- 1,
- 23,
- {
- B(StackCheck), //
- B(CreateRegExpLiteral), U8(0), U8(0), U8(0), //
- B(Star), R(1), //
- B(LoadIC), R(1), U8(1), U8(vector->GetIndex(slot2)), //
- B(Star), R(0), //
- B(LdaConstant), U8(2), //
- B(Star), R(2), //
- B(Call), R(0), R(1), U8(2), U8(vector->GetIndex(slot1)), //
- B(Return), //
- },
- 3,
- {"ab+d", "exec", "abdd"}},
+TEST(FunctionLiterals) {
+ InitializedIgnitionHandleScope scope;
+ BytecodeExpectationsPrinter printer(CcTest::isolate(),
+ ConstantPoolType::kMixed);
+
+ const char* snippets[] = {
+ "return function(){ }",
+ "return (function(){ })()",
+ "return (function(x){ return x; })(1)",
};
- // clang-format on
- for (size_t i = 0; i < arraysize(snippets); i++) {
- Handle<BytecodeArray> bytecode_array =
- helper.MakeBytecodeForFunctionBody(snippets[i].code_snippet);
- CheckBytecodeArrayEqual(snippets[i], bytecode_array);
- }
+ CHECK_EQ(BuildActual(printer, snippets),
+ LoadGolden("FunctionLiterals.golden"));
}
+TEST(RegExpLiterals) {
+ InitializedIgnitionHandleScope scope;
+ BytecodeExpectationsPrinter printer(CcTest::isolate(),
+ ConstantPoolType::kString);
-TEST(RegExpLiteralsWide) {
- InitializedHandleScope handle_scope;
- BytecodeGeneratorHelper helper;
- Zone zone;
-
- int wide_idx = 0;
-
- // clang-format off
- ExpectedSnippet<InstanceType, 257> snippets[] = {
- {"var a;" REPEAT_256(SPACE, "a = 1.23;") "return /ab+d/;",
- 1 * kPointerSize,
- 1,
- 1032,
- {
- B(StackCheck), //
- REPEAT_256(COMMA, //
- B(LdaConstant), U8(wide_idx++), //
- B(Star), R(0)), //
- B(CreateRegExpLiteralWide), U16(256), U16(0), U8(0), //
- B(Return) //
- },
- 257,
- {REPEAT_256(COMMA, InstanceType::HEAP_NUMBER_TYPE),
- InstanceType::ONE_BYTE_INTERNALIZED_STRING_TYPE}},
+ const char* snippets[] = {
+ "return /ab+d/;",
+ "return /(\\w+)\\s(\\w+)/i;",
+ "return /ab+d/.exec('abdd');",
};
- // clang-format on
- for (size_t i = 0; i < arraysize(snippets); i++) {
- Handle<BytecodeArray> bytecode_array =
- helper.MakeBytecodeForFunctionBody(snippets[i].code_snippet);
- CheckBytecodeArrayEqual(snippets[i], bytecode_array);
- }
+ CHECK_EQ(BuildActual(printer, snippets),
+ LoadGolden("RegExpLiterals.golden"));
}
+TEST(RegExpLiteralsWide) {
+ InitializedIgnitionHandleScope scope;
+ BytecodeExpectationsPrinter printer(CcTest::isolate(),
+ ConstantPoolType::kMixed);
-TEST(ArrayLiterals) {
- InitializedHandleScope handle_scope;
- BytecodeGeneratorHelper helper;
- Zone zone;
-
- FeedbackVectorSpec feedback_spec(&zone);
- FeedbackVectorSlot slot1 = feedback_spec.AddKeyedStoreICSlot();
- FeedbackVectorSlot slot2 = feedback_spec.AddKeyedStoreICSlot();
- FeedbackVectorSlot slot3 = feedback_spec.AddKeyedStoreICSlot();
-
- Handle<i::TypeFeedbackVector> vector =
- i::NewTypeFeedbackVector(helper.isolate(), &feedback_spec);
-
- int simple_flags =
- ArrayLiteral::kDisableMementos | ArrayLiteral::kShallowElements;
- int deep_elements_flags = ArrayLiteral::kDisableMementos;
- // clang-format off
- ExpectedSnippet<InstanceType> snippets[] = {
- {"return [ 1, 2 ];",
- 0,
- 1,
- 6,
- {
- B(StackCheck), //
- B(CreateArrayLiteral), U8(0), U8(0), U8(simple_flags), //
- B(Return) //
- },
- 1,
- {InstanceType::FIXED_ARRAY_TYPE}},
- {"var a = 1; return [ a, a + 1 ];",
- 4 * kPointerSize,
- 1,
- 39,
- {
- B(StackCheck), //
- B(LdaSmi8), U8(1), //
- B(Star), R(0), //
- B(CreateArrayLiteral), U8(0), U8(0), U8(3), //
- B(Star), R(2), //
- B(LdaZero), //
- B(Star), R(1), //
- B(Ldar), R(0), //
- B(KeyedStoreICSloppy), R(2), R(1), U8(vector->GetIndex(slot1)), //
- B(LdaSmi8), U8(1), //
- B(Star), R(1), //
- B(Ldar), R(0), //
- B(Star), R(3), //
- B(LdaSmi8), U8(1), //
- B(Add), R(3), //
- B(KeyedStoreICSloppy), R(2), R(1), U8(vector->GetIndex(slot1)), //
- B(Ldar), R(2), //
- B(Return), //
- },
- 1,
- {InstanceType::FIXED_ARRAY_TYPE}},
- {"return [ [ 1, 2 ], [ 3 ] ];",
- 0,
- 1,
- 6,
- {
- B(StackCheck), //
- B(CreateArrayLiteral), U8(0), U8(2), U8(deep_elements_flags), //
- B(Return) //
- },
- 1,
- {InstanceType::FIXED_ARRAY_TYPE}},
- {"var a = 1; return [ [ a, 2 ], [ a + 2 ] ];",
- 6 * kPointerSize,
- 1,
- 69,
- {
- B(StackCheck), //
- B(LdaSmi8), U8(1), //
- B(Star), R(0), //
- B(CreateArrayLiteral), U8(0), U8(2), U8(deep_elements_flags), //
- B(Star), R(2), //
- B(LdaZero), //
- B(Star), R(1), //
- B(CreateArrayLiteral), U8(1), U8(0), U8(simple_flags), //
- B(Star), R(4), //
- B(LdaZero), //
- B(Star), R(3), //
- B(Ldar), R(0), //
- B(KeyedStoreICSloppy), R(4), R(3), U8(vector->GetIndex(slot1)), //
- B(Ldar), R(4), //
- B(KeyedStoreICSloppy), R(2), R(1), U8(vector->GetIndex(slot3)), //
- B(LdaSmi8), U8(1), //
- B(Star), R(1), //
- B(CreateArrayLiteral), U8(2), U8(1), U8(simple_flags), //
- B(Star), R(4), //
- B(LdaZero), //
- B(Star), R(3), //
- B(Ldar), R(0), //
- B(Star), R(5), //
- B(LdaSmi8), U8(2), //
- B(Add), R(5), //
- B(KeyedStoreICSloppy), R(4), R(3), U8(vector->GetIndex(slot2)), //
- B(Ldar), R(4), //
- B(KeyedStoreICSloppy), R(2), R(1), U8(vector->GetIndex(slot3)), //
- B(Ldar), R(2), //
- B(Return), //
- },
- 3,
- {InstanceType::FIXED_ARRAY_TYPE, InstanceType::FIXED_ARRAY_TYPE,
- InstanceType::FIXED_ARRAY_TYPE}},
+ const char* snippets[] = {
+ "var a;" REPEAT_256(SPACE, "\na = 1.23;") "return /ab+d/;",
};
- // clang-format on
- for (size_t i = 0; i < arraysize(snippets); i++) {
- Handle<BytecodeArray> bytecode_array =
- helper.MakeBytecodeForFunctionBody(snippets[i].code_snippet);
- CheckBytecodeArrayEqual(snippets[i], bytecode_array);
- }
+ CHECK_EQ(BuildActual(printer, snippets),
+ LoadGolden("RegExpLiteralsWide.golden"));
}
+TEST(ArrayLiterals) {
+ InitializedIgnitionHandleScope scope;
+ BytecodeExpectationsPrinter printer(CcTest::isolate(),
+ ConstantPoolType::kMixed);
-TEST(ArrayLiteralsWide) {
- InitializedHandleScope handle_scope;
- BytecodeGeneratorHelper helper;
- Zone zone;
-
- int wide_idx = 0;
- int simple_flags =
- ArrayLiteral::kDisableMementos | ArrayLiteral::kShallowElements;
-
- // clang-format off
- ExpectedSnippet<InstanceType, 257> snippets[] = {
- {"var a;" REPEAT_256(SPACE, "a = 1.23;") "return [ 1 , 2 ];",
- 1 * kPointerSize,
- 1,
- 1032,
- {
- B(StackCheck), //
- REPEAT_256(COMMA, //
- B(LdaConstant), U8(wide_idx++), //
- B(Star), R(0)), //
- B(CreateArrayLiteralWide), U16(256), U16(0), U8(simple_flags), //
- B(Return) //
- },
- 257,
- {REPEAT_256(COMMA, InstanceType::HEAP_NUMBER_TYPE),
- InstanceType::FIXED_ARRAY_TYPE}},
+ const char* snippets[] = {
+ "return [ 1, 2 ];",
+ "var a = 1; return [ a, a + 1 ];",
+ "return [ [ 1, 2 ], [ 3 ] ];",
+ "var a = 1; return [ [ a, 2 ], [ a + 2 ] ];",
};
- // clang-format on
- for (size_t i = 0; i < arraysize(snippets); i++) {
- Handle<BytecodeArray> bytecode_array =
- helper.MakeBytecodeForFunctionBody(snippets[i].code_snippet);
- CheckBytecodeArrayEqual(snippets[i], bytecode_array);
- }
+ CHECK_EQ(BuildActual(printer, snippets),
+ LoadGolden("ArrayLiterals.golden"));
}
+TEST(ArrayLiteralsWide) {
+ InitializedIgnitionHandleScope scope;
+ BytecodeExpectationsPrinter printer(CcTest::isolate(),
+ ConstantPoolType::kMixed);
-TEST(ObjectLiterals) {
- InitializedHandleScope handle_scope;
- BytecodeGeneratorHelper helper;
- Zone zone;
-
- FeedbackVectorSpec feedback_spec(&zone);
- FeedbackVectorSlot slot1 = feedback_spec.AddStoreICSlot();
-
- Handle<i::TypeFeedbackVector> vector =
- i::NewTypeFeedbackVector(helper.isolate(), &feedback_spec);
-
- int simple_flags = ObjectLiteral::kFastElements |
- ObjectLiteral::kShallowProperties |
- ObjectLiteral::kDisableMementos;
- int deep_elements_flags =
- ObjectLiteral::kFastElements | ObjectLiteral::kDisableMementos;
-
- // clang-format off
- ExpectedSnippet<InstanceType> snippets[] = {
- {"return { };",
- kPointerSize,
- 1,
- 8,
- {
- B(StackCheck), //
- B(CreateObjectLiteral), U8(0), U8(0), U8(simple_flags), //
- B(Star), R(0), //
- B(Return) //
- },
- 1,
- {InstanceType::FIXED_ARRAY_TYPE}},
- {"return { name: 'string', val: 9.2 };",
- kPointerSize,
- 1,
- 8,
- {
- B(StackCheck), //
- B(CreateObjectLiteral), U8(0), U8(0), U8(deep_elements_flags), //
- B(Star), R(0), //
- B(Return) //
- },
- 1,
- {InstanceType::FIXED_ARRAY_TYPE}},
- {"var a = 1; return { name: 'string', val: a };",
- 2 * kPointerSize,
- 1,
- 20,
- {
- B(StackCheck), //
- B(LdaSmi8), U8(1), //
- B(Star), R(0), //
- B(CreateObjectLiteral), U8(0), U8(0), U8(deep_elements_flags), //
- B(Star), R(1), //
- B(Ldar), R(0), //
- B(StoreICSloppy), R(1), U8(1), U8(vector->GetIndex(slot1)), //
- B(Ldar), R(1), //
- B(Return), //
- },
- 2,
- {InstanceType::FIXED_ARRAY_TYPE,
- InstanceType::ONE_BYTE_INTERNALIZED_STRING_TYPE}},
- {"var a = 1; return { val: a, val: a + 1 };",
- 3 * kPointerSize,
- 1,
- 26,
- {
- B(StackCheck), //
- B(LdaSmi8), U8(1), //
- B(Star), R(0), //
- B(CreateObjectLiteral), U8(0), U8(0), U8(deep_elements_flags), //
- B(Star), R(1), //
- B(Ldar), R(0), //
- B(Star), R(2), //
- B(LdaSmi8), U8(1), //
- B(Add), R(2), //
- B(StoreICSloppy), R(1), U8(1), U8(vector->GetIndex(slot1)), //
- B(Ldar), R(1), //
- B(Return), //
- },
- 2,
- {InstanceType::FIXED_ARRAY_TYPE,
- InstanceType::ONE_BYTE_INTERNALIZED_STRING_TYPE}},
- {"return { func: function() { } };",
- 1 * kPointerSize,
- 1,
- 17,
- {
- B(StackCheck), //
- B(CreateObjectLiteral), U8(0), U8(0), U8(deep_elements_flags), //
- B(Star), R(0), //
- B(CreateClosure), U8(1), U8(0), //
- B(StoreICSloppy), R(0), U8(2), U8(vector->GetIndex(slot1)), //
- B(Ldar), R(0), //
- B(Return), //
- },
- 3,
- {InstanceType::FIXED_ARRAY_TYPE, InstanceType::SHARED_FUNCTION_INFO_TYPE,
- InstanceType::ONE_BYTE_INTERNALIZED_STRING_TYPE}},
- {"return { func(a) { return a; } };",
- 1 * kPointerSize,
- 1,
- 17,
- {
- B(StackCheck), //
- B(CreateObjectLiteral), U8(0), U8(0), U8(deep_elements_flags), //
- B(Star), R(0), //
- B(CreateClosure), U8(1), U8(0), //
- B(StoreICSloppy), R(0), U8(2), U8(vector->GetIndex(slot1)), //
- B(Ldar), R(0), //
- B(Return), //
- },
- 3,
- {InstanceType::FIXED_ARRAY_TYPE, InstanceType::SHARED_FUNCTION_INFO_TYPE,
- InstanceType::ONE_BYTE_INTERNALIZED_STRING_TYPE}},
- {"return { get a() { return 2; } };",
- 6 * kPointerSize,
- 1,
- 33,
- {
- B(StackCheck), //
- B(CreateObjectLiteral), U8(0), U8(0), U8(deep_elements_flags), //
- B(Star), R(0), //
- B(Mov), R(0), R(1), //
- B(LdaConstant), U8(1), //
- B(Star), R(2), //
- B(CreateClosure), U8(2), U8(0), //
- B(Star), R(3), //
- B(LdaNull), //
- B(Star), R(4), //
- B(LdaZero), //
- B(Star), R(5), //
- B(CallRuntime), U16(Runtime::kDefineAccessorPropertyUnchecked), //
- /* */ R(1), U8(5), //
- B(Ldar), R(0), //
- B(Return), //
- },
- 3,
- {InstanceType::FIXED_ARRAY_TYPE,
- InstanceType::ONE_BYTE_INTERNALIZED_STRING_TYPE,
- InstanceType::SHARED_FUNCTION_INFO_TYPE}},
- {"return { get a() { return this.x; }, set a(val) { this.x = val } };",
- 6 * kPointerSize,
- 1,
- 35,
- {
- B(StackCheck), //
- B(CreateObjectLiteral), U8(0), U8(0), U8(deep_elements_flags), //
- B(Star), R(0), //
- B(Mov), R(0), R(1), //
- B(LdaConstant), U8(1), //
- B(Star), R(2), //
- B(CreateClosure), U8(2), U8(0), //
- B(Star), R(3), //
- B(CreateClosure), U8(3), U8(0), //
- B(Star), R(4), //
- B(LdaZero), //
- B(Star), R(5), //
- B(CallRuntime), U16(Runtime::kDefineAccessorPropertyUnchecked), //
- /* */ R(1), U8(5), //
- B(Ldar), R(0), //
- B(Return), //
- },
- 4,
- {InstanceType::FIXED_ARRAY_TYPE,
- InstanceType::ONE_BYTE_INTERNALIZED_STRING_TYPE,
- InstanceType::SHARED_FUNCTION_INFO_TYPE,
- InstanceType::SHARED_FUNCTION_INFO_TYPE}},
- {"return { set b(val) { this.y = val } };",
- 6 * kPointerSize,
- 1,
- 33,
- {
- B(StackCheck), //
- B(CreateObjectLiteral), U8(0), U8(0), U8(deep_elements_flags), //
- B(Star), R(0), //
- B(Mov), R(0), R(1), //
- B(LdaConstant), U8(1), //
- B(Star), R(2), //
- B(LdaNull), //
- B(Star), R(3), //
- B(CreateClosure), U8(2), U8(0), //
- B(Star), R(4), //
- B(LdaZero), //
- B(Star), R(5), //
- B(CallRuntime), U16(Runtime::kDefineAccessorPropertyUnchecked), //
- /* */ R(1), U8(5), //
- B(Ldar), R(0), //
- B(Return), //
- },
- 3,
- {InstanceType::FIXED_ARRAY_TYPE,
- InstanceType::ONE_BYTE_INTERNALIZED_STRING_TYPE,
- InstanceType::SHARED_FUNCTION_INFO_TYPE}},
- {"var a = 1; return { 1: a };",
- 6 * kPointerSize,
- 1,
- 33,
- {
- B(StackCheck), //
- B(LdaSmi8), U8(1), //
- B(Star), R(0), //
- B(CreateObjectLiteral), U8(0), U8(0), U8(deep_elements_flags), //
- B(Star), R(1), //
- B(Mov), R(1), R(2), //
- B(LdaSmi8), U8(1), //
- B(Star), R(3), //
- B(Ldar), R(0), //
- B(Star), R(4), //
- B(LdaZero), //
- B(Star), R(5), //
- B(CallRuntime), U16(Runtime::kSetProperty), R(2), U8(4), //
- B(Ldar), R(1), //
- B(Return), //
- },
- 1,
- {InstanceType::FIXED_ARRAY_TYPE}},
- {"return { __proto__: null }",
- 3 * kPointerSize,
- 1,
- 21,
- {
- B(StackCheck), //
- B(CreateObjectLiteral), U8(0), U8(0), U8(simple_flags), //
- B(Star), R(0), //
- B(Mov), R(0), R(1), //
- B(LdaNull), B(Star), R(2), //
- B(CallRuntime), U16(Runtime::kInternalSetPrototype), R(1), U8(2), //
- B(Ldar), R(0), //
- B(Return), //
- },
- 1,
- {InstanceType::FIXED_ARRAY_TYPE}},
- {"var a = 'test'; return { [a]: 1 }",
- 7 * kPointerSize,
- 1,
- 37,
- {
- B(StackCheck), //
- B(LdaConstant), U8(0), //
- B(Star), R(0), //
- B(CreateObjectLiteral), U8(1), U8(0), U8(simple_flags), //
- B(Star), R(1), //
- B(Mov), R(1), R(2), //
- B(Ldar), R(0), //
- B(ToName), //
- B(Star), R(3), //
- B(LdaSmi8), U8(1), //
- B(Star), R(4), //
- B(LdaZero), //
- B(Star), R(5), //
- B(LdaZero), //
- B(Star), R(6), //
- B(CallRuntime), U16(Runtime::kDefineDataPropertyInLiteral), R(2), //
- /* */ U8(5), //
- B(Ldar), R(1), //
- B(Return), //
- },
- 2,
- {InstanceType::ONE_BYTE_INTERNALIZED_STRING_TYPE,
- InstanceType::FIXED_ARRAY_TYPE}},
- {"var a = 'test'; return { val: a, [a]: 1 }",
- 7 * kPointerSize,
- 1,
- 43,
- {
- B(StackCheck), //
- B(LdaConstant), U8(0), //
- B(Star), R(0), //
- B(CreateObjectLiteral), U8(1), U8(0), U8(deep_elements_flags), //
- B(Star), R(1), //
- B(Ldar), R(0), //
- B(StoreICSloppy), R(1), U8(2), U8(vector->GetIndex(slot1)), //
- B(Mov), R(1), R(2), //
- B(Ldar), R(0), //
- B(ToName), //
- B(Star), R(3), //
- B(LdaSmi8), U8(1), //
- B(Star), R(4), //
- B(LdaZero), //
- B(Star), R(5), //
- B(LdaZero), //
- B(Star), R(6), //
- B(CallRuntime), U16(Runtime::kDefineDataPropertyInLiteral), R(2), //
- /* */ U8(5), //
- B(Ldar), R(1), //
- B(Return), //
- },
- 3,
- {InstanceType::ONE_BYTE_INTERNALIZED_STRING_TYPE,
- InstanceType::FIXED_ARRAY_TYPE,
- InstanceType::ONE_BYTE_INTERNALIZED_STRING_TYPE}},
- {"var a = 'test'; return { [a]: 1, __proto__: {} }",
- 7 * kPointerSize,
- 1,
- 53,
- {
- B(StackCheck), //
- B(LdaConstant), U8(0), //
- B(Star), R(0), //
- B(CreateObjectLiteral), U8(1), U8(1), U8(simple_flags), //
- B(Star), R(1), //
- B(Mov), R(1), R(2), //
- B(Ldar), R(0), //
- B(ToName), //
- B(Star), R(3), //
- B(LdaSmi8), U8(1), //
- B(Star), R(4), //
- B(LdaZero), //
- B(Star), R(5), //
- B(LdaZero), //
- B(Star), R(6), //
- B(CallRuntime), U16(Runtime::kDefineDataPropertyInLiteral), R(2), //
- /* */ U8(5), //
- B(Mov), R(1), R(2), //
- B(CreateObjectLiteral), U8(1), U8(0), U8(13), //
- B(Star), R(4), //
- B(Star), R(3), //
- B(CallRuntime), U16(Runtime::kInternalSetPrototype), R(2), U8(2), //
- B(Ldar), R(1), //
- B(Return), //
- },
- 2,
- {InstanceType::ONE_BYTE_INTERNALIZED_STRING_TYPE,
- InstanceType::FIXED_ARRAY_TYPE}},
- {"var n = 'name'; return { [n]: 'val', get a() { }, set a(b) {} };",
- 7 * kPointerSize,
- 1,
- 77,
- {
- B(StackCheck), //
- B(LdaConstant), U8(0), //
- B(Star), R(0), //
- B(CreateObjectLiteral), U8(1), U8(0), U8(simple_flags), //
- B(Star), R(1), //
- B(Mov), R(1), R(2), //
- B(Ldar), R(0), //
- B(ToName), //
- B(Star), R(3), //
- B(LdaConstant), U8(2), //
- B(Star), R(4), //
- B(LdaZero), //
- B(Star), R(5), //
- B(LdaZero), //
- B(Star), R(6), //
- B(CallRuntime), U16(Runtime::kDefineDataPropertyInLiteral), R(2), //
- /* */ U8(5), //
- B(Mov), R(1), R(2), //
- B(LdaConstant), U8(3), //
- B(Star), R(3), //
- B(CreateClosure), U8(4), U8(0), //
- B(Star), R(4), //
- B(LdaZero), //
- B(Star), R(5), //
- B(CallRuntime), U16(Runtime::kDefineGetterPropertyUnchecked), //
- /* */ R(2), U8(4), //
- B(Mov), R(1), R(2), //
- B(LdaConstant), U8(3), //
- B(Star), R(3), //
- B(CreateClosure), U8(5), U8(0), //
- B(Star), R(4), //
- B(LdaZero), //
- B(Star), R(5), //
- B(CallRuntime), U16(Runtime::kDefineSetterPropertyUnchecked), //
- /* */ R(2), U8(4), //
- B(Ldar), R(1), //
- B(Return), //
- },
- 6,
- {InstanceType::ONE_BYTE_INTERNALIZED_STRING_TYPE,
- InstanceType::FIXED_ARRAY_TYPE,
- InstanceType::ONE_BYTE_INTERNALIZED_STRING_TYPE,
- InstanceType::ONE_BYTE_INTERNALIZED_STRING_TYPE,
- InstanceType::SHARED_FUNCTION_INFO_TYPE,
- InstanceType::SHARED_FUNCTION_INFO_TYPE}},
+ const char* snippets[] = {
+ "var a;" REPEAT_256(SPACE, "\na = 1.23;") "return [ 1 , 2 ];",
};
- // clang-format on
- for (size_t i = 0; i < arraysize(snippets); i++) {
- Handle<BytecodeArray> bytecode_array =
- helper.MakeBytecodeForFunctionBody(snippets[i].code_snippet);
- CheckBytecodeArrayEqual(snippets[i], bytecode_array);
- }
+ CHECK_EQ(BuildActual(printer, snippets),
+ LoadGolden("ArrayLiteralsWide.golden"));
}
+TEST(ObjectLiterals) {
+ InitializedIgnitionHandleScope scope;
+ BytecodeExpectationsPrinter printer(CcTest::isolate(),
+ ConstantPoolType::kMixed);
+
+ const char* snippets[] = {
+ "return { };",
+ "return { name: 'string', val: 9.2 };",
+ "var a = 1; return { name: 'string', val: a };",
+ "var a = 1; return { val: a, val: a + 1 };",
+ "return { func: function() { } };",
+ "return { func(a) { return a; } };",
+ "return { get a() { return 2; } };",
+ "return { get a() { return this.x; }, set a(val) { this.x = val } };",
+ "return { set b(val) { this.y = val } };",
+ "var a = 1; return { 1: a };",
+ "return { __proto__: null }",
+ "var a = 'test'; return { [a]: 1 }",
+ "var a = 'test'; return { val: a, [a]: 1 }",
+ "var a = 'test'; return { [a]: 1, __proto__: {} }",
+ "var n = 'name'; return { [n]: 'val', get a() { }, set a(b) {} };",
+ };
+
+ CHECK_EQ(BuildActual(printer, snippets),
+ LoadGolden("ObjectLiterals.golden"));
+}
TEST(ObjectLiteralsWide) {
- InitializedHandleScope handle_scope;
- BytecodeGeneratorHelper helper;
- Zone zone;
-
- int deep_elements_flags =
- ObjectLiteral::kFastElements | ObjectLiteral::kDisableMementos;
- int wide_idx = 0;
-
- // clang-format off
- ExpectedSnippet<InstanceType, 257> snippets[] = {
- {"var a;" REPEAT_256(SPACE,
- "a = 1.23;") "return { name: 'string', val: 9.2 };",
- 2 * kPointerSize,
- 1,
- 1034,
- {
- B(StackCheck), //
- REPEAT_256(COMMA, //
- B(LdaConstant), U8(wide_idx++), //
- B(Star), R(0)), //
- B(CreateObjectLiteralWide), U16(256), U16(0), //
- /* */ U8(deep_elements_flags), //
- B(Star), R(1), //
- B(Return) //
- },
- 257,
- {REPEAT_256(COMMA, InstanceType::HEAP_NUMBER_TYPE),
- InstanceType::FIXED_ARRAY_TYPE}},
+ InitializedIgnitionHandleScope scope;
+ BytecodeExpectationsPrinter printer(CcTest::isolate(),
+ ConstantPoolType::kMixed);
+ const char* snippets[] = {
+ "var a;" REPEAT_256(SPACE, "\na = 1.23;")
+ "return { name: 'string', val: 9.2 };",
};
- // clang-format on
- for (size_t i = 0; i < arraysize(snippets); i++) {
- Handle<BytecodeArray> bytecode_array =
- helper.MakeBytecodeForFunctionBody(snippets[i].code_snippet);
- CheckBytecodeArrayEqual(snippets[i], bytecode_array);
- }
+ CHECK_EQ(BuildActual(printer, snippets),
+ LoadGolden("ObjectLiteralsWide.golden"));
}
-
TEST(TopLevelObjectLiterals) {
- InitializedHandleScope handle_scope;
- BytecodeGeneratorHelper helper;
-
- int has_function_flags = ObjectLiteral::kFastElements |
- ObjectLiteral::kHasFunction |
- ObjectLiteral::kDisableMementos;
- // clang-format off
- ExpectedSnippet<InstanceType> snippets[] = {
- {"var a = { func: function() { } };",
- 5 * kPointerSize,
- 1,
- 49,
- {
- B(LdaConstant), U8(0), //
- B(Star), R(1), //
- B(LdaZero), //
- B(Star), R(2), //
- B(CallRuntime), U16(Runtime::kDeclareGlobals), R(1), U8(2), //
- B(StackCheck), //
- B(LdaConstant), U8(1), //
- B(Star), R(1), //
- B(LdaZero), //
- B(Star), R(2), //
- B(CreateObjectLiteral), U8(2), U8(0), U8(has_function_flags), //
- B(Star), R(4), //
- B(CreateClosure), U8(3), U8(1), //
- B(StoreICSloppy), R(4), U8(4), U8(3), //
- B(CallRuntime), U16(Runtime::kToFastProperties), R(4), U8(1), //
- B(Ldar), R(4), //
- B(Star), R(3), //
- B(CallRuntime), U16(Runtime::kInitializeVarGlobal), R(1), U8(3), //
- B(LdaUndefined), //
- B(Return), //
- },
- 5,
- {InstanceType::FIXED_ARRAY_TYPE,
- InstanceType::ONE_BYTE_INTERNALIZED_STRING_TYPE,
- InstanceType::FIXED_ARRAY_TYPE,
- InstanceType::SHARED_FUNCTION_INFO_TYPE,
- InstanceType::ONE_BYTE_INTERNALIZED_STRING_TYPE}},
+ InitializedIgnitionHandleScope scope;
+ BytecodeExpectationsPrinter printer(CcTest::isolate(),
+ ConstantPoolType::kMixed);
+ printer.set_wrap(false);
+ printer.set_test_function_name("f");
+ printer.set_execute(false);
+ printer.set_top_level(true);
+
+ const char* snippets[] = {
+ "var a = { func: function() { } };",
};
- // clang-format on
- for (size_t i = 0; i < arraysize(snippets); i++) {
- Handle<BytecodeArray> bytecode_array =
- helper.MakeTopLevelBytecode(snippets[i].code_snippet);
- CheckBytecodeArrayEqual(snippets[i], bytecode_array);
- }
+ CHECK_EQ(BuildActual(printer, snippets),
+ LoadGolden("TopLevelObjectLiterals.golden"));
}
-
TEST(TryCatch) {
- InitializedHandleScope handle_scope;
- BytecodeGeneratorHelper helper;
-
- int closure = Register::function_closure().index();
- int context = Register::current_context().index();
-
- // clang-format off
- ExpectedSnippet<const char*> snippets[] = {
- {"try { return 1; } catch(e) { return 2; }",
- 5 * kPointerSize,
- 1,
- 40,
- {
- B(StackCheck), //
- B(Mov), R(context), R(1), //
- B(LdaSmi8), U8(1), //
- B(Return), //
- B(Star), R(3), //
- B(LdaConstant), U8(0), //
- B(Star), R(2), //
- B(Ldar), R(closure), //
- B(Star), R(4), //
- B(CallRuntime), U16(Runtime::kPushCatchContext), R(2), U8(3), //
- B(Star), R(1), //
- B(CallRuntime), U16(Runtime::kInterpreterClearPendingMessage), //
- /* */ R(0), U8(0), //
- B(Ldar), R(1), //
- B(PushContext), R(0), //
- B(LdaSmi8), U8(2), //
- B(PopContext), R(0), //
- B(Return), //
- // TODO(mstarzinger): Potential optimization, elide next bytes.
- B(LdaUndefined), //
- B(Return), //
- },
- 1,
- {"e"},
- 1,
- {{4, 7, 7}}},
- {"var a; try { a = 1 } catch(e1) {}; try { a = 2 } catch(e2) { a = 3 }",
- 6 * kPointerSize,
- 1,
- 81,
- {
- B(StackCheck), //
- B(Mov), R(context), R(2), //
- B(LdaSmi8), U8(1), //
- B(Star), R(0), //
- B(Jump), U8(30), //
- B(Star), R(4), //
- B(LdaConstant), U8(0), //
- B(Star), R(3), //
- B(Ldar), R(closure), //
- B(Star), R(5), //
- B(CallRuntime), U16(Runtime::kPushCatchContext), R(3), U8(3), //
- B(Star), R(2), //
- B(CallRuntime), U16(Runtime::kInterpreterClearPendingMessage), //
- /* */ R(0), U8(0), //
- B(Ldar), R(2), //
- B(PushContext), R(1), //
- B(PopContext), R(1), //
- B(Mov), R(context), R(2), //
- B(LdaSmi8), U8(2), //
- B(Star), R(0), //
- B(Jump), U8(34), //
- B(Star), R(4), //
- B(LdaConstant), U8(1), //
- B(Star), R(3), //
- B(Ldar), R(closure), //
- B(Star), R(5), //
- B(CallRuntime), U16(Runtime::kPushCatchContext), R(3), U8(3), //
- B(Star), R(2), //
- B(CallRuntime), U16(Runtime::kInterpreterClearPendingMessage), //
- /* */ R(0), U8(0), //
- B(Ldar), R(2), //
- B(PushContext), R(1), //
- B(LdaSmi8), U8(3), //
- B(Star), R(0), //
- B(PopContext), R(1), //
- B(LdaUndefined), //
- B(Return), //
- },
- 2,
- {"e1", "e2"},
- 2,
- {{4, 8, 10}, {41, 45, 47}}},
+ InitializedIgnitionHandleScope scope;
+ BytecodeExpectationsPrinter printer(CcTest::isolate(),
+ ConstantPoolType::kString);
+
+ const char* snippets[] = {
+ "try { return 1; } catch(e) { return 2; }",
+ "var a;\n"
+ "try { a = 1 } catch(e1) {};\n"
+ "try { a = 2 } catch(e2) { a = 3 }",
};
- // clang-format on
- for (size_t i = 0; i < arraysize(snippets); i++) {
- Handle<BytecodeArray> bytecode_array =
- helper.MakeBytecodeForFunctionBody(snippets[i].code_snippet);
- CheckBytecodeArrayEqual(snippets[i], bytecode_array);
- }
+ CHECK_EQ(BuildActual(printer, snippets),
+ LoadGolden("TryCatch.golden"));
}
-
TEST(TryFinally) {
- InitializedHandleScope handle_scope;
- BytecodeGeneratorHelper helper;
-
- int closure = Register::function_closure().index();
- int context = Register::current_context().index();
-
- // clang-format off
- ExpectedSnippet<const char*> snippets[] = {
- {"var a = 1; try { a = 2; } finally { a = 3; }",
- 4 * kPointerSize,
- 1,
- 51,
- {
- B(StackCheck), //
- B(LdaSmi8), U8(1), //
- B(Star), R(0), //
- B(Mov), R(context), R(3), //
- B(LdaSmi8), U8(2), //
- B(Star), R(0), //
- B(LdaSmi8), U8(-1), //
- B(Star), R(1), //
- B(Jump), U8(7), //
- B(Star), R(2), //
- B(LdaZero), //
- B(Star), R(1), //
- B(CallRuntime), U16(Runtime::kInterpreterClearPendingMessage), //
- /* */ R(0), U8(0), //
- B(Star), R(3), //
- B(LdaSmi8), U8(3), //
- B(Star), R(0), //
- B(CallRuntime), U16(Runtime::kInterpreterSetPendingMessage), //
- /* */ R(3), U8(1), //
- B(LdaZero), //
- B(TestEqualStrict), R(1), //
- B(JumpIfTrue), U8(4), //
- B(Jump), U8(5), //
- B(Ldar), R(2), //
- B(ReThrow), //
- B(LdaUndefined), //
- B(Return), //
- },
- 0,
- {},
- 1,
- {{8, 12, 18}}},
- {"var a = 1; try { a = 2; } catch(e) { a = 20 } finally { a = 3; }",
- 9 * kPointerSize,
- 1,
- 88,
- {
- B(StackCheck), //
- B(LdaSmi8), U8(1), //
- B(Star), R(0), //
- B(Mov), R(context), R(4), //
- B(Mov), R(context), R(5), //
- B(LdaSmi8), U8(2), //
- B(Star), R(0), //
- B(Jump), U8(34), //
- B(Star), R(7), //
- B(LdaConstant), U8(0), //
- B(Star), R(6), //
- B(Ldar), R(closure), //
- B(Star), R(8), //
- B(CallRuntime), U16(Runtime::kPushCatchContext), R(6), U8(3), //
- B(Star), R(5), //
- B(CallRuntime), U16(Runtime::kInterpreterClearPendingMessage), //
- /* */ R(0), U8(0), //
- B(Ldar), R(5), //
- B(PushContext), R(1), //
- B(LdaSmi8), U8(20), //
- B(Star), R(0), //
- B(PopContext), R(1), //
- B(LdaSmi8), U8(-1), //
- B(Star), R(2), //
- B(Jump), U8(7), //
- B(Star), R(3), //
- B(LdaZero), //
- B(Star), R(2), //
- B(CallRuntime), U16(Runtime::kInterpreterClearPendingMessage), //
- /* */ R(0), U8(0), //
- B(Star), R(4), //
- B(LdaSmi8), U8(3), //
- B(Star), R(0), //
- B(CallRuntime), U16(Runtime::kInterpreterSetPendingMessage), //
- /* */ R(4), U8(1), //
- B(LdaZero), //
- B(TestEqualStrict), R(2), //
- B(JumpIfTrue), U8(4), //
- B(Jump), U8(5), //
- B(Ldar), R(3), //
- B(ReThrow), //
- B(LdaUndefined), //
- B(Return), //
- },
- 1,
- {"e"},
- 2,
- {{8, 49, 55}, {11, 15, 17}}},
- {"var a; try {"
- " try { a = 1 } catch(e) { a = 2 }"
- "} catch(e) { a = 20 } finally { a = 3; }",
- 10 * kPointerSize,
- 1,
- 121,
- {
- B(StackCheck), //
- B(Mov), R(context), R(4), //
- B(Mov), R(context), R(5), //
- B(Mov), R(context), R(6), //
- B(LdaSmi8), U8(1), //
- B(Star), R(0), //
- B(Jump), U8(34), //
- B(Star), R(8), //
- B(LdaConstant), U8(0), //
- B(Star), R(7), //
- B(Ldar), R(closure), //
- B(Star), R(9), //
- B(CallRuntime), U16(Runtime::kPushCatchContext), R(7), U8(3), //
- B(Star), R(6), //
- B(CallRuntime), U16(Runtime::kInterpreterClearPendingMessage), //
- /* */ R(0), U8(0), //
- B(Ldar), R(6), //
- B(PushContext), R(1), //
- B(LdaSmi8), U8(2), //
- B(Star), R(0), //
- B(PopContext), R(1), //
- B(Jump), U8(34), //
- B(Star), R(7), //
- B(LdaConstant), U8(0), //
- B(Star), R(6), //
- B(Ldar), R(closure), //
- B(Star), R(8), //
- B(CallRuntime), U16(Runtime::kPushCatchContext), R(6), U8(3), //
- B(Star), R(5), //
- B(CallRuntime), U16(Runtime::kInterpreterClearPendingMessage), //
- /* */ R(0), U8(0), //
- B(Ldar), R(5), //
- B(PushContext), R(1), //
- B(LdaSmi8), U8(20), //
- B(Star), R(0), //
- B(PopContext), R(1), //
- B(LdaSmi8), U8(-1), //
- B(Star), R(2), //
- B(Jump), U8(7), //
- B(Star), R(3), //
- B(LdaZero), //
- B(Star), R(2), //
- B(CallRuntime), U16(Runtime::kInterpreterClearPendingMessage), //
- /* */ R(0), U8(0), //
- B(Star), R(4), //
- B(LdaSmi8), U8(3), //
- B(Star), R(0), //
- B(CallRuntime), U16(Runtime::kInterpreterSetPendingMessage), //
- /* */ R(4), U8(1), //
- B(LdaZero), //
- B(TestEqualStrict), R(2), //
- B(JumpIfTrue), U8(4), //
- B(Jump), U8(5), //
- B(Ldar), R(3), //
- B(ReThrow), //
- B(LdaUndefined), //
- B(Return), //
- },
- 1,
- {"e"},
- 3,
- {{4, 82, 88}, {7, 48, 50}, {10, 14, 16}}},
+ InitializedIgnitionHandleScope scope;
+ BytecodeExpectationsPrinter printer(CcTest::isolate(),
+ ConstantPoolType::kString);
+ const char* snippets[] = {
+ "var a = 1;\n"
+ "try { a = 2; } finally { a = 3; }",
+ "var a = 1;\n"
+ "try { a = 2; } catch(e) { a = 20 } finally { a = 3; }",
+ "var a; try {\n"
+ " try { a = 1 } catch(e) { a = 2 }\n"
+ "} catch(e) { a = 20 } finally { a = 3; }",
};
- // clang-format on
- for (size_t i = 0; i < arraysize(snippets); i++) {
- Handle<BytecodeArray> bytecode_array =
- helper.MakeBytecodeForFunctionBody(snippets[i].code_snippet);
- CheckBytecodeArrayEqual(snippets[i], bytecode_array);
- }
+ CHECK_EQ(BuildActual(printer, snippets),
+ LoadGolden("TryFinally.golden"));
}
-
TEST(Throw) {
- InitializedHandleScope handle_scope;
- BytecodeGeneratorHelper helper;
-
- // clang-format off
- ExpectedSnippet<const char*> snippets[] = {
- {"throw 1;",
- 0,
- 1,
- 4,
- {
- B(StackCheck), //
- B(LdaSmi8), U8(1), //
- B(Throw), //
- },
- 0},
- {"throw 'Error';",
- 0,
- 1,
- 4,
- {
- B(StackCheck), //
- B(LdaConstant), U8(0), //
- B(Throw), //
- },
- 1,
- {"Error"}},
- {"var a = 1; if (a) { throw 'Error'; };",
- 1 * kPointerSize,
- 1,
- 12,
- {
- B(StackCheck), //
- B(LdaSmi8), U8(1), //
- B(Star), R(0), //
- B(JumpIfToBooleanFalse), U8(5), //
- B(LdaConstant), U8(0), //
- B(Throw), //
- B(LdaUndefined), //
- B(Return), //
- },
- 1,
- {"Error"}},
+ InitializedIgnitionHandleScope scope;
+ BytecodeExpectationsPrinter printer(CcTest::isolate(),
+ ConstantPoolType::kString);
+ const char* snippets[] = {
+ "throw 1;",
+ "throw 'Error';",
+ "var a = 1; if (a) { throw 'Error'; };",
};
- // clang-format on
- for (size_t i = 0; i < arraysize(snippets); i++) {
- Handle<BytecodeArray> bytecode_array =
- helper.MakeBytecodeForFunctionBody(snippets[i].code_snippet);
- CheckBytecodeArrayEqual(snippets[i], bytecode_array);
- }
+ CHECK_EQ(BuildActual(printer, snippets),
+ LoadGolden("Throw.golden"));
}
-
TEST(CallNew) {
- InitializedHandleScope handle_scope;
- BytecodeGeneratorHelper helper;
- Zone zone;
-
- FeedbackVectorSpec feedback_spec(&zone);
- FeedbackVectorSlot slot1 = feedback_spec.AddGeneralSlot();
- FeedbackVectorSlot slot2 = feedback_spec.AddLoadICSlot();
- USE(slot1);
-
- Handle<i::TypeFeedbackVector> vector =
- i::NewTypeFeedbackVector(helper.isolate(), &feedback_spec);
-
- // clang-format off
- ExpectedSnippet<InstanceType> snippets[] = {
- {"function bar() { this.value = 0; }\n"
- "function f() { return new bar(); }\n"
- "f()",
- 1 * kPointerSize,
- 1,
- 11,
- {
- B(StackCheck), //
- B(LdaGlobal), U8(0), U8(vector->GetIndex(slot2)), //
- B(Star), R(0), //
- B(New), R(0), R(0), U8(0), //
- B(Return), //
- },
- 1,
- {InstanceType::ONE_BYTE_INTERNALIZED_STRING_TYPE}},
- {"function bar(x) { this.value = 18; this.x = x;}\n"
- "function f() { return new bar(3); }\n"
- "f()",
- 2 * kPointerSize,
- 1,
- 17,
- {
- B(StackCheck), //
- B(LdaGlobal), U8(0), U8(vector->GetIndex(slot2)), //
- B(Star), R(0), //
- B(LdaSmi8), U8(3), //
- B(Star), R(1), //
- B(Ldar), R(0), //
- B(New), R(0), R(1), U8(1), //
- B(Return), //
- },
- 1,
- {InstanceType::ONE_BYTE_INTERNALIZED_STRING_TYPE}},
- {"function bar(w, x, y, z) {\n"
- " this.value = 18;\n"
- " this.x = x;\n"
- " this.y = y;\n"
- " this.z = z;\n"
- "}\n"
- "function f() { return new bar(3, 4, 5); }\n"
- "f()",
- 4 * kPointerSize,
- 1,
- 25,
- {
- B(StackCheck), //
- B(LdaGlobal), U8(0), U8(vector->GetIndex(slot2)), //
- B(Star), R(0), //
- B(LdaSmi8), U8(3), //
- B(Star), R(1), //
- B(LdaSmi8), U8(4), //
- B(Star), R(2), //
- B(LdaSmi8), U8(5), //
- B(Star), R(3), //
- B(Ldar), R(0), //
- B(New), R(0), R(1), U8(3), //
- B(Return), //
- },
- 1,
- {InstanceType::ONE_BYTE_INTERNALIZED_STRING_TYPE}},
- };
- // clang-format on
-
- for (size_t i = 0; i < arraysize(snippets); i++) {
- Handle<BytecodeArray> bytecode_array =
- helper.MakeBytecode(snippets[i].code_snippet, "f");
- CheckBytecodeArrayEqual(snippets[i], bytecode_array);
- }
-}
+ InitializedIgnitionHandleScope scope;
+ BytecodeExpectationsPrinter printer(CcTest::isolate(),
+ ConstantPoolType::kMixed);
+ printer.set_wrap(false);
+ printer.set_test_function_name("f");
+ const char* snippets[] = {
+ "function bar() { this.value = 0; }\n"
+ "function f() { return new bar(); }\n"
+ "f()",
-TEST(ContextVariables) {
- InitializedHandleScope handle_scope;
- BytecodeGeneratorHelper helper;
- Zone zone;
+ "function bar(x) { this.value = 18; this.x = x;}\n"
+ "function f() { return new bar(3); }\n"
+ "f()",
- FeedbackVectorSpec feedback_spec(&zone);
- FeedbackVectorSlot slot = feedback_spec.AddCallICSlot();
-
- Handle<i::TypeFeedbackVector> vector =
- i::NewTypeFeedbackVector(helper.isolate(), &feedback_spec);
+ "function bar(w, x, y, z) {\n"
+ " this.value = 18;\n"
+ " this.x = x;\n"
+ " this.y = y;\n"
+ " this.z = z;\n"
+ "}\n"
+ "function f() { return new bar(3, 4, 5); }\n"
+ "f()",
+ };
- int closure = Register::function_closure().index();
- int context = Register::current_context().index();
- int new_target = Register::new_target().index();
- int first_context_slot = Context::MIN_CONTEXT_SLOTS;
+ CHECK_EQ(BuildActual(printer, snippets),
+ LoadGolden("CallNew.golden"));
+}
+TEST(ContextVariables) {
// The wide check below relies on MIN_CONTEXT_SLOTS + 3 + 249 == 256, if this
// ever changes, the REPEAT_XXX should be changed to output the correct number
// of unique variables to trigger the wide slot load / store.
STATIC_ASSERT(Context::MIN_CONTEXT_SLOTS + 3 + 249 == 256);
- int wide_slot = first_context_slot + 3;
-
- // clang-format off
- ExpectedSnippet<InstanceType> snippets[] = {
- {"var a; return function() { a = 1; };",
- 1 * kPointerSize,
- 1,
- 12,
- {
- B(CallRuntime), U16(Runtime::kNewFunctionContext), //
- /* */ R(closure), U8(1), //
- B(PushContext), R(0), //
- B(StackCheck), //
- B(CreateClosure), U8(0), U8(0), //
- B(Return), //
- },
- 1,
- {InstanceType::SHARED_FUNCTION_INFO_TYPE}},
- {"var a = 1; return function() { a = 2; };",
- 1 * kPointerSize,
- 1,
- 17,
- {
- B(CallRuntime), U16(Runtime::kNewFunctionContext), //
- /* */ R(closure), U8(1), //
- B(PushContext), R(0), //
- B(StackCheck), //
- B(LdaSmi8), U8(1), //
- B(StaContextSlot), R(context), U8(first_context_slot), //
- B(CreateClosure), U8(0), U8(0), //
- B(Return), //
- },
- 1,
- {InstanceType::SHARED_FUNCTION_INFO_TYPE}},
- {"var a = 1; var b = 2; return function() { a = 2; b = 3 };",
- 1 * kPointerSize,
- 1,
- 22,
- {
- B(CallRuntime), U16(Runtime::kNewFunctionContext), //
- /* */ R(closure), U8(1), //
- B(PushContext), R(0), //
- B(StackCheck), //
- B(LdaSmi8), U8(1), //
- B(StaContextSlot), R(context), U8(first_context_slot), //
- B(LdaSmi8), U8(2), //
- B(StaContextSlot), R(context), U8(first_context_slot + 1), //
- B(CreateClosure), U8(0), U8(0), //
- B(Return), //
- },
- 1,
- {InstanceType::SHARED_FUNCTION_INFO_TYPE}},
- {"var a; (function() { a = 2; })(); return a;",
- 3 * kPointerSize,
- 1,
- 25,
- {
- B(CallRuntime), U16(Runtime::kNewFunctionContext), //
- /* */ R(closure), U8(1), //
- B(PushContext), R(0), //
- B(StackCheck), //
- B(LdaUndefined), //
- B(Star), R(2), //
- B(CreateClosure), U8(0), U8(0), //
- B(Star), R(1), //
- B(Call), R(1), R(2), U8(1), U8(vector->GetIndex(slot)), //
- B(LdaContextSlot), R(context), U8(first_context_slot), //
- B(Return), //
- },
- 1,
- {InstanceType::SHARED_FUNCTION_INFO_TYPE}},
- {"'use strict'; let a = 1; { let b = 2; return function() { a + b; }; }",
- 4 * kPointerSize,
- 1,
- 47,
- {
- B(CallRuntime), U16(Runtime::kNewFunctionContext), //
- /* */ R(closure), U8(1), //
- B(PushContext), R(0), //
- B(LdaTheHole), //
- B(StaContextSlot), R(context), U8(first_context_slot), //
- B(StackCheck), //
- B(LdaSmi8), U8(1), //
- B(StaContextSlot), R(context), U8(first_context_slot), //
- B(LdaConstant), U8(0), //
- B(Star), R(2), //
- B(Ldar), R(closure), //
- B(Star), R(3), //
- B(CallRuntime), U16(Runtime::kPushBlockContext), R(2), U8(2), //
- B(PushContext), R(1), //
- B(LdaTheHole), //
- B(StaContextSlot), R(context), U8(first_context_slot), //
- B(LdaSmi8), U8(2), //
- B(StaContextSlot), R(context), U8(first_context_slot), //
- B(CreateClosure), U8(1), U8(0), //
- B(PopContext), R(0), //
- B(Return), //
- },
- 2,
- {InstanceType::FIXED_ARRAY_TYPE,
- InstanceType::SHARED_FUNCTION_INFO_TYPE}},
- {"'use strict';\n"
- REPEAT_249_UNIQUE_VARS()
- "eval();"
- "var b = 100;"
- "return b",
- 3 * kPointerSize,
- 1,
- 1042,
- {
- B(CallRuntime), U16(Runtime::kNewFunctionContext), R(closure), //
- /* */ U8(1), //
- B(PushContext), R(0), //
- B(Ldar), THIS(1), //
- B(StaContextSlot), R(context), U8(first_context_slot), //
- B(CreateUnmappedArguments), //
- B(StaContextSlot), R(context), U8(first_context_slot + 1), //
- B(Ldar), R(new_target), //
- B(StaContextSlot), R(context), U8(first_context_slot + 2), //
- B(StackCheck), //
- REPEAT_249(COMMA, //
- B(LdaZero), //
- B(StaContextSlot), R(context), U8(wide_slot++)), //
- B(LdaUndefined), //
- B(Star), R(2), //
- B(LdaGlobal), U8(0), U8(1), //
- B(Star), R(1), //
- B(Call), R(1), R(2), U8(1), U8(0), //
- B(LdaSmi8), U8(100), //
- B(StaContextSlotWide), R(context), U16(256), //
- B(LdaContextSlotWide), R(context), U16(256), //
- B(Return), //
- },
- 1,
- {InstanceType::ONE_BYTE_INTERNALIZED_STRING_TYPE}},
+
+ InitializedIgnitionHandleScope scope;
+ BytecodeExpectationsPrinter printer(CcTest::isolate(),
+ ConstantPoolType::kMixed);
+ const char* snippets[] = {
+ "var a; return function() { a = 1; };",
+ "var a = 1; return function() { a = 2; };",
+ "var a = 1; var b = 2; return function() { a = 2; b = 3 };",
+ "var a; (function() { a = 2; })(); return a;",
+ "'use strict';\n"
+ "let a = 1;\n"
+ "{ let b = 2; return function() { a + b; }; }",
+ "'use strict';\n"
rmcilroy 2016/02/24 08:55:35 You've skipped the REPEAT_249_UNIQUE_VARS() test h
Stefano Sanfilippo 2016/02/24 14:55:02 Done.
};
- // clang-format on
- for (size_t i = 0; i < arraysize(snippets); i++) {
- Handle<BytecodeArray> bytecode_array =
- helper.MakeBytecodeForFunctionBody(snippets[i].code_snippet);
- CheckBytecodeArrayEqual(snippets[i], bytecode_array);
- }
+ CHECK_EQ(BuildActual(printer, snippets),
+ LoadGolden("ContextVariables.golden"));
}
-
TEST(ContextParameters) {
- InitializedHandleScope handle_scope;
- BytecodeGeneratorHelper helper;
-
- int closure = Register::function_closure().index();
- int context = Register::current_context().index();
- int first_context_slot = Context::MIN_CONTEXT_SLOTS;
-
- // clang-format off
- ExpectedSnippet<InstanceType> snippets[] = {
- {"function f(arg1) { return function() { arg1 = 2; }; }",
- 1 * kPointerSize,
- 2,
- 17,
- {
- B(CallRuntime), U16(Runtime::kNewFunctionContext), //
- /* */ R(closure), U8(1), //
- B(PushContext), R(0), //
- B(Ldar), R(helper.kLastParamIndex), //
- B(StaContextSlot), R(context), U8(first_context_slot), //
- B(StackCheck), //
- B(CreateClosure), U8(0), U8(0), //
- B(Return), //
- },
- 1,
- {InstanceType::SHARED_FUNCTION_INFO_TYPE}},
- {"function f(arg1) { var a = function() { arg1 = 2; }; return arg1; }",
- 2 * kPointerSize,
- 2,
- 22,
- {
- B(CallRuntime), U16(Runtime::kNewFunctionContext), //
- /* */ R(closure), U8(1), //
- B(PushContext), R(1), //
- B(Ldar), R(helper.kLastParamIndex), //
- B(StaContextSlot), R(context), U8(first_context_slot), //
- B(StackCheck), //
- B(CreateClosure), U8(0), U8(0), //
- B(Star), R(0), //
- B(LdaContextSlot), R(context), U8(first_context_slot), //
- B(Return), //
- },
- 1,
- {InstanceType::SHARED_FUNCTION_INFO_TYPE}},
- {"function f(a1, a2, a3, a4) { return function() { a1 = a3; }; }",
- 1 * kPointerSize,
- 5,
- 22,
- {
- B(CallRuntime), U16(Runtime::kNewFunctionContext), //
- /* */ R(closure), U8(1), //
- B(PushContext), R(0), //
- B(Ldar), R(helper.kLastParamIndex - 3), //
- B(StaContextSlot), R(context), U8(first_context_slot + 1), //
- B(Ldar), R(helper.kLastParamIndex -1), //
- B(StaContextSlot), R(context), U8(first_context_slot), //
- B(StackCheck), //
- B(CreateClosure), U8(0), U8(0), //
- B(Return), //
- },
- 1,
- {InstanceType::SHARED_FUNCTION_INFO_TYPE}},
- {"function f() { var self = this; return function() { self = 2; }; }",
- 1 * kPointerSize,
- 1,
- 17,
- {
- B(CallRuntime), U16(Runtime::kNewFunctionContext), //
- /* */ R(closure), U8(1), //
- B(PushContext), R(0), //
- B(StackCheck), //
- B(Ldar), R(helper.kLastParamIndex), //
- B(StaContextSlot), R(context), U8(first_context_slot), //
- B(CreateClosure), U8(0), U8(0), //
- B(Return), //
- },
- 1,
- {InstanceType::SHARED_FUNCTION_INFO_TYPE}},
+ InitializedIgnitionHandleScope scope;
+ BytecodeExpectationsPrinter printer(CcTest::isolate(),
+ ConstantPoolType::kMixed);
+ printer.set_wrap(false);
+ printer.set_test_function_name("f");
+
+ const char* snippets[] = {
+ "function f(arg1) { return function() { arg1 = 2; }; }",
+ "function f(arg1) { var a = function() { arg1 = 2; }; return arg1; }",
+ "function f(a1, a2, a3, a4) { return function() { a1 = a3; }; }",
+ "function f() { var self = this; return function() { self = 2; }; }",
};
- // clang-format on
- for (size_t i = 0; i < arraysize(snippets); i++) {
- Handle<BytecodeArray> bytecode_array =
- helper.MakeBytecodeForFunction(snippets[i].code_snippet);
- CheckBytecodeArrayEqual(snippets[i], bytecode_array);
- }
+ CHECK_EQ(BuildActual(printer, snippets, "", "\nf();"),
+ LoadGolden("ContextParameters.golden"));
}
-
TEST(OuterContextVariables) {
- InitializedHandleScope handle_scope;
- BytecodeGeneratorHelper helper;
-
- int context = Register::current_context().index();
- int first_context_slot = Context::MIN_CONTEXT_SLOTS;
-
- // clang-format off
- ExpectedSnippet<InstanceType> snippets[] = {
- {"function Outer() {"
- " var outerVar = 1;"
- " function Inner(innerArg) {"
- " this.innerFunc = function() { return outerVar * innerArg; }"
- " }"
- " this.getInnerFunc = function() { return new Inner(1).innerFunc; }"
- "}"
- "var f = new Outer().getInnerFunc();",
- 2 * kPointerSize,
- 1,
- 21,
- {
- B(StackCheck), //
- B(Ldar), R(context), //
- B(Star), R(0), //
- B(LdaContextSlot), R(0), U8(Context::PREVIOUS_INDEX), //
- B(Star), R(0), //
- B(LdaContextSlot), R(0), U8(first_context_slot), //
- B(Star), R(1), //
- B(LdaContextSlot), R(context), U8(first_context_slot), //
- B(Mul), R(1), //
- B(Return), //
- }},
- {"function Outer() {"
- " var outerVar = 1;"
- " function Inner(innerArg) {"
- " this.innerFunc = function() { outerVar = innerArg; }"
- " }"
- " this.getInnerFunc = function() { return new Inner(1).innerFunc; }"
- "}"
- "var f = new Outer().getInnerFunc();",
- 2 * kPointerSize,
- 1,
- 22,
- {
- B(StackCheck), //
- B(LdaContextSlot), R(context), U8(first_context_slot), //
- B(Star), R(0), //
- B(Ldar), R(context), //
- B(Star), R(1), //
- B(LdaContextSlot), R(1), U8(Context::PREVIOUS_INDEX), //
- B(Star), R(1), //
- B(Ldar), R(0), //
- B(StaContextSlot), R(1), U8(first_context_slot), //
- B(LdaUndefined), //
- B(Return), //
- }},
- };
- // clang-format on
-
- for (size_t i = 0; i < arraysize(snippets); i++) {
- Handle<BytecodeArray> bytecode_array =
- helper.MakeBytecodeForFunctionNoFilter(snippets[i].code_snippet);
- CheckBytecodeArrayEqual(snippets[i], bytecode_array);
- }
+ InitializedIgnitionHandleScope scope;
+ BytecodeExpectationsPrinter printer(CcTest::isolate(),
+ ConstantPoolType::kMixed);
+ printer.set_wrap(false);
+ printer.set_test_function_name("f");
+
+ const char* snippets[] = {
+ "function Outer() {\n"
+ " var outerVar = 1;\n"
+ " function Inner(innerArg) {\n"
+ " this.innerFunc = function() { return outerVar * innerArg; }\n"
+ " }\n"
+ " this.getInnerFunc = function() { return new Inner(1).innerFunc; }\n"
+ "}\n"
+ "var f = new Outer().getInnerFunc();",
+
+ "function Outer() {\n"
+ " var outerVar = 1;\n"
+ " function Inner(innerArg) {\n"
+ " this.innerFunc = function() { outerVar = innerArg; }\n"
+ " }\n"
+ " this.getInnerFunc = function() { return new Inner(1).innerFunc; }\n"
+ "}\n"
+ "var f = new Outer().getInnerFunc();",
+ };
+
+ CHECK_EQ(BuildActual(printer, snippets, "", "\nf();"),
+ LoadGolden("OuterContextVariables.golden"));
}
-
TEST(CountOperators) {
- InitializedHandleScope handle_scope;
- BytecodeGeneratorHelper helper;
- Zone zone;
-
- FeedbackVectorSpec feedback_spec(&zone);
- FeedbackVectorSlot slot1 = feedback_spec.AddLoadICSlot();
- FeedbackVectorSlot slot2 = feedback_spec.AddStoreICSlot();
- Handle<i::TypeFeedbackVector> vector =
- i::NewTypeFeedbackVector(helper.isolate(), &feedback_spec);
-
- FeedbackVectorSpec store_feedback_spec(&zone);
- FeedbackVectorSlot store_slot = store_feedback_spec.AddStoreICSlot();
- Handle<i::TypeFeedbackVector> store_vector =
- i::NewTypeFeedbackVector(helper.isolate(), &store_feedback_spec);
-
- int closure = Register::function_closure().index();
- int context = Register::current_context().index();
- int first_context_slot = Context::MIN_CONTEXT_SLOTS;
-
- int object_literal_flags =
- ObjectLiteral::kFastElements | ObjectLiteral::kDisableMementos;
- int array_literal_flags =
- ArrayLiteral::kDisableMementos | ArrayLiteral::kShallowElements;
-
- // clang-format off
- ExpectedSnippet<InstanceType> snippets[] = {
- {"var a = 1; return ++a;",
- 1 * kPointerSize,
- 1,
- 10,
- {
- B(StackCheck), //
- B(LdaSmi8), U8(1), //
- B(Star), R(0), //
- B(ToNumber), //
- B(Inc), //
- B(Star), R(0), //
- B(Return), //
- }},
- {"var a = 1; return a++;",
- 2 * kPointerSize,
- 1,
- 14,
- {
- B(StackCheck), //
- B(LdaSmi8), U8(1), //
- B(Star), R(0), //
- B(ToNumber), //
- B(Star), R(1), //
- B(Inc), //
- B(Star), R(0), //
- B(Ldar), R(1), //
- B(Return), //
- }},
- {"var a = 1; return --a;",
- 1 * kPointerSize,
- 1,
- 10,
- {
- B(StackCheck), //
- B(LdaSmi8), U8(1), //
- B(Star), R(0), //
- B(ToNumber), //
- B(Dec), //
- B(Star), R(0), //
- B(Return), //
- }},
- {"var a = 1; return a--;",
- 2 * kPointerSize,
- 1,
- 14,
- {
- B(StackCheck), //
- B(LdaSmi8), U8(1), //
- B(Star), R(0), //
- B(ToNumber), //
- B(Star), R(1), //
- B(Dec), //
- B(Star), R(0), //
- B(Ldar), R(1), //
- B(Return), //
- }},
- {"var a = { val: 1 }; return a.val++;",
- 3 * kPointerSize,
- 1,
- 26,
- {
- B(StackCheck), //
- B(CreateObjectLiteral), U8(0), U8(0), U8(object_literal_flags), //
- B(Star), R(1), //
- B(Star), R(0), //
- B(Star), R(1), //
- B(LoadIC), R(1), U8(1), U8(vector->GetIndex(slot1)), //
- B(ToNumber), //
- B(Star), R(2), //
- B(Inc), //
- B(StoreICSloppy), R(1), U8(1), U8(vector->GetIndex(slot2)), //
- B(Ldar), R(2), //
- B(Return), //
- },
- 2,
- {InstanceType::FIXED_ARRAY_TYPE,
- InstanceType::ONE_BYTE_INTERNALIZED_STRING_TYPE}},
- {"var a = { val: 1 }; return --a.val;",
- 2 * kPointerSize,
- 1,
- 22,
- {
- B(StackCheck), //
- B(CreateObjectLiteral), U8(0), U8(0), U8(object_literal_flags), //
- B(Star), R(1), //
- B(Star), R(0), //
- B(Star), R(1), //
- B(LoadIC), R(1), U8(1), U8(vector->GetIndex(slot1)), //
- B(ToNumber), //
- B(Dec), //
- B(StoreICSloppy), R(1), U8(1), U8(vector->GetIndex(slot2)), //
- B(Return), //
- },
- 2,
- {InstanceType::FIXED_ARRAY_TYPE,
- InstanceType::ONE_BYTE_INTERNALIZED_STRING_TYPE}},
- {"var name = 'var'; var a = { val: 1 }; return a[name]--;",
- 5 * kPointerSize,
- 1,
- 33,
- {
- B(StackCheck), //
- B(LdaConstant), U8(0), //
- B(Star), R(0), //
- B(CreateObjectLiteral), U8(1), U8(0), U8(object_literal_flags), //
- B(Star), R(2), //
- B(Star), R(1), //
- B(Star), R(2), //
- B(Ldar), R(0), //
- B(Star), R(3), //
- B(KeyedLoadIC), R(2), U8(vector->GetIndex(slot1)), //
- B(ToNumber), //
- B(Star), R(4), //
- B(Dec), //
- B(KeyedStoreICSloppy), R(2), R(3), U8(vector->GetIndex(slot2)), //
- B(Ldar), R(4), //
- B(Return), //
- },
- 2,
- {InstanceType::ONE_BYTE_INTERNALIZED_STRING_TYPE,
- InstanceType::FIXED_ARRAY_TYPE}},
- {"var name = 'var'; var a = { val: 1 }; return ++a[name];",
- 4 * kPointerSize,
- 1,
- 29,
- {
- B(StackCheck), //
- B(LdaConstant), U8(0), //
- B(Star), R(0), //
- B(CreateObjectLiteral), U8(1), U8(0), U8(object_literal_flags), //
- B(Star), R(2), //
- B(Star), R(1), //
- B(Star), R(2), //
- B(Ldar), R(0), //
- B(Star), R(3), //
- B(KeyedLoadIC), R(2), U8(vector->GetIndex(slot1)), //
- B(ToNumber), //
- B(Inc), //
- B(KeyedStoreICSloppy), R(2), R(3), U8(vector->GetIndex(slot2)), //
- B(Return), //
- },
- 2,
- {InstanceType::ONE_BYTE_INTERNALIZED_STRING_TYPE,
- InstanceType::FIXED_ARRAY_TYPE}},
- {"var a = 1; var b = function() { return a }; return ++a;",
- 2 * kPointerSize,
- 1,
- 27,
- {
- B(CallRuntime), U16(Runtime::kNewFunctionContext), R(closure), //
- /* */ U8(1), //
- B(PushContext), R(1), //
- B(StackCheck), //
- B(LdaSmi8), U8(1), //
- B(StaContextSlot), R(context), U8(first_context_slot), //
- B(CreateClosure), U8(0), U8(0), //
- B(Star), R(0), //
- B(LdaContextSlot), R(context), U8(first_context_slot), //
- B(ToNumber), //
- B(Inc), //
- B(StaContextSlot), R(context), U8(first_context_slot), //
- B(Return), //
- },
- 1,
- {InstanceType::SHARED_FUNCTION_INFO_TYPE}},
- {"var a = 1; var b = function() { return a }; return a--;",
- 3 * kPointerSize,
- 1,
- 31,
- {
- B(CallRuntime), U16(Runtime::kNewFunctionContext), R(closure), //
- /* */ U8(1), //
- B(PushContext), R(1), //
- B(StackCheck), //
- B(LdaSmi8), U8(1), //
- B(StaContextSlot), R(context), U8(first_context_slot), //
- B(CreateClosure), U8(0), U8(0), //
- B(Star), R(0), //
- B(LdaContextSlot), R(context), U8(first_context_slot), //
- B(ToNumber), //
- B(Star), R(2), //
- B(Dec), //
- B(StaContextSlot), R(context), U8(first_context_slot), //
- B(Ldar), R(2), //
- B(Return), //
- },
- 1,
- {InstanceType::SHARED_FUNCTION_INFO_TYPE}},
- {"var idx = 1; var a = [1, 2]; return a[idx++] = 2;",
- 4 * kPointerSize,
- 1,
- 28,
- {
- B(StackCheck), //
- B(LdaSmi8), U8(1), //
- B(Star), R(0), //
- B(CreateArrayLiteral), U8(0), U8(0), U8(array_literal_flags), //
- B(Star), R(1), //
- B(Star), R(2), //
- B(Ldar), R(0), //
- B(ToNumber), //
- B(Star), R(3), //
- B(Inc), //
- B(Star), R(0), //
- B(LdaSmi8), U8(2), //
- B(KeyedStoreICSloppy), R(2), R(3), //
- /* */ U8(store_vector->GetIndex(store_slot)), //
- B(Return), //
- },
- 1,
- {InstanceType::FIXED_ARRAY_TYPE}},
- };
- // clang-format on
-
- for (size_t i = 0; i < arraysize(snippets); i++) {
- Handle<BytecodeArray> bytecode_array =
- helper.MakeBytecodeForFunctionBody(snippets[i].code_snippet);
- CheckBytecodeArrayEqual(snippets[i], bytecode_array);
- }
+ InitializedIgnitionHandleScope scope;
+ BytecodeExpectationsPrinter printer(CcTest::isolate(),
+ ConstantPoolType::kMixed);
+ const char* snippets[] = {
+ "var a = 1; return ++a;",
+ "var a = 1; return a++;",
+ "var a = 1; return --a;",
+ "var a = 1; return a--;",
+ "var a = { val: 1 }; return a.val++;",
+ "var a = { val: 1 }; return --a.val;",
+ "var name = 'var'; var a = { val: 1 }; return a[name]--;",
+ "var name = 'var'; var a = { val: 1 }; return ++a[name];",
+ "var a = 1; var b = function() { return a }; return ++a;",
+ "var a = 1; var b = function() { return a }; return a--;",
+ "var idx = 1; var a = [1, 2]; return a[idx++] = 2;",
+ };
+
+ CHECK_EQ(BuildActual(printer, snippets),
+ LoadGolden("CountOperators.golden"));
}
-
TEST(GlobalCountOperators) {
- InitializedHandleScope handle_scope;
- BytecodeGeneratorHelper helper;
- Zone zone;
-
- FeedbackVectorSpec feedback_spec(&zone);
- FeedbackVectorSlot slot1 = feedback_spec.AddLoadICSlot();
- FeedbackVectorSlot slot2 = feedback_spec.AddStoreICSlot();
-
- Handle<i::TypeFeedbackVector> vector =
- i::NewTypeFeedbackVector(helper.isolate(), &feedback_spec);
-
- // clang-format off
- ExpectedSnippet<const char*> snippets[] = {
- {"var global = 1;\nfunction f() { return ++global; }\nf()",
- 0,
- 1,
- 10,
- {
- B(StackCheck), //
- B(LdaGlobal), U8(0), U8(vector->GetIndex(slot1)), //
- B(ToNumber), //
- B(Inc), //
- B(StaGlobalSloppy), U8(0), U8(vector->GetIndex(slot2)), //
- B(Return), //
- },
- 1,
- {"global"}},
- {"var global = 1;\nfunction f() { return global--; }\nf()",
- 1 * kPointerSize,
- 1,
- 14,
- {
- B(StackCheck), //
- B(LdaGlobal), U8(0), U8(vector->GetIndex(slot1)), //
- B(ToNumber), //
- B(Star), R(0), //
- B(Dec), //
- B(StaGlobalSloppy), U8(0), U8(vector->GetIndex(slot2)), //
- B(Ldar), R(0), //
- B(Return),
- },
- 1,
- {"global"}},
- {"unallocated = 1;\nfunction f() { 'use strict'; return --unallocated; }"
- "f()",
- 0,
- 1,
- 10,
- {
- B(StackCheck), //
- B(LdaGlobal), U8(0), U8(vector->GetIndex(slot1)), //
- B(ToNumber), //
- B(Dec), //
- B(StaGlobalStrict), U8(0), U8(vector->GetIndex(slot2)), //
- B(Return), //
- },
- 1,
- {"unallocated"}},
- {"unallocated = 1;\nfunction f() { return unallocated++; }\nf()",
- 1 * kPointerSize,
- 1,
- 14,
- {
- B(StackCheck), //
- B(LdaGlobal), U8(0), U8(vector->GetIndex(slot1)), //
- B(ToNumber), //
- B(Star), R(0), //
- B(Inc), //
- B(StaGlobalSloppy), U8(0), U8(vector->GetIndex(slot2)), //
- B(Ldar), R(0), //
- B(Return),
- },
- 1,
- {"unallocated"}},
+ InitializedIgnitionHandleScope scope;
+ BytecodeExpectationsPrinter printer(CcTest::isolate(),
+ ConstantPoolType::kString);
+ printer.set_wrap(false);
+ printer.set_test_function_name("f");
+
+ const char* snippets[] = {
+ "var global = 1;\nfunction f() { return ++global; }\nf()",
+ "var global = 1;\nfunction f() { return global--; }\nf()",
+ "unallocated = 1;\nfunction f() { 'use strict'; return --unallocated; }"
+ "f()",
+ "unallocated = 1;\nfunction f() { return unallocated++; }\nf()",
};
- // clang-format on
- for (size_t i = 0; i < arraysize(snippets); i++) {
- Handle<BytecodeArray> bytecode_array =
- helper.MakeBytecode(snippets[i].code_snippet, "f");
- CheckBytecodeArrayEqual(snippets[i], bytecode_array);
- }
+ CHECK_EQ(BuildActual(printer, snippets),
+ LoadGolden("GlobalCountOperators.golden"));
}
-
TEST(CompoundExpressions) {
- InitializedHandleScope handle_scope;
- BytecodeGeneratorHelper helper;
- Zone zone;
-
- int closure = Register::function_closure().index();
- int context = Register::current_context().index();
- int first_context_slot = Context::MIN_CONTEXT_SLOTS;
-
- FeedbackVectorSpec feedback_spec(&zone);
- FeedbackVectorSlot slot1 = feedback_spec.AddLoadICSlot();
- FeedbackVectorSlot slot2 = feedback_spec.AddStoreICSlot();
-
- Handle<i::TypeFeedbackVector> vector =
- i::NewTypeFeedbackVector(helper.isolate(), &feedback_spec);
-
- int object_literal_flags =
- ObjectLiteral::kFastElements | ObjectLiteral::kDisableMementos;
-
- // clang-format off
- ExpectedSnippet<InstanceType> snippets[] = {
- {"var a = 1; a += 2;",
- 2 * kPointerSize,
- 1,
- 15,
- {
- B(StackCheck), //
- B(LdaSmi8), U8(1), //
- B(Star), R(0), //
- B(Star), R(1), //
- B(LdaSmi8), U8(2), //
- B(Add), R(1), //
- B(Star), R(0), //
- B(LdaUndefined), //
- B(Return), //
- }},
- {"var a = 1; a /= 2;",
- 2 * kPointerSize,
- 1,
- 15,
- {
- B(StackCheck), //
- B(LdaSmi8), U8(1), //
- B(Star), R(0), //
- B(Star), R(1), //
- B(LdaSmi8), U8(2), //
- B(Div), R(1), //
- B(Star), R(0), //
- B(LdaUndefined), //
- B(Return), //
- }},
- {"var a = { val: 2 }; a.name *= 2;",
- 3 * kPointerSize,
- 1,
- 27,
- {
- B(StackCheck), //
- B(CreateObjectLiteral), U8(0), U8(0), U8(object_literal_flags), //
- B(Star), R(1), //
- B(Star), R(0), //
- B(Star), R(1), //
- B(LoadIC), R(1), U8(1), U8(vector->GetIndex(slot1)), //
- B(Star), R(2), //
- B(LdaSmi8), U8(2), //
- B(Mul), R(2), //
- B(StoreICSloppy), R(1), U8(1), U8(vector->GetIndex(slot2)), //
- B(LdaUndefined), //
- B(Return), //
- },
- 2,
- {InstanceType::FIXED_ARRAY_TYPE,
- InstanceType::ONE_BYTE_INTERNALIZED_STRING_TYPE}},
- {"var a = { 1: 2 }; a[1] ^= 2;",
- 4 * kPointerSize,
- 1,
- 30,
- {
- B(StackCheck), //
- B(CreateObjectLiteral), U8(0), U8(0), U8(object_literal_flags), //
- B(Star), R(1), //
- B(Star), R(0), //
- B(Star), R(1), //
- B(LdaSmi8), U8(1), //
- B(Star), R(2), //
- B(KeyedLoadIC), R(1), U8(vector->GetIndex(slot1)), //
- B(Star), R(3), //
- B(LdaSmi8), U8(2), //
- B(BitwiseXor), R(3), //
- B(KeyedStoreICSloppy), R(1), R(2), U8(vector->GetIndex(slot2)), //
- B(LdaUndefined), //
- B(Return), //
- },
- 1,
- {InstanceType::FIXED_ARRAY_TYPE}},
- {"var a = 1; (function f() { return a; }); a |= 24;",
- 2 * kPointerSize,
- 1,
- 30,
- {
- B(CallRuntime), U16(Runtime::kNewFunctionContext), R(closure), //
- /* */ U8(1), //
- B(PushContext), R(0), //
- B(StackCheck), //
- B(LdaSmi8), U8(1), //
- B(StaContextSlot), R(context), U8(first_context_slot), //
- B(CreateClosure), U8(0), U8(0), //
- B(LdaContextSlot), R(context), U8(first_context_slot), //
- B(Star), R(1), //
- B(LdaSmi8), U8(24), //
- B(BitwiseOr), R(1), //
- B(StaContextSlot), R(context), U8(first_context_slot), //
- B(LdaUndefined), //
- B(Return), //
- },
- 1,
- {InstanceType::SHARED_FUNCTION_INFO_TYPE}},
+ InitializedIgnitionHandleScope scope;
+ BytecodeExpectationsPrinter printer(CcTest::isolate(),
+ ConstantPoolType::kMixed);
+ const char* snippets[] = {
+ "var a = 1; a += 2;",
+ "var a = 1; a /= 2;",
+ "var a = { val: 2 }; a.name *= 2;",
+ "var a = { 1: 2 }; a[1] ^= 2;",
+ "var a = 1; (function f() { return a; }); a |= 24;",
};
- // clang-format on
- for (size_t i = 0; i < arraysize(snippets); i++) {
- Handle<BytecodeArray> bytecode_array =
- helper.MakeBytecodeForFunctionBody(snippets[i].code_snippet);
- CheckBytecodeArrayEqual(snippets[i], bytecode_array);
- }
+ CHECK_EQ(BuildActual(printer, snippets),
+ LoadGolden("CompoundExpressions.golden"));
}
-
TEST(GlobalCompoundExpressions) {
- InitializedHandleScope handle_scope;
- BytecodeGeneratorHelper helper;
- Zone zone;
-
- FeedbackVectorSpec feedback_spec(&zone);
- FeedbackVectorSlot slot1 = feedback_spec.AddLoadICSlot();
- FeedbackVectorSlot slot2 = feedback_spec.AddStoreICSlot();
-
- Handle<i::TypeFeedbackVector> vector =
- i::NewTypeFeedbackVector(helper.isolate(), &feedback_spec);
-
- // clang-format off
- ExpectedSnippet<const char*> snippets[] = {
- {"var global = 1;\nfunction f() { return global &= 1; }\nf()",
- 1 * kPointerSize,
- 1,
- 14,
- {
- B(StackCheck), //
- B(LdaGlobal), U8(0), U8(vector->GetIndex(slot1)), //
- B(Star), R(0), //
- B(LdaSmi8), U8(1), //
- B(BitwiseAnd), R(0), //
- B(StaGlobalSloppy), U8(0), U8(vector->GetIndex(slot2)), //
- B(Return), //
- },
- 1,
- {"global"}},
- {"unallocated = 1;\nfunction f() { return unallocated += 1; }\nf()",
- 1 * kPointerSize,
- 1,
- 14,
- {
- B(StackCheck), //
- B(LdaGlobal), U8(0), U8(vector->GetIndex(slot1)), //
- B(Star), R(0), //
- B(LdaSmi8), U8(1), //
- B(Add), R(0), //
- B(StaGlobalSloppy), U8(0), U8(vector->GetIndex(slot2)), //
- B(Return), //
- },
- 1,
- {"unallocated"}},
+ InitializedIgnitionHandleScope scope;
+ BytecodeExpectationsPrinter printer(CcTest::isolate(),
+ ConstantPoolType::kString);
+ printer.set_wrap(false);
+ printer.set_test_function_name("f");
+
+ const char* snippets[] = {
+ "var global = 1;\nfunction f() { return global &= 1; }\nf()",
+ "unallocated = 1;\nfunction f() { return unallocated += 1; }\nf()",
};
- // clang-format on
- for (size_t i = 0; i < arraysize(snippets); i++) {
- Handle<BytecodeArray> bytecode_array =
- helper.MakeBytecode(snippets[i].code_snippet, "f");
- CheckBytecodeArrayEqual(snippets[i], bytecode_array);
- }
+ CHECK_EQ(BuildActual(printer, snippets),
+ LoadGolden("GlobalCompoundExpressions.golden"));
}
-
TEST(CreateArguments) {
- InitializedHandleScope handle_scope;
- BytecodeGeneratorHelper helper;
- Zone zone;
-
- int closure = Register::function_closure().index();
- int context = Register::current_context().index();
- int first_context_slot = Context::MIN_CONTEXT_SLOTS;
-
- FeedbackVectorSpec feedback_spec(&zone);
- FeedbackVectorSlot slot = feedback_spec.AddKeyedLoadICSlot();
-
- Handle<i::TypeFeedbackVector> vector =
- i::NewTypeFeedbackVector(helper.isolate(), &feedback_spec);
-
- // clang-format off
- ExpectedSnippet<const char*> snippets[] = {
- {"function f() { return arguments; }",
- 1 * kPointerSize,
- 1,
- 7,
- {
- B(CreateMappedArguments), //
- B(Star), R(0), //
- B(StackCheck), //
- B(Ldar), R(0), //
- B(Return), //
- }},
- {"function f() { return arguments[0]; }",
- 2 * kPointerSize,
- 1,
- 13,
- {
- B(CreateMappedArguments), //
- B(Star), R(0), //
- B(StackCheck), //
- B(Ldar), R(0), //
- B(Star), R(1), //
- B(LdaZero), //
- B(KeyedLoadIC), R(1), U8(vector->GetIndex(slot)), //
- B(Return), //
- }},
- {"function f() { 'use strict'; return arguments; }",
- 1 * kPointerSize,
- 1,
- 7,
- {
- B(CreateUnmappedArguments), //
- B(Star), R(0), //
- B(StackCheck), //
- B(Ldar), R(0), //
- B(Return), //
- }},
- {"function f(a) { return arguments[0]; }",
- 3 * kPointerSize,
- 2,
- 25,
- {
- B(CallRuntime), U16(Runtime::kNewFunctionContext), R(closure), //
- /* */ U8(1), //
- B(PushContext), R(1), //
- B(Ldar), R(BytecodeGeneratorHelper::kLastParamIndex), //
- B(StaContextSlot), R(context), U8(first_context_slot), //
- B(CreateMappedArguments), //
- B(Star), R(0), //
- B(StackCheck), //
- B(Ldar), R(0), //
- B(Star), R(2), //
- B(LdaZero), //
- B(KeyedLoadIC), R(2), U8(vector->GetIndex(slot)), //
- B(Return), //
- }},
- {"function f(a, b, c) { return arguments; }",
- 2 * kPointerSize,
- 4,
- 29,
- {
- B(CallRuntime), U16(Runtime::kNewFunctionContext), R(closure), //
- /* */ U8(1), //
- B(PushContext), R(1), //
- B(Ldar), R(BytecodeGeneratorHelper::kLastParamIndex - 2), //
- B(StaContextSlot), R(context), U8(first_context_slot + 2), //
- B(Ldar), R(BytecodeGeneratorHelper::kLastParamIndex - 1), //
- B(StaContextSlot), R(context), U8(first_context_slot + 1), //
- B(Ldar), R(BytecodeGeneratorHelper::kLastParamIndex), //
- B(StaContextSlot), R(context), U8(first_context_slot), //
- B(CreateMappedArguments), //
- B(Star), R(0), //
- B(StackCheck), //
- B(Ldar), R(0), //
- B(Return), //
- }},
- {"function f(a, b, c) { 'use strict'; return arguments; }",
- 1 * kPointerSize,
- 4,
- 7,
- {
- B(CreateUnmappedArguments), //
- B(Star), R(0), //
- B(StackCheck), //
- B(Ldar), R(0), //
- B(Return), //
- }},
+ InitializedIgnitionHandleScope scope;
+ BytecodeExpectationsPrinter printer(CcTest::isolate(),
+ ConstantPoolType::kString);
+ printer.set_wrap(false);
+ printer.set_test_function_name("f");
+
+ const char* snippets[] = {
+ "function f() { return arguments; }",
+ "function f() { return arguments[0]; }",
+ "function f() { 'use strict'; return arguments; }",
+ "function f(a) { return arguments[0]; }",
+ "function f(a, b, c) { return arguments; }",
+ "function f(a, b, c) { 'use strict'; return arguments; }",
};
- // clang-format on
- for (size_t i = 0; i < arraysize(snippets); i++) {
- Handle<BytecodeArray> bytecode_array =
- helper.MakeBytecodeForFunction(snippets[i].code_snippet);
- CheckBytecodeArrayEqual(snippets[i], bytecode_array);
- }
+ CHECK_EQ(BuildActual(printer, snippets, "", "\nf();"),
+ LoadGolden("CreateArguments.golden"));
}
TEST(CreateRestParameter) {
- InitializedHandleScope handle_scope;
- BytecodeGeneratorHelper helper;
- Zone zone;
-
- FeedbackVectorSpec feedback_spec(&zone);
- FeedbackVectorSlot slot = feedback_spec.AddKeyedLoadICSlot();
- FeedbackVectorSlot slot1 = feedback_spec.AddKeyedLoadICSlot();
-
- Handle<i::TypeFeedbackVector> vector =
- i::NewTypeFeedbackVector(helper.isolate(), &feedback_spec);
-
- // clang-format off
- ExpectedSnippet<int> snippets[] = {
- {"function f(...restArgs) { return restArgs; }",
- 1 * kPointerSize,
- 1,
- 7,
- {
- B(CreateRestParameter), //
- B(Star), R(0), //
- B(StackCheck), //
- B(Ldar), R(0), //
- B(Return), //
- },
- 0,
- {}},
- {"function f(a, ...restArgs) { return restArgs; }",
- 2 * kPointerSize,
- 2,
- 14,
- {
- B(CreateRestParameter), //
- B(Star), R(0), //
- B(LdaTheHole), //
- B(Star), R(1), //
- B(StackCheck), //
- B(Ldar), A(1, 2), //
- B(Star), R(1), //
- B(Ldar), R(0), //
- B(Return), //
- },
- 0,
- {}},
- {"function f(a, ...restArgs) { return restArgs[0]; }",
- 3 * kPointerSize,
- 2,
- 20,
- {
- B(CreateRestParameter), //
- B(Star), R(0), //
- B(LdaTheHole), //
- B(Star), R(1), //
- B(StackCheck), //
- B(Ldar), A(1, 2), //
- B(Star), R(1), //
- B(Ldar), R(0), //
- B(Star), R(2), //
- B(LdaZero), //
- B(KeyedLoadIC), R(2), U8(vector->GetIndex(slot)), //
- B(Return), //
- },
- 0,
- {}},
- {"function f(a, ...restArgs) { return restArgs[0] + arguments[0]; }",
- 5 * kPointerSize,
- 2,
- 35,
- {
- B(CreateUnmappedArguments), //
- B(Star), R(0), //
- B(CreateRestParameter), //
- B(Star), R(1), //
- B(LdaTheHole), //
- B(Star), R(2), //
- B(StackCheck), //
- B(Ldar), A(1, 2), //
- B(Star), R(2), //
- B(Ldar), R(1), //
- B(Star), R(3), //
- B(LdaZero), //
- B(KeyedLoadIC), R(3), U8(vector->GetIndex(slot)), //
- B(Star), R(4), //
- B(Ldar), R(0), //
- B(Star), R(3), //
- B(LdaZero), //
- B(KeyedLoadIC), R(3), U8(vector->GetIndex(slot1)), //
- B(Add), R(4), //
- B(Return), //
- },
- 0,
- {}},
+ InitializedIgnitionHandleScope scope;
+ BytecodeExpectationsPrinter printer(CcTest::isolate(),
+ ConstantPoolType::kNumber);
+ printer.set_wrap(false);
+ printer.set_test_function_name("f");
+
+ const char* snippets[] = {
+ "function f(...restArgs) { return restArgs; }",
+ "function f(a, ...restArgs) { return restArgs; }",
+ "function f(a, ...restArgs) { return restArgs[0]; }",
+ "function f(a, ...restArgs) { return restArgs[0] + arguments[0]; }",
};
- // clang-format on
- for (size_t i = 0; i < arraysize(snippets); i++) {
- Handle<BytecodeArray> bytecode_array =
- helper.MakeBytecodeForFunction(snippets[i].code_snippet);
- CheckBytecodeArrayEqual(snippets[i], bytecode_array);
- }
+ CHECK_EQ(BuildActual(printer, snippets, "", "\nf();"),
+ LoadGolden("CreateRestParameter.golden"));
}
TEST(IllegalRedeclaration) {
bool old_legacy_const_flag = FLAG_legacy_const;
FLAG_legacy_const = true;
- InitializedHandleScope handle_scope;
- BytecodeGeneratorHelper helper;
-
CHECK_GE(MessageTemplate::kVarRedeclaration, 128);
// Must adapt bytecode if this changes.
- // clang-format off
- ExpectedSnippet<Handle<Object>, 2> snippets[] = {
- {"const a = 1; { var a = 2; }",
- 3 * kPointerSize,
- 1,
- 14,
- {
- B(LdaConstant), U8(0), //
- B(Star), R(1), //
- B(LdaConstant), U8(1), //
- B(Star), R(2), //
- B(CallRuntime), U16(Runtime::kNewSyntaxError), R(1), U8(2), //
- B(Throw), //
- },
- 2,
- {helper.factory()->NewNumberFromInt(MessageTemplate::kVarRedeclaration),
- helper.factory()->NewStringFromAsciiChecked("a")}},
+ InitializedIgnitionHandleScope scope;
+ BytecodeExpectationsPrinter printer(CcTest::isolate(),
+ ConstantPoolType::kMixed);
+ const char* snippets[] = {
+ "const a = 1; { var a = 2; }"
};
- // clang-format on
- for (size_t i = 0; i < arraysize(snippets); i++) {
- Handle<BytecodeArray> bytecode_array =
- helper.MakeBytecodeForFunctionBody(snippets[i].code_snippet);
- CheckBytecodeArrayEqual(snippets[i], bytecode_array);
- }
+ CHECK_EQ(BuildActual(printer, snippets),
+ LoadGolden("IllegalRedeclaration.golden"));
FLAG_legacy_const = old_legacy_const_flag;
}
-
TEST(ForIn) {
- InitializedHandleScope handle_scope;
- BytecodeGeneratorHelper helper;
- Zone zone;
-
- int simple_flags =
- ArrayLiteral::kDisableMementos | ArrayLiteral::kShallowElements;
- int deep_elements_flags =
- ObjectLiteral::kFastElements | ObjectLiteral::kDisableMementos;
-
- FeedbackVectorSpec feedback_spec(&zone);
- feedback_spec.AddStoreICSlot();
- FeedbackVectorSlot slot2 = feedback_spec.AddStoreICSlot();
- FeedbackVectorSlot slot3 = feedback_spec.AddStoreICSlot();
- FeedbackVectorSlot slot4 = feedback_spec.AddStoreICSlot();
- Handle<i::TypeFeedbackVector> vector =
- i::NewTypeFeedbackVector(helper.isolate(), &feedback_spec);
-
- // clang-format off
- ExpectedSnippet<InstanceType> snippets[] = {
- {"for (var p in null) {}",
- 2 * kPointerSize,
- 1,
- 3,
- {
- B(StackCheck), //
- B(LdaUndefined), //
- B(Return) //
- },
- 0},
- {"for (var p in undefined) {}",
- 2 * kPointerSize,
- 1,
- 3,
- {
- B(StackCheck), //
- B(LdaUndefined), //
- B(Return) //
- },
- 0},
- {"for (var p in undefined) {}",
- 2 * kPointerSize,
- 1,
- 3,
- {
- B(StackCheck), //
- B(LdaUndefined), //
- B(Return) //
- },
- 0},
- {"var x = 'potatoes';\n"
- "for (var p in x) { return p; }",
- 8 * kPointerSize,
- 1,
- 46,
- {
- B(StackCheck), //
- B(LdaConstant), U8(0), //
- B(Star), R(1), //
- B(JumpIfUndefined), U8(39), //
- B(JumpIfNull), U8(37), //
- B(ToObject), //
- B(JumpIfNull), U8(34), //
- B(Star), R(3), //
- B(ForInPrepare), R(4), //
- B(LdaZero), //
- B(Star), R(7), //
- B(ForInDone), R(7), R(6), //
- B(JumpIfTrue), U8(22), //
- B(ForInNext), R(3), R(7), R(4), //
- B(JumpIfUndefined), U8(10), //
- B(Star), R(0), //
- B(StackCheck), //
- B(Ldar), R(0), //
- B(Star), R(2), //
- B(Return), //
- B(ForInStep), R(7), //
- B(Star), R(7), //
- B(Jump), U8(-23), //
- B(LdaUndefined), //
- B(Return), //
- },
- 1,
- {InstanceType::ONE_BYTE_INTERNALIZED_STRING_TYPE}},
- {"var x = 0;\n"
- "for (var p in [1,2,3]) { x += p; }",
- 9 * kPointerSize,
- 1,
- 58,
- {
- B(StackCheck), //
- B(LdaZero), //
- B(Star), R(1), //
- B(CreateArrayLiteral), U8(0), U8(0), U8(3), //
- B(JumpIfUndefined), U8(48), //
- B(JumpIfNull), U8(46), //
- B(ToObject), //
- B(JumpIfNull), U8(43), //
- B(Star), R(3), //
- B(ForInPrepare), R(4), //
- B(LdaZero), //
- B(Star), R(7), //
- B(ForInDone), R(7), R(6), //
- B(JumpIfTrue), U8(31), //
- B(ForInNext), R(3), R(7), R(4), //
- B(JumpIfUndefined), U8(19), //
- B(Star), R(0), //
- B(StackCheck), //
- B(Ldar), R(0), //
- B(Star), R(2), //
- B(Ldar), R(1), //
- B(Star), R(8), //
- B(Ldar), R(2), //
- B(Add), R(8), //
- B(Star), R(1), //
- B(ForInStep), R(7), //
- B(Star), R(7), //
- B(Jump), U8(-32), //
- B(LdaUndefined), //
- B(Return), //
- },
- 1,
- {InstanceType::FIXED_ARRAY_TYPE}},
- {"var x = { 'a': 1, 'b': 2 };\n"
- "for (x['a'] in [10, 20, 30]) {\n"
- " if (x['a'] == 10) continue;\n"
- " if (x['a'] == 20) break;\n"
- "}",
- 8 * kPointerSize,
- 1,
- 95,
- {
- B(StackCheck), //
- B(CreateObjectLiteral), U8(0), U8(0), U8(deep_elements_flags), //
- B(Star), R(1), //
- B(Star), R(0), //
- B(CreateArrayLiteral), U8(1), U8(1), U8(simple_flags), //
- B(JumpIfUndefined), U8(80), //
- B(JumpIfNull), U8(78), //
- B(ToObject), //
- B(JumpIfNull), U8(75), //
- B(Star), R(1), //
- B(ForInPrepare), R(2), //
- B(LdaZero), //
- B(Star), R(5), //
- B(ForInDone), R(5), R(4), //
- B(JumpIfTrue), U8(63), //
- B(ForInNext), R(1), R(5), R(2), //
- B(JumpIfUndefined), U8(51), //
- B(Star), R(6), //
- B(Ldar), R(0), //
- B(Star), R(7), //
- B(Ldar), R(6), //
- B(StoreICSloppy), R(7), U8(2), U8(vector->GetIndex(slot4)), //
- B(StackCheck), //
- B(Ldar), R(0), //
- B(Star), R(6), //
- B(LoadIC), R(6), U8(2), U8(vector->GetIndex(slot2)), //
- B(Star), R(7), //
- B(LdaSmi8), U8(10), //
- B(TestEqual), R(7), //
- B(JumpIfFalse), U8(4), //
- B(Jump), U8(20), //
- B(Ldar), R(0), //
- B(Star), R(6), //
- B(LoadIC), R(6), U8(2), U8(vector->GetIndex(slot3)), //
- B(Star), R(7), //
- B(LdaSmi8), U8(20), //
- B(TestEqual), R(7), //
- B(JumpIfFalse), U8(4), //
- B(Jump), U8(8), //
- B(ForInStep), R(5), //
- B(Star), R(5), //
- B(Jump), U8(-64), //
- B(LdaUndefined), //
- B(Return), //
- },
- 3,
- {InstanceType::FIXED_ARRAY_TYPE, InstanceType::FIXED_ARRAY_TYPE,
- InstanceType::ONE_BYTE_INTERNALIZED_STRING_TYPE}},
- {"var x = [ 10, 11, 12 ] ;\n"
- "for (x[0] in [1,2,3]) { return x[3]; }",
- 9 * kPointerSize,
- 1,
- 70,
- {
- B(StackCheck), //
- B(CreateArrayLiteral), U8(0), U8(0), U8(simple_flags), //
- B(Star), R(0), //
- B(CreateArrayLiteral), U8(1), U8(1), U8(simple_flags), //
- B(JumpIfUndefined), U8(57), //
- B(JumpIfNull), U8(55), //
- B(ToObject), //
- B(JumpIfNull), U8(52), //
- B(Star), R(1), //
- B(ForInPrepare), R(2), //
- B(LdaZero), //
- B(Star), R(5), //
- B(ForInDone), R(5), R(4), //
- B(JumpIfTrue), U8(40), //
- B(ForInNext), R(1), R(5), R(2), //
- B(JumpIfUndefined), U8(28), //
- B(Star), R(6), //
- B(Ldar), R(0), //
- B(Star), R(7), //
- B(LdaZero), //
- B(Star), R(8), //
- B(Ldar), R(6), //
- B(KeyedStoreICSloppy), R(7), R(8), U8(vector->GetIndex(slot3)), //
- B(StackCheck), //
- B(Ldar), R(0), //
- B(Star), R(6), //
- B(LdaSmi8), U8(3), //
- B(KeyedLoadIC), R(6), U8(vector->GetIndex(slot2)), //
- B(Return), //
- B(ForInStep), R(5), //
- B(Star), R(5), //
- B(Jump), U8(-41), //
- B(LdaUndefined), //
- B(Return), //
- },
- 2,
- {InstanceType::FIXED_ARRAY_TYPE, InstanceType::FIXED_ARRAY_TYPE}},
+ InitializedIgnitionHandleScope scope;
+ BytecodeExpectationsPrinter printer(CcTest::isolate(),
+ ConstantPoolType::kMixed);
+ const char* snippets[] = {
oth 2016/02/24 13:43:55 // clang-format off
+ "for (var p in null) {}",
+
+ "for (var p in undefined) {}",
+
+ "for (var p in undefined) {}",
+
+ "var x = 'potatoes';\n"
+ "for (var p in x) { return p; }",
+
+ "var x = 0;\n"
+ "for (var p in [1,2,3]) { x += p; }",
+
+ "var x = { 'a': 1, 'b': 2 };\n"
+ "for (x['a'] in [10, 20, 30]) {\n"
+ " if (x['a'] == 10) continue;\n"
+ " if (x['a'] == 20) break;\n"
+ "}",
+
+ "var x = [ 10, 11, 12 ] ;\n"
+ "for (x[0] in [1,2,3]) { return x[3]; }",
oth 2016/02/24 13:43:55 // clang-format on
};
- // clang-format on
- for (size_t i = 0; i < arraysize(snippets); i++) {
- Handle<BytecodeArray> bytecode_array =
- helper.MakeBytecodeForFunctionBody(snippets[i].code_snippet);
- CheckBytecodeArrayEqual(snippets[i], bytecode_array);
- }
+ CHECK_EQ(BuildActual(printer, snippets),
+ LoadGolden("ForIn.golden"));
}
-
// TODO(rmcilroy): Do something about this; new bytecode is too large
// (150+ instructions) to adapt manually.
rmcilroy 2016/02/24 08:55:35 Remove TODO
Stefano Sanfilippo 2016/02/24 14:55:01 Done.
-DISABLED_TEST(ForOf) {
- InitializedHandleScope handle_scope;
- BytecodeGeneratorHelper helper;
- Zone zone;
-
- int array_literal_flags =
- ArrayLiteral::kDisableMementos | ArrayLiteral::kShallowElements;
- int object_literal_flags =
- ObjectLiteral::kFastElements | ObjectLiteral::kDisableMementos;
-
- FeedbackVectorSpec feedback_spec(&zone);
- FeedbackVectorSlot slot1 = feedback_spec.AddCallICSlot();
- FeedbackVectorSlot slot2 = feedback_spec.AddKeyedLoadICSlot();
- FeedbackVectorSlot slot3 = feedback_spec.AddCallICSlot();
- FeedbackVectorSlot slot4 = feedback_spec.AddLoadICSlot();
- FeedbackVectorSlot slot5 = feedback_spec.AddLoadICSlot();
- FeedbackVectorSlot slot6 = feedback_spec.AddLoadICSlot();
- FeedbackVectorSlot slot7 = feedback_spec.AddStoreICSlot();
- FeedbackVectorSlot slot8 = feedback_spec.AddLoadICSlot();
- Handle<i::TypeFeedbackVector> vector =
- i::NewTypeFeedbackVector(helper.isolate(), &feedback_spec);
-
- // clang-format off
- ExpectedSnippet<InstanceType, 8> snippets[] = {
- {"for (var p of [0, 1, 2]) {}",
- 7 * kPointerSize,
- 1,
- 86,
- {
- B(StackCheck), //
- B(CreateArrayLiteral), U8(0), U8(0), U8(array_literal_flags), //
- B(Star), R(5), //
- B(LdaConstant), U8(1), //
- B(KeyedLoadIC), R(5), U8(vector->GetIndex(slot2)), //
- B(Star), R(4), //
- B(Call), R(4), R(5), U8(1), U8(vector->GetIndex(slot1)), //
- B(Star), R(1), //
- B(Ldar), R(1), //
- B(Star), R(6), //
- B(LoadIC), R(6), U8(2), U8(vector->GetIndex(slot4)), //
- B(Star), R(5), //
- B(Call), R(5), R(6), U8(1), U8(vector->GetIndex(slot3)), //
- B(Star), R(2), //
- B(Star), R(4), //
- B(CallRuntime), U16(Runtime::kInlineIsJSReceiver), R(4), U8(1), //
- B(LogicalNot), //
- B(JumpIfFalse), U8(11), //
- B(Ldar), R(2), //
- B(Star), R(4), //
- B(CallRuntime), U16(Runtime::kThrowIteratorResultNotAnObject), //
- /* */ R(4), U8(1), //
- B(Ldar), R(2), //
- B(Star), R(4), //
- B(LoadIC), R(4), U8(3), U8(vector->GetIndex(slot5)), //
- B(JumpIfToBooleanTrue), U8(19), //
- B(Ldar), R(2), //
- B(Star), R(4), //
- B(LoadIC), R(4), U8(4), U8(vector->GetIndex(slot6)), //
- B(Star), R(0), //
- B(StackCheck), //
- B(Ldar), R(0), //
- B(Star), R(3), //
- B(Jump), U8(-61), //
- B(LdaUndefined), //
- B(Return), //
- },
- 5,
- {InstanceType::FIXED_ARRAY_TYPE, InstanceType::SYMBOL_TYPE,
- InstanceType::ONE_BYTE_INTERNALIZED_STRING_TYPE,
- InstanceType::ONE_BYTE_INTERNALIZED_STRING_TYPE,
- InstanceType::ONE_BYTE_INTERNALIZED_STRING_TYPE}},
- {"var x = 'potatoes';\n"
- "for (var p of x) { return p; }",
- 8 * kPointerSize,
- 1,
- 85,
- {
- B(StackCheck), //
- B(LdaConstant), U8(0), //
- B(Star), R(3), //
- B(Star), R(6), //
- B(LdaConstant), U8(1), //
- B(KeyedLoadIC), R(6), U8(vector->GetIndex(slot2)), //
- B(Star), R(5), //
- B(Call), R(5), R(6), U8(1), U8(vector->GetIndex(slot1)), //
- B(Star), R(1), //
- B(Ldar), R(1), //
- B(Star), R(7), //
- B(LoadIC), R(7), U8(2), U8(vector->GetIndex(slot4)), //
- B(Star), R(6), //
- B(Call), R(6), R(7), U8(1), U8(vector->GetIndex(slot3)), //
- B(Star), R(2), //
- B(Star), R(5), //
- B(CallRuntime), U16(Runtime::kInlineIsJSReceiver), R(5), U8(1), //
- B(LogicalNot), //
- B(JumpIfFalse), U8(11), //
- B(Ldar), R(2), //
- B(Star), R(5), //
- B(CallRuntime), U16(Runtime::kThrowIteratorResultNotAnObject), //
- /* */ R(5), U8(1), //
- B(Ldar), R(2), //
- B(Star), R(5), //
- B(LoadIC), R(5), U8(3), U8(vector->GetIndex(slot5)), //
- B(JumpIfToBooleanTrue), U8(18), //
- B(Ldar), R(2), //
- B(Star), R(5), //
- B(LoadIC), R(5), U8(4), U8(vector->GetIndex(slot6)), //
- B(Star), R(0), //
- B(StackCheck), //
- B(Ldar), R(0), //
- B(Star), R(4), //
- B(Return), //
- B(LdaUndefined), //
- B(Return), //
- },
- 5,
- {InstanceType::ONE_BYTE_INTERNALIZED_STRING_TYPE,
- InstanceType::SYMBOL_TYPE,
- InstanceType::ONE_BYTE_INTERNALIZED_STRING_TYPE,
- InstanceType::ONE_BYTE_INTERNALIZED_STRING_TYPE,
- InstanceType::ONE_BYTE_INTERNALIZED_STRING_TYPE}},
- {"for (var x of [10, 20, 30]) {\n"
- " if (x == 10) continue;\n"
- " if (x == 20) break;\n"
- "}",
- 7 * kPointerSize,
- 1,
- 108,
- {
- B(StackCheck), //
- B(CreateArrayLiteral), U8(0), U8(0), U8(array_literal_flags), //
- B(Star), R(5), //
- B(LdaConstant), U8(1), //
- B(KeyedLoadIC), R(5), U8(vector->GetIndex(slot2)), //
- B(Star), R(4), //
- B(Call), R(4), R(5), U8(1), U8(vector->GetIndex(slot1)), //
- B(Star), R(1), //
- B(Ldar), R(1), //
- B(Star), R(6), //
- B(LoadIC), R(6), U8(2), U8(vector->GetIndex(slot4)), //
- B(Star), R(5), //
- B(Call), R(5), R(6), U8(1), U8(vector->GetIndex(slot3)), //
- B(Star), R(2), //
- B(Star), R(4), //
- B(CallRuntime), U16(Runtime::kInlineIsJSReceiver), R(4), U8(1), //
- B(LogicalNot), //
- B(JumpIfFalse), U8(11), //
- B(Ldar), R(2), //
- B(Star), R(4), //
- B(CallRuntime), U16(Runtime::kThrowIteratorResultNotAnObject), //
- /* */ R(4), U8(1), //
- B(Ldar), R(2), //
- B(Star), R(4), //
- B(LoadIC), R(4), U8(3), U8(vector->GetIndex(slot5)), //
- B(JumpIfToBooleanTrue), U8(41), //
- B(Ldar), R(2), //
- B(Star), R(4), //
- B(LoadIC), R(4), U8(4), U8(vector->GetIndex(slot6)), //
- B(Star), R(0), //
- B(StackCheck), //
- B(Ldar), R(0), //
- B(Star), R(3), //
- B(Star), R(4), //
- B(LdaSmi8), U8(10), //
- B(TestEqual), R(4), //
- B(JumpIfFalse), U8(4), //
- B(Jump), U8(-69), //
- B(Ldar), R(3), //
- B(Star), R(4), //
- B(LdaSmi8), U8(20), //
- B(TestEqual), R(4), //
- B(JumpIfFalse), U8(4), //
- B(Jump), U8(4), //
- B(Jump), U8(-83), //
- B(LdaUndefined), //
- B(Return), //
- },
- 5,
- {InstanceType::FIXED_ARRAY_TYPE, InstanceType::SYMBOL_TYPE,
- InstanceType::ONE_BYTE_INTERNALIZED_STRING_TYPE,
- InstanceType::ONE_BYTE_INTERNALIZED_STRING_TYPE,
- InstanceType::ONE_BYTE_INTERNALIZED_STRING_TYPE}},
- {"var x = { 'a': 1, 'b': 2 };\n"
- "for (x['a'] of [1,2,3]) { return x['a']; }",
- 6 * kPointerSize,
- 1,
- 103,
- {
- B(StackCheck), //
- B(CreateObjectLiteral), U8(0), U8(0), U8(object_literal_flags), //
- B(Star), R(3), //
- B(Star), R(2), //
- B(CreateArrayLiteral), U8(1), U8(1), U8(array_literal_flags), //
- B(Star), R(4), //
- B(LdaConstant), U8(2), //
- B(KeyedLoadIC), R(4), U8(vector->GetIndex(slot2)), //
- B(Star), R(3), //
- B(Call), R(3), R(4), U8(1), U8(vector->GetIndex(slot1)), //
- B(Star), R(0), //
- B(Ldar), R(0), //
- B(Star), R(5), //
- B(LoadIC), R(5), U8(3), U8(vector->GetIndex(slot4)), //
- B(Star), R(4), //
- B(Call), R(4), R(5), U8(1), U8(vector->GetIndex(slot3)), //
- B(Star), R(1), //
- B(Star), R(3), //
- B(CallRuntime), U16(Runtime::kInlineIsJSReceiver), R(3), U8(1), //
- B(LogicalNot), //
- B(JumpIfFalse), U8(11), //
- B(Ldar), R(1), //
- B(Star), R(3), //
- B(CallRuntime), U16(Runtime::kThrowIteratorResultNotAnObject), //
- /* */ R(3), U8(1), //
- B(Ldar), R(1), //
- B(Star), R(3), //
- B(LoadIC), R(3), U8(4), U8(vector->GetIndex(slot5)), //
- B(JumpIfToBooleanTrue), U8(28), //
- B(Ldar), R(2), //
- B(Star), R(3), //
- B(Ldar), R(1), //
- B(Star), R(4), //
- B(LoadIC), R(4), U8(5), U8(vector->GetIndex(slot6)), //
- B(StoreICSloppy), R(3), U8(6), U8(vector->GetIndex(slot7)), //
- B(StackCheck), //
- B(Ldar), R(2), //
- B(Star), R(3), //
- B(LoadIC), R(3), U8(6), U8(vector->GetIndex(slot8)), //
- B(Return), //
- B(LdaUndefined), //
- B(Return), //
- },
- 7,
- {InstanceType::FIXED_ARRAY_TYPE,
- InstanceType::FIXED_ARRAY_TYPE,
- InstanceType::SYMBOL_TYPE,
- InstanceType::ONE_BYTE_INTERNALIZED_STRING_TYPE,
- InstanceType::ONE_BYTE_INTERNALIZED_STRING_TYPE,
- InstanceType::ONE_BYTE_INTERNALIZED_STRING_TYPE,
- InstanceType::ONE_BYTE_INTERNALIZED_STRING_TYPE}},
- };
- // clang-format on
+TEST(ForOf) {
+ InitializedIgnitionHandleScope scope;
+ BytecodeExpectationsPrinter printer(CcTest::isolate(),
+ ConstantPoolType::kMixed);
+ const char* snippets[] = {
+ "for (var p of [0, 1, 2]) {}",
- for (size_t i = 0; i < arraysize(snippets); i++) {
- Handle<BytecodeArray> bytecode_array =
- helper.MakeBytecodeForFunctionBody(snippets[i].code_snippet);
- CheckBytecodeArrayEqual(snippets[i], bytecode_array);
- }
-}
+ "var x = 'potatoes';\n"
+ "for (var p of x) { return p; }",
+ "for (var x of [10, 20, 30]) {\n"
+ " if (x == 10) continue;\n"
+ " if (x == 20) break;\n"
+ "}",
-TEST(Conditional) {
- InitializedHandleScope handle_scope;
- BytecodeGeneratorHelper helper;
-
- // clang-format off
- ExpectedSnippet<int> snippets[] = {
- {"return 1 ? 2 : 3;",
- 0,
- 1,
- 12,
- {
- B(StackCheck), //
- B(LdaSmi8), U8(1), //
- B(JumpIfToBooleanFalse), U8(6), //
- B(LdaSmi8), U8(2), //
- B(Jump), U8(4), //
- B(LdaSmi8), U8(3), //
- B(Return), //
- }},
- {"return 1 ? 2 ? 3 : 4 : 5;",
- 0,
- 1,
- 20,
- {
- B(StackCheck), //
- B(LdaSmi8), U8(1), //
- B(JumpIfToBooleanFalse), U8(14), //
- B(LdaSmi8), U8(2), //
- B(JumpIfToBooleanFalse), U8(6), //
- B(LdaSmi8), U8(3), //
- B(Jump), U8(4), //
- B(LdaSmi8), U8(4), //
- B(Jump), U8(4), //
- B(LdaSmi8), U8(5), //
- B(Return), //
- }},
+ "var x = { 'a': 1, 'b': 2 };\n"
+ "for (x['a'] of [1,2,3]) { return x['a']; }",
};
- // clang-format on
- for (size_t i = 0; i < arraysize(snippets); i++) {
- Handle<BytecodeArray> bytecode_array =
- helper.MakeBytecodeForFunctionBody(snippets[i].code_snippet);
- CheckBytecodeArrayEqual(snippets[i], bytecode_array);
- }
+ CHECK_EQ(BuildActual(printer, snippets),
+ LoadGolden("ForOf.golden"));
}
-
-TEST(Switch) {
- InitializedHandleScope handle_scope;
- BytecodeGeneratorHelper helper;
-
- // clang-format off
- ExpectedSnippet<int> snippets[] = {
- {"var a = 1;\n"
- "switch(a) {\n"
- " case 1: return 2;\n"
- " case 2: return 3;\n"
- "}\n",
- 3 * kPointerSize,
- 1,
- 31,
- {
- B(StackCheck), //
- B(LdaSmi8), U8(1), //
- B(Star), R(1), // The tag variable is allocated as a
- B(Star), R(0), // local by the parser, hence the store
- B(Star), R(2), // to another local register.
- B(LdaSmi8), U8(1), //
- B(TestEqualStrict), R(2), //
- B(JumpIfTrue), U8(10), //
- B(LdaSmi8), U8(2), //
- B(TestEqualStrict), R(2), //
- B(JumpIfTrue), U8(7), //
- B(Jump), U8(8), //
- B(LdaSmi8), U8(2), //
- B(Return), //
- B(LdaSmi8), U8(3), //
- B(Return), //
- B(LdaUndefined), //
- B(Return), //
- }},
- {"var a = 1;\n"
- "switch(a) {\n"
- " case 1: a = 2; break;\n"
- " case 2: a = 3; break;\n"
- "}\n",
- 3 * kPointerSize,
- 1,
- 37,
- {
- B(StackCheck), //
- B(LdaSmi8), U8(1), //
- B(Star), R(1), //
- B(Star), R(0), //
- B(Star), R(2), //
- B(LdaSmi8), U8(1), //
- B(TestEqualStrict), R(2), //
- B(JumpIfTrue), U8(10), //
- B(LdaSmi8), U8(2), //
- B(TestEqualStrict), R(2), //
- B(JumpIfTrue), U8(10), //
- B(Jump), U8(14), //
- B(LdaSmi8), U8(2), //
- B(Star), R(1), //
- B(Jump), U8(8), //
- B(LdaSmi8), U8(3), //
- B(Star), R(1), //
- B(Jump), U8(2), //
- B(LdaUndefined), //
- B(Return), //
- }},
- {"var a = 1;\n"
- "switch(a) {\n"
- " case 1: a = 2; // fall-through\n"
- " case 2: a = 3; break;\n"
- "}\n",
- 3 * kPointerSize,
- 1,
- 35,
- {
- B(StackCheck), //
- B(LdaSmi8), U8(1), //
- B(Star), R(1), //
- B(Star), R(0), //
- B(Star), R(2), //
- B(LdaSmi8), U8(1), //
- B(TestEqualStrict), R(2), //
- B(JumpIfTrue), U8(10), //
- B(LdaSmi8), U8(2), //
- B(TestEqualStrict), R(2), //
- B(JumpIfTrue), U8(8), //
- B(Jump), U8(12), //
- B(LdaSmi8), U8(2), //
- B(Star), R(1), //
- B(LdaSmi8), U8(3), //
- B(Star), R(1), //
- B(Jump), U8(2), //
- B(LdaUndefined), //
- B(Return), //
- }},
- {"var a = 1;\n"
- "switch(a) {\n"
- " case 2: break;\n"
- " case 3: break;\n"
- " default: a = 1; break;\n"
- "}\n",
- 3 * kPointerSize,
- 1,
- 35,
- {
- B(StackCheck), //
- B(LdaSmi8), U8(1), //
- B(Star), R(1), //
- B(Star), R(0), //
- B(Star), R(2), //
- B(LdaSmi8), U8(2), //
- B(TestEqualStrict), R(2), //
- B(JumpIfTrue), U8(10), //
- B(LdaSmi8), U8(3), //
- B(TestEqualStrict), R(2), //
- B(JumpIfTrue), U8(6), //
- B(Jump), U8(6), //
- B(Jump), U8(10), //
- B(Jump), U8(8), //
- B(LdaSmi8), U8(1), //
- B(Star), R(1), //
- B(Jump), U8(2), //
- B(LdaUndefined), //
- B(Return), //
- }},
- {"var a = 1;\n"
- "switch(typeof(a)) {\n"
- " case 2: a = 1; break;\n"
- " case 3: a = 2; break;\n"
- " default: a = 3; break;\n"
- "}\n",
- 3 * kPointerSize,
- 1,
- 44,
- {
- B(StackCheck), //
- B(LdaSmi8), U8(1), //
- B(Star), R(1), //
- B(TypeOf), //
- B(Star), R(0), //
- B(Star), R(2), //
- B(LdaSmi8), U8(2), //
- B(TestEqualStrict), R(2), //
- B(JumpIfTrue), U8(10), //
- B(LdaSmi8), U8(3), //
- B(TestEqualStrict), R(2), //
- B(JumpIfTrue), U8(10), //
- B(Jump), U8(14), //
- B(LdaSmi8), U8(1), //
- B(Star), R(1), //
- B(Jump), U8(14), //
- B(LdaSmi8), U8(2), //
- B(Star), R(1), //
- B(Jump), U8(8), //
- B(LdaSmi8), U8(3), //
- B(Star), R(1), //
- B(Jump), U8(2), //
- B(LdaUndefined), //
- B(Return), //
- }},
- {"var a = 1;\n"
- "switch(a) {\n"
- " case typeof(a): a = 1; break;\n"
- " default: a = 2; break;\n"
- "}\n",
- 3 * kPointerSize,
- 1,
- 32,
- {
- B(StackCheck), //
- B(LdaSmi8), U8(1), //
- B(Star), R(1), //
- B(Star), R(0), //
- B(Star), R(2), //
- B(Ldar), R(1), //
- B(TypeOf), //
- B(TestEqualStrict), R(2), //
- B(JumpIfTrue), U8(4), //
- B(Jump), U8(8), //
- B(LdaSmi8), U8(1), //
- B(Star), R(1), //
- B(Jump), U8(8), //
- B(LdaSmi8), U8(2), //
- B(Star), R(1), //
- B(Jump), U8(2), //
- B(LdaUndefined), //
- B(Return), //
- }},
- {"var a = 1;\n"
- "switch(a) {\n"
- " case 1:\n" REPEAT_64(SPACE, " a = 2;")
- "break;\n"
- " case 2: a = 3; break;"
- "}\n",
- 3 * kPointerSize,
- 1,
- 289,
- {
- B(StackCheck), //
- B(LdaSmi8), U8(1), //
- B(Star), R(1), //
- B(Star), R(0), //
- B(Star), R(2), //
- B(LdaSmi8), U8(1), //
- B(TestEqualStrict), R(2), //
- B(JumpIfTrue), U8(10), //
- B(LdaSmi8), U8(2), //
- B(TestEqualStrict), R(2), //
- B(JumpIfTrueConstant), U8(0), //
- B(JumpConstant), U8(1), //
- REPEAT_64(COMMA, //
- B(LdaSmi8), U8(2), //
- B(Star), R(1)), //
- B(Jump), U8(8), //
- B(LdaSmi8), U8(3), //
- B(Star), R(1), //
- B(Jump), U8(2), //
- B(LdaUndefined), //
- B(Return), //
- },
- 2,
- {262, 266}},
- {"var a = 1;\n"
- "switch(a) {\n"
- " case 1: \n"
- " switch(a + 1) {\n"
- " case 2 : a = 1; break;\n"
- " default : a = 2; break;\n"
- " } // fall-through\n"
- " case 2: a = 3;\n"
- "}\n",
- 5 * kPointerSize,
- 1,
- 61,
- {
- B(StackCheck), //
- B(LdaSmi8), U8(1), //
- B(Star), R(2), //
- B(Star), R(0), //
- B(Star), R(3), //
- B(LdaSmi8), U8(1), //
- B(TestEqualStrict), R(3), //
- B(JumpIfTrue), U8(10), //
- B(LdaSmi8), U8(2), //
- B(TestEqualStrict), R(3), //
- B(JumpIfTrue), U8(36), //
- B(Jump), U8(38), //
- B(Ldar), R(2), //
- B(Star), R(4), //
- B(LdaSmi8), U8(1), //
- B(Add), R(4), //
- B(Star), R(1), //
- B(Star), R(4), //
- B(LdaSmi8), U8(2), //
- B(TestEqualStrict), R(4), //
- B(JumpIfTrue), U8(4), //
- B(Jump), U8(8), //
- B(LdaSmi8), U8(1), //
- B(Star), R(2), //
- B(Jump), U8(8), //
- B(LdaSmi8), U8(2), //
- B(Star), R(2), //
- B(Jump), U8(2), //
- B(LdaSmi8), U8(3), //
- B(Star), R(2), //
- B(LdaUndefined), //
- B(Return), //
- }},
+TEST(Conditional) {
+ InitializedIgnitionHandleScope scope;
+ BytecodeExpectationsPrinter printer(CcTest::isolate(),
+ ConstantPoolType::kNumber);
+ const char* snippets[] = {
+ "return 1 ? 2 : 3;",
+ "return 1 ? 2 ? 3 : 4 : 5;",
};
- // clang-format on
- for (size_t i = 0; i < arraysize(snippets); i++) {
- Handle<BytecodeArray> bytecode_array =
- helper.MakeBytecodeForFunctionBody(snippets[i].code_snippet);
- CheckBytecodeArrayEqual(snippets[i], bytecode_array);
- }
+ CHECK_EQ(BuildActual(printer, snippets),
+ LoadGolden("Conditional.golden"));
}
+TEST(Switch) {
+ InitializedIgnitionHandleScope scope;
+ BytecodeExpectationsPrinter printer(CcTest::isolate(),
+ ConstantPoolType::kNumber);
+ const char* snippets[] = {
+ "var a = 1;\n"
+ "switch(a) {\n"
+ " case 1: return 2;\n"
+ " case 2: return 3;\n"
+ "}\n",
+
+ "var a = 1;\n"
+ "switch(a) {\n"
+ " case 1: a = 2; break;\n"
+ " case 2: a = 3; break;\n"
+ "}\n",
+
+ "var a = 1;\n"
+ "switch(a) {\n"
+ " case 1: a = 2; // fall-through\n"
+ " case 2: a = 3; break;\n"
+ "}\n",
+
+ "var a = 1;\n"
+ "switch(a) {\n"
+ " case 2: break;\n"
+ " case 3: break;\n"
+ " default: a = 1; break;\n"
+ "}\n",
+
+ "var a = 1;\n"
+ "switch(typeof(a)) {\n"
+ " case 2: a = 1; break;\n"
+ " case 3: a = 2; break;\n"
+ " default: a = 3; break;\n"
+ "}\n",
+
+ "var a = 1;\n"
+ "switch(a) {\n"
+ " case typeof(a): a = 1; break;\n"
+ " default: a = 2; break;\n"
+ "}\n",
+
+ "var a = 1;\n"
+ "switch(a) {\n"
+ " case 1:\n" REPEAT_64(SPACE, " a = 2;\n")
+ "break;\n"
+ " case 2: a = 3; break;\n"
+ "}\n",
+
+ "var a = 1;\n"
+ "switch(a) {\n"
+ " case 1: \n"
+ " switch(a + 1) {\n"
+ " case 2 : a = 1; break;\n"
+ " default : a = 2; break;\n"
+ " } // fall-through\n"
+ " case 2: a = 3;\n"
+ "}\n",
+ };
+
+ CHECK_EQ(BuildActual(printer, snippets),
+ LoadGolden("Switch.golden"));
+}
TEST(BasicBlockToBoolean) {
- InitializedHandleScope handle_scope;
- BytecodeGeneratorHelper helper;
-
- // Check that we generate JumpIfToBoolean if they are at the start of basic
- // blocks.
- // clang-format off
- ExpectedSnippet<int> snippets[] = {
- {"var a = 1; if (a || a < 0) { return 1; }",
- 2 * kPointerSize,
- 1,
- 21,
- {
- B(StackCheck), //
- B(LdaSmi8), U8(1), //
- B(Star), R(0), //
- B(JumpIfToBooleanTrue), U8(9), //
- B(Ldar), R(0), //
- B(Star), R(1), //
- B(LdaZero), //
- B(TestLessThan), R(1), //
- B(JumpIfToBooleanFalse), U8(5), //
- B(LdaSmi8), U8(1), //
- B(Return), //
- B(LdaUndefined), //
- B(Return), //
- }},
- {"var a = 1; if (a && a < 0) { return 1; }",
- 2 * kPointerSize,
- 1,
- 21,
- {
- B(StackCheck), //
- B(LdaSmi8), U8(1), //
- B(Star), R(0), //
- B(JumpIfToBooleanFalse), U8(9), //
- B(Ldar), R(0), //
- B(Star), R(1), //
- B(LdaZero), //
- B(TestLessThan), R(1), //
- B(JumpIfToBooleanFalse), U8(5), //
- B(LdaSmi8), U8(1), //
- B(Return), //
- B(LdaUndefined), //
- B(Return), //
- }},
- {"var a = 1; a = (a || a < 0) ? 2 : 3;",
- 2 * kPointerSize,
- 1,
- 26,
- {
- B(StackCheck), //
- B(LdaSmi8), U8(1), //
- B(Star), R(0), //
- B(JumpIfToBooleanTrue), U8(9), //
- B(Ldar), R(0), //
- B(Star), R(1), //
- B(LdaZero), //
- B(TestLessThan), R(1), //
- B(JumpIfToBooleanFalse), U8(6), //
- B(LdaSmi8), U8(2), //
- B(Jump), U8(4), //
- B(LdaSmi8), U8(3), //
- B(Star), R(0), //
- B(LdaUndefined), //
- B(Return), //
- }},
+ InitializedIgnitionHandleScope scope;
+ BytecodeExpectationsPrinter printer(CcTest::isolate(),
+ ConstantPoolType::kNumber);
+ const char* snippets[] = {
+ "var a = 1; if (a || a < 0) { return 1; }",
+ "var a = 1; if (a && a < 0) { return 1; }",
+ "var a = 1; a = (a || a < 0) ? 2 : 3;",
};
- // clang-format on
- for (size_t i = 0; i < arraysize(snippets); i++) {
- Handle<BytecodeArray> bytecode_array =
- helper.MakeBytecodeForFunctionBody(snippets[i].code_snippet);
- CheckBytecodeArrayEqual(snippets[i], bytecode_array);
- }
+ CHECK_EQ(BuildActual(printer, snippets),
+ LoadGolden("BasicBlockToBoolean.golden"));
}
-
TEST(DeadCodeRemoval) {
- InitializedHandleScope handle_scope;
- BytecodeGeneratorHelper helper;
-
- // clang-format off
- ExpectedSnippet<int> snippets[] = {
- {"return; var a = 1; a();",
- 1 * kPointerSize,
- 1,
- 3,
- {
- B(StackCheck), //
- B(LdaUndefined), //
- B(Return), //
- }},
- {"if (false) { return; }; var a = 1;",
- 1 * kPointerSize,
- 1,
- 7,
- {
- B(StackCheck), //
- B(LdaSmi8), U8(1), //
- B(Star), R(0), //
- B(LdaUndefined), //
- B(Return), //
- }},
- {"if (true) { return 1; } else { return 2; };",
- 0,
- 1,
- 4,
- {
- B(StackCheck), //
- B(LdaSmi8), U8(1), //
- B(Return), //
- }},
- {"var a = 1; if (a) { return 1; }; return 2;",
- 1 * kPointerSize,
- 1,
- 13,
- {
- B(StackCheck), //
- B(LdaSmi8), U8(1), //
- B(Star), R(0), //
- B(JumpIfToBooleanFalse), U8(5), //
- B(LdaSmi8), U8(1), //
- B(Return), //
- B(LdaSmi8), U8(2), //
- B(Return), //
- }},
+ InitializedIgnitionHandleScope scope;
+ BytecodeExpectationsPrinter printer(CcTest::isolate(),
+ ConstantPoolType::kNumber);
+ const char* snippets[] = {
+ "return; var a = 1; a();",
+ "if (false) { return; }; var a = 1;",
+ "if (true) { return 1; } else { return 2; };",
+ "var a = 1; if (a) { return 1; }; return 2;",
};
- // clang-format on
- for (size_t i = 0; i < arraysize(snippets); i++) {
- Handle<BytecodeArray> bytecode_array =
- helper.MakeBytecodeForFunctionBody(snippets[i].code_snippet);
- CheckBytecodeArrayEqual(snippets[i], bytecode_array);
- }
+ CHECK_EQ(BuildActual(printer, snippets),
+ LoadGolden("DeadCodeRemoval.golden"));
}
-
TEST(ThisFunction) {
- InitializedHandleScope handle_scope;
- BytecodeGeneratorHelper helper;
-
- int closure = Register::function_closure().index();
-
- // clang-format off
- ExpectedSnippet<int> snippets[] = {
- {"var f;\n f = function f() { }",
- 2 * kPointerSize,
- 1,
- 19,
- {
- B(LdaTheHole), //
- B(Star), R(0), //
- B(StackCheck), //
- B(Ldar), R(closure), //
- B(Star), R(1), //
- B(Ldar), R(0), //
- B(JumpIfNotHole), U8(5), //
- B(Mov), R(1), R(0), //
- B(Ldar), R(1), //
- B(LdaUndefined), //
- B(Return), //
- }},
- {"var f;\n f = function f() { return f; }",
- 2 * kPointerSize,
- 1,
- 23,
- {
- B(LdaTheHole), //
- B(Star), R(0), //
- B(StackCheck), //
- B(Ldar), R(closure), //
- B(Star), R(1), //
- B(Ldar), R(0), //
- B(JumpIfNotHole), U8(5), //
- B(Mov), R(1), R(0), //
- B(Ldar), R(1), //
- B(Ldar), R(0), //
- B(JumpIfNotHole), U8(3), //
- B(LdaUndefined), //
- B(Return), //
- }},
+ InitializedIgnitionHandleScope scope;
+ BytecodeExpectationsPrinter printer(CcTest::isolate(),
+ ConstantPoolType::kNumber);
+ printer.set_wrap(false);
+ printer.set_test_function_name("f");
+
+ const char* snippets[] = {
+ "var f;\n f = function f() { }",
+ "var f;\n f = function f() { return f; }",
};
- // clang-format on
- for (size_t i = 0; i < arraysize(snippets); i++) {
- Handle<BytecodeArray> bytecode_array =
- helper.MakeBytecodeForFunction(snippets[i].code_snippet);
- CheckBytecodeArrayEqual(snippets[i], bytecode_array);
- }
+ CHECK_EQ(BuildActual(printer, snippets, "", "\nf();"),
+ LoadGolden("ThisFunction.golden"));
}
-
TEST(NewTarget) {
- InitializedHandleScope handle_scope;
- BytecodeGeneratorHelper helper;
-
- int new_target = Register::new_target().index();
-
- // clang-format off
- ExpectedSnippet<InstanceType> snippets[] = {
- {"return new.target;",
- 2 * kPointerSize,
- 1,
- 19,
- {
- B(Ldar), R(new_target), //
- B(Star), R(0), //
- B(StackCheck), //
- B(Ldar), R(0), //
- B(JumpIfNotHole), U8(11), //
- B(LdaConstant), U8(0), //
- B(Star), R(1), //
- B(CallRuntime), U16(Runtime::kThrowReferenceError), R(1), U8(1), //
- B(Return), //
- },
- 1,
- {InstanceType::ONE_BYTE_INTERNALIZED_STRING_TYPE}},
- {"new.target;",
- 2 * kPointerSize,
- 1,
- 20,
- {
- B(Ldar), R(new_target), //
- B(Star), R(0), //
- B(StackCheck), //
- B(Ldar), R(0), //
- B(JumpIfNotHole), U8(11), //
- B(LdaConstant), U8(0), //
- B(Star), R(1), //
- B(CallRuntime), U16(Runtime::kThrowReferenceError), R(1), U8(1), //
- B(LdaUndefined), //
- B(Return), //
- },
- 1,
- {InstanceType::ONE_BYTE_INTERNALIZED_STRING_TYPE}}};
- // clang-format on
-
- for (size_t i = 0; i < arraysize(snippets); i++) {
- Handle<BytecodeArray> bytecode_array =
- helper.MakeBytecodeForFunctionBody(snippets[i].code_snippet);
- CheckBytecodeArrayEqual(snippets[i], bytecode_array);
- }
-}
+ InitializedIgnitionHandleScope scope;
+ BytecodeExpectationsPrinter printer(CcTest::isolate(),
+ ConstantPoolType::kMixed);
+ const char* snippets[] = {
+ "return new.target;",
+ "new.target;",
+ };
+
+ CHECK_EQ(BuildActual(printer, snippets),
+ LoadGolden("NewTarget.golden"));
+}
TEST(RemoveRedundantLdar) {
- InitializedHandleScope handle_scope;
- BytecodeGeneratorHelper helper;
-
- // clang-format off
- ExpectedSnippet<int> snippets[] = {
- {"var ld_a = 1;\n" // This test is to check Ldar does not
- "while(true) {\n" // get removed if the preceding Star is
- " ld_a = ld_a + ld_a;\n" // in a different basicblock.
- " if (ld_a > 10) break;\n"
- "}\n"
- "return ld_a;",
- 2 * kPointerSize,
- 1,
- 31,
- {B(StackCheck), //
- B(LdaSmi8), U8(1), //
- B(Star), R(0), //
- B(StackCheck), //
- B(Ldar), R(0), // This load should not be removed as it
- B(Star), R(1), // is the target of the branch.
- B(Ldar), R(0), //
- B(Add), R(1), //
- B(Star), R(0), //
- B(Star), R(1), //
- B(LdaSmi8), U8(10), //
- B(TestGreaterThan), R(1), //
- B(JumpIfFalse), U8(4), //
- B(Jump), U8(4), //
- B(Jump), U8(-21), //
- B(Ldar), R(0), //
- B(Return)}},
- {"var ld_a = 1;\n"
- "do {\n"
- " ld_a = ld_a + ld_a;\n"
- " if (ld_a > 10) continue;\n"
- "} while(false);\n"
- "return ld_a;",
- 2 * kPointerSize,
- 1,
- 29,
- {B(StackCheck), //
- B(LdaSmi8), U8(1), //
- B(Star), R(0), //
- B(StackCheck), //
- B(Ldar), R(0), //
- B(Star), R(1), //
- B(Ldar), R(0), //
- B(Add), R(1), //
- B(Star), R(0), //
- B(Star), R(1), //
- B(LdaSmi8), U8(10), //
- B(TestGreaterThan), R(1), //
- B(JumpIfFalse), U8(4), //
- B(Jump), U8(2), //
- B(Ldar), R(0), //
- B(Return)}},
- {"var ld_a = 1;\n"
- " ld_a = ld_a + ld_a;\n"
- " return ld_a;",
- 2 * kPointerSize,
- 1,
- 14,
- {
- B(StackCheck), //
- B(LdaSmi8), U8(1), //
- B(Star), R(0), //
- B(Star), R(1), //
- B(Ldar), R(0), //
- B(Add), R(1), //
- B(Star), R(0), //
- B(Return) //
- }},
+ InitializedIgnitionHandleScope scope;
+ BytecodeExpectationsPrinter printer(CcTest::isolate(),
+ ConstantPoolType::kNumber);
+ const char* snippets[] = {
+ "var ld_a = 1;\n" // This test is to check Ldar does not
+ "while(true) {\n" // get removed if the preceding Star is
+ " ld_a = ld_a + ld_a;\n" // in a different basicblock.
+ " if (ld_a > 10) break;\n"
+ "}\n"
+ "return ld_a;",
+
+ "var ld_a = 1;\n"
+ "do {\n"
+ " ld_a = ld_a + ld_a;\n"
+ " if (ld_a > 10) continue;\n"
+ "} while(false);\n"
+ "return ld_a;",
+
+ "var ld_a = 1;\n"
+ " ld_a = ld_a + ld_a;\n"
+ " return ld_a;",
};
- // clang-format on
- for (size_t i = 0; i < arraysize(snippets); i++) {
- Handle<BytecodeArray> bytecode_array =
- helper.MakeBytecodeForFunctionBody(snippets[i].code_snippet);
- CheckBytecodeArrayEqual(snippets[i], bytecode_array);
- }
+ CHECK_EQ(BuildActual(printer, snippets),
+ LoadGolden("RemoveRedundantLdar.golden"));
}
-
TEST(AssignmentsInBinaryExpression) {
- InitializedHandleScope handle_scope;
- BytecodeGeneratorHelper helper;
-
- // clang-format off
- ExpectedSnippet<const char*> snippets[] = {
- {"var x = 0, y = 1;\n"
- "return (x = 2, y = 3, x = 4, y = 5)",
- 2 * kPointerSize,
- 1,
- 25,
- {
- B(StackCheck), //
- B(LdaZero), B(Star), R(0), //
- B(LdaSmi8), U8(1), //
- B(Star), R(1), //
- B(LdaSmi8), U8(2), //
- B(Star), R(0), //
- B(LdaSmi8), U8(3), //
- B(Star), R(1), //
- B(LdaSmi8), U8(4), //
- B(Star), R(0), //
- B(LdaSmi8), U8(5), //
- B(Star), R(1), //
- B(Return), //
- },
- 0},
- {"var x = 55;\n"
- "var y = (x = 100);\n"
- "return y",
- 2 * kPointerSize,
- 1,
- 12,
- {
- B(StackCheck), //
- B(LdaSmi8), U8(55), //
- B(Star), R(0), //
- B(LdaSmi8), U8(100), //
- B(Star), R(0), //
- B(Star), R(1), //
- B(Return), //
- },
- 0},
- {"var x = 55;\n"
- "x = x + (x = 100) + (x = 101);\n"
- "return x;",
- 3 * kPointerSize,
- 1,
- 24,
- {
- B(StackCheck), //
- B(LdaSmi8), U8(55), //
- B(Star), R(0), //
- B(Star), R(1), //
- B(LdaSmi8), U8(100), //
- B(Star), R(0), //
- B(Add), R(1), //
- B(Star), R(2), //
- B(LdaSmi8), U8(101), //
- B(Star), R(0), //
- B(Add), R(2), //
- B(Star), R(0), //
- B(Return), //
- },
- 0},
- {"var x = 55;\n"
- "x = (x = 56) - x + (x = 57);\n"
- "x++;\n"
- "return x;",
- 3 * kPointerSize,
- 1,
- 32,
- {
- B(StackCheck), //
- B(LdaSmi8), U8(55), //
- B(Star), R(0), //
- B(LdaSmi8), U8(56), //
- B(Star), R(0), //
- B(Star), R(1), //
- B(Ldar), R(0), //
- B(Sub), R(1), //
- B(Star), R(2), //
- B(LdaSmi8), U8(57), //
- B(Star), R(0), //
- B(Add), R(2), //
- B(Star), R(0), //
- B(ToNumber), //
- B(Star), R(1), //
- B(Inc), //
- B(Star), R(0), //
- B(Return), //
- },
- 0},
- {"var x = 55;\n"
- "var y = x + (x = 1) + (x = 2) + (x = 3);\n"
- "return y;",
- 4 * kPointerSize,
- 1,
- 32,
- {
- B(StackCheck), //
- B(LdaSmi8), U8(55), //
- B(Star), R(0), //
- B(Star), R(2), //
- B(LdaSmi8), U8(1), //
- B(Star), R(0), //
- B(Add), R(2), //
- B(Star), R(3), //
- B(LdaSmi8), U8(2), //
- B(Star), R(0), //
- B(Add), R(3), //
- B(Star), R(2), //
- B(LdaSmi8), U8(3), //
- B(Star), R(0), //
- B(Add), R(2), //
- B(Star), R(1), //
- B(Return), //
- },
- 0},
- {"var x = 55;\n"
- "var x = x + (x = 1) + (x = 2) + (x = 3);\n"
- "return x;",
- 3 * kPointerSize,
- 1,
- 32,
- {
- B(StackCheck), //
- B(LdaSmi8), U8(55), //
- B(Star), R(0), //
- B(Star), R(1), //
- B(LdaSmi8), U8(1), //
- B(Star), R(0), //
- B(Add), R(1), //
- B(Star), R(2), //
- B(LdaSmi8), U8(2), //
- B(Star), R(0), //
- B(Add), R(2), //
- B(Star), R(1), //
- B(LdaSmi8), U8(3), //
- B(Star), R(0), //
- B(Add), R(1), //
- B(Star), R(0), //
- B(Return), //
- },
- 0},
- {"var x = 10, y = 20;\n"
- "return x + (x = 1) + (x + 1) * (y = 2) + (y = 3) + (x = 4) + (y = 5) + "
- "y;\n",
- 5 * kPointerSize,
- 1,
- 70,
- {
- B(StackCheck), //
- B(LdaSmi8), U8(10), //
- B(Star), R(0), //
- B(LdaSmi8), U8(20), //
- B(Star), R(1), //
- B(Ldar), R(0), //
- B(Star), R(2), //
- B(LdaSmi8), U8(1), //
- B(Star), R(0), //
- B(Add), R(2), //
- B(Star), R(3), //
- B(Ldar), R(0), //
- B(Star), R(2), //
- B(LdaSmi8), U8(1), //
- B(Add), R(2), //
- B(Star), R(4), //
- B(LdaSmi8), U8(2), //
- B(Star), R(1), //
- B(Mul), R(4), //
- B(Add), R(3), //
- B(Star), R(2), //
- B(LdaSmi8), U8(3), //
- B(Star), R(1), //
- B(Add), R(2), //
- B(Star), R(3), //
- B(LdaSmi8), U8(4), //
- B(Star), R(0), //
- B(Add), R(3), //
- B(Star), R(2), //
- B(LdaSmi8), U8(5), //
- B(Star), R(1), //
- B(Add), R(2), //
- B(Star), R(3), //
- B(Ldar), R(1), //
- B(Add), R(3), //
- B(Return), //
- },
- 0},
- {"var x = 17;\n"
- "return 1 + x + (x++) + (++x);\n",
- 4 * kPointerSize,
- 1,
- 38,
- {
- B(StackCheck), //
- B(LdaSmi8), U8(17), //
- B(Star), R(0), //
- B(LdaSmi8), U8(1), //
- B(Star), R(1), //
- B(Ldar), R(0), //
- B(Add), R(1), //
- B(Star), R(2), //
- B(Ldar), R(0), //
- B(ToNumber), //
- B(Star), R(1), //
- B(Inc), //
- B(Star), R(0), //
- B(Ldar), R(1), //
- B(Add), R(2), //
- B(Star), R(3), //
- B(Ldar), R(0), //
- B(ToNumber), //
- B(Inc), //
- B(Star), R(0), //
- B(Add), R(3), //
- B(Return), //
- },
- 0}
+ InitializedIgnitionHandleScope scope;
+ BytecodeExpectationsPrinter printer(CcTest::isolate(),
+ ConstantPoolType::kString);
+ const char* snippets[] = {
+ "var x = 0, y = 1;\n"
+ "return (x = 2, y = 3, x = 4, y = 5)",
rmcilroy 2016/02/24 08:55:35 nit - I realize this wasn't your change, but pleas
Stefano Sanfilippo 2016/02/24 14:55:01 Done.
+
+ "var x = 55;\n"
+ "var y = (x = 100);\n"
+ "return y",
+
+ "var x = 55;\n"
+ "x = x + (x = 100) + (x = 101);\n"
+ "return x;",
+
+ "var x = 55;\n"
+ "x = (x = 56) - x + (x = 57);\n"
+ "x++;\n"
+ "return x;",
+
+ "var x = 55;\n"
+ "var y = x + (x = 1) + (x = 2) + (x = 3);\n"
+ "return y;",
+
+ "var x = 55;\n"
+ "var x = x + (x = 1) + (x = 2) + (x = 3);\n"
+ "return x;",
+
+ "var x = 10, y = 20;\n"
+ "return x + (x = 1) + (x + 1) * (y = 2) + (y = 3) + (x = 4) + (y = 5) + "
+ "y;\n",
+
+ "var x = 17;\n"
+ "return 1 + x + (x++) + (++x);\n",
};
- // clang-format on
- for (size_t i = 0; i < arraysize(snippets); i++) {
- Handle<BytecodeArray> bytecode_array =
- helper.MakeBytecodeForFunctionBody(snippets[i].code_snippet);
- CheckBytecodeArrayEqual(snippets[i], bytecode_array);
- }
+ CHECK_EQ(BuildActual(printer, snippets),
+ LoadGolden("AssignmentsInBinaryExpression.golden"));
}
-
TEST(Eval) {
- InitializedHandleScope handle_scope;
- BytecodeGeneratorHelper helper;
- Zone zone;
-
- int closure = Register::function_closure().index();
- int context = Register::current_context().index();
- int new_target = Register::new_target().index();
-
- int first_context_slot = Context::MIN_CONTEXT_SLOTS;
-
- // clang-format off
- ExpectedSnippet<const char*> snippets[] = {
- {"return eval('1;');",
- 9 * kPointerSize,
- 1,
- 65,
- {
- B(CallRuntime), U16(Runtime::kNewFunctionContext), R(closure), //
- /* */ U8(1), //
- B(PushContext), R(0), //
- B(Ldar), THIS(1), //
- B(StaContextSlot), R(context), U8(first_context_slot), //
- B(CreateMappedArguments), //
- B(StaContextSlot), R(context), U8(first_context_slot + 1), //
- B(Ldar), R(new_target), //
- B(StaContextSlot), R(context), U8(first_context_slot + 2), //
- B(StackCheck), //
- B(LdaConstant), U8(0), //
- B(Star), R(3), //
- B(CallRuntimeForPair), U16(Runtime::kLoadLookupSlotForCall), //
- /* */ R(3), U8(1), R(1), //
- B(LdaConstant), U8(1), //
- B(Star), R(3), //
- B(Mov), R(1), R(4), //
- B(Mov), R(3), R(5), //
- B(Mov), R(closure), R(6), //
- B(LdaZero), //
- B(Star), R(7), //
- B(LdaSmi8), U8(10), //
- B(Star), R(8), //
- B(CallRuntime), U16(Runtime::kResolvePossiblyDirectEval), R(4), //
- /* */ U8(5), //
- B(Star), R(1), //
- B(Call), R(1), R(2), U8(2), U8(0), //
- B(Return), //
- },
- 2,
- {"eval", "1;"}},
+ InitializedIgnitionHandleScope scope;
+ BytecodeExpectationsPrinter printer(CcTest::isolate(),
+ ConstantPoolType::kString);
+ const char* snippets[] = {
+ "return eval('1;');",
};
- // clang-format on
- for (size_t i = 0; i < arraysize(snippets); i++) {
- Handle<BytecodeArray> bytecode_array =
- helper.MakeBytecodeForFunctionBody(snippets[i].code_snippet);
- CheckBytecodeArrayEqual(snippets[i], bytecode_array);
- }
+ CHECK_EQ(BuildActual(printer, snippets),
+ LoadGolden("Eval.golden"));
}
-
TEST(LookupSlot) {
- InitializedHandleScope handle_scope;
- BytecodeGeneratorHelper helper;
-
- int closure = Register::function_closure().index();
- int context = Register::current_context().index();
- int first_context_slot = Context::MIN_CONTEXT_SLOTS;
- int new_target = Register::new_target().index();
-
- // clang-format off
- ExpectedSnippet<const char*> snippets[] = {
- {"eval('var x = 10;'); return x;",
- 9 * kPointerSize,
- 1,
- 67,
- {
- B(CallRuntime), U16(Runtime::kNewFunctionContext), R(closure), //
- /* */ U8(1), //
- B(PushContext), R(0), //
- B(Ldar), THIS(1), //
- B(StaContextSlot), R(context), U8(first_context_slot), //
- B(CreateMappedArguments), //
- B(StaContextSlot), R(context), U8(first_context_slot + 1), //
- B(Ldar), R(new_target), //
- B(StaContextSlot), R(context), U8(first_context_slot + 2), //
- B(StackCheck), //
- B(LdaConstant), U8(0), //
- B(Star), R(3), //
- B(CallRuntimeForPair), U16(Runtime::kLoadLookupSlotForCall), //
- R(3), U8(1), R(1), //
- B(LdaConstant), U8(1), //
- B(Star), R(3), //
- B(Mov), R(1), R(4), //
- B(Mov), R(3), R(5), //
- B(Mov), R(closure), R(6), //
- B(LdaZero), //
- B(Star), R(7), //
- B(LdaSmi8), U8(10), //
- B(Star), R(8), //
- B(CallRuntime), U16(Runtime::kResolvePossiblyDirectEval), R(4), //
- U8(5), //
- B(Star), R(1), //
- B(Call), R(1), R(2), U8(2), U8(0), //
- B(LdaLookupSlot), U8(2), //
- B(Return), //
- },
- 3,
- {"eval", "var x = 10;", "x"}},
- {"eval('var x = 10;'); return typeof x;",
- 9 * kPointerSize,
- 1,
- 68,
- {
- B(CallRuntime), U16(Runtime::kNewFunctionContext), R(closure), //
- /* */ U8(1), //
- B(PushContext), R(0), //
- B(Ldar), THIS(1), //
- B(StaContextSlot), R(context), U8(first_context_slot), //
- B(CreateMappedArguments), //
- B(StaContextSlot), R(context), U8(first_context_slot + 1), //
- B(Ldar), R(new_target), //
- B(StaContextSlot), R(context), U8(first_context_slot + 2), //
- B(StackCheck), //
- B(LdaConstant), U8(0), //
- B(Star), R(3), //
- B(CallRuntimeForPair), U16(Runtime::kLoadLookupSlotForCall), //
- /* */ R(3), U8(1), R(1), //
- B(LdaConstant), U8(1), //
- B(Star), R(3), //
- B(Mov), R(1), R(4), //
- B(Mov), R(3), R(5), //
- B(Mov), R(closure), R(6), //
- B(LdaZero), //
- B(Star), R(7), //
- B(LdaSmi8), U8(10), //
- B(Star), R(8), //
- B(CallRuntime), U16(Runtime::kResolvePossiblyDirectEval), R(4), //
- /* */ U8(5), //
- B(Star), R(1), //
- B(Call), R(1), R(2), U8(2), U8(0), //
- B(LdaLookupSlotInsideTypeof), U8(2), //
- B(TypeOf), //
- B(Return), //
- },
- 3,
- {"eval", "var x = 10;", "x"}},
- {"x = 20; return eval('');",
- 9 * kPointerSize,
- 1,
- 69,
- {
- B(CallRuntime), U16(Runtime::kNewFunctionContext), R(closure), //
- U8(1), //
- B(PushContext), R(0), //
- B(Ldar), THIS(1), //
- B(StaContextSlot), R(context), U8(first_context_slot), //
- B(CreateMappedArguments), //
- B(StaContextSlot), R(context), U8(first_context_slot + 1), //
- B(Ldar), R(new_target), //
- B(StaContextSlot), R(context), U8(first_context_slot + 2), //
- B(StackCheck), //
- B(LdaSmi8), U8(20), //
- B(StaLookupSlotSloppy), U8(0), //
- B(LdaConstant), U8(1), //
- B(Star), R(3), //
- B(CallRuntimeForPair), U16(Runtime::kLoadLookupSlotForCall), //
- /* */ R(3), U8(1), R(1), //
- B(LdaConstant), U8(2), //
- B(Star), R(3), //
- B(Mov), R(1), R(4), //
- B(Mov), R(3), R(5), //
- B(Mov), R(closure), R(6), //
- B(LdaZero), //
- B(Star), R(7), //
- B(LdaSmi8), U8(10), //
- B(Star), R(8), //
- B(CallRuntime), U16(Runtime::kResolvePossiblyDirectEval), R(4), //
- /* */ U8(5), //
- B(Star), R(1), //
- B(Call), R(1), R(2), U8(2), U8(0), //
- B(Return), //
- },
- 3,
- {"x", "eval", ""}},
+ InitializedIgnitionHandleScope scope;
+ BytecodeExpectationsPrinter printer(CcTest::isolate(),
+ ConstantPoolType::kString);
+
+ const char* snippets[] = {
+ "eval('var x = 10;'); return x;",
+ "eval('var x = 10;'); return typeof x;",
+ "x = 20; return eval('');",
};
- // clang-format on
- for (size_t i = 0; i < arraysize(snippets); i++) {
- Handle<BytecodeArray> bytecode_array =
- helper.MakeBytecodeForFunctionBody(snippets[i].code_snippet);
- CheckBytecodeArrayEqual(snippets[i], bytecode_array);
- }
+ CHECK_EQ(BuildActual(printer, snippets),
+ LoadGolden("LookupSlot.golden"));
}
-
TEST(CallLookupSlot) {
- InitializedHandleScope handle_scope;
- BytecodeGeneratorHelper helper;
- Zone zone;
-
- FeedbackVectorSpec feedback_spec(&zone);
- FeedbackVectorSlot slot1 = feedback_spec.AddLoadICSlot();
- FeedbackVectorSlot slot2 = feedback_spec.AddCallICSlot();
- USE(slot1);
-
- Handle<i::TypeFeedbackVector> vector =
- i::NewTypeFeedbackVector(helper.isolate(), &feedback_spec);
-
- int closure = Register::function_closure().index();
- int context = Register::current_context().index();
- int new_target = Register::new_target().index();
-
- // clang-format off
- ExpectedSnippet<InstanceType> snippets[] = {
- {"g = function(){}; eval(''); return g();",
- 9 * kPointerSize,
- 1,
- 85,
- {
- B(CallRuntime), U16(Runtime::kNewFunctionContext), R(closure), //
- /* */ U8(1), //
- B(PushContext), R(0), //
- B(Ldar), THIS(1), //
- B(StaContextSlot), R(context), U8(4), //
- B(CreateMappedArguments), //
- B(StaContextSlot), R(context), U8(5), //
- B(Ldar), R(new_target), //
- B(StaContextSlot), R(context), U8(6), //
- B(StackCheck), //
- B(CreateClosure), U8(0), U8(0), //
- B(StaLookupSlotSloppy), U8(1), //
- B(LdaConstant), U8(2), //
- B(Star), R(3), //
- B(CallRuntimeForPair), U16(Runtime::kLoadLookupSlotForCall), //
- R(3), U8(1), R(1), //
- B(LdaConstant), U8(3), //
- B(Star), R(3), //
- B(Mov), R(1), R(4), //
- B(Mov), R(3), R(5), //
- B(Mov), R(closure), R(6), //
- B(LdaZero), //
- B(Star), R(7), //
- B(LdaSmi8), U8(10), //
- B(Star), R(8), //
- B(CallRuntime), U16(Runtime::kResolvePossiblyDirectEval), R(4), //
- U8(5), //
- B(Star), R(1), //
- B(Call), R(1), R(2), U8(2), U8(0), //
- B(LdaConstant), U8(1), //
- B(Star), R(3), //
- B(CallRuntimeForPair), U16(Runtime::kLoadLookupSlotForCall), //
- R(3), U8(1), R(1), //
- B(Call), R(1), R(2), U8(1), U8(vector->GetIndex(slot2)), //
- B(Return), //
- },
- 4,
- {InstanceType::SHARED_FUNCTION_INFO_TYPE,
- InstanceType::ONE_BYTE_INTERNALIZED_STRING_TYPE,
- InstanceType::ONE_BYTE_INTERNALIZED_STRING_TYPE,
- InstanceType::ONE_BYTE_INTERNALIZED_STRING_TYPE}},
+ InitializedIgnitionHandleScope scope;
+ BytecodeExpectationsPrinter printer(CcTest::isolate(),
+ ConstantPoolType::kMixed);
+ const char* snippets[] = {
+ "g = function(){}; eval(''); return g();",
};
- // clang-format on
- for (size_t i = 0; i < arraysize(snippets); i++) {
- Handle<BytecodeArray> bytecode_array =
- helper.MakeBytecodeForFunctionBody(snippets[i].code_snippet);
- CheckBytecodeArrayEqual(snippets[i], bytecode_array);
- }
+ CHECK_EQ(BuildActual(printer, snippets),
+ LoadGolden("CallLookupSlot.golden"));
}
-
// TODO(mythria): tests for variable/function declaration in lookup slots.
TEST(LookupSlotInEval) {
- InitializedHandleScope handle_scope;
- BytecodeGeneratorHelper helper;
-
- const char* function_prologue = "var f;"
- "var x = 1;"
- "function f1() {"
- " eval(\"function t() {";
- const char* function_epilogue = " }; f = t; f();\");"
- "}"
- "f1();";
-
- // clang-format off
- ExpectedSnippet<const char*> snippets[] = {
- {"return x;",
- 0 * kPointerSize,
- 1,
- 4,
- {
- B(StackCheck), //
- B(LdaLookupSlot), U8(0), //
- B(Return) //
- },
- 1,
- {"x"}},
- {"x = 10;",
- 0 * kPointerSize,
- 1,
- 7,
- {
- B(StackCheck), //
- B(LdaSmi8), U8(10), //
- B(StaLookupSlotSloppy), U8(0), //
- B(LdaUndefined), //
- B(Return), //
- },
- 1,
- {"x"}},
- {"'use strict'; x = 10;",
- 0 * kPointerSize,
- 1,
- 7,
- {
- B(StackCheck), //
- B(LdaSmi8), U8(10), //
- B(StaLookupSlotStrict), U8(0), //
- B(LdaUndefined), //
- B(Return), //
- },
- 1,
- {"x"}},
- {"return typeof x;",
- 0 * kPointerSize,
- 1,
- 5,
- {
- B(StackCheck), //
- B(LdaLookupSlotInsideTypeof), U8(0), //
- B(TypeOf), //
- B(Return), //
- },
- 1,
- {"x"}},
+ InitializedIgnitionHandleScope scope;
+ BytecodeExpectationsPrinter printer(CcTest::isolate(),
+ ConstantPoolType::kString);
+ printer.set_wrap(false);
+ printer.set_test_function_name("f");
+
+ const char* snippets[] = {
+ "return x;",
+ "x = 10;",
+ "'use strict'; x = 10;",
+ "return typeof x;",
};
- // clang-format on
-
- for (size_t i = 0; i < arraysize(snippets); i++) {
- std::string script = std::string(function_prologue) +
- std::string(snippets[i].code_snippet) +
- std::string(function_epilogue);
- Handle<BytecodeArray> bytecode_array =
- helper.MakeBytecode(script.c_str(), "*", "f");
- CheckBytecodeArrayEqual(snippets[i], bytecode_array);
- }
-}
+ std::string actual = BuildActual(printer, snippets,
+ "var f;\n"
+ "var x = 1;\n"
+ "function f1() {\n"
+ " eval(\"function t() {",
+
+ " }; f = t; f();\");\n"
+ "}\n"
+ "f1();");
+
+ CHECK_EQ(actual, LoadGolden("LookupSlotInEval.golden"));
+}
TEST(LookupSlotWideInEval) {
- InitializedHandleScope handle_scope;
- BytecodeGeneratorHelper helper;
-
- const char* function_prologue =
- "var f;"
- "var x = 1;"
- "function f1() {"
- " eval(\"function t() {";
- const char* function_epilogue =
- " }; f = t; f();\");"
- "}"
- "f1();";
-
- int const_count[] = {0, 0, 0, 0};
- // clang-format off
- ExpectedSnippet<InstanceType, 257> snippets[] = {
- {REPEAT_256(SPACE, "var y = 2.3;")
- "return x;",
- 1 * kPointerSize,
- 1,
- 1029,
- {
- B(StackCheck), //
- REPEAT_256(SPACE, //
- B(LdaConstant), U8(const_count[0]++), //
- B(Star), R(0), ) //
- B(LdaLookupSlotWide), U16(256), //
- B(Return) //
- },
- 257,
- {REPEAT_256(COMMA, InstanceType::HEAP_NUMBER_TYPE),
- InstanceType::ONE_BYTE_INTERNALIZED_STRING_TYPE}},
- {REPEAT_256(SPACE, "var y = 2.3;")
- "return typeof x;",
- 1 * kPointerSize,
- 1,
- 1030,
- {
- B(StackCheck), //
- REPEAT_256(SPACE, //
- B(LdaConstant), U8(const_count[1]++), //
- B(Star), R(0), ) //
- B(LdaLookupSlotInsideTypeofWide), U16(256), //
- B(TypeOf), //
- B(Return) //
- },
- 257,
- {REPEAT_256(COMMA, InstanceType::HEAP_NUMBER_TYPE),
- InstanceType::ONE_BYTE_INTERNALIZED_STRING_TYPE}},
- {REPEAT_256(SPACE, "var y = 2.3;")
- "x = 10;",
- 1 * kPointerSize,
- 1,
- 1032,
- {
- B(StackCheck), //
- REPEAT_256(SPACE, //
- B(LdaConstant), U8(const_count[2]++), //
- B(Star), R(0), ) //
- B(LdaSmi8), U8(10), //
- B(StaLookupSlotSloppyWide), U16(256), //
- B(LdaUndefined), //
- B(Return) //
- },
- 257,
- {REPEAT_256(COMMA, InstanceType::HEAP_NUMBER_TYPE),
- InstanceType::ONE_BYTE_INTERNALIZED_STRING_TYPE}},
- {"'use strict';"
- REPEAT_256(SPACE, "var y = 2.3;")
- "x = 10;",
- 1 * kPointerSize,
- 1,
- 1032,
- {
- B(StackCheck), //
- REPEAT_256(SPACE, //
- B(LdaConstant), U8(const_count[3]++), //
- B(Star), R(0), ) //
- B(LdaSmi8), U8(10), //
- B(StaLookupSlotStrictWide), U16(256), //
- B(LdaUndefined), //
- B(Return) //
- },
- 257,
- {REPEAT_256(COMMA, InstanceType::HEAP_NUMBER_TYPE),
- InstanceType::ONE_BYTE_INTERNALIZED_STRING_TYPE}},
+ InitializedIgnitionHandleScope scope;
+ BytecodeExpectationsPrinter printer(CcTest::isolate(),
+ ConstantPoolType::kMixed);
+ printer.set_wrap(false);
+ printer.set_test_function_name("f");
+
+ const char* snippets[] = {
+ REPEAT_256(SPACE, "var y = 2.3; ") "return x;",
+ REPEAT_256(SPACE, "var y = 2.3; ") "return typeof x;",
+ REPEAT_256(SPACE, "var y = 2.3; ") "x = 10;",
+ "'use strict';" REPEAT_256(SPACE, "var y = 2.3; ") "x = 10;",
};
- // clang-format on
-
- for (size_t i = 0; i < arraysize(snippets); i++) {
- std::string script = std::string(function_prologue) +
- std::string(snippets[i].code_snippet) +
- std::string(function_epilogue);
- Handle<BytecodeArray> bytecode_array =
- helper.MakeBytecode(script.c_str(), "*", "f");
- CheckBytecodeArrayEqual(snippets[i], bytecode_array);
- }
-}
+ std::string actual = BuildActual(printer, snippets,
+ "var f;\n"
+ "var x = 1;\n"
+ "function f1() {\n"
+ " eval(\"function t() {",
+
+ " }; f = t; f();\");\n"
+ "}\n"
+ "f1();");
+
+ CHECK_EQ(actual, LoadGolden("LookupSlotWideInEval.golden"));
+}
TEST(DeleteLookupSlotInEval) {
- InitializedHandleScope handle_scope;
- BytecodeGeneratorHelper helper;
-
- const char* function_prologue = "var f;"
- "var x = 1;"
- "z = 10;"
- "function f1() {"
- " var y;"
- " eval(\"function t() {";
- const char* function_epilogue = " }; f = t; f();\");"
- "}"
- "f1();";
-
- // clang-format off
- ExpectedSnippet<const char*> snippets[] = {
- {"delete x;",
- 1 * kPointerSize,
- 1,
- 12,
- {
- B(StackCheck), //
- B(LdaConstant), U8(0), //
- B(Star), R(0), //
- B(CallRuntime), U16(Runtime::kDeleteLookupSlot), R(0), U8(1), //
- B(LdaUndefined), //
- B(Return) //
- },
- 1,
- {"x"}},
- {"return delete y;",
- 0 * kPointerSize,
- 1,
- 3,
- {
- B(StackCheck), //
- B(LdaFalse), //
- B(Return) //
- },
- 0},
- {"return delete z;",
- 1 * kPointerSize,
- 1,
- 11,
- {
- B(StackCheck), //
- B(LdaConstant), U8(0), //
- B(Star), R(0), //
- B(CallRuntime), U16(Runtime::kDeleteLookupSlot), R(0), U8(1), //
- B(Return) //
- },
- 1,
- {"z"}},
+ InitializedIgnitionHandleScope scope;
+ BytecodeExpectationsPrinter printer(CcTest::isolate(),
+ ConstantPoolType::kString);
+ printer.set_wrap(false);
+ printer.set_test_function_name("f");
+
+ const char* snippets[] = {
+ "delete x;",
+ "return delete y;",
+ "return delete z;",
};
- // clang-format on
-
- for (size_t i = 0; i < arraysize(snippets); i++) {
- std::string script = std::string(function_prologue) +
- std::string(snippets[i].code_snippet) +
- std::string(function_epilogue);
- Handle<BytecodeArray> bytecode_array =
- helper.MakeBytecode(script.c_str(), "*", "f");
- CheckBytecodeArrayEqual(snippets[i], bytecode_array);
- }
+
+ std::string actual = BuildActual(printer, snippets,
+ "var f;\n"
+ "var x = 1;\n"
+ "z = 10;\n"
+ "function f1() {\n"
+ " var y;\n"
+ " eval(\"function t() { ",
+
+ " }; f = t; f();\");\n"
+ "}\n"
+ "f1();");
+
+ CHECK_EQ(actual, LoadGolden("DeleteLookupSlotInEval.golden"));
}
TEST(WideRegisters) {
@@ -7949,1151 +1669,204 @@ TEST(WideRegisters) {
}
std::string prologue(os.str());
- // clang-format off
- ExpectedSnippet<int> snippets[] = {
- {"x0 = x127;\n"
- "return x0;\n",
- 161 * kPointerSize,
- 1,
- 11,
- {
- B(StackCheck), //
- B(MovWide), R16(131), R16(125), //
- B(Ldar), R(125), //
- B(Star), R(0), //
- B(Return), //
- }},
- {"x127 = x126;\n"
- "return x127;\n",
- 161 * kPointerSize,
- 1,
- 23,
- {
- B(StackCheck), //
- B(MovWide), R16(130), R16(125), //
- B(Ldar), R(125), //
- B(Star), R(125), //
- B(MovWide), R16(125), R16(131), //
- B(MovWide), R16(131), R16(125), //
- B(Ldar), R(125), //
- B(Return), //
- }},
- {"if (x2 > 3) { return x129; }\n"
- "return x128;\n",
- 162 * kPointerSize,
- 1,
- 37,
- {
- B(StackCheck), //
- B(Ldar), R(2), //
- B(Star), R(125), //
- B(MovWide), R16(125), R16(161), //
- B(LdaSmi8), U8(3), //
- B(MovWide), R16(161), R16(125), //
- B(TestGreaterThan), R(125), //
- B(JumpIfFalse), U8(10), //
- B(MovWide), R16(133), R16(125), //
- B(Ldar), R(125), //
- B(Return), //
- B(MovWide), R16(132), R16(125), //
- B(Ldar), R(125), //
- B(Return), //
- }},
- {"var x0 = 0;\n"
- "if (x129 == 3) { var x129 = x0; }\n"
- "if (x2 > 3) { return x0; }\n"
- "return x129;\n",
- 162 * kPointerSize,
- 1,
- 69,
- {
- B(StackCheck), //
- B(LdaZero), //
- B(Star), R(0), //
- B(MovWide), R16(133), R16(125), //
- B(Ldar), R(125), //
- B(Star), R(125), //
- B(MovWide), R16(125), R16(161), //
- B(LdaSmi8), U8(3), //
- B(MovWide), R16(161), R16(125), //
- B(TestEqual), R(125), //
- B(JumpIfFalse), U8(11), //
- B(Ldar), R(0), //
- B(Star), R(125), //
- B(MovWide), R16(125), R16(133), //
- B(Ldar), R(2), //
- B(Star), R(125), //
- B(MovWide), R16(125), R16(161), //
- B(LdaSmi8), U8(3), //
- B(MovWide), R16(161), R16(125), //
- B(TestGreaterThan), R(125), //
- B(JumpIfFalse), U8(5), //
- B(Ldar), R(0), //
- B(Return), //
- B(MovWide), R16(133), R16(125), //
- B(Ldar), R(125), //
- B(Return), //
- }},
- {"var x0 = 0;\n"
- "var x1 = 0;\n"
- "for (x128 = 0; x128 < 64; x128++) {"
- " x1 += x128;"
- "}"
- "return x128;\n",
- 162 * kPointerSize,
- 1,
- 99,
- {
- B(StackCheck), //
- B(LdaZero), //
- B(Star), R(0), //
- B(LdaZero), //
- B(Star), R(1), //
- B(LdaZero), //
- B(Star), R(125), //
- B(MovWide), R16(125), R16(132), //
- B(MovWide), R16(132), R16(125), //
- B(Ldar), R(125), //
- B(Star), R(125), //
- B(MovWide), R16(125), R16(161), //
- B(LdaSmi8), U8(64), //
- B(MovWide), R16(161), R16(125), //
- B(TestLessThan), R(125), //
- B(JumpIfFalse), U8(53), //
- B(StackCheck), //
- B(Ldar), R(1), //
- B(Star), R(125), //
- B(MovWide), R16(125), R16(161), //
- B(MovWide), R16(132), R16(125), //
- B(Ldar), R(125), //
- B(MovWide), R16(161), R16(125), //
- B(Add), R(125), //
- B(Star), R(1), //
- B(MovWide), R16(132), R16(125), //
- B(Ldar), R(125), //
- B(ToNumber), //
- B(Star), R(125), //
- B(MovWide), R16(125), R16(161), //
- B(Inc), //
- B(Star), R(125), //
- B(MovWide), R16(125), R16(132), //
- B(Jump), U8(-74), //
- B(MovWide), R16(132), R16(125), //
- B(Ldar), R(125), //
- B(Return), //
- }},
- {"var x0 = 1234;\n"
- "var x1 = 0;\n"
- "for (x128 in x0) {"
- " x1 += x128;"
- "}"
- "return x1;\n",
- 167 * kPointerSize,
- 1,
- 111,
- {
- B(StackCheck), //
- B(LdaConstant), U8(0), //
- B(Star), R(0), //
- B(LdaZero), //
- B(Star), R(1), //
- B(Ldar), R(0), //
- B(JumpIfUndefined), U8(98), //
- B(JumpIfNull), U8(96), //
- B(ToObject), //
- B(JumpIfNull), U8(93), //
- B(Star), R(125), //
- B(MovWide), R16(125), R16(161), //
- B(ForInPrepareWide), R16(162), //
- B(LdaZero), //
- B(Star), R(125), //
- B(MovWide), R16(125), R16(165), //
- B(MovWide), R16(165), R16(125), //
- B(MovWide), R16(164), R16(126), //
- B(ForInDone), R(125), R(126), //
- B(JumpIfTrue), U8(60), //
- B(ForInNextWide), R16(161), R16(165), R16(162), //
- B(JumpIfUndefined), U8(35), //
- B(Star), R(125), //
- B(MovWide), R16(125), R16(132), //
- B(StackCheck), //
- B(Ldar), R(1), //
- B(Star), R(125), //
- B(MovWide), R16(125), R16(166), //
- B(MovWide), R16(132), R16(125), //
- B(Ldar), R(125), //
- B(MovWide), R16(166), R16(125), //
- B(Add), R(125), //
- B(Star), R(1), //
- B(MovWide), R16(165), R16(125), //
- B(ForInStep), R(125), //
- B(Star), R(125), //
- B(MovWide), R16(125), R16(165), //
- B(Jump), U8(-71), //
- B(Ldar), R(1), //
- B(Return), //
- },
- 1,
- {1234}},
- {"x0 = %Add(x64, x63);\n"
- "x1 = %Add(x27, x143);\n"
- "%TheHole();\n"
- "return x1;\n",
- 163 * kPointerSize,
- 1,
- 66,
- {
- B(StackCheck), //
- B(Ldar), R(64), //
- B(Star), R(125), //
- B(MovWide), R16(125), R16(161), //
- B(Ldar), R(63), //
- B(Star), R(125), //
- B(MovWide), R16(125), R16(162), //
- B(CallRuntimeWide), U16(Runtime::kAdd), R16(161), U8(2), //
- B(Star), R(0), //
- B(Ldar), R(27), //
- B(Star), R(125), //
- B(MovWide), R16(125), R16(161), //
- B(MovWide), R16(147), R16(125), //
- B(Ldar), R(125), //
- B(Star), R(125), //
- B(MovWide), R16(125), R16(162), //
- B(CallRuntimeWide), U16(Runtime::kAdd), R16(161), U8(2), //
- B(Star), R(1), //
- B(CallRuntime), U16(Runtime::kTheHole), R(0), U8(0), //
- B(Ldar), R(1), //
- B(Return), //
- }}
- };
- // clang-format on
+ InitializedIgnitionHandleScope scope;
+ BytecodeExpectationsPrinter printer(CcTest::isolate(),
+ ConstantPoolType::kNumber);
+ const char* snippets[] = {
+ "x0 = x127;\n"
oth 2016/02/24 13:43:55 clang-format off
+ "return x0;\n",
- InitializedHandleScope handle_scope;
- BytecodeGeneratorHelper helper;
+ "x127 = x126;\n"
+ "return x127;\n",
- for (size_t i = 0; i < arraysize(snippets); ++i) {
- std::string body = prologue + snippets[i].code_snippet;
- Handle<BytecodeArray> bytecode_array =
- helper.MakeBytecodeForFunctionBody(body.c_str());
- CheckBytecodeArrayEqual(snippets[i], bytecode_array);
- }
+ "if (x2 > 3) { return x129; }\n"
+ "return x128;\n",
+
+ "var x0 = 0;\n"
+ "if (x129 == 3) { var x129 = x0; }\n"
+ "if (x2 > 3) { return x0; }\n"
+ "return x129;\n",
+
+ "var x0 = 0;\n"
+ "var x1 = 0;\n"
+ "for (x128 = 0; x128 < 64; x128++) {"
+ " x1 += x128;"
+ "}"
+ "return x128;\n",
+
+ "var x0 = 1234;\n"
+ "var x1 = 0;\n"
+ "for (x128 in x0) {"
+ " x1 += x128;"
+ "}"
+ "return x1;\n",
+
+ "x0 = %Add(x64, x63);\n"
+ "x1 = %Add(x27, x143);\n"
+ "%TheHole();\n"
+ "return x1;\n",
oth 2016/02/24 13:43:55 clang-format on
+ };
+
+ CHECK_EQ(BuildActual(printer, snippets, prologue.c_str()),
+ LoadGolden("WideRegisters.golden"));
}
TEST(ConstVariable) {
- InitializedHandleScope handle_scope;
- BytecodeGeneratorHelper helper;
- // clang-format off
- ExpectedSnippet<const char*> snippets[] = {
- {"const x = 10;",
- 1 * kPointerSize,
- 1,
- 10,
- {
- B(LdaTheHole), //
- B(Star), R(0), //
- B(StackCheck), //
- B(LdaSmi8), U8(10), //
- B(Star), R(0), //
- B(LdaUndefined), //
- B(Return) //
- },
- 0},
- {"const x = 10; return x;",
- 2 * kPointerSize,
- 1,
- 20,
- {
- B(LdaTheHole), //
- B(Star), R(0), //
- B(StackCheck), //
- B(LdaSmi8), U8(10), //
- B(Star), R(0), //
- B(JumpIfNotHole), U8(11), //
- B(LdaConstant), U8(0), //
- B(Star), R(1), //
- B(CallRuntime), U16(Runtime::kThrowReferenceError), R(1), U8(1), //
- B(Return) //
- },
- 1,
- {"x"}},
- {"const x = ( x = 20);",
- 3 * kPointerSize,
- 1,
- 32,
- {
- B(LdaTheHole), //
- B(Star), R(0), //
- B(StackCheck), //
- B(LdaSmi8), U8(20), //
- B(Star), R(1), //
- B(Ldar), R(0), //
- B(JumpIfNotHole), U8(11), //
- B(LdaConstant), U8(0), //
- B(Star), R(2), //
- B(CallRuntime), U16(Runtime::kThrowReferenceError), R(2), U8(1), //
- B(CallRuntime), U16(Runtime::kThrowConstAssignError), R(0), //
- /* */ U8(0), //
- B(Ldar), R(1), //
- B(Star), R(0), //
- B(LdaUndefined), //
- B(Return) //
- },
- 1,
- {"x"}},
- {"const x = 10; x = 20;",
- 3 * kPointerSize,
- 1,
- 36,
- {
- B(LdaTheHole), //
- B(Star), R(0), //
- B(StackCheck), //
- B(LdaSmi8), U8(10), //
- B(Star), R(0), //
- B(LdaSmi8), U8(20), //
- B(Star), R(1), //
- B(Ldar), R(0), //
- B(JumpIfNotHole), U8(11), //
- B(LdaConstant), U8(0), //
- B(Star), R(2), //
- B(CallRuntime), U16(Runtime::kThrowReferenceError), R(2), U8(1), //
- B(CallRuntime), U16(Runtime::kThrowConstAssignError), R(0), //
- /* */ U8(0), //
- B(Ldar), R(1), //
- B(Star), R(0), //
- B(LdaUndefined), //
- B(Return) //
- },
- 1,
- {"x"}},
+ InitializedIgnitionHandleScope scope;
+ BytecodeExpectationsPrinter printer(CcTest::isolate(),
+ ConstantPoolType::kString);
+ const char* snippets[] = {
+ "const x = 10;",
+ "const x = 10; return x;",
+ "const x = ( x = 20);",
+ "const x = 10; x = 20;",
};
- // clang-format on
- for (size_t i = 0; i < arraysize(snippets); i++) {
- Handle<BytecodeArray> bytecode_array =
- helper.MakeBytecodeForFunctionBody(snippets[i].code_snippet);
- CheckBytecodeArrayEqual(snippets[i], bytecode_array);
- }
+ CHECK_EQ(BuildActual(printer, snippets),
+ LoadGolden("ConstVariable.golden"));
}
TEST(LetVariable) {
- InitializedHandleScope handle_scope;
- BytecodeGeneratorHelper helper;
-
- // clang-format off
- ExpectedSnippet<const char*> snippets[] = {
- {"let x = 10;",
- 1 * kPointerSize,
- 1,
- 10,
- {
- B(LdaTheHole), //
- B(Star), R(0), //
- B(StackCheck), //
- B(LdaSmi8), U8(10), //
- B(Star), R(0), //
- B(LdaUndefined), //
- B(Return) //
- },
- 0},
- {"let x = 10; return x;",
- 2 * kPointerSize,
- 1,
- 20,
- {
- B(LdaTheHole), //
- B(Star), R(0), //
- B(StackCheck), //
- B(LdaSmi8), U8(10), //
- B(Star), R(0), //
- B(JumpIfNotHole), U8(11), //
- B(LdaConstant), U8(0), //
- B(Star), R(1), //
- B(CallRuntime), U16(Runtime::kThrowReferenceError), R(1), U8(1), //
- B(Return) //
- },
- 1,
- {"x"}},
- {"let x = (x = 20);",
- 3 * kPointerSize,
- 1,
- 27,
- {
- B(LdaTheHole), //
- B(Star), R(0), //
- B(StackCheck), //
- B(LdaSmi8), U8(20), //
- B(Star), R(1), //
- B(Ldar), R(0), //
- B(JumpIfNotHole), U8(11), //
- B(LdaConstant), U8(0), //
- B(Star), R(2), //
- B(CallRuntime), U16(Runtime::kThrowReferenceError), R(2), U8(1), //
- B(Ldar), R(1), //
- B(Star), R(0), //
- B(LdaUndefined), //
- B(Return) //
- },
- 1,
- {"x"}},
- {"let x = 10; x = 20;",
- 3 * kPointerSize,
- 1,
- 31,
- {
- B(LdaTheHole), //
- B(Star), R(0), //
- B(StackCheck), //
- B(LdaSmi8), U8(10), //
- B(Star), R(0), //
- B(LdaSmi8), U8(20), //
- B(Star), R(1), //
- B(Ldar), R(0), //
- B(JumpIfNotHole), U8(11), //
- B(LdaConstant), U8(0), //
- B(Star), R(2), //
- B(CallRuntime), U16(Runtime::kThrowReferenceError), R(2), U8(1), //
- B(Ldar), R(1), //
- B(Star), R(0), //
- B(LdaUndefined), //
- B(Return) //
- },
- 1,
- {"x"}},
+ InitializedIgnitionHandleScope scope;
+ BytecodeExpectationsPrinter printer(CcTest::isolate(),
+ ConstantPoolType::kString);
+ const char* snippets[] = {
+ "let x = 10;",
+ "let x = 10; return x;",
+ "let x = (x = 20);",
+ "let x = 10; x = 20;",
};
- // clang-format on
- for (size_t i = 0; i < arraysize(snippets); i++) {
- Handle<BytecodeArray> bytecode_array =
- helper.MakeBytecodeForFunctionBody(snippets[i].code_snippet);
- CheckBytecodeArrayEqual(snippets[i], bytecode_array);
- }
+ CHECK_EQ(BuildActual(printer, snippets),
+ LoadGolden("LetVariable.golden"));
}
TEST(LegacyConstVariable) {
bool old_legacy_const_flag = FLAG_legacy_const;
FLAG_legacy_const = true;
- InitializedHandleScope handle_scope;
- BytecodeGeneratorHelper helper;
-
- // clang-format off
- ExpectedSnippet<const char*> snippets[] = {
- {"const x = 10;",
- 2 * kPointerSize,
- 1,
- 19,
- {
- B(LdaTheHole), //
- B(Star), R(0), //
- B(StackCheck), //
- B(LdaSmi8), U8(10), //
- B(Star), R(1), //
- B(Ldar), R(0), //
- B(JumpIfNotHole), U8(5), //
- B(Mov), R(1), R(0), //
- B(Ldar), R(1), //
- B(LdaUndefined), //
- B(Return) //
- },
- 0},
- {"const x = 10; return x;",
- 2 * kPointerSize,
- 1,
- 23,
- {
- B(LdaTheHole), //
- B(Star), R(0), //
- B(StackCheck), //
- B(LdaSmi8), U8(10), //
- B(Star), R(1), //
- B(Ldar), R(0), //
- B(JumpIfNotHole), U8(5), //
- B(Mov), R(1), R(0), //
- B(Ldar), R(1), //
- B(Ldar), R(0), //
- B(JumpIfNotHole), U8(3), //
- B(LdaUndefined), //
- B(Return) //
- },
- 0},
- {"const x = ( x = 20);",
- 2 * kPointerSize,
- 1,
- 23,
- {
- B(LdaTheHole), //
- B(Star), R(0), //
- B(StackCheck), //
- B(LdaSmi8), U8(20), //
- B(Star), R(1), //
- B(Ldar), R(0), //
- B(Ldar), R(1), //
- B(Ldar), R(0), //
- B(JumpIfNotHole), U8(5), //
- B(Mov), R(1), R(0), //
- B(Ldar), R(1), //
- B(LdaUndefined), //
- B(Return) //
- },
- 0},
- {"const x = 10; x = 20;",
- 2 * kPointerSize,
- 1,
- 27,
- {
- B(LdaTheHole), //
- B(Star), R(0), //
- B(StackCheck), //
- B(LdaSmi8), U8(10), //
- B(Star), R(1), //
- B(Ldar), R(0), //
- B(JumpIfNotHole), U8(5), //
- B(Mov), R(1), R(0), //
- B(Ldar), R(1), //
- B(LdaSmi8), U8(20), //
- B(Star), R(1), //
- B(Ldar), R(0), //
- B(Ldar), R(1), //
- B(LdaUndefined), //
- B(Return) //
- },
- 0},
+ InitializedIgnitionHandleScope scope;
+ BytecodeExpectationsPrinter printer(CcTest::isolate(),
+ ConstantPoolType::kString);
+ const char* snippets[] = {
+ "const x = 10;",
+ "const x = 10; return x;",
+ "const x = ( x = 20);",
+ "const x = 10; x = 20;",
};
- // clang-format on
- for (size_t i = 0; i < arraysize(snippets); i++) {
- Handle<BytecodeArray> bytecode_array =
- helper.MakeBytecodeForFunctionBody(snippets[i].code_snippet);
- CheckBytecodeArrayEqual(snippets[i], bytecode_array);
- }
+ CHECK_EQ(BuildActual(printer, snippets),
+ LoadGolden("LegacyConstVariable.golden"));
FLAG_legacy_const = old_legacy_const_flag;
}
TEST(ConstVariableContextSlot) {
- InitializedHandleScope handle_scope;
- BytecodeGeneratorHelper helper;
-
- int closure = Register::function_closure().index();
- int context = Register::current_context().index();
-
// TODO(mythria): Add tests for initialization of this via super calls.
// TODO(mythria): Add tests that walk the context chain.
- // clang-format off
- ExpectedSnippet<InstanceType> snippets[] = {
- {"const x = 10; function f1() {return x;}",
- 2 * kPointerSize,
- 1,
- 24,
- {
- B(CallRuntime), U16(Runtime::kNewFunctionContext), R(closure), //
- U8(1), //
- B(PushContext), R(1), //
- B(LdaTheHole), //
- B(StaContextSlot), R(context), U8(4), //
- B(CreateClosure), U8(0), U8(0), //
- B(Star), R(0), //
- B(StackCheck), //
- B(LdaSmi8), U8(10), //
- B(StaContextSlot), R(context), U8(4), //
- B(LdaUndefined), //
- B(Return) //
- },
- 1,
- {InstanceType::SHARED_FUNCTION_INFO_TYPE}},
- {"const x = 10; function f1() {return x;} return x;",
- 3 * kPointerSize,
- 1,
- 37,
- {
- B(CallRuntime), U16(Runtime::kNewFunctionContext), R(closure), //
- U8(1), //
- B(PushContext), R(1), //
- B(LdaTheHole), //
- B(StaContextSlot), R(context), U8(4), //
- B(CreateClosure), U8(0), U8(0), //
- B(Star), R(0), //
- B(StackCheck), //
- B(LdaSmi8), U8(10), //
- B(StaContextSlot), R(context), U8(4), //
- B(LdaContextSlot), R(context), U8(4), //
- B(JumpIfNotHole), U8(11), //
- B(LdaConstant), U8(1), //
- B(Star), R(2), //
- B(CallRuntime), U16(Runtime::kThrowReferenceError), R(2), U8(1), //
- B(Return) //
- },
- 2,
- {InstanceType::SHARED_FUNCTION_INFO_TYPE,
- InstanceType::ONE_BYTE_INTERNALIZED_STRING_TYPE}},
- {"const x = (x = 20); function f1() {return x;}",
- 4 * kPointerSize,
- 1,
- 50,
- {
- B(CallRuntime), U16(Runtime::kNewFunctionContext), R(closure), //
- /* */ U8(1), //
- B(PushContext), R(1), //
- B(LdaTheHole), //
- B(StaContextSlot), R(context), U8(4), //
- B(CreateClosure), U8(0), U8(0), //
- B(Star), R(0), //
- B(StackCheck), //
- B(LdaSmi8), U8(20), //
- B(Star), R(2), //
- B(LdaContextSlot), R(context), U8(4), //
- B(JumpIfNotHole), U8(11), //
- B(LdaConstant), U8(1), //
- B(Star), R(3), //
- B(CallRuntime), U16(Runtime::kThrowReferenceError), R(3), U8(1), //
- B(CallRuntime), U16(Runtime::kThrowConstAssignError), R(0), //
- U8(0), //
- B(Ldar), R(2), //
- B(StaContextSlot), R(context), U8(4), //
- B(StaContextSlot), R(context), U8(4), //
- B(LdaUndefined), //
- B(Return) //
- },
- 2,
- {InstanceType::SHARED_FUNCTION_INFO_TYPE,
- InstanceType::ONE_BYTE_INTERNALIZED_STRING_TYPE}},
- {"const x = 10; x = 20; function f1() {return x;}",
- 4 * kPointerSize,
- 1,
- 52,
- {
- B(CallRuntime), U16(Runtime::kNewFunctionContext), R(closure), //
- /* */ U8(1), //
- B(PushContext), R(1), //
- B(LdaTheHole), //
- B(StaContextSlot), R(context), U8(4), //
- B(CreateClosure), U8(0), U8(0), //
- B(Star), R(0), //
- B(StackCheck), //
- B(LdaSmi8), U8(10), //
- B(StaContextSlot), R(context), U8(4), //
- B(LdaSmi8), U8(20), //
- B(Star), R(2), //
- B(LdaContextSlot), R(context), U8(4), //
- B(JumpIfNotHole), U8(11), //
- B(LdaConstant), U8(1), //
- B(Star), R(3), //
- B(CallRuntime), U16(Runtime::kThrowReferenceError), R(3), U8(1), //
- B(CallRuntime), U16(Runtime::kThrowConstAssignError), R(0), //
- U8(0), //
- B(Ldar), R(2), //
- B(StaContextSlot), R(context), U8(4), //
- B(LdaUndefined), //
- B(Return) //
- },
- 2,
- {InstanceType::SHARED_FUNCTION_INFO_TYPE,
- InstanceType::ONE_BYTE_INTERNALIZED_STRING_TYPE}},
+ InitializedIgnitionHandleScope scope;
+ BytecodeExpectationsPrinter printer(CcTest::isolate(),
+ ConstantPoolType::kMixed);
+ const char* snippets[] = {
+ "const x = 10; function f1() {return x;}",
+ "const x = 10; function f1() {return x;} return x;",
+ "const x = (x = 20); function f1() {return x;}",
+ "const x = 10; x = 20; function f1() {return x;}",
};
- // clang-format on
- for (size_t i = 0; i < arraysize(snippets); i++) {
- Handle<BytecodeArray> bytecode_array =
- helper.MakeBytecodeForFunctionBody(snippets[i].code_snippet);
- CheckBytecodeArrayEqual(snippets[i], bytecode_array);
- }
+ CHECK_EQ(BuildActual(printer, snippets),
+ LoadGolden("ConstVariableContextSlot.golden"));
}
TEST(LetVariableContextSlot) {
- InitializedHandleScope handle_scope;
- BytecodeGeneratorHelper helper;
-
- int closure = Register::function_closure().index();
- int context = Register::current_context().index();
-
- // clang-format off
- ExpectedSnippet<InstanceType> snippets[] = {
- {"let x = 10; function f1() {return x;}",
- 2 * kPointerSize,
- 1,
- 24,
- {
- B(CallRuntime), U16(Runtime::kNewFunctionContext), R(closure), //
- /* */ U8(1), //
- B(PushContext), R(1), //
- B(LdaTheHole), //
- B(StaContextSlot), R(context), U8(4), //
- B(CreateClosure), U8(0), U8(0), //
- B(Star), R(0), //
- B(StackCheck), //
- B(LdaSmi8), U8(10), //
- B(StaContextSlot), R(context), U8(4), //
- B(LdaUndefined), //
- B(Return) //
- },
- 1,
- {InstanceType::SHARED_FUNCTION_INFO_TYPE}},
- {"let x = 10; function f1() {return x;} return x;",
- 3 * kPointerSize,
- 1,
- 37,
- {
- B(CallRuntime), U16(Runtime::kNewFunctionContext), R(closure), //
- /* */ U8(1), //
- B(PushContext), R(1), //
- B(LdaTheHole), //
- B(StaContextSlot), R(context), U8(4), //
- B(CreateClosure), U8(0), U8(0), //
- B(Star), R(0), //
- B(StackCheck), //
- B(LdaSmi8), U8(10), //
- B(StaContextSlot), R(context), U8(4), //
- B(LdaContextSlot), R(context), U8(4), //
- B(JumpIfNotHole), U8(11), //
- B(LdaConstant), U8(1), //
- B(Star), R(2), //
- B(CallRuntime), U16(Runtime::kThrowReferenceError), R(2), U8(1), //
- B(Return) //
- },
- 2,
- {InstanceType::SHARED_FUNCTION_INFO_TYPE,
- InstanceType::ONE_BYTE_INTERNALIZED_STRING_TYPE}},
- {"let x = (x = 20); function f1() {return x;}",
- 4 * kPointerSize,
- 1,
- 45,
- {
- B(CallRuntime), U16(Runtime::kNewFunctionContext), R(closure), //
- /* */ U8(1), //
- B(PushContext), R(1), //
- B(LdaTheHole), //
- B(StaContextSlot), R(context), U8(4), //
- B(CreateClosure), U8(0), U8(0), //
- B(Star), R(0), //
- B(StackCheck), //
- B(LdaSmi8), U8(20), //
- B(Star), R(2), //
- B(LdaContextSlot), R(context), U8(4), //
- B(JumpIfNotHole), U8(11), //
- B(LdaConstant), U8(1), //
- B(Star), R(3), //
- B(CallRuntime), U16(Runtime::kThrowReferenceError), R(3), U8(1), //
- B(Ldar), R(2), //
- B(StaContextSlot), R(context), U8(4), //
- B(StaContextSlot), R(context), U8(4), //
- B(LdaUndefined), //
- B(Return) //
- },
- 2,
- {InstanceType::SHARED_FUNCTION_INFO_TYPE,
- InstanceType::ONE_BYTE_INTERNALIZED_STRING_TYPE}},
- {"let x = 10; x = 20; function f1() {return x;}",
- 4 * kPointerSize,
- 1,
- 47,
- {
- B(CallRuntime), U16(Runtime::kNewFunctionContext), R(closure), //
- /* */ U8(1), //
- B(PushContext), R(1), //
- B(LdaTheHole), //
- B(StaContextSlot), R(context), U8(4), //
- B(CreateClosure), U8(0), U8(0), //
- B(Star), R(0), //
- B(StackCheck), //
- B(LdaSmi8), U8(10), //
- B(StaContextSlot), R(context), U8(4), //
- B(LdaSmi8), U8(20), //
- B(Star), R(2), //
- B(LdaContextSlot), R(context), U8(4), //
- B(JumpIfNotHole), U8(11), //
- B(LdaConstant), U8(1), //
- B(Star), R(3), //
- B(CallRuntime), U16(Runtime::kThrowReferenceError), R(3), U8(1), //
- B(Ldar), R(2), //
- B(StaContextSlot), R(context), U8(4), //
- B(LdaUndefined), //
- B(Return) //
- },
- 2,
- {InstanceType::SHARED_FUNCTION_INFO_TYPE,
- InstanceType::ONE_BYTE_INTERNALIZED_STRING_TYPE}},
+ InitializedIgnitionHandleScope scope;
+ BytecodeExpectationsPrinter printer(CcTest::isolate(),
+ ConstantPoolType::kMixed);
+ const char* snippets[] = {
+ "let x = 10; function f1() {return x;}",
+ "let x = 10; function f1() {return x;} return x;",
+ "let x = (x = 20); function f1() {return x;}",
+ "let x = 10; x = 20; function f1() {return x;}",
};
- // clang-format on
- for (size_t i = 0; i < arraysize(snippets); i++) {
- Handle<BytecodeArray> bytecode_array =
- helper.MakeBytecodeForFunctionBody(snippets[i].code_snippet);
- CheckBytecodeArrayEqual(snippets[i], bytecode_array);
- }
+ CHECK_EQ(BuildActual(printer, snippets),
+ LoadGolden("LetVariableContextSlot.golden"));
}
TEST(DoExpression) {
bool old_flag = FLAG_harmony_do_expressions;
FLAG_harmony_do_expressions = true;
- InitializedHandleScope handle_scope;
- BytecodeGeneratorHelper helper;
-
- // clang-format off
- ExpectedSnippet<const char*> snippets[] = {
- {"var a = do { }; return a;",
- 2 * kPointerSize,
- 1,
- 6,
- {
- B(StackCheck), //
- B(Ldar), R(0), //
- B(Star), R(1), //
- B(Return) //
- },
- 0},
- {"var a = do { var x = 100; }; return a;",
- 3 * kPointerSize,
- 1,
- 11,
- {
- B(StackCheck), //
- B(LdaSmi8), U8(100), //
- B(Star), R(1), //
- B(LdaUndefined), //
- B(Star), R(0), //
- B(Star), R(2), //
- B(Return) //
- },
- 0},
- {"while(true) { var a = 10; a = do { ++a; break; }; a = 20; }",
- 2 * kPointerSize,
- 1,
- 26,
- {
- B(StackCheck), //
- B(StackCheck), //
- B(LdaSmi8), U8(10), //
- B(Star), R(1), //
- B(ToNumber), //
- B(Inc), //
- B(Star), R(1), //
- B(Star), R(0), //
- B(Jump), U8(12), //
- B(Ldar), R(0), //
- B(Star), R(1), //
- B(LdaSmi8), U8(20), //
- B(Star), R(1), //
- B(Jump), U8(-21), //
- B(LdaUndefined), //
- B(Return), //
- },
- 0},
+ InitializedIgnitionHandleScope scope;
+ BytecodeExpectationsPrinter printer(CcTest::isolate(),
+ ConstantPoolType::kString);
+ const char* snippets[] = {
+ "var a = do { }; return a;",
+ "var a = do { var x = 100; }; return a;",
+ "while(true) { var a = 10; a = do { ++a; break; }; a = 20; }",
};
- // clang-format on
- for (size_t i = 0; i < arraysize(snippets); i++) {
- Handle<BytecodeArray> bytecode_array =
- helper.MakeBytecodeForFunctionBody(snippets[i].code_snippet);
- CheckBytecodeArrayEqual(snippets[i], bytecode_array);
- }
+ CHECK_EQ(BuildActual(printer, snippets),
+ LoadGolden("DoExpression.golden"));
+
FLAG_harmony_do_expressions = old_flag;
}
TEST(WithStatement) {
- InitializedHandleScope handle_scope;
- BytecodeGeneratorHelper helper;
-
- int deep_elements_flags =
- ObjectLiteral::kFastElements | ObjectLiteral::kDisableMementos;
- int context = Register::current_context().index();
- int closure = Register::function_closure().index();
- int new_target = Register::new_target().index();
-
- // clang-format off
- ExpectedSnippet<InstanceType> snippets[] = {
- {"with ({x:42}) { return x; }",
- 5 * kPointerSize,
- 1,
- 47,
- {
- B(CallRuntime), U16(Runtime::kNewFunctionContext), R(closure), //
- /* */ U8(1), //
- B(PushContext), R(0), //
- B(Ldar), THIS(1), //
- B(StaContextSlot), R(context), U8(4), //
- B(CreateMappedArguments), //
- B(StaContextSlot), R(context), U8(5), //
- B(Ldar), R(new_target), //
- B(StaContextSlot), R(context), U8(6), //
- B(StackCheck), //
- B(CreateObjectLiteral), U8(0), U8(0), U8(deep_elements_flags), //
- B(Star), R(2), //
- B(ToObject), //
- B(Star), R(3), //
- B(Ldar), R(closure), //
- B(Star), R(4), //
- B(CallRuntime), U16(Runtime::kPushWithContext), R(3), U8(2), //
- B(PushContext), R(1), //
- B(LdaLookupSlot), U8(1), //
- B(PopContext), R(0), //
- B(Return), //
- },
- 2,
- {InstanceType::FIXED_ARRAY_TYPE,
- InstanceType::ONE_BYTE_INTERNALIZED_STRING_TYPE}},
+ InitializedIgnitionHandleScope scope;
+ BytecodeExpectationsPrinter printer(CcTest::isolate(),
+ ConstantPoolType::kMixed);
+ const char* snippets[] = {
+ "with ({x:42}) { return x; }",
};
- // clang-format on
- for (size_t i = 0; i < arraysize(snippets); i++) {
- Handle<BytecodeArray> bytecode_array =
- helper.MakeBytecodeForFunctionBody(snippets[i].code_snippet);
- CheckBytecodeArrayEqual(snippets[i], bytecode_array);
- }
+ CHECK_EQ(BuildActual(printer, snippets),
+ LoadGolden("WithStatement.golden"));
}
TEST(DoDebugger) {
- InitializedHandleScope handle_scope;
- BytecodeGeneratorHelper helper;
-
- // clang-format off
- ExpectedSnippet<const char*> snippet = {
- "debugger;",
- 0,
- 1,
- 4,
- {
- B(StackCheck), //
- B(Debugger), //
- B(LdaUndefined), //
- B(Return) //
- },
- 0
+ InitializedIgnitionHandleScope scope;
+ BytecodeExpectationsPrinter printer(CcTest::isolate(),
+ ConstantPoolType::kString);
+ const char* snippets[] = {
+ "debugger;",
};
- // clang-format on
- Handle<BytecodeArray> bytecode_array =
- helper.MakeBytecodeForFunctionBody(snippet.code_snippet);
- CheckBytecodeArrayEqual(snippet, bytecode_array);
+ CHECK_EQ(BuildActual(printer, snippets),
+ LoadGolden("DoDebugger.golden"));
}
// TODO(rmcilroy): Update expectations after switch to
// Runtime::kDefineDataPropertyInLiteral.
TEST(ClassDeclarations) {
- InitializedHandleScope handle_scope;
- BytecodeGeneratorHelper helper;
-
- int closure = Register::function_closure().index();
- int context = Register::current_context().index();
-
- // clang-format off
- ExpectedSnippet<InstanceType, 12> snippets[] = {
- {"class Person {\n"
- " constructor(name) { this.name = name; }\n"
- " speak() { console.log(this.name + ' is speaking.'); }\n"
- "}\n",
- 9 * kPointerSize,
- 1,
- 71,
- {
- B(LdaTheHole), //
- B(Star), R(1), //
- B(StackCheck), //
- B(LdaTheHole), //
- B(Star), R(0), //
- B(LdaTheHole), //
- B(Star), R(2), //
- B(CreateClosure), U8(0), U8(0), //
- B(Star), R(3), //
- B(LdaSmi8), U8(15), //
- B(Star), R(4), //
- B(LdaConstant), U8(1), //
- B(Star), R(5), //
- B(CallRuntime), U16(Runtime::kDefineClass), R(2), U8(4), //
- B(Star), R(2), //
- B(LoadIC), R(2), U8(2), U8(1), //
- B(Star), R(3), //
- B(Mov), R(3), R(4), //
- B(LdaConstant), U8(3), //
- B(Star), R(5), //
- B(CreateClosure), U8(4), U8(0), //
- B(Star), R(6), //
- B(LdaSmi8), U8(2), //
- B(Star), R(7), //
- B(LdaZero), //
- B(Star), R(8), //
- B(CallRuntime), U16(Runtime::kDefineDataPropertyInLiteral), R(4), U8(5),
- B(CallRuntime), U16(Runtime::kFinalizeClassDefinition), R(2), U8(2), //
- B(Star), R(0), //
- B(Star), R(1), //
- B(LdaUndefined), //
- B(Return) //
- },
- 5,
- { InstanceType::SHARED_FUNCTION_INFO_TYPE, kInstanceTypeDontCare,
- InstanceType::ONE_BYTE_INTERNALIZED_STRING_TYPE,
- InstanceType::ONE_BYTE_INTERNALIZED_STRING_TYPE,
- InstanceType::SHARED_FUNCTION_INFO_TYPE}},
- {"class person {\n"
- " constructor(name) { this.name = name; }\n"
- " speak() { console.log(this.name + ' is speaking.'); }\n"
- "}\n",
- 9 * kPointerSize,
- 1,
- 71,
- {
- B(LdaTheHole), //
- B(Star), R(1), //
- B(StackCheck), //
- B(LdaTheHole), //
- B(Star), R(0), //
- B(LdaTheHole), //
- B(Star), R(2), //
- B(CreateClosure), U8(0), U8(0), //
- B(Star), R(3), //
- B(LdaSmi8), U8(15), //
- B(Star), R(4), //
- B(LdaConstant), U8(1), //
- B(Star), R(5), //
- B(CallRuntime), U16(Runtime::kDefineClass), R(2), U8(4), //
- B(Star), R(2), //
- B(LoadIC), R(2), U8(2), U8(1), //
- B(Star), R(3), //
- B(Mov), R(3), R(4), //
- B(LdaConstant), U8(3), //
- B(Star), R(5), //
- B(CreateClosure), U8(4), U8(0), //
- B(Star), R(6), //
- B(LdaSmi8), U8(2), //
- B(Star), R(7), //
- B(LdaZero), //
- B(Star), R(8), //
- B(CallRuntime), U16(Runtime::kDefineDataPropertyInLiteral), R(4), U8(5),
- B(CallRuntime), U16(Runtime::kFinalizeClassDefinition), R(2), U8(2), //
- B(Star), R(0), //
- B(Star), R(1), //
- B(LdaUndefined), //
- B(Return) //
- },
- 5,
- { InstanceType::SHARED_FUNCTION_INFO_TYPE, kInstanceTypeDontCare,
- InstanceType::ONE_BYTE_INTERNALIZED_STRING_TYPE,
- InstanceType::ONE_BYTE_INTERNALIZED_STRING_TYPE,
- InstanceType::SHARED_FUNCTION_INFO_TYPE}},
- {"var n0 = 'a';"
- "var n1 = 'b';"
- "class N {\n"
- " [n0]() { return n0; }\n"
- " static [n1]() { return n1; }\n"
- "}\n",
- 10 * kPointerSize,
- 1,
- 125,
- {
- B(CallRuntime), U16(Runtime::kNewFunctionContext), R(closure), //
- /* */ U8(1), //
- B(PushContext), R(2), //
- B(LdaTheHole), //
- B(Star), R(1), //
- B(StackCheck), //
- B(LdaConstant), U8(0), //
- B(StaContextSlot), R(context), U8(4), //
- B(LdaConstant), U8(1), //
- B(StaContextSlot), R(context), U8(5), //
- B(LdaTheHole), //
- B(Star), R(0), //
- B(LdaTheHole), //
- B(Star), R(3), //
- B(CreateClosure), U8(2), U8(0), //
- B(Star), R(4), //
- B(LdaSmi8), U8(41), //
- B(Star), R(5), //
- B(LdaSmi8), U8(107), //
- B(Star), R(6), //
- B(CallRuntime), U16(Runtime::kDefineClass), R(3), U8(4), //
- B(Star), R(3), //
- B(LoadIC), R(3), U8(3), U8(1), //
- B(Star), R(4), //
- B(Mov), R(4), R(5), //
- B(LdaContextSlot), R(context), U8(4), //
- B(ToName), //
- B(Star), R(6), //
- B(CreateClosure), U8(4), U8(0), //
- B(Star), R(7), //
- B(LdaSmi8), U8(2), //
- B(Star), R(8), //
- B(LdaSmi8), U8(1), //
- B(Star), R(9), //
- B(CallRuntime), U16(Runtime::kDefineDataPropertyInLiteral), R(5), U8(5),
- B(Mov), R(3), R(5), //
- B(LdaContextSlot), R(context), U8(5), //
- B(ToName), //
- B(Star), R(6), //
- B(LdaConstant), U8(3), //
- B(TestEqualStrict), R(6), //
- B(JumpIfFalse), U8(7), //
- B(CallRuntime), U16(Runtime::kThrowStaticPrototypeError), //
- /* */ R(0), U8(0), //
- B(CreateClosure), U8(5), U8(0), //
- B(Star), R(7), //
- B(LdaSmi8), U8(1), //
- B(Star), R(9), //
- B(CallRuntime), U16(Runtime::kDefineDataPropertyInLiteral), R(5), U8(5),
- B(CallRuntime), U16(Runtime::kFinalizeClassDefinition), R(3), U8(2), //
- B(Star), R(0), //
- B(Star), R(1), //
- B(LdaUndefined), //
- B(Return), //
- },
- 6,
- { InstanceType::ONE_BYTE_INTERNALIZED_STRING_TYPE,
- InstanceType::ONE_BYTE_INTERNALIZED_STRING_TYPE,
- InstanceType::SHARED_FUNCTION_INFO_TYPE,
- InstanceType::ONE_BYTE_INTERNALIZED_STRING_TYPE,
- InstanceType::SHARED_FUNCTION_INFO_TYPE,
- InstanceType::SHARED_FUNCTION_INFO_TYPE}},
- {"var count = 0;\n"
- "class C { constructor() { count++; }}\n"
- "return new C();\n",
- 10 * kPointerSize,
- 1,
- 74,
- {
- B(CallRuntime), U16(Runtime::kNewFunctionContext), R(closure), U8(1), //
- B(PushContext), R(2), //
- B(LdaTheHole), //
- B(Star), R(1), //
- B(StackCheck), //
- B(LdaZero), //
- B(StaContextSlot), R(context), U8(4), //
- B(LdaTheHole), //
- B(Star), R(0), //
- B(LdaTheHole), //
- B(Star), R(3), //
- B(CreateClosure), U8(0), U8(0), //
- B(Star), R(4), //
- B(LdaSmi8), U8(30), //
- B(Star), R(5), //
- B(LdaSmi8), U8(67), //
- B(Star), R(6), //
- B(CallRuntime), U16(Runtime::kDefineClass), R(3), U8(4), //
- B(Star), R(3), //
- B(LoadIC), R(3), U8(1), U8(1), //
- B(Star), R(4), //
- B(CallRuntime), U16(Runtime::kFinalizeClassDefinition), R(3), U8(2), //
- B(Star), R(0), //
- B(Star), R(1), //
- B(JumpIfNotHole), U8(11), //
- B(LdaConstant), U8(2), //
- B(Star), R(4), //
- B(CallRuntime), U16(Runtime::kThrowReferenceError), R(4), U8(1), //
- B(Star), R(3), //
- B(New), R(3), R(0), U8(0), //
- B(Return), //
- },
- 3,
- { InstanceType::SHARED_FUNCTION_INFO_TYPE,
- InstanceType::ONE_BYTE_INTERNALIZED_STRING_TYPE,
- InstanceType::ONE_BYTE_INTERNALIZED_STRING_TYPE}},
- };
- // clang-format on
-
- for (size_t i = 0; i < arraysize(snippets); i++) {
- Handle<BytecodeArray> bytecode_array =
- helper.MakeBytecodeForFunctionBody(snippets[i].code_snippet);
- CheckBytecodeArrayEqual(snippets[i], bytecode_array);
- }
+ InitializedIgnitionHandleScope scope;
+ BytecodeExpectationsPrinter printer(CcTest::isolate(),
+ ConstantPoolType::kMixed);
+ const char* snippets[] = {
+ "class Person {\n"
oth 2016/02/24 13:43:55 clang-format off
+ " constructor(name) { this.name = name; }\n"
+ " speak() { console.log(this.name + ' is speaking.'); }\n"
+ "}\n",
+
+ "class person {\n"
+ " constructor(name) { this.name = name; }\n"
+ " speak() { console.log(this.name + ' is speaking.'); }\n"
+ "}\n",
+
+ "var n0 = 'a';"
+ "var n1 = 'b';"
+ "class N {\n"
+ " [n0]() { return n0; }\n"
+ " static [n1]() { return n1; }\n"
+ "}\n",
+
+ "var count = 0;\n"
+ "class C { constructor() { count++; }}\n"
+ "return new C();\n",
oth 2016/02/24 13:43:55 clang-format on
+ };
+
+ CHECK_EQ(BuildActual(printer, snippets),
+ LoadGolden("ClassDeclarations.golden"));
}
// TODO(oth): Add tests for super keyword.

Powered by Google App Engine
This is Rietveld 408576698