test/cctest/interpreter/Throw.golden - Issue 1717293002: [Interpreter] Refactor bytecode generator test suite.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: test/cctest/interpreter/Throw.golden

Issue 1717293002: [Interpreter] Refactor bytecode generator test suite. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: std::vector instead of initializer_list, golden path as constant. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 #

	2 # Autogenerated by generate-bytecode-expectations

	3 #

	4

	5 ---

	6 pool type: string

	7 execute: yes

	8 wrap: yes

	9

	10 ---

	11 snippet: "

	12 throw 1;

	13 "

	14 frame size: 0

	15 parameter count: 1

	16 bytecodes: [

	17 B(StackCheck),

	18 B(LdaSmi8), U8(1),

	19 B(Throw),

	20 ]

	21 constant pool: [

	22 ]

	23 handlers: [

	24 ]

	25

	26 ---

	27 snippet: "

	28 throw 'Error';

	29 "

	30 frame size: 0

	31 parameter count: 1

	32 bytecodes: [

	33 B(StackCheck),

	34 B(LdaConstant), U8(0),

	35 B(Throw),

	36 ]

	37 constant pool: [

	38 "Error",

	39 ]

	40 handlers: [

	41 ]

	42

	43 ---

	44 snippet: "

	45 var a = 1; if (a) { throw 'Error'; };

	46 "

	47 frame size: 1 # in multiples of sizeof(void*)

	48 parameter count: 1

	49 bytecodes: [

	50 B(StackCheck),

	51 B(LdaSmi8), U8(1),

	52 B(Star), R(0),

	53 B(JumpIfToBooleanFalse), U8(5),

	54 B(LdaConstant), U8(0),

	55 B(Throw),

	56 B(LdaUndefined),

	57 B(Return),

	58 ]

	59 constant pool: [

	60 "Error",

	61 ]

	62 handlers: [

	63 ]

	64

OLD	NEW