test/cctest/interpreter/Conditional.golden - Issue 1717293002: [Interpreter] Refactor bytecode generator test suite.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: test/cctest/interpreter/Conditional.golden

Issue 1717293002: [Interpreter] Refactor bytecode generator test suite. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: std::vector instead of initializer_list, golden path as constant. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 #

	2 # Autogenerated by generate-bytecode-expectations

	3 #

	4

	5 ---

	6 pool type: number

	7 execute: yes

	8 wrap: yes

	9

	10 ---

	11 snippet: "

	12 return 1 ? 2 : 3;

	13 "

	14 frame size: 0

	15 parameter count: 1

	16 bytecodes: [

	17 B(StackCheck),

	18 B(LdaSmi8), U8(1),

	19 B(JumpIfToBooleanFalse), U8(6),

	20 B(LdaSmi8), U8(2),

	21 B(Jump), U8(4),

	22 B(LdaSmi8), U8(3),

	23 B(Return),

	24 ]

	25 constant pool: [

	26 ]

	27 handlers: [

	28 ]

	29

	30 ---

	31 snippet: "

	32 return 1 ? 2 ? 3 : 4 : 5;

	33 "

	34 frame size: 0

	35 parameter count: 1

	36 bytecodes: [

	37 B(StackCheck),

	38 B(LdaSmi8), U8(1),

	39 B(JumpIfToBooleanFalse), U8(14),

	40 B(LdaSmi8), U8(2),

	41 B(JumpIfToBooleanFalse), U8(6),

	42 B(LdaSmi8), U8(3),

	43 B(Jump), U8(4),

	44 B(LdaSmi8), U8(4),

	45 B(Jump), U8(4),

	46 B(LdaSmi8), U8(5),

	47 B(Return),

	48 ]

	49 constant pool: [

	50 ]

	51 handlers: [

	52 ]

	53

OLD	NEW