base/trace_event/trace_log.h - Issue 1717283003: tracing: Make ConvertableToTraceFormat move-only scoped_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/trace_event/trace_log.h

Issue 1717283003: tracing: Make ConvertableToTraceFormat move-only scoped_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: . Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/trace_event/trace_log.h

diff --git a/base/trace_event/trace_log.h b/base/trace_event/trace_log.h

index 7d2d748df5bec240f20ecebe3bab6726e72b0079..2de969ce3037d328ef51d375d8d75abe817f9c74 100644

--- a/base/trace_event/trace_log.h

+++ b/base/trace_event/trace_log.h

@@ -191,7 +191,7 @@ class BASE_EXPORT TraceLog : public MemoryDumpProvider {

const char** arg_names,

const unsigned char* arg_types,

const unsigned long long* arg_values,

- const scoped_refptr<ConvertableToTraceFormat>* convertable_values,

+ scoped_ptr<ConvertableToTraceFormat>* convertable_values,

unsigned int flags);

TraceEventHandle AddTraceEventWithBindId(

char phase,

@@ -204,7 +204,7 @@ class BASE_EXPORT TraceLog : public MemoryDumpProvider {

const char** arg_names,

const unsigned char* arg_types,

const unsigned long long* arg_values,

- const scoped_refptr<ConvertableToTraceFormat>* convertable_values,

+ scoped_ptr<ConvertableToTraceFormat>* convertable_values,

unsigned int flags);

TraceEventHandle AddTraceEventWithProcessId(

char phase,

@@ -217,7 +217,7 @@ class BASE_EXPORT TraceLog : public MemoryDumpProvider {

const char** arg_names,

const unsigned char* arg_types,

const unsigned long long* arg_values,

- const scoped_refptr<ConvertableToTraceFormat>* convertable_values,

+ scoped_ptr<ConvertableToTraceFormat>* convertable_values,

unsigned int flags);

TraceEventHandle AddTraceEventWithThreadIdAndTimestamp(

char phase,

@@ -231,7 +231,7 @@ class BASE_EXPORT TraceLog : public MemoryDumpProvider {

const char** arg_names,

const unsigned char* arg_types,

const unsigned long long* arg_values,

- const scoped_refptr<ConvertableToTraceFormat>* convertable_values,

+ scoped_ptr<ConvertableToTraceFormat>* convertable_values,

unsigned int flags);

TraceEventHandle AddTraceEventWithThreadIdAndTimestamp(

char phase,

@@ -246,7 +246,7 @@ class BASE_EXPORT TraceLog : public MemoryDumpProvider {

const char** arg_names,

const unsigned char* arg_types,

const unsigned long long* arg_values,

- const scoped_refptr<ConvertableToTraceFormat>* convertable_values,

+ scoped_ptr<ConvertableToTraceFormat>* convertable_values,

unsigned int flags);

// Adds a metadata event that will be written when the trace log is flushed.

@@ -256,7 +256,7 @@ class BASE_EXPORT TraceLog : public MemoryDumpProvider {

const char** arg_names,

const unsigned char* arg_types,

const unsigned long long* arg_values,

- const scoped_refptr<ConvertableToTraceFormat>* convertable_values,

+ scoped_ptr<ConvertableToTraceFormat>* convertable_values,

unsigned int flags);

void UpdateTraceEventDuration(const unsigned char* category_group_enabled,

« no previous file with comments | « base/trace_event/trace_event_unittest.cc ('k') | base/trace_event/trace_log.cc » ('j') | cc/debug/benchmark_instrumentation.cc » ('J')