base/trace_event/common/trace_event_common.h - Issue 1717283003: tracing: Make ConvertableToTraceFormat move-only scoped_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/trace_event/common/trace_event_common.h

Issue 1717283003: tracing: Make ConvertableToTraceFormat move-only scoped_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: . Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/trace_event/common/trace_event_common.h

diff --git a/base/trace_event/common/trace_event_common.h b/base/trace_event/common/trace_event_common.h

index 8d13fc2e8cb8a59662291e8c8c499624ab1c64e5..e8a849a1c55ee2b2bd4a8c8421ebd49d8b7f8719 100644

--- a/base/trace_event/common/trace_event_common.h

+++ b/base/trace_event/common/trace_event_common.h

@@ -156,7 +156,7 @@

// };

// TRACE_EVENT1("foo", "bar", "data",

-// scoped_refptr<ConvertableToTraceFormat>(new MyData()));

+// scoped_ptr<ConvertableToTraceFormat>(new MyData()));

// The trace framework will take ownership if the passed pointer and it will

// be free'd when the trace buffer is flushed.

« no previous file with comments | « base/test/test_pending_task_unittest.cc ('k') | base/trace_event/heap_profiler_heap_dump_writer.h » ('j') | cc/debug/benchmark_instrumentation.cc » ('J')