third_party/WebKit/Source/platform/web_process_memory_dump_impl.cc - Issue 1717283003: tracing: Make ConvertableToTraceFormat move-only scoped_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/web_process_memory_dump_impl.cc

Issue 1717283003: tracing: Make ConvertableToTraceFormat move-only scoped_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« cc/layers/layer_impl.cc ('K') | « third_party/WebKit/Source/platform/graphics/GraphicsLayerDebugInfo.cpp ('k') | third_party/WebKit/Source/platform/web_process_memory_dump_impl_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/web_process_memory_dump_impl.cc

diff --git a/third_party/WebKit/Source/platform/web_process_memory_dump_impl.cc b/third_party/WebKit/Source/platform/web_process_memory_dump_impl.cc

index 0cd4b7ad473a7fa81967c747272fb3717c9649db..5953f3c14b46730d390d6ecc490d48dd1b375566 100644

--- a/third_party/WebKit/Source/platform/web_process_memory_dump_impl.cc

+++ b/third_party/WebKit/Source/platform/web_process_memory_dump_impl.cc

@@ -173,11 +173,10 @@ void WebProcessMemoryDumpImpl::dumpHeapUsage(

const char* allocator_name) {

scoped_refptr<base::trace_event::MemoryDumpSessionState> session_state =

process_memory_dump_->session_state();

- scoped_refptr<base::trace_event::TracedValue> heap_dump = ExportHeapDump(

- bytes_by_context,

- session_state->stack_frame_deduplicator(),

+ scoped_ptr<base::trace_event::TracedValue> heap_dump = ExportHeapDump(

+ bytes_by_context, session_state->stack_frame_deduplicator(),

session_state->type_name_deduplicator());

- process_memory_dump_->AddHeapDump(allocator_name, heap_dump);

+ process_memory_dump_->AddHeapDump(allocator_name, std::move(heap_dump));

std::string base_name = base::StringPrintf("tracing/heap_profiler_%s",

allocator_name);

overhead.DumpInto(base_name.c_str(), process_memory_dump_);