Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Unified Diff: components/exo/shell_surface.cc

Issue 1717283003: tracing: Make ConvertableToTraceFormat move-only scoped_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/exo/shell_surface.cc
diff --git a/components/exo/shell_surface.cc b/components/exo/shell_surface.cc
index 5e2e9eb795a6dc3b62878edd892cce27059b0c24..6ce2050bed9326c6c5961eda090f5c3a644e2c3a 100644
--- a/components/exo/shell_surface.cc
+++ b/components/exo/shell_surface.cc
@@ -229,10 +229,9 @@ Surface* ShellSurface::GetMainSurface(const aura::Window* window) {
return window->GetProperty(kMainSurfaceKey);
}
-scoped_refptr<base::trace_event::TracedValue> ShellSurface::AsTracedValue()
- const {
- scoped_refptr<base::trace_event::TracedValue> value =
- new base::trace_event::TracedValue;
+scoped_ptr<base::trace_event::TracedValue> ShellSurface::AsTracedValue() const {
+ scoped_ptr<base::trace_event::TracedValue> value(
+ new base::trace_event::TracedValue());
value->SetString("title", base::UTF16ToUTF8(title_));
value->SetString("application_id", application_id_);
return value;

Powered by Google App Engine
This is Rietveld 408576698