cc/test/ordered_simple_task_runner.h - Issue 1717283003: tracing: Make ConvertableToTraceFormat move-only scoped_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/test/ordered_simple_task_runner.h

Issue 1717283003: tracing: Make ConvertableToTraceFormat move-only scoped_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: cc/test/ordered_simple_task_runner.h

diff --git a/cc/test/ordered_simple_task_runner.h b/cc/test/ordered_simple_task_runner.h

index c7abe409e9fc354933dd738eacdbcd8a36d970ea..0ebd25c6f6029e9511ff5b36136f3e51879afa94 100644

--- a/cc/test/ordered_simple_task_runner.h

+++ b/cc/test/ordered_simple_task_runner.h

@@ -37,7 +37,7 @@ class TestOrderablePendingTask : public base::TestPendingTask {

bool operator<(const TestOrderablePendingTask& other) const;

// base::trace_event tracing functionality

- scoped_refptr<base::trace_event::ConvertableToTraceFormat> AsValue() const;

+ scoped_ptr<base::trace_event::ConvertableToTraceFormat> AsValue() const;

void AsValueInto(base::trace_event::TracedValue* state) const;

private:

@@ -106,7 +106,7 @@ class OrderedSimpleTaskRunner : public base::SingleThreadTaskRunner {

bool RunForPeriod(base::TimeDelta period);

// base::trace_event tracing functionality

- scoped_refptr<base::trace_event::ConvertableToTraceFormat> AsValue() const;

+ scoped_ptr<base::trace_event::ConvertableToTraceFormat> AsValue() const;

virtual void AsValueInto(base::trace_event::TracedValue* state) const;

// Common conditions to run for, exposed publicly to allow external users to

« cc/layers/layer_impl.cc ('K') | « cc/scheduler/scheduler_unittest.cc ('k') | cc/test/ordered_simple_task_runner.cc » ('j') | no next file with comments »