cc/debug/traced_display_item_list.cc - Issue 1717283003: tracing: Make ConvertableToTraceFormat move-only scoped_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/debug/traced_display_item_list.cc

Issue 1717283003: tracing: Make ConvertableToTraceFormat move-only scoped_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: cc/debug/traced_display_item_list.cc

diff --git a/cc/debug/traced_display_item_list.cc b/cc/debug/traced_display_item_list.cc

index 1b45a593f2a98f8c527bb7b7ace73ab1f597ad78..7da87b97fe9b3a4d5566391f30b6b52dff003554 100644

--- a/cc/debug/traced_display_item_list.cc

+++ b/cc/debug/traced_display_item_list.cc

@@ -19,8 +19,8 @@ TracedDisplayItemList::~TracedDisplayItemList() {

}

void TracedDisplayItemList::AppendAsTraceFormat(std::string* out) const {

- scoped_refptr<base::trace_event::ConvertableToTraceFormat> convertable =

- display_item_list_->AsValue(include_items_);

+ scoped_ptr<base::trace_event::ConvertableToTraceFormat> convertable(

+ display_item_list_->AsValue(include_items_));

convertable->AppendAsTraceFormat(out);

}

« no previous file with comments | « cc/debug/traced_display_item_list.h ('k') | cc/layers/layer.h » ('j') | cc/layers/layer_impl.cc » ('J')