Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(588)

Unified Diff: cc/debug/rendering_stats.cc

Issue 1717283003: tracing: Make ConvertableToTraceFormat move-only scoped_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/debug/rendering_stats.cc
diff --git a/cc/debug/rendering_stats.cc b/cc/debug/rendering_stats.cc
index b78b4f9f0b747c653ff2983b62eb4442b5b5dc5e..f0d56aab4adca567f9f717fd747db8764444b563 100644
--- a/cc/debug/rendering_stats.cc
+++ b/cc/debug/rendering_stats.cc
@@ -50,10 +50,10 @@ RenderingStats::RenderingStats(const RenderingStats& other) = default;
RenderingStats::~RenderingStats() {
}
-scoped_refptr<base::trace_event::ConvertableToTraceFormat>
+scoped_ptr<base::trace_event::ConvertableToTraceFormat>
RenderingStats::AsTraceableData() const {
- scoped_refptr<base::trace_event::TracedValue> record_data =
- new base::trace_event::TracedValue();
+ scoped_ptr<base::trace_event::TracedValue> record_data(
+ new base::trace_event::TracedValue());
record_data->SetInteger("frame_count", frame_count);
record_data->SetInteger("visible_content_area", visible_content_area);
record_data->SetInteger("approximated_visible_content_area",
@@ -80,7 +80,7 @@ RenderingStats::AsTraceableData() const {
commit_to_activate_duration_estimate.AddToTracedValue(
"commit_to_activate_duration_estimate_ms", record_data.get());
- return record_data;
+ return std::move(record_data);
}
void RenderingStats::Add(const RenderingStats& other) {

Powered by Google App Engine
This is Rietveld 408576698