Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1502)

Unified Diff: cc/debug/frame_viewer_instrumentation.cc

Issue 1717283003: tracing: Make ConvertableToTraceFormat move-only scoped_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/debug/frame_viewer_instrumentation.cc
diff --git a/cc/debug/frame_viewer_instrumentation.cc b/cc/debug/frame_viewer_instrumentation.cc
index e12858371d612ad3624ad9bd3578b6de179f7875..5181aa89c91f21cfe2addfe35ba8595d628e8fe3 100644
--- a/cc/debug/frame_viewer_instrumentation.cc
+++ b/cc/debug/frame_viewer_instrumentation.cc
@@ -26,18 +26,18 @@ const char kSourceFrameNumber[] = "sourceFrameNumber";
const char kAnalyzeTask[] = "AnalyzeTask";
const char kRasterTask[] = "RasterTask";
-scoped_refptr<base::trace_event::ConvertableToTraceFormat> TileDataAsValue(
+scoped_ptr<base::trace_event::ConvertableToTraceFormat> TileDataAsValue(
const void* tile_id,
TileResolution tile_resolution,
int source_frame_number,
int layer_id) {
- scoped_refptr<base::trace_event::TracedValue> res(
+ scoped_ptr<base::trace_event::TracedValue> res(
new base::trace_event::TracedValue());
TracedValue::SetIDRef(tile_id, res.get(), kTileId);
res->SetString(kTileResolution, TileResolutionToString(tile_resolution));
res->SetInteger(kSourceFrameNumber, source_frame_number);
res->SetInteger(kLayerId, layer_id);
- return res;
+ return std::move(res);
}
} // namespace

Powered by Google App Engine
This is Rietveld 408576698