base/trace_event/winheap_dump_provider_win_unittest.cc - Issue 1717283003: tracing: Make ConvertableToTraceFormat move-only scoped_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/trace_event/winheap_dump_provider_win_unittest.cc

Issue 1717283003: tracing: Make ConvertableToTraceFormat move-only scoped_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/trace_event/winheap_dump_provider_win_unittest.cc

diff --git a/base/trace_event/winheap_dump_provider_win_unittest.cc b/base/trace_event/winheap_dump_provider_win_unittest.cc

index c74a7b7bc82d41da134f29ec1392103169bdb4b7..d7488fee457b49d5e440f58d21c8b00eddd33d05 100644

--- a/base/trace_event/winheap_dump_provider_win_unittest.cc

+++ b/base/trace_event/winheap_dump_provider_win_unittest.cc

@@ -14,7 +14,7 @@ namespace base {

namespace trace_event {

TEST(WinHeapDumpProviderTest, OnMemoryDump) {

- ProcessMemoryDump pmd(new MemoryDumpSessionState(nullptr, nullptr));

+ ProcessMemoryDump pmd(new MemoryDumpSessionState);

MemoryDumpArgs dump_args = {MemoryDumpLevelOfDetail::DETAILED};

WinHeapDumpProvider* winheap_dump_provider =

« no previous file with comments | « base/trace_event/trace_log.cc ('k') | cc/debug/benchmark_instrumentation.cc » ('j') | cc/layers/layer_impl.cc » ('J')