base/trace_event/trace_event_argument.h - Issue 1717283003: tracing: Make ConvertableToTraceFormat move-only scoped_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/trace_event/trace_event_argument.h

Issue 1717283003: tracing: Make ConvertableToTraceFormat move-only scoped_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/trace_event/trace_event_argument.h

diff --git a/base/trace_event/trace_event_argument.h b/base/trace_event/trace_event_argument.h

index a127b0d66d562909485cc95f9c5e88b3135bb577..d7064798581ad558debac3052ba88cf2f6b95021 100644

--- a/base/trace_event/trace_event_argument.h

+++ b/base/trace_event/trace_event_argument.h

@@ -26,6 +26,7 @@ class BASE_EXPORT TracedValue : public ConvertableToTraceFormat {

public:

TracedValue();

explicit TracedValue(size_t capacity);

+ ~TracedValue() override;

void EndDictionary();

void EndArray();

@@ -75,8 +76,6 @@ class BASE_EXPORT TracedValue : public ConvertableToTraceFormat {

scoped_ptr<base::Value> ToBaseValue() const;

private:

- ~TracedValue() override;

Pickle pickle_;

#ifndef NDEBUG

« no previous file with comments | « base/trace_event/trace_event_android.cc ('k') | base/trace_event/trace_event_argument_unittest.cc » ('j') | cc/layers/layer_impl.cc » ('J')