base/trace_event/memory_allocator_dump.h - Issue 1717283003: tracing: Make ConvertableToTraceFormat move-only scoped_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/trace_event/memory_allocator_dump.h

Issue 1717283003: tracing: Make ConvertableToTraceFormat move-only scoped_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « base/trace_event/heap_profiler_type_name_deduplicator_unittest.cc ('k') | base/trace_event/memory_allocator_dump_unittest.cc » ('j') | cc/layers/layer_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: base/trace_event/memory_allocator_dump.h

diff --git a/base/trace_event/memory_allocator_dump.h b/base/trace_event/memory_allocator_dump.h

index 33a15432b98bc2d7b8c0fc7889570c715433d7f0..9f91de953359baace1e9177e697c98a845fa9f0f 100644

--- a/base/trace_event/memory_allocator_dump.h

+++ b/base/trace_event/memory_allocator_dump.h

@@ -12,7 +12,7 @@

#include "base/base_export.h"

#include "base/logging.h"

#include "base/macros.h"

-#include "base/memory/ref_counted.h"

+#include "base/memory/scoped_ptr.h"

#include "base/trace_event/memory_allocator_dump_guid.h"

#include "base/values.h"

@@ -93,7 +93,7 @@ class BASE_EXPORT MemoryAllocatorDump {

private:

const std::string absolute_name_;

ProcessMemoryDump* const process_memory_dump_; // Not owned (PMD owns this).

- scoped_refptr<TracedValue> attributes_;

+ scoped_ptr<TracedValue> attributes_;

MemoryAllocatorDumpGuid guid_;

int flags_; // See enum Flags.