Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1556)

Unified Diff: base/trace_event/heap_profiler_heap_dump_writer.h

Issue 1717283003: tracing: Make ConvertableToTraceFormat move-only scoped_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/trace_event/heap_profiler_heap_dump_writer.h
diff --git a/base/trace_event/heap_profiler_heap_dump_writer.h b/base/trace_event/heap_profiler_heap_dump_writer.h
index 41f5488e35896ca31545e3bd0f4749a32a79a540..e6cf93b4ade771f6c3b3a27f595ffc6d9da16ec6 100644
--- a/base/trace_event/heap_profiler_heap_dump_writer.h
+++ b/base/trace_event/heap_profiler_heap_dump_writer.h
@@ -12,7 +12,7 @@
#include "base/base_export.h"
#include "base/containers/hash_tables.h"
#include "base/macros.h"
-#include "base/memory/ref_counted.h"
+#include "base/memory/scoped_ptr.h"
#include "base/trace_event/heap_profiler_allocation_context.h"
namespace base {
@@ -26,7 +26,7 @@ class TypeNameDeduplicator;
// a traced value with an "entries" array that can be dumped in the trace log,
// following the format described in https://goo.gl/KY7zVE. The number of
// entries is kept reasonable because long tails are not included.
-BASE_EXPORT scoped_refptr<TracedValue> ExportHeapDump(
+BASE_EXPORT scoped_ptr<TracedValue> ExportHeapDump(
const hash_map<AllocationContext, size_t>& bytes_by_context,
StackFrameDeduplicator* stack_frame_deduplicator,
TypeNameDeduplicator* type_name_deduplicator);
@@ -54,7 +54,7 @@ struct BASE_EXPORT Entry {
BASE_EXPORT bool operator<(Entry lhs, Entry rhs);
// Serializes entries to an "entries" array in a traced value.
-BASE_EXPORT scoped_refptr<TracedValue> Serialize(const std::set<Entry>& dump);
+BASE_EXPORT scoped_ptr<TracedValue> Serialize(const std::set<Entry>& dump);
// Helper class to dump a snapshot of an |AllocationRegister| or other heap
// bookkeeping structure into a |TracedValue|. This class is intended to be

Powered by Google App Engine
This is Rietveld 408576698