Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1872)

Unified Diff: base/test/test_pending_task_unittest.cc

Issue 1717283003: tracing: Make ConvertableToTraceFormat move-only scoped_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/test/test_pending_task_unittest.cc
diff --git a/base/test/test_pending_task_unittest.cc b/base/test/test_pending_task_unittest.cc
index 7623ce4a72dde59df35b38820d5f603f17bf1de4..39a6a4350a538deb79386f4c5d88352a95b7ee61 100644
--- a/base/test/test_pending_task_unittest.cc
+++ b/base/test/test_pending_task_unittest.cc
@@ -19,7 +19,9 @@ TEST(TestPendingTaskTest, TraceSupport) {
TRACE_EVENT1("test", "TestPendingTask::TraceSupport", "task", task.AsValue());
// Just a basic check that the trace output has *something* in it.
- EXPECT_THAT(task.AsValue()->ToString(), ::testing::HasSubstr("post_time"));
+ scoped_ptr<base::trace_event::ConvertableToTraceFormat> task_value(
+ task.AsValue());
+ EXPECT_THAT(task_value->ToString(), ::testing::HasSubstr("post_time"));
}
TEST(TestPendingTaskTest, ToString) {

Powered by Google App Engine
This is Rietveld 408576698