cc/layers/layer_impl.cc - Issue 1717283003: tracing: Make ConvertableToTraceFormat move-only scoped_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/layers/layer_impl.cc

Issue 1717283003: tracing: Make ConvertableToTraceFormat move-only scoped_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Petrcermak + oysteine review + LayerDebugInfo refptr wrapper Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: cc/layers/layer_impl.cc

diff --git a/cc/layers/layer_impl.cc b/cc/layers/layer_impl.cc

index aa34a8d3a715f9adaddfe1d26ed702515f60423a..9be4103277fdfcad0efb639ae7d6fbcb07ac2942 100644

--- a/cc/layers/layer_impl.cc

+++ b/cc/layers/layer_impl.cc

@@ -19,6 +19,7 @@

#include "cc/base/math_util.h"

#include "cc/base/simple_enclosed_region.h"

#include "cc/debug/debug_colors.h"

+#include "cc/debug/layer_debug_info.h"

#include "cc/debug/layer_tree_debug_state.h"

#include "cc/debug/micro_benchmark_impl.h"

#include "cc/debug/traced_value.h"

@@ -202,9 +203,8 @@ void LayerImpl::SetScrollParent(LayerImpl* parent) {

SetNeedsPushProperties();

}

-void LayerImpl::SetDebugInfo(

- scoped_refptr<base::trace_event::ConvertableToTraceFormat> other) {

- debug_info_ = other;

+void LayerImpl::SetDebugInfo(scoped_refptr<LayerDebugInfo> debug_info) {

+ debug_info_ = debug_info;

danakj 2016/02/26 22:59:38 you should move() here, don't need to hold a refer

SetNeedsPushProperties();

}

« no previous file with comments | « cc/layers/layer_impl.h ('k') | cc/output/begin_frame_args.h » ('j') | no next file with comments »