tracing: Make ConvertableToTraceFormat move-only scoped_ptr

base/trace_event/trace_event_argument_unittest.cc

Index: base/trace_event/trace_event_argument_unittest.cc
diff --git a/base/trace_event/trace_event_argument_unittest.cc b/base/trace_event/trace_event_argument_unittest.cc
index 82436ba1994de42135b9f0cb0f2df4b19c769f6f..98012f93c15d4588d892f3bba5938fea7f5aab1b 100644
--- a/base/trace_event/trace_event_argument_unittest.cc
+++ b/base/trace_event/trace_event_argument_unittest.cc
@@ -15,7 +15,7 @@ namespace base {
 namespace trace_event {
 
 TEST(TraceEventArgumentTest, FlatDictionary) {
-  scoped_refptr<TracedValue> value = new TracedValue();
+  scoped_ptr<TracedValue> value(new TracedValue());
   value->SetInteger("int", 2014);
   value->SetDouble("double", 0.0);
   value->SetBoolean("bool", true);
@@ -28,7 +28,7 @@ TEST(TraceEventArgumentTest, FlatDictionary) {
 }
 
 TEST(TraceEventArgumentTest, NoDotPathExpansion) {
-  scoped_refptr<TracedValue> value = new TracedValue();
+  scoped_ptr<TracedValue> value(new TracedValue());
   value->SetInteger("in.t", 2014);
   value->SetDouble("doub.le", 0.0);
   value->SetBoolean("bo.ol", true);
@@ -41,7 +41,7 @@ TEST(TraceEventArgumentTest, NoDotPathExpansion) {
 }
 
 TEST(TraceEventArgumentTest, Hierarchy) {
-  scoped_refptr<TracedValue> value = new TracedValue();
+  scoped_ptr<TracedValue> value(new TracedValue());
   value->SetInteger("i0", 2014);
   value->BeginDictionary("dict1");
   value->SetInteger("i1", 2014);
@@ -77,7 +77,7 @@ TEST(TraceEventArgumentTest, LongStrings) {
     kLongString3[i] = 'a' + (i % 25);
   kLongString3[sizeof(kLongString3) - 1] = '\0';
 
-  scoped_refptr<TracedValue> value = new TracedValue();
+  scoped_ptr<TracedValue> value(new TracedValue());
   value->SetString("a", "short");
   value->SetString("b", kLongString);
   value->BeginArray("c");
@@ -113,7 +113,7 @@ TEST(TraceEventArgumentTest, PassBaseValue) {
   list_value->AppendString("in_list");
   list_value->Append(std::move(dict_value));
 
-  scoped_refptr<TracedValue> value = new TracedValue();
+  scoped_ptr<TracedValue> value(new TracedValue());
   value->BeginDictionary("outer_dict");
   value->SetValue("inner_list", std::move(list_value));
   value->EndDictionary();
@@ -130,10 +130,10 @@ TEST(TraceEventArgumentTest, PassBaseValue) {
 }
 
 TEST(TraceEventArgumentTest, PassTracedValue) {
-  auto dict_value = make_scoped_refptr(new TracedValue);
+  auto dict_value = make_scoped_ptr(new TracedValue);

[oystein (OOO til 10th of July), 2016/02/26 19:46:55]

nit: inconsistent usage of 'new TracedValue' vs 'new TracedValue()' here.

[Primiano Tucci (use gerrit), 2016/02/26 22:52:50]

Fixed (even if I think is a broader problem, should do  a massive pass in
another CL to fix this)

   dict_value->SetInteger("a", 1);
 
-  auto nested_dict_value = make_scoped_refptr(new TracedValue);
+  auto nested_dict_value = make_scoped_ptr(new TracedValue);
   nested_dict_value->SetInteger("b", 2);
   nested_dict_value->BeginArray("c");
   nested_dict_value->AppendString("foo");