tracing: Make ConvertableToTraceFormat move-only scoped_ptr

cc/debug/benchmark_instrumentation.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/trace_event/trace_event.h"
 #include "cc/debug/benchmark_instrumentation.h"
 
 namespace cc {
 namespace benchmark_instrumentation {
 
 // Please do not change the trace events in this file without updating
 // tools/perf/measurements/rendering_stats.py accordingly.
 // The benchmarks search for events and their arguments by name.
 
 void IssueImplThreadRenderingStatsEvent(const RenderingStats& stats) {
   TRACE_EVENT_INSTANT1("benchmark",
                        "BenchmarkInstrumentation::ImplThreadRenderingStats",
                        TRACE_EVENT_SCOPE_THREAD,
                        "data", stats.AsTraceableData());
 }
 
 void IssueDisplayRenderingStatsEvent() {
-  scoped_refptr<base::trace_event::TracedValue> record_data =
-      new base::trace_event::TracedValue();
+  auto record_data = make_scoped_ptr(new base::trace_event::TracedValue());

[danakj, 2016/02/25 23:10:07]

current guidance is "don't spell smart pointers as auto".

we haz plans to improve that but for now spell it out please. you could write
scoped_ptr<T> value(new T); to keep it more terse while writing the type.

[Primiano Tucci (use gerrit), 2016/02/26 07:01:04]

Ok changed all the places in the CL where I did auto ... = make_scoped to be
more verbose.

FWIW btw, despite this CL the rest of the codebase seems to have plenty of auto
.* = make_scoped (I might have contributed quite to that a bit in the past :-/)

   record_data->SetInteger("frame_count", 1);
   TRACE_EVENT_INSTANT1(
-      "benchmark",
-      "BenchmarkInstrumentation::DisplayRenderingStats",
-      TRACE_EVENT_SCOPE_THREAD,
-      "data",
-      scoped_refptr<base::trace_event::ConvertableToTraceFormat>(record_data));
+      "benchmark", "BenchmarkInstrumentation::DisplayRenderingStats",
+      TRACE_EVENT_SCOPE_THREAD, "data", std::move(record_data));
 }
 
 }  // namespace benchmark_instrumentation
 }  // namespace cc