Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Side by Side Diff: cc/debug/devtools_instrumentation.h

Issue 1717283003: tracing: Make ConvertableToTraceFormat move-only scoped_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CC_DEBUG_DEVTOOLS_INSTRUMENTATION_H_ 5 #ifndef CC_DEBUG_DEVTOOLS_INSTRUMENTATION_H_
6 #define CC_DEBUG_DEVTOOLS_INSTRUMENTATION_H_ 6 #define CC_DEBUG_DEVTOOLS_INSTRUMENTATION_H_
7 7
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include "base/macros.h" 10 #include "base/macros.h"
(...skipping 129 matching lines...) Expand 10 before | Expand all | Expand 10 after
140 } 140 }
141 141
142 inline void DidRequestMainThreadFrame(int layer_tree_host_id) { 142 inline void DidRequestMainThreadFrame(int layer_tree_host_id) {
143 TRACE_EVENT_INSTANT1(internal::kCategoryFrame, 143 TRACE_EVENT_INSTANT1(internal::kCategoryFrame,
144 internal::kRequestMainThreadFrame, 144 internal::kRequestMainThreadFrame,
145 TRACE_EVENT_SCOPE_THREAD, 145 TRACE_EVENT_SCOPE_THREAD,
146 internal::kLayerTreeId, 146 internal::kLayerTreeId,
147 layer_tree_host_id); 147 layer_tree_host_id);
148 } 148 }
149 149
150 inline scoped_refptr<base::trace_event::ConvertableToTraceFormat> 150 inline scoped_ptr<base::trace_event::ConvertableToTraceFormat>
151 BeginMainThreadFrameData(int frame_id) { 151 BeginMainThreadFrameData(int frame_id) {
152 scoped_refptr<base::trace_event::TracedValue> value = 152 scoped_ptr<base::trace_event::TracedValue> value(
153 new base::trace_event::TracedValue(); 153 new base::trace_event::TracedValue());
154 value->SetInteger("frameId", frame_id); 154 value->SetInteger("frameId", frame_id);
155 return value; 155 return std::move(value);
156 } 156 }
157 157
158 inline void WillBeginMainThreadFrame(int layer_tree_host_id, int frame_id) { 158 inline void WillBeginMainThreadFrame(int layer_tree_host_id, int frame_id) {
159 TRACE_EVENT_INSTANT2( 159 TRACE_EVENT_INSTANT2(
160 internal::kCategoryFrame, internal::kBeginMainThreadFrame, 160 internal::kCategoryFrame, internal::kBeginMainThreadFrame,
161 TRACE_EVENT_SCOPE_THREAD, internal::kLayerTreeId, layer_tree_host_id, 161 TRACE_EVENT_SCOPE_THREAD, internal::kLayerTreeId, layer_tree_host_id,
162 internal::kData, BeginMainThreadFrameData(frame_id)); 162 internal::kData, BeginMainThreadFrameData(frame_id));
163 } 163 }
164 164
165 inline scoped_refptr<base::trace_event::ConvertableToTraceFormat> 165 inline scoped_ptr<base::trace_event::ConvertableToTraceFormat>
166 NeedsBeginFrameData(bool needs_begin_frame) { 166 NeedsBeginFrameData(bool needs_begin_frame) {
167 scoped_refptr<base::trace_event::TracedValue> value = 167 scoped_ptr<base::trace_event::TracedValue> value(
168 new base::trace_event::TracedValue(); 168 new base::trace_event::TracedValue());
169 value->SetInteger("needsBeginFrame", needs_begin_frame); 169 value->SetInteger("needsBeginFrame", needs_begin_frame);
170 return value; 170 return std::move(value);
171 } 171 }
172 172
173 inline void NeedsBeginFrameChanged(int layer_tree_host_id, bool new_value) { 173 inline void NeedsBeginFrameChanged(int layer_tree_host_id, bool new_value) {
174 TRACE_EVENT_INSTANT2( 174 TRACE_EVENT_INSTANT2(
175 internal::kCategoryFrame, internal::kNeedsBeginFrameChanged, 175 internal::kCategoryFrame, internal::kNeedsBeginFrameChanged,
176 TRACE_EVENT_SCOPE_THREAD, internal::kLayerTreeId, layer_tree_host_id, 176 TRACE_EVENT_SCOPE_THREAD, internal::kLayerTreeId, layer_tree_host_id,
177 internal::kData, NeedsBeginFrameData(new_value)); 177 internal::kData, NeedsBeginFrameData(new_value));
178 } 178 }
179 179
180 } // namespace devtools_instrumentation 180 } // namespace devtools_instrumentation
181 } // namespace cc 181 } // namespace cc
182 182
183 #endif // CC_DEBUG_DEVTOOLS_INSTRUMENTATION_H_ 183 #endif // CC_DEBUG_DEVTOOLS_INSTRUMENTATION_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698