tracing: Make ConvertableToTraceFormat move-only scoped_ptr

base/trace_event/heap_profiler_stack_frame_deduplicator_unittest.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <iterator>
 
 #include "base/macros.h"
-#include "base/memory/ref_counted.h"
+#include "base/memory/scoped_ptr.h"
 #include "base/trace_event/heap_profiler_allocation_context.h"
 #include "base/trace_event/heap_profiler_stack_frame_deduplicator.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace base {
 namespace trace_event {
 
 // Define all strings once, because the deduplicator requires pointer equality,
 // and string interning is unreliable.
 const char kBrowserMain[] = "BrowserMain";
 const char kRendererMain[] = "RendererMain";
 const char kCreateWidget[] = "CreateWidget";
 const char kInitialize[] = "Initialize";
 const char kMalloc[] = "malloc";
 
 TEST(StackFrameDeduplicatorTest, SingleBacktrace) {
   StackFrame bt[] = {kBrowserMain, kCreateWidget, kMalloc};
 
   // The call tree should look like this (index in brackets).
   //
   // BrowserMain [0]
   //   CreateWidget [1]
   //     malloc [2]
 
-  scoped_refptr<StackFrameDeduplicator> dedup = new StackFrameDeduplicator;
+  scoped_ptr<StackFrameDeduplicator> dedup(new StackFrameDeduplicator);
   ASSERT_EQ(2, dedup->Insert(std::begin(bt), std::end(bt)));
 
   auto iter = dedup->begin();
   ASSERT_EQ(kBrowserMain, (iter + 0)->frame);
   ASSERT_EQ(-1, (iter + 0)->parent_frame_index);
 
   ASSERT_EQ(kCreateWidget, (iter + 1)->frame);
   ASSERT_EQ(0, (iter + 1)->parent_frame_index);
 
   ASSERT_EQ(kMalloc, (iter + 2)->frame);
@@ skipping 12 matching lines @@
   // The call tree should look like this (index in brackets).
   //
   // BrowserMain [0]
   //   CreateWidget [1]
   // RendererMain [2]
   //   CreateWidget [3]
   //
   // Note that there will be two instances of CreateWidget,
   // with different parents.
 
-  scoped_refptr<StackFrameDeduplicator> dedup = new StackFrameDeduplicator;
+  scoped_ptr<StackFrameDeduplicator> dedup(new StackFrameDeduplicator);
   ASSERT_EQ(1, dedup->Insert(std::begin(bt0), std::end(bt0)));
   ASSERT_EQ(3, dedup->Insert(std::begin(bt1), std::end(bt1)));
 
   auto iter = dedup->begin();
   ASSERT_EQ(kBrowserMain, (iter + 0)->frame);
   ASSERT_EQ(-1, (iter + 0)->parent_frame_index);
 
   ASSERT_EQ(kCreateWidget, (iter + 1)->frame);
   ASSERT_EQ(0, (iter + 1)->parent_frame_index);
 
@@ skipping 11 matching lines @@
   StackFrame bt1[] = {kBrowserMain, kInitialize};
 
   // The call tree should look like this (index in brackets).
   //
   // BrowserMain [0]
   //   CreateWidget [1]
   //   Initialize [2]
   //
   // Note that BrowserMain will be re-used.
 
-  scoped_refptr<StackFrameDeduplicator> dedup = new StackFrameDeduplicator;
+  scoped_ptr<StackFrameDeduplicator> dedup(new StackFrameDeduplicator);
   ASSERT_EQ(1, dedup->Insert(std::begin(bt0), std::end(bt0)));
   ASSERT_EQ(2, dedup->Insert(std::begin(bt1), std::end(bt1)));
 
   auto iter = dedup->begin();
   ASSERT_EQ(kBrowserMain, (iter + 0)->frame);
   ASSERT_EQ(-1, (iter + 0)->parent_frame_index);
 
   ASSERT_EQ(kCreateWidget, (iter + 1)->frame);
   ASSERT_EQ(0, (iter + 1)->parent_frame_index);
 
   ASSERT_EQ(kInitialize, (iter + 2)->frame);
   ASSERT_EQ(0, (iter + 2)->parent_frame_index);
 
   ASSERT_EQ(iter + 3, dedup->end());
 
   // Inserting the same backtrace again should return the index of the existing
   // node.
   ASSERT_EQ(1, dedup->Insert(std::begin(bt0), std::end(bt0)));
   ASSERT_EQ(2, dedup->Insert(std::begin(bt1), std::end(bt1)));
   ASSERT_EQ(dedup->begin() + 3, dedup->end());
 }
 
 TEST(StackFrameDeduplicatorTest, NullPaddingIsRemoved) {
   StackFrame bt0[] = {kBrowserMain, nullptr, nullptr, nullptr};
 
-  scoped_refptr<StackFrameDeduplicator> dedup = new StackFrameDeduplicator;
+  scoped_ptr<StackFrameDeduplicator> dedup(new StackFrameDeduplicator);
 
   // There are four frames in the backtrace, but the null pointers should be
   // skipped, so only one frame is inserted, which will have index 0.
   ASSERT_EQ(4u, arraysize(bt0));
   ASSERT_EQ(0, dedup->Insert(std::begin(bt0), std::end(bt0)));
   ASSERT_EQ(dedup->begin() + 1, dedup->end());
 }
 
 }  // namespace trace_event
 }  // namespace base