Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1717263002: [Smart Lock, UI] Fix title for federated credentials. (Closed)

Created:
4 years, 10 months ago by melandory
Modified:
4 years, 10 months ago
Reviewers:
vasilii
CC:
chromium-reviews, gcasto+watchlist_chromium.org, vabr+watchlistpasswordmanager_chromium.org, mkwst+watchlist-passwords_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Smart Lock, UI] Fix title for federated credentials. BUG=542138 Committed: https://crrev.com/9eb8628f36b65e040270529120d84111ff450fe1 Cr-Commit-Position: refs/heads/master@{#377029}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/password_manager/save_password_infobar_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
melandory
PTAL, thanks!
4 years, 10 months ago (2016-02-22 10:27:12 UTC) #2
vasilii
lgtm The previous code was strange.
4 years, 10 months ago (2016-02-22 10:36:04 UTC) #3
melandory
On 2016/02/22 10:36:04, vasilii wrote: > lgtm > > The previous code was strange. Yep, ...
4 years, 10 months ago (2016-02-22 10:56:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1717263002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1717263002/1
4 years, 10 months ago (2016-02-23 16:33:28 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-23 18:53:41 UTC) #7
commit-bot: I haz the power
4 years, 10 months ago (2016-02-23 18:55:59 UTC) #9
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/9eb8628f36b65e040270529120d84111ff450fe1
Cr-Commit-Position: refs/heads/master@{#377029}

Powered by Google App Engine
This is Rietveld 408576698