add new copyTo version to SkBitmap, which takes SkColorType

add new copyTo version to SkBitmap, which takes SkColorType

BUG=skia:

Committed: http://code.google.com/p/skia/source/detail?r=13553

[scroggo, 2014-02-20 22:14:42]

lgtm

https://codereview.chromium.org/171723007/diff/1/gm/bitmapcopy.cpp
File gm/bitmapcopy.cpp (right):

https://codereview.chromium.org/171723007/diff/1/gm/bitmapcopy.cpp#newcode18
gm/bitmapcopy.cpp:18: "8888",
nit: different name for non-native 8888?

https://codereview.chromium.org/171723007/diff/1/src/core/SkBitmap.cpp
File src/core/SkBitmap.cpp (right):

https://codereview.chromium.org/171723007/diff/1/src/core/SkBitmap.cpp#newcod...
src/core/SkBitmap.cpp:1072: ctable.reset(new
SkColorTable(*src->getColorTable()));
nit: SkNEW_ARGS.

I know the old code did the same thing, but if src is Index8, should we just ref
its color table?

https://codereview.chromium.org/171723007/diff/1/src/images/SkDecodingImageGe...
File src/images/SkDecodingImageGenerator.cpp (right):

https://codereview.chromium.org/171723007/diff/1/src/images/SkDecodingImageGe...
src/images/SkDecodingImageGenerator.cpp:53: // a bitmap described fInfo and
fRowBytes
described by*

[reed1, 2014-02-21 19:17:53]

https://codereview.chromium.org/171723007/diff/1/gm/bitmapcopy.cpp
File gm/bitmapcopy.cpp (right):

https://codereview.chromium.org/171723007/diff/1/gm/bitmapcopy.cpp#newcode18
gm/bitmapcopy.cpp:18: "8888",
On 2014/02/20 22:14:43, scroggo wrote:
> nit: different name for non-native 8888?

Done.

https://codereview.chromium.org/171723007/diff/1/src/core/SkBitmap.cpp
File src/core/SkBitmap.cpp (right):

https://codereview.chromium.org/171723007/diff/1/src/core/SkBitmap.cpp#newcod...
src/core/SkBitmap.cpp:1072: ctable.reset(new
SkColorTable(*src->getColorTable()));
On 2014/02/20 22:14:43, scroggo wrote:
> nit: SkNEW_ARGS.
> 
> I know the old code did the same thing, but if src is Index8, should we just
ref
> its color table?

Are we convinced ctables are thread-safe-immutable? I'll file a bug to
circle-back on this suggestion.

https://codereview.chromium.org/171723007/diff/1/src/core/SkBitmap.cpp#newcod...
src/core/SkBitmap.cpp:1072: ctable.reset(new
SkColorTable(*src->getColorTable()));
On 2014/02/20 22:14:43, scroggo wrote:
> nit: SkNEW_ARGS.

Done.

> I know the old code did the same thing, but if src is Index8, should we just
ref
> its color table?

https://codereview.chromium.org/171723007/diff/1/src/images/SkDecodingImageGe...
File src/images/SkDecodingImageGenerator.cpp (right):

https://codereview.chromium.org/171723007/diff/1/src/images/SkDecodingImageGe...
src/images/SkDecodingImageGenerator.cpp:53: // a bitmap described fInfo and
fRowBytes
On 2014/02/20 22:14:43, scroggo wrote:
> described by*

Done.

[reed1, 2014-02-21 19:18:01]

The CQ bit was checked by reed@google.com

[commit-bot: I haz the power, 2014-02-21 19:18:02]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/reed@google.com/171723007/250001

[reed1, 2014-02-21 20:51:17]

The CQ bit was checked by reed@google.com

[commit-bot: I haz the power, 2014-02-21 20:51:28]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/reed@google.com/171723007/330001

[Sergey Berezin, 2014-02-22 01:48:15]

On 2014/02/21 20:51:28, I haz the power (commit-bot) wrote:
> CQ is trying da patch. Follow status at
> https://skia-tree-status.appspot.com/cq/reed%40google.com/171723007/330001

FYI, this CL seems to be stuck in CQ, we are investigating the reasons, but
there is no ETA. You may consider landing this change manually.

[commit-bot: I haz the power, 2014-02-23 03:59:08]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/reed@google.com/171723007/330001

[commit-bot: I haz the power, 2014-02-23 03:59:44]

Change committed as 13553