[MD History] Extract shared stylesheet.

[MD History] Extract shared stylesheet.

This CL extracts a shared stylesheet for the MD History elements so that
CSS styles and variables can be reused between elements.

Some errant styles are also cleaned up.

BUG=425625
Committed: https://crrev.com/36873d6892fb8ca9578c7627f100dae46b25733d
Cr-Commit-Position: refs/heads/master@{#377169}

[calamity, 2016-02-23 02:47:29]

Description was changed from

==========
[MD History] Extract shared stylesheet.

This CL extracts a shared stylesheet for the MD History elements so that
CSS styles and variables can be reused between elements.

BUG=425625
==========

to

==========
[MD History] Extract shared stylesheet.

This CL extracts a shared stylesheet for the MD History elements so that
CSS styles and variables can be reused between elements.

Some errant styles are also cleaned up.

BUG=425625
==========

[calamity, 2016-02-23 02:48:06]

calamity@chromium.org changed reviewers:
+ tsergeant@chromium.org

[tsergeant, 2016-02-23 04:52:26]

lgtm

https://codereview.chromium.org/1717213003/diff/1/chrome/browser/resources/md...
File chrome/browser/resources/md_history/history_item.html (right):

https://codereview.chromium.org/1717213003/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_history/history_item.html:11: <link rel="import"
href="chrome://history/shared_style.html">
Nit: Move the blank line from before this line to after this line so the spacing
doesn't change.

https://codereview.chromium.org/1717213003/diff/1/chrome/browser/resources/md...
File chrome/browser/resources/md_history/history_toolbar.html (right):

https://codereview.chromium.org/1717213003/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_history/history_toolbar.html:7: <link rel="import"
href="chrome://history/shared_style.html">
Same here.

https://codereview.chromium.org/1717213003/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_history/history_toolbar.html:57: flex: 0 1
var(--card-max-width);
Huh, I'm kinda surprised this works.

[calamity, 2016-02-23 05:33:42]

calamity@chromium.org changed reviewers:
+ dbeam@chromium.org

[calamity, 2016-02-23 05:33:43]

+dbeam for chrome/browser/browser_resources.grd

https://codereview.chromium.org/1717213003/diff/1/chrome/browser/resources/md...
File chrome/browser/resources/md_history/history_item.html (right):

https://codereview.chromium.org/1717213003/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_history/history_item.html:11: <link rel="import"
href="chrome://history/shared_style.html">
On 2016/02/23 04:52:26, tsergeant wrote:
> Nit: Move the blank line from before this line to after this line so the
spacing
> doesn't change.

Done.

https://codereview.chromium.org/1717213003/diff/1/chrome/browser/resources/md...
File chrome/browser/resources/md_history/history_toolbar.html (right):

https://codereview.chromium.org/1717213003/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_history/history_toolbar.html:7: <link rel="import"
href="chrome://history/shared_style.html">
On 2016/02/23 04:52:26, tsergeant wrote:
> Same here.

Done.

https://codereview.chromium.org/1717213003/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_history/history_toolbar.html:57: flex: 0 1
var(--card-max-width);
On 2016/02/23 04:52:26, tsergeant wrote:
> Huh, I'm kinda surprised this works.

Acknowledged.

[Dan Beam, 2016-02-23 18:32:03]

lgtm

https://codereview.chromium.org/1717213003/diff/1/chrome/browser/resources/md...
File chrome/browser/resources/md_history/history_toolbar.html (right):

https://codereview.chromium.org/1717213003/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_history/history_toolbar.html:57: flex: 0 1
var(--card-max-width);
On 2016/02/23 04:52:26, tsergeant wrote:
> Huh, I'm kinda surprised this works.

why are you surprised by this working?

[tsergeant, 2016-02-23 22:35:14]

https://codereview.chromium.org/1717213003/diff/1/chrome/browser/resources/md...
File chrome/browser/resources/md_history/history_toolbar.html (right):

https://codereview.chromium.org/1717213003/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_history/history_toolbar.html:57: flex: 0 1
var(--card-max-width);
On 2016/02/23 18:32:03, Dan Beam wrote:
> On 2016/02/23 04:52:26, tsergeant wrote:
> > Huh, I'm kinda surprised this works.
> 
> why are you surprised by this working?

I expected that the variables polyfill would only replace entire property
values, not individual sections of shorthand properties like this.

[calamity, 2016-02-24 00:10:07]

The CQ bit was checked by calamity@chromium.org

[calamity, 2016-02-24 00:10:07]

The patchset sent to the CQ was uploaded after l-g-t-m from
tsergeant@chromium.org
Link to the patchset: https://codereview.chromium.org/1717213003/#ps20001
(title: "fix nits")

[commit-bot: I haz the power, 2016-02-24 00:11:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1717213003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1717213003/20001

[commit-bot: I haz the power, 2016-02-24 01:19:10]

Description was changed from

==========
[MD History] Extract shared stylesheet.

This CL extracts a shared stylesheet for the MD History elements so that
CSS styles and variables can be reused between elements.

Some errant styles are also cleaned up.

BUG=425625
==========

to

==========
[MD History] Extract shared stylesheet.

This CL extracts a shared stylesheet for the MD History elements so that
CSS styles and variables can be reused between elements.

Some errant styles are also cleaned up.

BUG=425625
==========

[commit-bot: I haz the power, 2016-02-24 01:19:11]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-02-24 01:21:38]

Description was changed from

==========
[MD History] Extract shared stylesheet.

This CL extracts a shared stylesheet for the MD History elements so that
CSS styles and variables can be reused between elements.

Some errant styles are also cleaned up.

BUG=425625
==========

to

==========
[MD History] Extract shared stylesheet.

This CL extracts a shared stylesheet for the MD History elements so that
CSS styles and variables can be reused between elements.

Some errant styles are also cleaned up.

BUG=425625

Committed: https://crrev.com/36873d6892fb8ca9578c7627f100dae46b25733d
Cr-Commit-Position: refs/heads/master@{#377169}
==========

[commit-bot: I haz the power, 2016-02-24 01:21:40]

Patchset 2 (id:??) landed as
https://crrev.com/36873d6892fb8ca9578c7627f100dae46b25733d
Cr-Commit-Position: refs/heads/master@{#377169}