Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issue 1717213003: [MD History] Extract shared stylesheet. (Closed)

Created:
4 years, 10 months ago by calamity
Modified:
4 years, 10 months ago
Reviewers:
tsergeant, Dan Beam
CC:
chromium-reviews, arv+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD History] Extract shared stylesheet. This CL extracts a shared stylesheet for the MD History elements so that CSS styles and variables can be reused between elements. Some errant styles are also cleaned up. BUG=425625 Committed: https://crrev.com/36873d6892fb8ca9578c7627f100dae46b25733d Cr-Commit-Position: refs/heads/master@{#377169}

Patch Set 1 #

Total comments: 8

Patch Set 2 : fix nits #

Messages

Total messages: 15 (7 generated)
calamity
4 years, 10 months ago (2016-02-23 02:48:06 UTC) #3
tsergeant
lgtm https://codereview.chromium.org/1717213003/diff/1/chrome/browser/resources/md_history/history_item.html File chrome/browser/resources/md_history/history_item.html (right): https://codereview.chromium.org/1717213003/diff/1/chrome/browser/resources/md_history/history_item.html#newcode11 chrome/browser/resources/md_history/history_item.html:11: <link rel="import" href="chrome://history/shared_style.html"> Nit: Move the blank line ...
4 years, 10 months ago (2016-02-23 04:52:26 UTC) #4
calamity
+dbeam for chrome/browser/browser_resources.grd https://codereview.chromium.org/1717213003/diff/1/chrome/browser/resources/md_history/history_item.html File chrome/browser/resources/md_history/history_item.html (right): https://codereview.chromium.org/1717213003/diff/1/chrome/browser/resources/md_history/history_item.html#newcode11 chrome/browser/resources/md_history/history_item.html:11: <link rel="import" href="chrome://history/shared_style.html"> On 2016/02/23 04:52:26, ...
4 years, 10 months ago (2016-02-23 05:33:43 UTC) #6
Dan Beam
lgtm https://codereview.chromium.org/1717213003/diff/1/chrome/browser/resources/md_history/history_toolbar.html File chrome/browser/resources/md_history/history_toolbar.html (right): https://codereview.chromium.org/1717213003/diff/1/chrome/browser/resources/md_history/history_toolbar.html#newcode57 chrome/browser/resources/md_history/history_toolbar.html:57: flex: 0 1 var(--card-max-width); On 2016/02/23 04:52:26, tsergeant ...
4 years, 10 months ago (2016-02-23 18:32:03 UTC) #7
tsergeant
https://codereview.chromium.org/1717213003/diff/1/chrome/browser/resources/md_history/history_toolbar.html File chrome/browser/resources/md_history/history_toolbar.html (right): https://codereview.chromium.org/1717213003/diff/1/chrome/browser/resources/md_history/history_toolbar.html#newcode57 chrome/browser/resources/md_history/history_toolbar.html:57: flex: 0 1 var(--card-max-width); On 2016/02/23 18:32:03, Dan Beam ...
4 years, 10 months ago (2016-02-23 22:35:14 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1717213003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1717213003/20001
4 years, 10 months ago (2016-02-24 00:11:27 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-24 01:19:11 UTC) #13
commit-bot: I haz the power
4 years, 10 months ago (2016-02-24 01:21:40 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/36873d6892fb8ca9578c7627f100dae46b25733d
Cr-Commit-Position: refs/heads/master@{#377169}

Powered by Google App Engine
This is Rietveld 408576698