Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 1717203002: X87: [stubs] Introduce a dedicated FastNewObjectStub. (Closed)

Created:
4 years, 10 months ago by zhengxing.li
Modified:
4 years, 10 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [stubs] Introduce a dedicated FastNewObjectStub. port ba2077aac3a775523ca3fc9600fcf76f55e8d1c2 (r34136) original commit message: Move the already existing fast case for %NewObject into a dedicated FastNewObjectStub that we can utilize in places where we would otherwise fallback to %NewObject immediately, which is rather expensive. Also use FastNewObjectStub as the generic implementation of JSCreate, which should make constructor inlining based on SharedFunctionInfo (w/o specializing to a concrete closure) viable soon. BUG= Committed: https://crrev.com/4453164df714afa6fbb7cf75aefe8e02566984ff Cr-Commit-Position: refs/heads/master@{#34182}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+173 lines, -147 lines) Patch
M src/x87/builtins-x87.cc View 3 chunks +17 lines, -147 lines 0 comments Download
M src/x87/code-stubs-x87.cc View 1 chunk +136 lines, -0 lines 0 comments Download
M src/x87/interface-descriptors-x87.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M src/x87/macro-assembler-x87.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/x87/macro-assembler-x87.cc View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
PTAL, thanks!
4 years, 10 months ago (2016-02-22 01:57:12 UTC) #2
Weiliang
lgtm
4 years, 10 months ago (2016-02-22 02:23:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1717203002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1717203002/1
4 years, 10 months ago (2016-02-22 02:25:27 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-22 02:47:13 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-22 02:47:24 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4453164df714afa6fbb7cf75aefe8e02566984ff
Cr-Commit-Position: refs/heads/master@{#34182}

Powered by Google App Engine
This is Rietveld 408576698