Revert of Convert Google Now's Authentication Manager to use Promises (https://codereview.chromium.…

trunk/src/chrome/browser/resources/google_now/utility.js

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 'use strict';
 
 /**
  * @fileoverview Utility objects and functions for Google Now extension.
  * Most important entities here:
  * (1) 'wrapper' is a module used to add error handling and other services to
@@ skipping 419 matching lines @@
 })();
 
 wrapper.instrumentChromeApiFunction('alarms.get', 1);
 wrapper.instrumentChromeApiFunction('alarms.onAlarm.addListener', 0);
 wrapper.instrumentChromeApiFunction('identity.getAuthToken', 1);
 wrapper.instrumentChromeApiFunction('identity.onSignInChanged.addListener', 0);
 wrapper.instrumentChromeApiFunction('identity.removeCachedAuthToken', 1);
 wrapper.instrumentChromeApiFunction('webstorePrivate.getBrowserLogin', 0);
 
 /**
- * Add task tracking support to Promise.then.
+ * Add task tracking support to Promises.
  * @override
  */
 Promise.prototype.then = function() {
   var originalThen = Promise.prototype.then;
   return function(callback) {
-    return originalThen.call(this, wrapper.wrapCallback(callback, false));
-  }
-}();
-
-/**
- * Add task tracking support to Promise.catch.
- * @override
- */
-Promise.prototype.catch = function() {
-  var originalCatch = Promise.prototype.catch;
-  return function(callback) {
-    return originalCatch.call(this, wrapper.wrapCallback(callback, false));
+    originalThen.call(this, wrapper.wrapCallback(callback, false));
   }
 }();
 
 /**
  * Builds the object to manage tasks (mutually exclusive chains of events).
  * @param {function(string, string): boolean} areConflicting Function that
  *     checks if a new task can't be added to a task queue that contains an
  *     existing task.
  * @return {Object} Task manager interface.
  */
@@ skipping 262 matching lines @@
 /**
  * Wraps chrome.identity to provide limited listening support for
  * the sign in state by polling periodically for the auth token.
  * @return {Object} The Authentication Manager interface.
  */
 function buildAuthenticationManager() {
   var alarmName = 'sign-in-alarm';
 
   /**
    * Gets an OAuth2 access token.
-   * @return {Promise} A promise to get the authentication token. If there is
-   *     no token, the request is rejected.
+   * @param {function(string=)} callback Called on completion.
+   *     The string contains the token. It's undefined if there was an error.
    */
-  function getAuthToken() {
-    return new Promise(function(resolve, reject) {
-      instrumented.identity.getAuthToken({interactive: false}, function(token) {
-        if (chrome.runtime.lastError || !token) {
-          reject();
-        } else {
-          resolve(token);
-        }
-      });
+  function getAuthToken(callback) {
+    instrumented.identity.getAuthToken({interactive: false}, function(token) {
+      token = chrome.runtime.lastError ? undefined : token;
+      callback(token);
     });
   }
 
   /**
    * Determines whether there is an account attached to the profile.
-   * @return {Promise} A promise to determine if there is an account attached
-   *     to the profile.
+   * @param {function(boolean)} callback Called on completion.
    */
-  function isSignedIn() {
-    return new Promise(function(resolve) {
-      instrumented.webstorePrivate.getBrowserLogin(function(accountInfo) {
-        resolve(!!accountInfo.login);
-      });
+  function isSignedIn(callback) {
+    instrumented.webstorePrivate.getBrowserLogin(function(accountInfo) {
+      callback(!!accountInfo.login);
     });
   }
 
   /**
    * Removes the specified cached token.
    * @param {string} token Authentication Token to remove from the cache.
-   * @return {Promise} A promise that resolves on completion.
+   * @param {function()} callback Called on completion.
    */
-  function removeToken(token) {
-    return new Promise(function(resolve) {
-      instrumented.identity.removeCachedAuthToken({token: token}, function() {
-        // Let Chrome know about a possible problem with the token.
-        getAuthToken();
-        resolve();
-      });
+  function removeToken(token, callback) {
+    instrumented.identity.removeCachedAuthToken({token: token}, function() {
+      // Let Chrome now about a possible problem with the token.
+      getAuthToken(function() {});
+      callback();
     });
   }
 
   var listeners = [];
 
   /**
    * Registers a listener that gets called back when the signed in state
    * is found to be changed.
    * @param {function()} callback Called when the answer to isSignedIn changes.
    */
   function addListener(callback) {
     listeners.push(callback);
   }
 
   /**
    * Checks if the last signed in state matches the current one.
    * If it doesn't, it notifies the listeners of the change.
    */
   function checkAndNotifyListeners() {
-    isSignedIn().then(function(signedIn) {
+    isSignedIn(function(signedIn) {
       instrumented.storage.local.get('lastSignedInState', function(items) {
         items = items || {};
         if (items.lastSignedInState != signedIn) {
           chrome.storage.local.set(
               {lastSignedInState: signedIn});
           listeners.forEach(function(callback) {
             callback();
           });
         }
       });
@@ skipping 13 matching lines @@
   // One hour is just an arbitrary amount of time chosen.
   chrome.alarms.create(alarmName, {periodInMinutes: 60});
 
   return {
     addListener: addListener,
     getAuthToken: getAuthToken,
     isSignedIn: isSignedIn,
     removeToken: removeToken
   };
 }