Issue 171713007: Revert of Convert Google Now's Authentication Manager to use Promises (https://codereview.chromium.…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 171713007: Revert of Convert Google Now's Authentication Manager to use Promises (https://codereview.chromium.… (Closed)

Created:
6 years, 10 months ago by robliao

Modified:
6 years, 10 months ago

Reviewers:
robliao

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

Revert of Convert Google Now's Authentication Manager to use Promises (https://codereview.chromium.org/162273002/) Reason for revert: Promise.catch may not always be called back, breaking an assumption about the task tracking system. Original issue's description: > Convert Google Now's Authentication Manager to use Promises > > BUG=164227 > R=rgustafson@chromium.org, skare@chromium.org, vadimt@chromium.org > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252109 TBR=skare@chromium.org,rgustafson@chromium.org,vadimt@chromium.org NOTREECHECKS=true NOTRY=true BUG=164227 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252134

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+56 lines, -79 lines)			Patch
M	trunk/src/chrome/browser/resources/google_now/background.js	View	5 chunks	+20 lines, -5 lines	0 comments	Download
M	trunk/src/chrome/browser/resources/google_now/background_unittest.gtestjs	View	4 chunks	+14 lines, -12 lines	0 comments	Download
M	trunk/src/chrome/browser/resources/google_now/common_test_util.js	View	1 chunk	+3 lines, -22 lines	0 comments	Download
M	trunk/src/chrome/browser/resources/google_now/utility.js	View	3 chunks	+19 lines, -40 lines	0 comments	Download

Total messages: 2 (0 generated)

robliao

6 years, 10 months ago (2014-02-20 00:24:39 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r252134 (tree was closed).