chromeos/network/client_cert_util.h - Issue 1717123002: Allow ${CERT_SAN_EMAIL} and ${CERT_SAN_UPN} in the ONC Identity field

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromeos/network/client_cert_util.h

Issue 1717123002: Allow ${CERT_SAN_EMAIL} and ${CERT_SAN_UPN} in the ONC Identity field (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: change to use new GetSubjectAltNameByType() name Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chromeos/network/client_cert_resolver_unittest.cc ('K') | « chromeos/network/client_cert_resolver_unittest.cc ('k') | chromeos/network/client_cert_util.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chromeos/network/client_cert_util.h

diff --git a/chromeos/network/client_cert_util.h b/chromeos/network/client_cert_util.h

index c1fd42bb599cf2116dff3097febdf0cb73f3c20b..6b4141343bff42a7d6fe72a6a79c9a3c980fd2bf 100644

--- a/chromeos/network/client_cert_util.h

+++ b/chromeos/network/client_cert_util.h

@@ -46,6 +46,9 @@ struct CHROMEOS_EXPORT ClientCertConfig {

// If |client_cert_type| equals kPattern, this contains the pattern.

CertificatePattern pattern;

+ // The value of kIdentity, to enable substitutions.

Ryan Sleevi 2016/02/29 23:51:51 This documentation is entirely unclear. I'm not ev

+ std::string policy_identity;

};

// Returns true only if any fields set in this pattern match exactly with

« chromeos/network/client_cert_resolver_unittest.cc ('K') | « chromeos/network/client_cert_resolver_unittest.cc ('k') | chromeos/network/client_cert_util.cc » ('j') | no next file with comments »