Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(485)

Issue 1717053002: Don't try to find a slot in a v0 shadow tree. (Closed)

Created:
4 years, 10 months ago by rune
Modified:
4 years, 10 months ago
Reviewers:
hayato, kochi
CC:
chromium-reviews, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't try to find a slot in a v0 shadow tree. ElementShadow::assignedSlotFor asserts that it's only called for V1 ElementShadows and doesn't null check m_slotAssignment. Guard with an if-check for V1 when assignedSlotFor from Node::assignedSlot like we already do from Node::assignedSlotForBinding. R=hayato@chromium.org,kochi@chromium.org BUG=588209 Committed: https://crrev.com/d20f8d9a716b2f64a0f53f7be939d7ab68768ac7 Cr-Commit-Position: refs/heads/master@{#376699}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -2 lines) Patch
A third_party/WebKit/LayoutTests/fast/dom/shadow/slotted-pseudo-element-in-v0-tree-crash.html View 1 chunk +14 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/dom/shadow/slotted-pseudo-element-in-v0-tree-crash-expected.txt View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Node.cpp View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
rune
ptal
4 years, 10 months ago (2016-02-20 01:14:17 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1717053002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1717053002/1
4 years, 10 months ago (2016-02-20 01:17:13 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-20 02:37:44 UTC) #5
kochi
lgtm
4 years, 10 months ago (2016-02-22 05:26:59 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1717053002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1717053002/1
4 years, 10 months ago (2016-02-22 06:05:59 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-22 07:29:55 UTC) #9
commit-bot: I haz the power
4 years, 10 months ago (2016-02-22 07:31:18 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d20f8d9a716b2f64a0f53f7be939d7ab68768ac7
Cr-Commit-Position: refs/heads/master@{#376699}

Powered by Google App Engine
This is Rietveld 408576698