NaCl SDK: Remove unsupported dev headers.

NaCl SDK: Remove unsupported dev headers.

We shouldn't provide NaCl SDK headers for interfaces which are not available in
NaCl. This change removes PPB_ interfaces that are not built on OS_NACL in
ppapi/thunk/interfaces_ppb_public_dev.h

BUG=280338
R=binji@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252238

[binji, 2014-02-19 19:30:41]

lgtm

https://codereview.chromium.org/171703003/diff/1/native_client_sdk/src/librar...
File native_client_sdk/src/libraries/ppapi/library.dsc (left):

https://codereview.chromium.org/171703003/diff/1/native_client_sdk/src/librar...
native_client_sdk/src/libraries/ppapi/library.dsc:131:
'ppp_video_capture_dev.h',
do we want to remove the plugin side dev interfaces too?

https://codereview.chromium.org/171703003/diff/1/native_client_sdk/src/librar...
File native_client_sdk/src/libraries/ppapi_cpp/library.dsc (right):

https://codereview.chromium.org/171703003/diff/1/native_client_sdk/src/librar...
native_client_sdk/src/libraries/ppapi_cpp/library.dsc:65: 'alarms_dev.cc',
While you're here, can you alphabetize this?

[teravest, 2014-02-19 20:21:00]

On Wed, Feb 19, 2014 at 12:30 PM,  <binji@chromium.org> wrote:
> lgtm
>
>
>
https://codereview.chromium.org/171703003/diff/1/native_client_sdk/src/librar...
> File native_client_sdk/src/libraries/ppapi/library.dsc (left):
>
>
https://codereview.chromium.org/171703003/diff/1/native_client_sdk/src/librar...
> native_client_sdk/src/libraries/ppapi/library.dsc:131:
> 'ppp_video_capture_dev.h',
> do we want to remove the plugin side dev interfaces too?

I'll do that in another pass.

>
>
https://codereview.chromium.org/171703003/diff/1/native_client_sdk/src/librar...
> File native_client_sdk/src/libraries/ppapi_cpp/library.dsc (right):
>
>
https://codereview.chromium.org/171703003/diff/1/native_client_sdk/src/librar...
> native_client_sdk/src/libraries/ppapi_cpp/library.dsc:65:
> 'alarms_dev.cc',
> While you're here, can you alphabetize this?

Done.

>
> https://codereview.chromium.org/171703003/

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[teravest, 2014-02-19 20:21:07]

The CQ bit was checked by teravest@chromium.org

[commit-bot: I haz the power, 2014-02-19 20:26:29]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/teravest@chromium.org/171703003/60001

[commit-bot: I haz the power, 2014-02-20 00:23:33]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/teravest@chromium.org/171703003/60001

[commit-bot: I haz the power, 2014-02-20 03:07:49]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/teravest@chromium.org/171703003/60001

[commit-bot: I haz the power, 2014-02-20 05:23:32]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/teravest@chromium.org/171703003/60001

[commit-bot: I haz the power, 2014-02-20 09:25:30]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/teravest@chromium.org/171703003/60001

[commit-bot: I haz the power, 2014-02-20 12:38:43]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/teravest@chromium.org/171703003/60001

[teravest, 2014-02-20 15:38:42]

Committed patchset #2 manually as r252238 (presubmit successful).