Issue 1717003002: [fusl] Don't syscall(SYS_ioctl, ...) in stdio

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1717003002: [fusl] Don't syscall(SYS_ioctl, ...) in stdio (Closed)

Created:
4 years, 10 months ago by kulakowski

Modified:
4 years, 10 months ago

Reviewers:
viettrungluu

CC:
mojo-reviews_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

[fusl] Don't syscall(SYS_ioctl, ...) in stdio This previously inlined the definition of isatty, which asks for the window size via an ioctl call. Instead, use isatty. R=viettrungluu@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/872e67ca44f928f712d32aaeca991f2b7ff7a741

Created: 4 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -6 lines)			Patch
	M	fusl/src/stdio/__fdopen.c	View		2 chunks	+2 lines, -3 lines	0 comments	Download
	M	fusl/src/stdio/__stdout_write.c	View		1 chunk	+2 lines, -3 lines	0 comments	Download

Total messages: 4 (1 generated)

kulakowski

4 years, 10 months ago (2016-02-20 00:00:38 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
872e67ca44f928f712d32aaeca991f2b7ff7a741 (presubmit successful).