Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(524)

Issue 1716913002: Add fail check for GetKeyboardState() in Windows KeyMap (Closed)

Created:
4 years, 10 months ago by chongz
Modified:
4 years, 10 months ago
Reviewers:
dtapuska, Wez, brucedawson
CC:
chromium-reviews, tdresser+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add fail check for GetKeyboardState() in Windows KeyMap Stop updating layout if GetKeyboardState() failed. Will keep trying for each keypress. BUG=564678, 427616 Committed: https://crrev.com/ba05491d467bca3c53ab9ad74001a6bfbc799d6c Cr-Commit-Position: refs/heads/master@{#376551}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M ui/events/keycodes/platform_key_map_win.cc View 2 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
chongz
Hi brucedawson, can you take a look at this CL please? This is fixing the ...
4 years, 10 months ago (2016-02-19 20:53:50 UTC) #2
brucedawson
I added the generic /analyze tracking bug (427616) to the description. lgtm
4 years, 10 months ago (2016-02-19 21:33:27 UTC) #4
chongz
Hi Wez, this CL will fix the issue mentioned in http://crrev.com/1585193002 PTAL, thanks!
4 years, 10 months ago (2016-02-19 21:35:57 UTC) #6
Wez
lgtm
4 years, 10 months ago (2016-02-19 21:38:33 UTC) #7
Wez
lgtm
4 years, 10 months ago (2016-02-19 21:38:37 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1716913002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1716913002/1
4 years, 10 months ago (2016-02-19 21:40:11 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-19 22:22:56 UTC) #12
commit-bot: I haz the power
4 years, 10 months ago (2016-02-19 22:23:53 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ba05491d467bca3c53ab9ad74001a6bfbc799d6c
Cr-Commit-Position: refs/heads/master@{#376551}

Powered by Google App Engine
This is Rietveld 408576698