Chromium Code Reviews| Index: build/android/pylib/local/device/local_device_gtest_run.py |
| diff --git a/build/android/pylib/local/device/local_device_gtest_run.py b/build/android/pylib/local/device/local_device_gtest_run.py |
| index e740f564a23cdb8cb8c52aac216b99421a1d977d..b494b8d0317afe512dbb9ed8a0e6fe27cf2487cc 100644 |
| --- a/build/android/pylib/local/device/local_device_gtest_run.py |
| +++ b/build/android/pylib/local/device/local_device_gtest_run.py |
| @@ -315,8 +315,11 @@ class LocalDeviceGtestRun(local_device_test_run.LocalDeviceTestRun): |
| # Query all devices in case one fails. |
| test_lists = self._env.parallel_devices.pMap(list_tests).pGet(None) |
| - # TODO(agrieve): Make this fail rather than return an empty list when |
| - # all devices fail. |
| + |
| + # If all devices failed to s/list_tests/list tests, raise an exception. |
|
mikecase (-- gone --)
2016/02/25 16:43:44
In my previous comment (I probably wrote it incorr
BigBossZhiling
2016/02/25 18:10:13
Done.
|
| + if all([tl is None for tl in test_lists]): |
| + raise device_errors.CommandFailedError( |
| + 'Failed to list tests on any device') |
| return list(sorted(set().union(*[set(tl) for tl in test_lists if tl]))) |
| #override |