Raise exception when all devices fail to list tests.

build/android/pylib/local/device/local_device_gtest_run.py

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import collections
 import itertools
 import os
 import posixpath
 
 from devil.android import device_errors
@@ skipping 297 matching lines @@
         on_failure=self._env.BlacklistDevice)
     def list_tests(dev):
       tests = self._delegate.Run(
           None, dev, flags='--gtest_list_tests', timeout=20)
       tests = gtest_test_instance.ParseGTestListTests(tests)
       tests = self._test_instance.FilterTests(tests)
       return tests
 
     # Query all devices in case one fails.
     test_lists = self._env.parallel_devices.pMap(list_tests).pGet(None)
+
+    # If all devices failed to list_tests, raise an exception.
+    check_one_device_failed = lambda result: result == None
+    check_both_devices_failed = lambda device_x_failed, device_y_failed: device_x_failed and device_y_failed
+    if reduce(check_both_devices_failed, map(check_one_device_failed, test_lists)):

[mikecase (-- gone --), 2016/02/19 19:03:42]

You could just do "if all(map(check_one_device_failed, test_lists))" instead of
using reduce.

Also, you could simplify if further and just do something like...

if all([tl is None for tl in test_lists]):
  raise Exception()

^ I think that should work

[BigBossZhiling, 2016/02/19 22:13:47]

Done.

+      # Now we know that all devices failed to do list_tests.
+      raise Exception('Failed to list tests on all devices')

[mikecase (-- gone --), 2016/02/19 19:03:42]

Look around in devil/android/device_errors.py for a more appropriate error.

My guess would do something like raise a device_errors.CommandFailedError

[BigBossZhiling, 2016/02/19 22:13:47]

Done.

+
     # TODO(agrieve): Make this fail rather than return an empty list when
     #     all devices fail.

[mikecase (-- gone --), 2016/02/19 19:03:42]

nit: Remove this TODO.

     return list(sorted(set().union(*[set(tl) for tl in test_lists if tl])))
 
   #override
   def _RunTest(self, device, test):
     # Run the test.
     timeout = (self._test_instance.shard_timeout
                * self.GetTool(device).GetTimeoutScale())
     output = self._delegate.Run(
         test, device, flags=self._test_instance.test_arguments,
         timeout=timeout, retries=0)
@@ skipping 14 matching lines @@
   def TearDown(self):
     @local_device_test_run.handle_shard_failures
     def individual_device_tear_down(dev):
       for s in self._servers.get(str(dev), []):
         s.TearDown()
 
       tool = self.GetTool(dev)
       tool.CleanUpEnvironment()
 
     self._env.parallel_devices.pMap(individual_device_tear_down)