src/objects.h - Issue 1716833002: [runtime] Speed up C++ version of ArrayPush

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/objects.h

Issue 1716833002: [runtime] Speed up C++ version of ArrayPush (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: add TODO for Toon's comment Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/objects.h

diff --git a/src/objects.h b/src/objects.h

index f0a49d6db49e532fae35284f5806f36dec5fe458..7c8b6091d5aa9d34ab32f2a4caed87a311684236 100644

--- a/src/objects.h

+++ b/src/objects.h

@@ -2040,8 +2040,7 @@ class JSObject: public JSReceiver {

inline SeededNumberDictionary* element_dictionary(); // Gets slow elements.

// Requires: HasFastElements().

- static Handle<FixedArray> EnsureWritableFastElements(

- Handle<JSObject> object);

+ static void EnsureWritableFastElements(Handle<JSObject> object);

// Collects elements starting at index 0.

// Undefined values are placed after non-undefined values.

« no previous file with comments | « src/elements.cc ('k') | src/objects.cc » ('j') | no next file with comments »