src/debug/liveedit.cc - Issue 1716833002: [runtime] Speed up C++ version of ArrayPush

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/debug/liveedit.cc

Issue 1716833002: [runtime] Speed up C++ version of ArrayPush (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: add TODO for Toon's comment Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/debug/liveedit.cc

diff --git a/src/debug/liveedit.cc b/src/debug/liveedit.cc

index 91c990d19b7d078600d7b59bc7429e3c353c1b7c..2264154c52ceae99a41b93b4730cab6ab56cabd0 100644

--- a/src/debug/liveedit.cc

+++ b/src/debug/liveedit.cc

@@ -1909,8 +1909,9 @@ Handle<JSArray> LiveEdit::CheckAndDropActivations(

FixedArray::cast(old_shared_array->elements()));

Handle<JSArray> result = isolate->factory()->NewJSArray(len);

+ JSObject::EnsureWritableFastElements(result);

Handle<FixedArray> result_elements =

- JSObject::EnsureWritableFastElements(result);

+ handle(FixedArray::cast(result->elements()), isolate);

// Fill the default values.

for (int i = 0; i < len; i++) {

« no previous file with comments | « src/builtins.cc ('k') | src/elements.cc » ('j') | no next file with comments »