Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: src/debug/liveedit.cc

Issue 1716833002: [runtime] Speed up C++ version of ArrayPush (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« src/builtins.cc ('K') | « src/builtins.cc ('k') | src/elements.cc » ('j') | src/objects.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/debug/liveedit.cc
diff --git a/src/debug/liveedit.cc b/src/debug/liveedit.cc
index 91c990d19b7d078600d7b59bc7429e3c353c1b7c..2264154c52ceae99a41b93b4730cab6ab56cabd0 100644
--- a/src/debug/liveedit.cc
+++ b/src/debug/liveedit.cc
@@ -1909,8 +1909,9 @@ Handle<JSArray> LiveEdit::CheckAndDropActivations(
FixedArray::cast(old_shared_array->elements()));
Handle<JSArray> result = isolate->factory()->NewJSArray(len);
+ JSObject::EnsureWritableFastElements(result);
Handle<FixedArray> result_elements =
- JSObject::EnsureWritableFastElements(result);
+ handle(FixedArray::cast(result->elements()), isolate);
// Fill the default values.
for (int i = 0; i < len; i++) {
« src/builtins.cc ('K') | « src/builtins.cc ('k') | src/elements.cc » ('j') | src/objects.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698