Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Unified Diff: components/cloud_devices/description_items_inl.h

Issue 171683020: Use to base::checked_cast. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/cloud_devices/description_items.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/cloud_devices/description_items_inl.h
diff --git a/components/cloud_devices/description_items_inl.h b/components/cloud_devices/description_items_inl.h
index 2d7b86ae156fb199b3ca14c2073ca631e7a40bb4..5866807f2ea0610f80e489e305d288c7e22e1d9b 100644
--- a/components/cloud_devices/description_items_inl.h
+++ b/components/cloud_devices/description_items_inl.h
@@ -7,6 +7,7 @@
#include <vector>
+#include "base/numerics/safe_conversions.h"
#include "components/cloud_devices/description_items.h"
// Implementation of templates defined in header file.
@@ -83,7 +84,7 @@ bool SelectionCapability<Option, Traits>::IsValid() const {
if (!Traits::IsValid(options_[i]))
return false;
}
- return default_idx_ >= 0 && default_idx_ < static_cast<int>(size());
+ return default_idx_ >= 0 && default_idx_ < base::checked_cast<int>(size());
}
template <class Option, class Traits>
@@ -124,7 +125,7 @@ void SelectionCapability<Option, Traits>::SaveTo(
for (size_t i = 0; i < options_.size(); ++i) {
base::DictionaryValue* option_value = new base::DictionaryValue;
options_list->Append(option_value);
- if (static_cast<int>(i) == default_idx_)
+ if (base::checked_cast<int>(i) == default_idx_)
option_value->SetBoolean(json::kKeyIsDefault, true);
Traits::Save(options_[i], option_value);
}
« no previous file with comments | « components/cloud_devices/description_items.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698