Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Issue 171683015: Screen Orientation API: Add support for lockOrientation() / unlockOrientation() (Closed)

Created:
6 years, 10 months ago by Inactive
Modified:
6 years, 10 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews, jamesr, dglazkov+blink, abarth-chromium, kenneth.r.christiansen, mlamouri (slow - plz ping), Peter Beverloo
Visibility:
Public.

Description

Screen Orientation API: Add support for lockOrientation() / unlockOrientation() Screen Orientation API: Add support for lockOrientation() / unlockOrientation(). The test infrastructure is currently missing to fully test the functionality. It will be added in a follow-up patch. R=abarth BUG=162827 TEST=screen_orientation/lockOrientation-array-argument.html TEST=screen_orientation/lockOrientation-bad-argument.html TEST=screen_orientation/lockOrientation-bad-array-argument.html TEST=screen_orientation/lockOrientation-basic.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167561

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+242 lines, -8 lines) Patch
A LayoutTests/screen_orientation/lockOrientation-array-argument.html View 1 chunk +14 lines, -0 lines 0 comments Download
A LayoutTests/screen_orientation/lockOrientation-array-argument-expected.txt View 1 chunk +12 lines, -0 lines 0 comments Download
A LayoutTests/screen_orientation/lockOrientation-bad-argument.html View 1 chunk +39 lines, -0 lines 0 comments Download
A LayoutTests/screen_orientation/lockOrientation-bad-argument-expected.txt View 1 chunk +22 lines, -0 lines 0 comments Download
A LayoutTests/screen_orientation/lockOrientation-bad-array-argument.html View 1 chunk +34 lines, -0 lines 0 comments Download
A LayoutTests/screen_orientation/lockOrientation-bad-array-argument-expected.txt View 1 chunk +16 lines, -0 lines 0 comments Download
A LayoutTests/screen_orientation/lockOrientation-basic.html View 1 chunk +16 lines, -0 lines 0 comments Download
A LayoutTests/screen_orientation/lockOrientation-basic-expected.txt View 1 chunk +15 lines, -0 lines 0 comments Download
M Source/modules/screen_orientation/ScreenOrientation.h View 1 2 chunks +9 lines, -0 lines 0 comments Download
M Source/modules/screen_orientation/ScreenOrientation.cpp View 1 3 chunks +60 lines, -8 lines 0 comments Download
M public/platform/Platform.h View 2 chunks +3 lines, -0 lines 0 comments Download
M public/platform/WebScreenOrientation.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Inactive
6 years, 10 months ago (2014-02-20 17:02:19 UTC) #1
abarth-chromium
lgtm
6 years, 10 months ago (2014-02-20 21:09:22 UTC) #2
Inactive
The CQ bit was checked by ch.dumez@samsung.com
6 years, 10 months ago (2014-02-20 22:33:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/171683015/1
6 years, 10 months ago (2014-02-20 22:33:39 UTC) #4
Inactive
The CQ bit was unchecked by ch.dumez@samsung.com
6 years, 10 months ago (2014-02-20 23:05:33 UTC) #5
Inactive
The CQ bit was checked by ch.dumez@samsung.com
6 years, 10 months ago (2014-02-20 23:08:55 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/171683015/110001
6 years, 10 months ago (2014-02-20 23:09:09 UTC) #7
commit-bot: I haz the power
6 years, 10 months ago (2014-02-21 02:31:29 UTC) #8
Message was sent while issue was closed.
Change committed as 167561

Powered by Google App Engine
This is Rietveld 408576698