Issue 171683013: Add object hidden properties to heap snapshot

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 171683013: Add object hidden properties to heap snapshot (Closed)

Created:
6 years, 10 months ago by alph

Modified:
6 years, 10 months ago

Reviewers:
yurys, Yang, loislo

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Add object hidden properties to heap snapshot LOG=N

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+54 lines, -0 lines)			Patch
M	src/heap-snapshot-generator.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/heap-snapshot-generator.cc	View	2 chunks	+26 lines, -0 lines	0 comments	Download
M	src/objects.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	test/cctest/test-heap-profiler.cc	View	1 chunk	+26 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

yurys

This will confuse the users as real properties will be indistinguishable from hidden ones.

6 years, 10 months ago (2014-02-20 12:43:15 UTC) #2

alph

6 years, 10 months ago (2014-02-20 14:02:56 UTC) #3

On 2014/02/20 12:43:15, yurys wrote:
> This will confuse the users as real properties will be indistinguishable from
> hidden ones.

agree.