Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Issue 171683007: Unify monomorphic and polymorphic cases in IC::PatchCache. (Closed)

Created:
6 years, 10 months ago by ulan
Modified:
6 years, 9 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Visibility:
Public.

Description

Unify monomorphic and polymorphic cases in IC::PatchCache. BUG= R=verwaest@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20294

Patch Set 1 #

Patch Set 2 : Also override the type. #

Patch Set 3 : Rebase and add IsTransitionOfMonomorphicTarget from r19537 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -33 lines) Patch
M src/ic.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/ic.cc View 1 2 5 chunks +29 lines, -32 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
ulan
PTAL
6 years, 10 months ago (2014-02-19 15:27:12 UTC) #1
Toon Verwaest
lgtm
6 years, 10 months ago (2014-02-19 17:25:43 UTC) #2
ulan
On 2014/02/19 17:25:43, Toon Verwaest wrote: > lgtm I rebased and applied IsTransitionOfMonomorphicTarget from r19537 ...
6 years, 9 months ago (2014-03-27 09:39:26 UTC) #3
ulan
6 years, 9 months ago (2014-03-27 09:59:51 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 manually as r20294 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698