Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(470)

Unified Diff: google_apis/gcm/engine/mcs_client_unittest.cc

Issue 171683002: [GCM] Fix gcm login to properly identify chrome (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Self review Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: google_apis/gcm/engine/mcs_client_unittest.cc
diff --git a/google_apis/gcm/engine/mcs_client_unittest.cc b/google_apis/gcm/engine/mcs_client_unittest.cc
index 6bdce132b68b065fd6260ea024c6944691456840..1bb8bfd5d143bf3da68a4ee8294554457cf221ab 100644
--- a/google_apis/gcm/engine/mcs_client_unittest.cc
+++ b/google_apis/gcm/engine/mcs_client_unittest.cc
@@ -63,7 +63,7 @@ class TestMCSClient : public MCSClient {
TestMCSClient(base::Clock* clock,
ConnectionFactory* connection_factory,
GCMStore* gcm_store)
- : MCSClient(clock, connection_factory, gcm_store),
+ : MCSClient("", clock, connection_factory, gcm_store),
next_id_(0) {
}
@@ -181,7 +181,7 @@ void MCSClientTest::InitializeClient() {
void MCSClientTest::LoginClient(
const std::vector<std::string>& acknowledged_ids) {
scoped_ptr<mcs_proto::LoginRequest> login_request =
- BuildLoginRequest(kAndroidId, kSecurityToken, user_serial_numbers());
+ BuildLoginRequest(kAndroidId, kSecurityToken, "", user_serial_numbers());
for (size_t i = 0; i < acknowledged_ids.size(); ++i)
login_request->add_received_persistent_id(acknowledged_ids[i]);
GetFakeHandler()->ExpectOutgoingMessage(
@@ -342,7 +342,10 @@ TEST_F(MCSClientTest, SendMessageRMQWhileDisconnected) {
GetFakeHandler()->ExpectOutgoingMessage(
MCSMessage(
kLoginRequestTag,
- BuildLoginRequest(kAndroidId, kSecurityToken, user_serial_numbers()).
+ BuildLoginRequest(kAndroidId,
+ kSecurityToken,
+ "",
+ user_serial_numbers()).
PassAs<const google::protobuf::MessageLite>()));
// The second (re)send.
MCSMessage message2(BuildDataMessage("from",

Powered by Google App Engine
This is Rietveld 408576698